@opendaw/lib-box 0.0.76 → 0.0.77

package/dist/editing.d.ts

@@ -11,17 +11,18 @@ export declare class BoxEditing implements Editing {
     subscribe(observer: Observer<void>): Subscription;
     markSaved(): void;
     hasUnsavedChanges(): boolean;
-    isEmpty(): boolean;
+    hasNoChanges(): boolean;
     clear(): void;
     undo(): boolean;
     redo(): boolean;
     canUndo(): boolean;
     canRedo(): boolean;
+    /** @deprecated No longer needed — modify() now handles calls during undo/redo transparently. */
     mustModify(): boolean;
     modify<R>(modifier: SyncProvider<Maybe<R>>, mark?: boolean): Option<R>;
     beginModification(): ModificationProcess;
     mark(): void;
-    clearPending(): void;
+    revertPending(): void;
     disable(): void;
 }
 //# sourceMappingURL=editing.d.ts.map

package/dist/editing.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"editing.d.ts","sourceRoot":"","sources":["../src/editing.ts"],"names":[],"mappings":"AAAA,OAAO,EAAC,QAAQ,EAAC,MAAM,SAAS,CAAA;AAChC,OAAO,EAGH,OAAO,EAEP,KAAK,EAEL,QAAQ,EACR,MAAM,EACN,YAAY,EACZ,YAAY,EAEf,MAAM,kBAAkB,CAAA;AAiDzB,MAAM,WAAW,mBAAmB;IAChC,OAAO,IAAI,IAAI,CAAA;IACf,MAAM,IAAI,IAAI,CAAA;CACjB;AAED,qBAAa,UAAW,YAAW,OAAO;;gBAY1B,KAAK,EAAE,QAAQ;IAM3B,IAAI,KAAK,IAAI,QAAQ,CAAqB;IAE1C,SAAS,CAAC,QAAQ,EAAE,QAAQ,CAAC,IAAI,CAAC,GAAG,YAAY;IAIjD,SAAS,IAAI,IAAI;IAKjB,iBAAiB,IAAI,OAAO;IAM5B,OAAO,IAAI,OAAO;IAElB,KAAK,IAAI,IAAI;IASb,IAAI,IAAI,OAAO;IAWf,IAAI,IAAI,OAAO;IASf,OAAO,IAAI,OAAO;IAKlB,OAAO,IAAI,OAAO;IAkBlB,UAAU,IAAI,OAAO;IAErB,MAAM,CAAC,CAAC,EAAE,QAAQ,EAAE,YAAY,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,EAAE,IAAI,GAAE,OAAc,GAAG,MAAM,CAAC,CAAC,CAAC;IA4B5E,iBAAiB,IAAI,mBAAmB;IAoCxC,IAAI,IAAI,IAAI;IAYZ,YAAY,IAAI,IAAI;IAOpB,OAAO,IAAI,IAAI;CAGlB"}
+{"version":3,"file":"editing.d.ts","sourceRoot":"","sources":["../src/editing.ts"],"names":[],"mappings":"AAAA,OAAO,EAAC,QAAQ,EAAC,MAAM,SAAS,CAAA;AAChC,OAAO,EAGH,OAAO,EAEP,KAAK,EAEL,QAAQ,EACR,MAAM,EACN,YAAY,EACZ,YAAY,EAEf,MAAM,kBAAkB,CAAA;AAiDzB,MAAM,WAAW,mBAAmB;IAChC,OAAO,IAAI,IAAI,CAAA;IACf,MAAM,IAAI,IAAI,CAAA;CACjB;AAED,qBAAa,UAAW,YAAW,OAAO;;gBAY1B,KAAK,EAAE,QAAQ;IAM3B,IAAI,KAAK,IAAI,QAAQ,CAAqB;IAE1C,SAAS,CAAC,QAAQ,EAAE,QAAQ,CAAC,IAAI,CAAC,GAAG,YAAY;IAIjD,SAAS,IAAI,IAAI;IAKjB,iBAAiB,IAAI,OAAO;IAM5B,YAAY,IAAI,OAAO;IAEvB,KAAK,IAAI,IAAI;IASb,IAAI,IAAI,OAAO;IAWf,IAAI,IAAI,OAAO;IASf,OAAO,IAAI,OAAO;IAKlB,OAAO,IAAI,OAAO;IAMlB,gGAAgG;IAChG,UAAU,IAAI,OAAO;IAErB,MAAM,CAAC,CAAC,EAAE,QAAQ,EAAE,YAAY,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,EAAE,IAAI,GAAE,OAAc,GAAG,MAAM,CAAC,CAAC,CAAC;IA4B5E,iBAAiB,IAAI,mBAAmB;IAoCxC,IAAI,IAAI,IAAI;IAYZ,aAAa,IAAI,IAAI;IAOrB,OAAO,IAAI,IAAI;CAGlB"}

package/dist/editing.js

@@ -78,7 +78,7 @@ export class BoxEditing {
         }
         return this.#historyIndex !== this.#savedHistoryIndex;
     }
-    isEmpty() { return this.#marked.length === 0 && this.#pending.length === 0; }
+    hasNoChanges() { return this.#marked.length === 0 && this.#pending.length === 0; }
     clear() {
         assert(!this.#modifying, "Already modifying");
         Arrays.clear(this.#pending);
@@ -126,23 +126,12 @@ export class BoxEditing {
         }
         return this.#pending.length <= 0;
     }
-    // TODO This method exists to handle bidirectional sync between UI state and Box state.
-    //  Problem: When a Box field changes (e.g., during undo/redo), reactive subscriptions may fire
-    //  and attempt to call modify() to sync the UI state back to the Box. But since undo/redo
-    //  already has a transaction open (via Modification.inverse/forward calling beginTransaction
-    //  directly), calling modify() would fail with "Transaction already in progress".
-    //  Current workaround: Callers check mustModify() before calling modify(). If false (transaction
-    //  already open), they either skip the call or call setValue directly without recording history.
-    //  See: EditWrapper.forValue, EditWrapper.forAutomatableParameter, TransportGroup loop sync.
-    //  Better solution: Consider having Modification.inverse/forward use the same #modifying flag
-    //  as modify(), or introduce a unified "modification context" that both undo/redo and user
-    //  actions share. This would allow modify() to detect it's being called reactively during
-    //  undo/redo and handle it internally, rather than requiring all callers to guard with mustModify().
+    /** @deprecated No longer needed — modify() now handles calls during undo/redo transparently. */
     mustModify() { return !this.#graph.inTransaction(); }
     modify(modifier, mark = true) {
         assert(!this.#inProcess, "Cannot call modify while a modification process is running");
-        if (this.#modifying) {
-            // Nested modify call - just execute without separate recording
+        if (this.#modifying || this.#graph.inTransaction()) {
+            // Nested modify call or reactive call during undo/redo — just execute without separate recording
             this.#notifier.notify();
             return Option.wrap(modifier());
         }
@@ -218,7 +207,7 @@ export class BoxEditing {
         this.#marked.push(this.#pending.splice(0));
         this.#historyIndex = this.#marked.length;
     }
-    clearPending() {
+    revertPending() {
         if (this.#pending.length === 0) {
             return;
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@opendaw/lib-box",
-  "version": "0.0.76",
+  "version": "0.0.77",
   "sideEffects": false,
   "main": "./dist/index.js",
   "types": "./dist/index.d.ts",
@@ -23,12 +23,12 @@
     "test": "vitest run"
   },
   "dependencies": {
-    "@opendaw/lib-runtime": "^0.0.71",
-    "@opendaw/lib-std": "^0.0.70"
+    "@opendaw/lib-runtime": "^0.0.72",
+    "@opendaw/lib-std": "^0.0.71"
   },
   "devDependencies": {
     "@opendaw/eslint-config": "^0.0.27",
     "@opendaw/typescript-config": "^0.0.29"
   },
-  "gitHead": "ad6836ddfa539c9a2915aa7fbd473e5386887851"
+  "gitHead": "0b25229f66de4a59f75484d363b396dc1953b91c"
 }