@opendata-ai/openchart-engine 8.0.0-rc.1 → 8.0.0-rc.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@opendata-ai/openchart-engine",
-  "version": "8.0.0-rc.1",
+  "version": "8.0.0-rc.2",
   "description": "Headless compiler for openchart: spec validation, data compilation, scales, and layout",
   "license": "Apache-2.0",
   "author": "Riley Hilliard",
@@ -48,7 +48,7 @@
     "typecheck": "tsc --noEmit"
   },
   "dependencies": {
-    "@opendata-ai/openchart-core": "8.0.0-rc.1",
+    "@opendata-ai/openchart-core": "8.0.0-rc.2",
     "d3-array": "^3.2.0",
     "d3-format": "^3.1.2",
     "d3-interpolate": "^3.0.0",

package/src/compiler/__tests__/keys.test.ts

@@ -62,11 +62,11 @@ describe('dedupeKeys', () => {
   });
 
   it('suffixes duplicates with occurrence index', () => {
-    expect(dedupeKeys(['a', 'a', 'a'])).toEqual(['a\x010', 'a\x011', 'a\x012']);
+    expect(dedupeKeys(['a', 'a', 'a'])).toEqual(['a⸱0', 'a⸱1', 'a⸱2']);
   });
 
   it('only suffixes keys that appear more than once', () => {
-    expect(dedupeKeys(['a', 'b', 'a'])).toEqual(['a\x010', 'b', 'a\x011']);
+    expect(dedupeKeys(['a', 'b', 'a'])).toEqual(['a⸱0', 'b', 'a⸱1']);
   });
 
   it('handles empty array', () => {
@@ -78,12 +78,6 @@ describe('dedupeKeys', () => {
   });
 
   it('handles multiple duplicate groups', () => {
-    expect(dedupeKeys(['x', 'y', 'x', 'y', 'z'])).toEqual([
-      'x\x010',
-      'y\x010',
-      'x\x011',
-      'y\x011',
-      'z',
-    ]);
+    expect(dedupeKeys(['x', 'y', 'x', 'y', 'z'])).toEqual(['x⸱0', 'y⸱0', 'x⸱1', 'y⸱1', 'z']);
   });
 });

package/src/compiler/keys.ts

@@ -28,22 +28,23 @@ export function serializeKeyValue(v: unknown): string {
  *
  * Only keys that appear more than once get suffixed. Unique keys pass
  * through unchanged so keys remain human-readable when possible.
- * Uses SOH (\x01) as separator to avoid collisions with real data values.
+ * Uses U+2E31 (word separator middle dot) as separator - XML-safe and
+ * unlikely to appear in real data values.
  */
+const KEY_DEDUP_SEP = '⸱';
+
 export function dedupeKeys(keys: string[]): string[] {
-  // Count occurrences
   const counts = new Map<string, number>();
   for (const k of keys) {
     counts.set(k, (counts.get(k) ?? 0) + 1);
   }
 
-  // Assign suffixes only to duplicates
   const seen = new Map<string, number>();
   const result: string[] = [];
   for (const k of keys) {
     if (counts.get(k)! > 1) {
       const idx = seen.get(k) ?? 0;
-      result.push(`${k}\x01${idx}`);
+      result.push(`${k}${KEY_DEDUP_SEP}${idx}`);
       seen.set(k, idx + 1);
     } else {
       result.push(k);

package/src/layout/axes.ts

@@ -25,6 +25,7 @@ import {
   estimateTextWidth,
   getAxisTitleOffset,
   truncateRotatedLabel,
+  X_AXIS_TITLE_BAND,
   X_AXIS_TITLE_BAND_ROTATED,
 } from '@opendata-ai/openchart-core';
 import type { ScaleBand } from 'd3-scale';
@@ -705,12 +706,12 @@ export function computeAxes(
     });
 
     if (result.x.label) {
-      // Rotated: place the title just below the tick band (extent already
-      // includes the rotated label height and the title band). Flat: fixed 35px.
-      const rotatedBand = isRotated ? result.x.extent - X_AXIS_TITLE_BAND_ROTATED + 14 : 35;
+      const titleBand = isRotated ? X_AXIS_TITLE_BAND_ROTATED : X_AXIS_TITLE_BAND;
+      const tickBand = result.x.extent - titleBand;
+      const titleY = isRotated ? tickBand + 14 : tickBand + 9;
       result.x.titlePosition = {
         x: chartArea.x + chartArea.width / 2,
-        y: chartArea.y + chartArea.height + rotatedBand,
+        y: chartArea.y + chartArea.height + titleY,
       };
     }
   }