@opendata-ai/openchart-engine 2.7.0 → 2.8.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@opendata-ai/openchart-engine",
-  "version": "2.7.0",
+  "version": "2.8.0",
   "description": "Headless compiler for openchart: spec validation, data compilation, scales, and layout",
   "license": "Apache-2.0",
   "author": "Riley Hilliard",
@@ -45,7 +45,7 @@
     "typecheck": "tsc --noEmit"
   },
   "dependencies": {
-    "@opendata-ai/openchart-core": "2.7.0",
+    "@opendata-ai/openchart-core": "2.8.0",
     "d3-array": "^3.2.0",
     "d3-format": "^3.1.2",
     "d3-interpolate": "^3.0.0",

package/src/__tests__/compile-chart.test.ts

@@ -509,4 +509,82 @@ describe('compileGraph', () => {
     // Rotated labels should shrink the chart area height
     expect(layoutRotated.area.height).toBeLessThan(layoutNormal.area.height);
   });
+
+  it('hides legend when legend.show is false', () => {
+    const spec = {
+      ...lineSpec,
+      legend: { show: false },
+    };
+    const layout = compileChart(spec, { width: 600, height: 400 });
+    expect(layout.legend.entries).toHaveLength(0);
+    expect(layout.legend.bounds.width).toBe(0);
+    expect(layout.legend.bounds.height).toBe(0);
+  });
+
+  it('applies compact breakpoint overrides to chrome', () => {
+    const spec = {
+      ...lineSpec,
+      chrome: {
+        title: 'Full width title with extra context',
+        subtitle: 'Long subtitle with methodology details',
+      },
+      overrides: {
+        compact: {
+          chrome: {
+            title: 'Short title',
+            subtitle: 'Short sub',
+          },
+        },
+      },
+    };
+
+    // At compact width (< 400), overrides should apply
+    const compactLayout = compileChart(spec, { width: 350, height: 400 });
+    expect(compactLayout.chrome.title!.text).toBe('Short title');
+    expect(compactLayout.chrome.subtitle!.text).toBe('Short sub');
+
+    // At full width, base spec should apply
+    const fullLayout = compileChart(spec, { width: 800, height: 400 });
+    expect(fullLayout.chrome.title!.text).toBe('Full width title with extra context');
+    expect(fullLayout.chrome.subtitle!.text).toBe('Long subtitle with methodology details');
+  });
+
+  it('applies medium breakpoint overrides', () => {
+    const spec = {
+      ...lineSpec,
+      chrome: { title: 'Full title' },
+      overrides: {
+        medium: {
+          chrome: { title: 'Medium title' },
+        },
+      },
+    };
+
+    // At medium width (400-700), override should apply
+    const mediumLayout = compileChart(spec, { width: 500, height: 400 });
+    expect(mediumLayout.chrome.title!.text).toBe('Medium title');
+
+    // At full width, base spec should apply
+    const fullLayout = compileChart(spec, { width: 800, height: 400 });
+    expect(fullLayout.chrome.title!.text).toBe('Full title');
+  });
+
+  it('applies breakpoint override for legend show', () => {
+    const spec = {
+      ...lineSpec,
+      overrides: {
+        compact: {
+          legend: { show: false },
+        },
+      },
+    };
+
+    // At compact, legend hidden
+    const compactLayout = compileChart(spec, { width: 350, height: 400 });
+    expect(compactLayout.legend.entries).toHaveLength(0);
+
+    // At full, legend shown
+    const fullLayout = compileChart(spec, { width: 800, height: 400 });
+    expect(fullLayout.legend.entries.length).toBeGreaterThan(0);
+  });
 });

package/src/__tests__/legend.test.ts

@@ -82,6 +82,30 @@ describe('computeLegend', () => {
     expect(legend.bounds.height).toBeGreaterThan(0);
   });
 
+  it('returns empty entries when show is false', () => {
+    const specHidden: NormalizedChartSpec = {
+      ...specWithColor,
+      legend: { show: false },
+      hiddenSeries: [],
+      seriesStyles: {},
+    };
+    const legend = computeLegend(specHidden, fullStrategy, theme, chartArea);
+    expect(legend.entries).toHaveLength(0);
+    expect(legend.bounds.width).toBe(0);
+    expect(legend.bounds.height).toBe(0);
+  });
+
+  it('still shows legend when show is true', () => {
+    const specShown: NormalizedChartSpec = {
+      ...specWithColor,
+      legend: { show: true },
+      hiddenSeries: [],
+      seriesStyles: {},
+    };
+    const legend = computeLegend(specShown, fullStrategy, theme, chartArea);
+    expect(legend.entries).toHaveLength(3);
+  });
+
   it('uses correct swatch shape for chart type', () => {
     const lineLegend = computeLegend(specWithColor, fullStrategy, theme, chartArea);
     expect(lineLegend.entries[0].shape).toBe('line');

package/src/compile.ts

@@ -159,7 +159,58 @@ export function compileChart(spec: unknown, options: CompileOptions): ChartLayou
     throw new Error('compileChart received a graph spec. Use compileGraph instead.');
   }
 
-  const chartSpec = normalized as NormalizedChartSpec;
+  let chartSpec = normalized as NormalizedChartSpec;
+
+  // Responsive strategy
+  const breakpoint = getBreakpoint(options.width);
+  const strategy = getLayoutStrategy(breakpoint);
+
+  // Apply breakpoint-conditional overrides from the original spec
+  const rawSpec = spec as Record<string, unknown>;
+  const overrides = rawSpec.overrides as
+    | Partial<
+        Record<
+          string,
+          { chrome?: unknown; labels?: unknown; legend?: unknown; annotations?: unknown }
+        >
+      >
+    | undefined;
+  if (overrides?.[breakpoint]) {
+    const bp = overrides[breakpoint]!;
+    if (bp.chrome) {
+      chartSpec = {
+        ...chartSpec,
+        chrome: {
+          ...chartSpec.chrome,
+          ...(bp.chrome as NormalizedChartSpec['chrome']),
+        },
+      };
+    }
+    if (bp.labels) {
+      chartSpec = {
+        ...chartSpec,
+        labels: {
+          ...chartSpec.labels,
+          ...(bp.labels as NormalizedChartSpec['labels']),
+        },
+      };
+    }
+    if (bp.legend) {
+      chartSpec = {
+        ...chartSpec,
+        legend: {
+          ...chartSpec.legend,
+          ...(bp.legend as NormalizedChartSpec['legend']),
+        },
+      };
+    }
+    if (bp.annotations) {
+      chartSpec = {
+        ...chartSpec,
+        annotations: bp.annotations as NormalizedChartSpec['annotations'],
+      };
+    }
+  }
 
   // Resolve theme: merge spec-level theme with options-level overrides
   const mergedThemeConfig = options.theme
@@ -170,10 +221,6 @@ export function compileChart(spec: unknown, options: CompileOptions): ChartLayou
     theme = adaptTheme(theme);
   }
 
-  // Responsive strategy
-  const breakpoint = getBreakpoint(options.width);
-  const strategy = getLayoutStrategy(breakpoint);
-
   // Compute legend first (needs to reserve space)
   const preliminaryArea: Rect = {
     x: 0,

package/src/legend/compute.ts

@@ -87,6 +87,25 @@ export function computeLegend(
   theme: ResolvedTheme,
   chartArea: Rect,
 ): LegendLayout {
+  // Legend explicitly hidden via show: false
+  if (spec.legend?.show === false) {
+    return {
+      position: 'top',
+      entries: [],
+      bounds: { x: 0, y: 0, width: 0, height: 0 },
+      labelStyle: {
+        fontFamily: theme.fonts.family,
+        fontSize: theme.fonts.sizes.small,
+        fontWeight: theme.fonts.weights.normal,
+        fill: theme.colors.text,
+        lineHeight: 1.3,
+      },
+      swatchSize: SWATCH_SIZE,
+      swatchGap: SWATCH_GAP,
+      entryGap: ENTRY_GAP,
+    };
+  }
+
   const entries = extractColorEntries(spec, theme);
 
   const labelStyle: TextStyle = {