@opencraw/studio 0.0.12 → 0.0.14

package/dist/index.esm.js

@@ -1,14 +1,14 @@
 import { join, dirname, basename, extname, normalize, sep, resolve } from 'node:path';
 import { createServer } from 'node:http';
+import { promisify, stripVTControlCharacters } from 'node:util';
 import { fileURLToPath, pathToFileURL } from 'node:url';
 import { z } from 'zod';
 import { BODY_KINDS, HttpClient, BrowserClient, NODE_ID_ATTRIBUTE, sessionStateOf, rowsOfCells, parseXml, findDeckTables, findGridTables, analyzeTables, parseRegion, regionText, deckRegionText, isDeckDocument, readRecipeSource, parseInputRecipe, parseOutputRecipe, bindRecipeSet, memorySink, createCrawler, traceLine, UnknownHookError, resolveMissingPolicy, isWorkbookDocument, RecipeBindingError, RecipeValidationError, countMatches, matchesOf, tryParseJson, isPdfDocument, BrowserProfiles } from '@opencraw/core';
 import { randomBytes, createHash } from 'node:crypto';
 import { execFile } from 'node:child_process';
 import { createRequire } from 'node:module';
-import { promisify } from 'node:util';
 import { load } from 'cheerio';
-import { readFile, writeFile, mkdir } from 'node:fs/promises';
+import { readFile, writeFile, rm, rename, mkdir } from 'node:fs/promises';
 import { describeJson } from '@opencraw/probe';
 import { tmpdir } from 'node:os';
 import { existsSync, createReadStream } from 'node:fs';
@@ -2125,9 +2125,9 @@ async function runToResult(crawler, set, recipeId, records, rejectedRecords, ste
 }
 /** What a run that could not start reports. A hook is the author's own code, which Studio never loads (issue #150): say so, instead of leaving "unknown hook" to read as a typo. */
 function failureMessage(error) {
-  if (error instanceof UnknownHookError) return `${error.message}. Studio does not load hooks, so a recipe that uses one cannot be sample-run here; run it with the cli or the mcp server, or temporarily replace the hook step to preview the rest.`;
-  if (error instanceof Error) return error.message;
-  return String(error);
+  if (error instanceof UnknownHookError) return `${stripVTControlCharacters(error.message)}. Studio does not load hooks, so a recipe that uses one cannot be sample-run here; run it with the cli or the mcp server, or temporarily replace the hook step to preview the rest.`;
+  if (error instanceof Error) return stripVTControlCharacters(error.message);
+  return stripVTControlCharacters(String(error));
 }
 
 /** @returns A fresh, empty cache. */
@@ -2877,11 +2877,40 @@ function parseOne(file, content, kind, parse) {
  * round-trip for a hand-formatted file is future work; see this file's test
  * for what is guaranteed today.
  *
+ * The text goes to a sibling temporary file that is then renamed over the
+ * recipe, so a reader (or a crash) never sees a half-written file. Windows
+ * refuses a rename over a file another process has open (`EPERM`, `EBUSY`),
+ * so the rename is retried briefly and then gives way to a plain write.
+ *
  * @param path - The recipe file to write.
  * @param recipe - The whole recipe object.
  */
 async function saveRecipe(path, recipe) {
-  await writeFile(path, `${JSON.stringify(recipe, null, 2)}\n`, 'utf8');
+  const temporary = `${path}.${String(process.pid)}.tmp`;
+  const text = `${JSON.stringify(recipe, null, 2)}\n`;
+  await writeFile(temporary, text, 'utf8');
+  try {
+    await renameWithRetry(temporary, path);
+  } catch {
+    await writeFile(path, text, 'utf8');
+  } finally {
+    await rm(temporary, {
+      force: true
+    });
+  }
+}
+const RENAME_ATTEMPTS = 5;
+const RENAME_PAUSE_MS = 20;
+async function renameWithRetry(from, to) {
+  for (let attempt = 1;; attempt += 1) {
+    try {
+      await rename(from, to);
+      return;
+    } catch (error) {
+      if (attempt >= RENAME_ATTEMPTS) throw error;
+      await new Promise(resolve => setTimeout(resolve, RENAME_PAUSE_MS));
+    }
+  }
 }
 
 /** How many `name-2.ext`, `name-3.ext`… are tried before giving up on a folder full of same-named copies. */
@@ -5090,7 +5119,7 @@ async function handlePdfBytesRequest(response, state, query) {
     response.end(Buffer.from(bytes));
   } catch (error) {
     respondJson(response, 500, {
-      error: error instanceof Error ? error.message : String(error)
+      error: messageOf(error)
     });
   }
 }
@@ -5108,7 +5137,7 @@ async function handleCommand(request, response, state) {
     command = parsed.data;
   } catch (error) {
     respondJson(response, 400, {
-      error: error instanceof Error ? error.message : String(error)
+      error: messageOf(error)
     });
     return;
   }
@@ -5116,7 +5145,7 @@ async function handleCommand(request, response, state) {
     respondJson(response, 200, await dispatch(command, state));
   } catch (error) {
     respondJson(response, 500, {
-      error: error instanceof Error ? error.message : String(error)
+      error: messageOf(error)
     });
   }
 }
@@ -5246,6 +5275,10 @@ function handleUpgrade(request, socket, token, state) {
     state.sockets.delete(connection);
   });
 }
+/** An error's message as plain text: Playwright colours its call logs with ANSI codes, which a browser would show as raw escapes (issue #187). */
+function messageOf(error) {
+  return stripVTControlCharacters(error instanceof Error ? error.message : String(error));
+}
 
 /**
  * Runs `opencraw-studio`: starts the server, opens `folder` (if given) as

package/dist/src/recipe-workspace/save-recipe.use-case.d.ts

@@ -9,6 +9,11 @@
  * round-trip for a hand-formatted file is future work; see this file's test
  * for what is guaranteed today.
  *
+ * The text goes to a sibling temporary file that is then renamed over the
+ * recipe, so a reader (or a crash) never sees a half-written file. Windows
+ * refuses a rename over a file another process has open (`EPERM`, `EBUSY`),
+ * so the rename is retried briefly and then gives way to a plain write.
+ *
  * @param path - The recipe file to write.
  * @param recipe - The whole recipe object.
  */