@opencodereview/core 1.9.1

package/dist/detectors/type-safety.js

@@ -0,0 +1,306 @@
+/**
+ * Type Safety Detector (V3)
+ *
+ * TypeScript-specific type safety analysis:
+ * 1. Excessive `any` usage (`: any`, `as any`, `<any>`)
+ * 2. Missing return types on exported functions
+ * 3. Unsafe type assertions (`as unknown as X`)
+ * 4. Non-null assertion operator abuse (`!.`)
+ *
+ * AI models frequently generate TypeScript code with excessive `any` usage,
+ * unsafe assertions, and missing type annotations.
+ *
+ * Only operates on .ts/.tsx files.
+ *
+ * Implements the unified Detector interface.
+ *
+ * @since 0.3.0
+ */
+import { AIDefectCategory } from '../types.js';
+// ─── Helpers ───
+function isTypeScriptFile(filePath) {
+    return /\.(ts|tsx)$/.test(filePath);
+}
+// ─── Main Detector ───
+/**
+ * TypeSafetyDetector — detects type safety issues in AI-generated TypeScript code.
+ *
+ * Analyzes:
+ * - `any` abuse (: any, as any, <any>)
+ * - Missing return type annotations on exported functions
+ * - Unsafe type assertions (as unknown as X)
+ * - Excessive non-null assertion (!) usage
+ */
+export class TypeSafetyDetector {
+    name = 'type-safety';
+    version = '1.0.0';
+    tier = 1;
+    // ─── V3 Unified Interface ───
+    async detect(files) {
+        const allIssues = [];
+        let globalIndex = 0;
+        for (const file of files) {
+            // Only analyze TypeScript files
+            if (!isTypeScriptFile(file.path))
+                continue;
+            const issues = this.analyzeFile(file.path, file.content);
+            for (const issue of issues) {
+                issue.id = `type-safety:${globalIndex++}`;
+                allIssues.push(issue);
+            }
+        }
+        return allIssues;
+    }
+    // ─── Internal Analysis ───
+    analyzeFile(filePath, source) {
+        const issues = [];
+        const lines = source.split('\n');
+        // 1. Detect `any` usage
+        this.detectAnyUsage(filePath, lines, issues);
+        // 2. Detect missing return types on exported functions
+        this.detectMissingReturnTypes(filePath, lines, issues);
+        // 3. Detect unsafe type assertions
+        this.detectUnsafeAssertions(filePath, lines, issues);
+        // 4. Detect non-null assertion abuse
+        this.detectNonNullAssertions(filePath, lines, issues);
+        return issues;
+    }
+    // ─── 1. Any Usage Detection ───
+    detectAnyUsage(filePath, lines, issues) {
+        const anyLocations = [];
+        for (let i = 0; i < lines.length; i++) {
+            const line = lines[i];
+            const trimmed = line.trim();
+            // Skip comments
+            if (trimmed.startsWith('//') || trimmed.startsWith('*') || trimmed.startsWith('/*'))
+                continue;
+            // Skip suppressed lines
+            const prevLine = i > 0 ? lines[i - 1] : '';
+            if (prevLine.includes('// ai-validator-ignore') || prevLine.includes('// ai-validator-disable'))
+                continue;
+            // Detect `: any` (type annotation)
+            const colonAny = line.match(/:\s*any\b/g);
+            if (colonAny) {
+                for (const _m of colonAny) {
+                    anyLocations.push({ line: i + 1, kind: ': any' });
+                }
+            }
+            // Detect `as any` (type assertion)
+            const asAny = line.match(/\bas\s+any\b/g);
+            if (asAny) {
+                for (const _m of asAny) {
+                    anyLocations.push({ line: i + 1, kind: 'as any' });
+                }
+            }
+            // Detect `<any>` (type parameter / old-style assertion)
+            const angleBracketAny = line.match(/<any>/g);
+            if (angleBracketAny) {
+                for (const _m of angleBracketAny) {
+                    anyLocations.push({ line: i + 1, kind: '<any>' });
+                }
+            }
+        }
+        const anyCount = anyLocations.length;
+        if (anyCount === 0)
+            return;
+        // Determine severity based on count
+        let severity;
+        if (anyCount > 8) {
+            severity = 'medium';
+        }
+        else if (anyCount >= 4) {
+            severity = 'low';
+        }
+        else {
+            severity = 'info';
+        }
+        // Report per-location for the first few, then summary
+        if (anyCount <= 5) {
+            for (const loc of anyLocations) {
+                issues.push({
+                    id: '',
+                    detector: this.name,
+                    type: 'any-usage',
+                    category: AIDefectCategory.TYPE_SAFETY,
+                    severity,
+                    message: `Unsafe '${loc.kind}' usage — weakens TypeScript type checking`,
+                    file: filePath,
+                    line: loc.line,
+                    suggestion: 'Replace `any` with a specific type, `unknown`, or a generic type parameter.',
+                    fix: {
+                        description: 'Replace `any` with proper type annotation',
+                        autoFixable: false,
+                    },
+                    confidence: 0.9,
+                    detectionSource: 'static',
+                });
+            }
+        }
+        else {
+            // Report first 3 locations individually
+            for (const loc of anyLocations.slice(0, 3)) {
+                issues.push({
+                    id: '',
+                    detector: this.name,
+                    type: 'any-usage',
+                    category: AIDefectCategory.TYPE_SAFETY,
+                    severity,
+                    message: `Unsafe '${loc.kind}' usage — weakens TypeScript type checking`,
+                    file: filePath,
+                    line: loc.line,
+                    suggestion: 'Replace `any` with a specific type, `unknown`, or a generic type parameter.',
+                    fix: {
+                        description: 'Replace `any` with proper type annotation',
+                        autoFixable: false,
+                    },
+                    confidence: 0.9,
+                    detectionSource: 'static',
+                });
+            }
+            // Summary issue
+            issues.push({
+                id: '',
+                detector: this.name,
+                type: 'any-abuse',
+                category: AIDefectCategory.TYPE_SAFETY,
+                severity,
+                message: `Excessive 'any' usage: ${anyCount} occurrences found in file. AI-generated code often over-uses 'any' to bypass type errors.`,
+                file: filePath,
+                line: 1,
+                suggestion: `Review and replace 'any' types with proper type annotations. Consider using \`unknown\` with type guards.`,
+                fix: {
+                    description: `Replace ${anyCount} 'any' usages with proper types`,
+                    autoFixable: false,
+                },
+                confidence: 0.9,
+                detectionSource: 'static',
+            });
+        }
+    }
+    // ─── 2. Missing Return Types ───
+    detectMissingReturnTypes(filePath, lines, issues) {
+        for (let i = 0; i < lines.length; i++) {
+            const line = lines[i];
+            const trimmed = line.trim();
+            // Skip comments
+            if (trimmed.startsWith('//') || trimmed.startsWith('*') || trimmed.startsWith('/*'))
+                continue;
+            // Skip suppressed lines
+            const prevLine = i > 0 ? lines[i - 1] : '';
+            if (prevLine.includes('// ai-validator-ignore') || prevLine.includes('// ai-validator-disable'))
+                continue;
+            // Match exported function declarations
+            const exportFuncMatch = trimmed.match(/^export\s+(?:default\s+)?(?:async\s+)?function\s+(\w+)\s*\(([^)]*)\)\s*\{/);
+            if (exportFuncMatch) {
+                const funcName = exportFuncMatch[1];
+                // Check if there's a return type annotation between ) and {
+                const fullLine = line;
+                const closeParen = fullLine.lastIndexOf(')');
+                const openBrace = fullLine.indexOf('{', closeParen);
+                if (closeParen >= 0 && openBrace >= 0) {
+                    const between = fullLine.substring(closeParen + 1, openBrace).trim();
+                    // Should have `: SomeType` between ) and {
+                    if (!between.startsWith(':')) {
+                        issues.push({
+                            id: '',
+                            detector: this.name,
+                            type: 'missing-return-type',
+                            category: AIDefectCategory.TYPE_SAFETY,
+                            severity: 'low',
+                            message: `Exported function '${funcName}' is missing a return type annotation`,
+                            file: filePath,
+                            line: i + 1,
+                            suggestion: `Add an explicit return type: function ${funcName}(...): ReturnType { ... }`,
+                            fix: {
+                                description: `Add return type annotation to '${funcName}'`,
+                                autoFixable: false,
+                            },
+                            confidence: 0.85,
+                            detectionSource: 'static',
+                        });
+                    }
+                }
+            }
+        }
+    }
+    // ─── 3. Unsafe Type Assertions ───
+    detectUnsafeAssertions(filePath, lines, issues) {
+        for (let i = 0; i < lines.length; i++) {
+            const line = lines[i];
+            const trimmed = line.trim();
+            // Skip comments
+            if (trimmed.startsWith('//') || trimmed.startsWith('*') || trimmed.startsWith('/*'))
+                continue;
+            // Skip suppressed lines
+            const prevLine = i > 0 ? lines[i - 1] : '';
+            if (prevLine.includes('// ai-validator-ignore') || prevLine.includes('// ai-validator-disable'))
+                continue;
+            // Detect `as unknown as X` pattern
+            if (/\bas\s+unknown\s+as\s+\w/.test(line)) {
+                issues.push({
+                    id: '',
+                    detector: this.name,
+                    type: 'unsafe-assertion',
+                    category: AIDefectCategory.TYPE_SAFETY,
+                    severity: 'medium',
+                    message: `Unsafe double assertion 'as unknown as X' bypasses type checking entirely`,
+                    file: filePath,
+                    line: i + 1,
+                    suggestion: 'Avoid double assertions. Use proper type narrowing (type guards) or fix the underlying type mismatch.',
+                    fix: {
+                        description: 'Replace double assertion with proper type narrowing',
+                        autoFixable: false,
+                    },
+                    confidence: 0.95,
+                    detectionSource: 'static',
+                });
+            }
+        }
+    }
+    // ─── 4. Non-null Assertion Abuse ───
+    detectNonNullAssertions(filePath, lines, issues) {
+        const nonNullLocations = [];
+        for (let i = 0; i < lines.length; i++) {
+            const line = lines[i];
+            const trimmed = line.trim();
+            // Skip comments
+            if (trimmed.startsWith('//') || trimmed.startsWith('*') || trimmed.startsWith('/*'))
+                continue;
+            // Skip suppressed lines
+            const prevLine = i > 0 ? lines[i - 1] : '';
+            if (prevLine.includes('// ai-validator-ignore') || prevLine.includes('// ai-validator-disable'))
+                continue;
+            // Detect `!.` and `!;` and `!)` — non-null assertion operator
+            // Be careful not to match !== or != or regular !boolean
+            const nonNullMatches = line.match(/\w+!\./g) || [];
+            const nonNullEnd = line.match(/\w+!(?:[;,)\]\s]|$)/g) || [];
+            // Filter out != and !==
+            const filtered = [...nonNullMatches, ...nonNullEnd].filter(m => !m.includes('!='));
+            if (filtered.length > 0) {
+                nonNullLocations.push(i + 1);
+            }
+        }
+        // Only flag if there are many non-null assertions (>3 per file = noteworthy)
+        if (nonNullLocations.length > 5) {
+            issues.push({
+                id: '',
+                detector: this.name,
+                type: 'non-null-assertion-abuse',
+                category: AIDefectCategory.TYPE_SAFETY,
+                severity: 'low',
+                message: `Excessive non-null assertion (!) usage: ${nonNullLocations.length} occurrences. AI often uses '!' to suppress null checks instead of proper handling.`,
+                file: filePath,
+                line: nonNullLocations[0],
+                suggestion: 'Use optional chaining (?.), nullish coalescing (??), or proper null checks instead of non-null assertions.',
+                fix: {
+                    description: 'Replace non-null assertions with safe null handling',
+                    autoFixable: false,
+                },
+                confidence: 0.75,
+                detectionSource: 'static',
+            });
+        }
+    }
+}
+export default TypeSafetyDetector;
+//# sourceMappingURL=type-safety.js.map

package/dist/detectors/type-safety.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"type-safety.js","sourceRoot":"","sources":["../../src/detectors/type-safety.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;GAiBG;AAGH,OAAO,EAAE,gBAAgB,EAAE,MAAM,aAAa,CAAC;AAE/C,kBAAkB;AAElB,SAAS,gBAAgB,CAAC,QAAgB;IACxC,OAAO,aAAa,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;AACtC,CAAC;AAED,wBAAwB;AAExB;;;;;;;;GAQG;AACH,MAAM,OAAO,kBAAkB;IACpB,IAAI,GAAG,aAAa,CAAC;IACrB,OAAO,GAAG,OAAO,CAAC;IAClB,IAAI,GAAG,CAAU,CAAC;IAE3B,+BAA+B;IAE/B,KAAK,CAAC,MAAM,CAAC,KAAqB;QAChC,MAAM,SAAS,GAAmB,EAAE,CAAC;QACrC,IAAI,WAAW,GAAG,CAAC,CAAC;QAEpB,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;YACzB,gCAAgC;YAChC,IAAI,CAAC,gBAAgB,CAAC,IAAI,CAAC,IAAI,CAAC;gBAAE,SAAS;YAE3C,MAAM,MAAM,GAAG,IAAI,CAAC,WAAW,CAAC,IAAI,CAAC,IAAI,EAAE,IAAI,CAAC,OAAO,CAAC,CAAC;YACzD,KAAK,MAAM,KAAK,IAAI,MAAM,EAAE,CAAC;gBAC3B,KAAK,CAAC,EAAE,GAAG,eAAe,WAAW,EAAE,EAAE,CAAC;gBAC1C,SAAS,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;YACxB,CAAC;QACH,CAAC;QAED,OAAO,SAAS,CAAC;IACnB,CAAC;IAED,4BAA4B;IAEpB,WAAW,CAAC,QAAgB,EAAE,MAAc;QAClD,MAAM,MAAM,GAAmB,EAAE,CAAC;QAClC,MAAM,KAAK,GAAG,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;QAEjC,wBAAwB;QACxB,IAAI,CAAC,cAAc,CAAC,QAAQ,EAAE,KAAK,EAAE,MAAM,CAAC,CAAC;QAE7C,uDAAuD;QACvD,IAAI,CAAC,wBAAwB,CAAC,QAAQ,EAAE,KAAK,EAAE,MAAM,CAAC,CAAC;QAEvD,mCAAmC;QACnC,IAAI,CAAC,sBAAsB,CAAC,QAAQ,EAAE,KAAK,EAAE,MAAM,CAAC,CAAC;QAErD,qCAAqC;QACrC,IAAI,CAAC,uBAAuB,CAAC,QAAQ,EAAE,KAAK,EAAE,MAAM,CAAC,CAAC;QAEtD,OAAO,MAAM,CAAC;IAChB,CAAC;IAED,iCAAiC;IAEzB,cAAc,CAAC,QAAgB,EAAE,KAAe,EAAE,MAAsB;QAC9E,MAAM,YAAY,GAA0C,EAAE,CAAC;QAE/D,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,KAAK,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;YACtC,MAAM,IAAI,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC;YACtB,MAAM,OAAO,GAAG,IAAI,CAAC,IAAI,EAAE,CAAC;YAE5B,gBAAgB;YAChB,IAAI,OAAO,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,OAAO,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,OAAO,CAAC,UAAU,CAAC,IAAI,CAAC;gBAAE,SAAS;YAE9F,wBAAwB;YACxB,MAAM,QAAQ,GAAG,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC;YAC3C,IAAI,QAAQ,CAAC,QAAQ,CAAC,wBAAwB,CAAC,IAAI,QAAQ,CAAC,QAAQ,CAAC,yBAAyB,CAAC;gBAAE,SAAS;YAE1G,mCAAmC;YACnC,MAAM,QAAQ,GAAG,IAAI,CAAC,KAAK,CAAC,YAAY,CAAC,CAAC;YAC1C,IAAI,QAAQ,EAAE,CAAC;gBACb,KAAK,MAAM,EAAE,IAAI,QAAQ,EAAE,CAAC;oBAC1B,YAAY,CAAC,IAAI,CAAC,EAAE,IAAI,EAAE,CAAC,GAAG,CAAC,EAAE,IAAI,EAAE,OAAO,EAAE,CAAC,CAAC;gBACpD,CAAC;YACH,CAAC;YAED,mCAAmC;YACnC,MAAM,KAAK,GAAG,IAAI,CAAC,KAAK,CAAC,eAAe,CAAC,CAAC;YAC1C,IAAI,KAAK,EAAE,CAAC;gBACV,KAAK,MAAM,EAAE,IAAI,KAAK,EAAE,CAAC;oBACvB,YAAY,CAAC,IAAI,CAAC,EAAE,IAAI,EAAE,CAAC,GAAG,CAAC,EAAE,IAAI,EAAE,QAAQ,EAAE,CAAC,CAAC;gBACrD,CAAC;YACH,CAAC;YAED,wDAAwD;YACxD,MAAM,eAAe,GAAG,IAAI,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC;YAC7C,IAAI,eAAe,EAAE,CAAC;gBACpB,KAAK,MAAM,EAAE,IAAI,eAAe,EAAE,CAAC;oBACjC,YAAY,CAAC,IAAI,CAAC,EAAE,IAAI,EAAE,CAAC,GAAG,CAAC,EAAE,IAAI,EAAE,OAAO,EAAE,CAAC,CAAC;gBACpD,CAAC;YACH,CAAC;QACH,CAAC;QAED,MAAM,QAAQ,GAAG,YAAY,CAAC,MAAM,CAAC;QACrC,IAAI,QAAQ,KAAK,CAAC;YAAE,OAAO;QAE3B,oCAAoC;QACpC,IAAI,QAAkB,CAAC;QACvB,IAAI,QAAQ,GAAG,CAAC,EAAE,CAAC;YACjB,QAAQ,GAAG,QAAQ,CAAC;QACtB,CAAC;aAAM,IAAI,QAAQ,IAAI,CAAC,EAAE,CAAC;YACzB,QAAQ,GAAG,KAAK,CAAC;QACnB,CAAC;aAAM,CAAC;YACN,QAAQ,GAAG,MAAM,CAAC;QACpB,CAAC;QAED,sDAAsD;QACtD,IAAI,QAAQ,IAAI,CAAC,EAAE,CAAC;YAClB,KAAK,MAAM,GAAG,IAAI,YAAY,EAAE,CAAC;gBAC/B,MAAM,CAAC,IAAI,CAAC;oBACV,EAAE,EAAE,EAAE;oBACN,QAAQ,EAAE,IAAI,CAAC,IAAI;oBACnB,IAAI,EAAE,WAAW;oBACjB,QAAQ,EAAE,gBAAgB,CAAC,WAAW;oBACtC,QAAQ;oBACR,OAAO,EAAE,WAAW,GAAG,CAAC,IAAI,4CAA4C;oBACxE,IAAI,EAAE,QAAQ;oBACd,IAAI,EAAE,GAAG,CAAC,IAAI;oBACd,UAAU,EAAE,6EAA6E;oBACzF,GAAG,EAAE;wBACH,WAAW,EAAE,2CAA2C;wBACxD,WAAW,EAAE,KAAK;qBACnB;oBACD,UAAU,EAAE,GAAG;oBACf,eAAe,EAAE,QAAQ;iBAC1B,CAAC,CAAC;YACL,CAAC;QACH,CAAC;aAAM,CAAC;YACN,wCAAwC;YACxC,KAAK,MAAM,GAAG,IAAI,YAAY,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,CAAC,EAAE,CAAC;gBAC3C,MAAM,CAAC,IAAI,CAAC;oBACV,EAAE,EAAE,EAAE;oBACN,QAAQ,EAAE,IAAI,CAAC,IAAI;oBACnB,IAAI,EAAE,WAAW;oBACjB,QAAQ,EAAE,gBAAgB,CAAC,WAAW;oBACtC,QAAQ;oBACR,OAAO,EAAE,WAAW,GAAG,CAAC,IAAI,4CAA4C;oBACxE,IAAI,EAAE,QAAQ;oBACd,IAAI,EAAE,GAAG,CAAC,IAAI;oBACd,UAAU,EAAE,6EAA6E;oBACzF,GAAG,EAAE;wBACH,WAAW,EAAE,2CAA2C;wBACxD,WAAW,EAAE,KAAK;qBACnB;oBACD,UAAU,EAAE,GAAG;oBACf,eAAe,EAAE,QAAQ;iBAC1B,CAAC,CAAC;YACL,CAAC;YAED,gBAAgB;YAChB,MAAM,CAAC,IAAI,CAAC;gBACV,EAAE,EAAE,EAAE;gBACN,QAAQ,EAAE,IAAI,CAAC,IAAI;gBACnB,IAAI,EAAE,WAAW;gBACjB,QAAQ,EAAE,gBAAgB,CAAC,WAAW;gBACtC,QAAQ;gBACR,OAAO,EAAE,0BAA0B,QAAQ,4FAA4F;gBACvI,IAAI,EAAE,QAAQ;gBACd,IAAI,EAAE,CAAC;gBACP,UAAU,EAAE,2GAA2G;gBACvH,GAAG,EAAE;oBACH,WAAW,EAAE,WAAW,QAAQ,iCAAiC;oBACjE,WAAW,EAAE,KAAK;iBACnB;gBACD,UAAU,EAAE,GAAG;gBACf,eAAe,EAAE,QAAQ;aAC1B,CAAC,CAAC;QACL,CAAC;IACH,CAAC;IAED,kCAAkC;IAE1B,wBAAwB,CAAC,QAAgB,EAAE,KAAe,EAAE,MAAsB;QACxF,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,KAAK,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;YACtC,MAAM,IAAI,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC;YACtB,MAAM,OAAO,GAAG,IAAI,CAAC,IAAI,EAAE,CAAC;YAE5B,gBAAgB;YAChB,IAAI,OAAO,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,OAAO,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,OAAO,CAAC,UAAU,CAAC,IAAI,CAAC;gBAAE,SAAS;YAE9F,wBAAwB;YACxB,MAAM,QAAQ,GAAG,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC;YAC3C,IAAI,QAAQ,CAAC,QAAQ,CAAC,wBAAwB,CAAC,IAAI,QAAQ,CAAC,QAAQ,CAAC,yBAAyB,CAAC;gBAAE,SAAS;YAE1G,uCAAuC;YACvC,MAAM,eAAe,GAAG,OAAO,CAAC,KAAK,CACnC,2EAA2E,CAC5E,CAAC;YAEF,IAAI,eAAe,EAAE,CAAC;gBACpB,MAAM,QAAQ,GAAG,eAAe,CAAC,CAAC,CAAC,CAAC;gBACpC,4DAA4D;gBAC5D,MAAM,QAAQ,GAAG,IAAI,CAAC;gBACtB,MAAM,UAAU,GAAG,QAAQ,CAAC,WAAW,CAAC,GAAG,CAAC,CAAC;gBAC7C,MAAM,SAAS,GAAG,QAAQ,CAAC,OAAO,CAAC,GAAG,EAAE,UAAU,CAAC,CAAC;gBACpD,IAAI,UAAU,IAAI,CAAC,IAAI,SAAS,IAAI,CAAC,EAAE,CAAC;oBACtC,MAAM,OAAO,GAAG,QAAQ,CAAC,SAAS,CAAC,UAAU,GAAG,CAAC,EAAE,SAAS,CAAC,CAAC,IAAI,EAAE,CAAC;oBACrE,2CAA2C;oBAC3C,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,GAAG,CAAC,EAAE,CAAC;wBAC7B,MAAM,CAAC,IAAI,CAAC;4BACV,EAAE,EAAE,EAAE;4BACN,QAAQ,EAAE,IAAI,CAAC,IAAI;4BACnB,IAAI,EAAE,qBAAqB;4BAC3B,QAAQ,EAAE,gBAAgB,CAAC,WAAW;4BACtC,QAAQ,EAAE,KAAK;4BACf,OAAO,EAAE,sBAAsB,QAAQ,uCAAuC;4BAC9E,IAAI,EAAE,QAAQ;4BACd,IAAI,EAAE,CAAC,GAAG,CAAC;4BACX,UAAU,EAAE,yCAAyC,QAAQ,2BAA2B;4BACxF,GAAG,EAAE;gCACH,WAAW,EAAE,kCAAkC,QAAQ,GAAG;gCAC1D,WAAW,EAAE,KAAK;6BACnB;4BACD,UAAU,EAAE,IAAI;4BAChB,eAAe,EAAE,QAAQ;yBAC1B,CAAC,CAAC;oBACL,CAAC;gBACH,CAAC;YACH,CAAC;QACH,CAAC;IACH,CAAC;IAED,oCAAoC;IAE5B,sBAAsB,CAAC,QAAgB,EAAE,KAAe,EAAE,MAAsB;QACtF,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,KAAK,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;YACtC,MAAM,IAAI,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC;YACtB,MAAM,OAAO,GAAG,IAAI,CAAC,IAAI,EAAE,CAAC;YAE5B,gBAAgB;YAChB,IAAI,OAAO,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,OAAO,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,OAAO,CAAC,UAAU,CAAC,IAAI,CAAC;gBAAE,SAAS;YAE9F,wBAAwB;YACxB,MAAM,QAAQ,GAAG,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC;YAC3C,IAAI,QAAQ,CAAC,QAAQ,CAAC,wBAAwB,CAAC,IAAI,QAAQ,CAAC,QAAQ,CAAC,yBAAyB,CAAC;gBAAE,SAAS;YAE1G,mCAAmC;YACnC,IAAI,0BAA0B,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC;gBAC1C,MAAM,CAAC,IAAI,CAAC;oBACV,EAAE,EAAE,EAAE;oBACN,QAAQ,EAAE,IAAI,CAAC,IAAI;oBACnB,IAAI,EAAE,kBAAkB;oBACxB,QAAQ,EAAE,gBAAgB,CAAC,WAAW;oBACtC,QAAQ,EAAE,QAAQ;oBAClB,OAAO,EAAE,2EAA2E;oBACpF,IAAI,EAAE,QAAQ;oBACd,IAAI,EAAE,CAAC,GAAG,CAAC;oBACX,UAAU,EAAE,uGAAuG;oBACnH,GAAG,EAAE;wBACH,WAAW,EAAE,qDAAqD;wBAClE,WAAW,EAAE,KAAK;qBACnB;oBACD,UAAU,EAAE,IAAI;oBAChB,eAAe,EAAE,QAAQ;iBAC1B,CAAC,CAAC;YACL,CAAC;QACH,CAAC;IACH,CAAC;IAED,sCAAsC;IAE9B,uBAAuB,CAAC,QAAgB,EAAE,KAAe,EAAE,MAAsB;QACvF,MAAM,gBAAgB,GAAa,EAAE,CAAC;QAEtC,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,KAAK,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;YACtC,MAAM,IAAI,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC;YACtB,MAAM,OAAO,GAAG,IAAI,CAAC,IAAI,EAAE,CAAC;YAE5B,gBAAgB;YAChB,IAAI,OAAO,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,OAAO,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,OAAO,CAAC,UAAU,CAAC,IAAI,CAAC;gBAAE,SAAS;YAE9F,wBAAwB;YACxB,MAAM,QAAQ,GAAG,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC;YAC3C,IAAI,QAAQ,CAAC,QAAQ,CAAC,wBAAwB,CAAC,IAAI,QAAQ,CAAC,QAAQ,CAAC,yBAAyB,CAAC;gBAAE,SAAS;YAE1G,8DAA8D;YAC9D,wDAAwD;YACxD,MAAM,cAAc,GAAG,IAAI,CAAC,KAAK,CAAC,SAAS,CAAC,IAAI,EAAE,CAAC;YACnD,MAAM,UAAU,GAAG,IAAI,CAAC,KAAK,CAAC,sBAAsB,CAAC,IAAI,EAAE,CAAC;YAC5D,wBAAwB;YACxB,MAAM,QAAQ,GAAG,CAAC,GAAG,cAAc,EAAE,GAAG,UAAU,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,CAAC;YACnF,IAAI,QAAQ,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;gBACxB,gBAAgB,CAAC,IAAI,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC;YAC/B,CAAC;QACH,CAAC;QAED,6EAA6E;QAC7E,IAAI,gBAAgB,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YAChC,MAAM,CAAC,IAAI,CAAC;gBACV,EAAE,EAAE,EAAE;gBACN,QAAQ,EAAE,IAAI,CAAC,IAAI;gBACnB,IAAI,EAAE,0BAA0B;gBAChC,QAAQ,EAAE,gBAAgB,CAAC,WAAW;gBACtC,QAAQ,EAAE,KAAK;gBACf,OAAO,EAAE,2CAA2C,gBAAgB,CAAC,MAAM,qFAAqF;gBAChK,IAAI,EAAE,QAAQ;gBACd,IAAI,EAAE,gBAAgB,CAAC,CAAC,CAAC;gBACzB,UAAU,EAAE,4GAA4G;gBACxH,GAAG,EAAE;oBACH,WAAW,EAAE,qDAAqD;oBAClE,WAAW,EAAE,KAAK;iBACnB;gBACD,UAAU,EAAE,IAAI;gBAChB,eAAe,EAAE,QAAQ;aAC1B,CAAC,CAAC;QACL,CAAC;IACH,CAAC;CACF;AAED,eAAe,kBAAkB,CAAC"}

package/dist/detectors/v4/context-coherence.d.ts

@@ -0,0 +1,67 @@
+/**
+ * ContextCoherenceDetector — V4 detector for AI context window issues.
+ *
+ * Detects logic inconsistencies that arise from AI context window limitations.
+ * When AI models generate long code, they lose track of what they've already
+ * defined, used, or imported — leading to coherence issues.
+ *
+ * V4 improvements over V3:
+ * - Operates on CodeUnit IR (definitions, references, imports) instead of regex
+ * - Cross-unit analysis for referenced-but-undefined symbols
+ * - Structural analysis using definitions/references instead of source text
+ * - Dramatically reduced false positives
+ *
+ * @since 0.4.0
+ */
+import type { CodeUnit, SupportedLanguage } from '../../ir/types.js';
+import type { V4Detector, DetectorResult, DetectorCategory, DetectorContext } from './types.js';
+export declare class ContextCoherenceDetector implements V4Detector {
+    readonly id = "context-coherence";
+    readonly name = "Context Coherence Detector";
+    readonly category: DetectorCategory;
+    readonly supportedLanguages: SupportedLanguage[];
+    detect(units: CodeUnit[], context: DetectorContext): Promise<DetectorResult[]>;
+    /**
+     * Analysis 1: Detect functions/classes/types defined but never used and not exported.
+     *
+     * AI models sometimes define helper functions that are never called,
+     * or define types/interfaces that are never used — a sign of context loss.
+     */
+    private detectUnusedDefinitions;
+    /**
+     * Analysis 2: Detect inconsistent import patterns within the same file.
+     *
+     * When AI loses context mid-generation, it may import the same functionality
+     * from different modules in different parts of the file. For example:
+     * - import { readFile } from 'fs' AND import { readFile } from 'fs/promises'
+     * - import lodash AND import underscore (same purpose)
+     */
+    private detectInconsistentImports;
+    /**
+     * Analysis 3: Detect duplicate function names in the same scope.
+     *
+     * AI may re-define the same function name multiple times in a file
+     * when it loses track of what it has already generated.
+     */
+    private detectDuplicateFunctionNames;
+    /** Group code units by their function/method definition names. */
+    private groupByFunctionName;
+    /** Report duplicate function definitions within the same scope. */
+    private reportDuplicates;
+    /**
+     * Analysis 4: Detect referenced but undefined symbols across units within a file.
+     *
+     * If a symbol is referenced but never defined (and not imported),
+     * the AI may have "forgotten" to include the definition.
+     */
+    private detectUndefinedReferences;
+    /**
+     * Check if a name is a well-known global (e.g., console, window, process).
+     */
+    private isWellKnownGlobal;
+    /**
+     * Capitalize a symbol kind for display.
+     */
+    private capitalizeKind;
+}
+//# sourceMappingURL=context-coherence.d.ts.map

package/dist/detectors/v4/context-coherence.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"context-coherence.d.ts","sourceRoot":"","sources":["../../../src/detectors/v4/context-coherence.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;GAcG;AAEH,OAAO,KAAK,EAAE,QAAQ,EAAE,iBAAiB,EAAE,MAAM,mBAAmB,CAAC;AACrE,OAAO,KAAK,EAAE,UAAU,EAAE,cAAc,EAAE,gBAAgB,EAAE,eAAe,EAAE,MAAM,YAAY,CAAC;AAIhG,qBAAa,wBAAyB,YAAW,UAAU;IACzD,QAAQ,CAAC,EAAE,uBAAuB;IAClC,QAAQ,CAAC,IAAI,gCAAgC;IAC7C,QAAQ,CAAC,QAAQ,EAAE,gBAAgB,CAAuB;IAC1D,QAAQ,CAAC,kBAAkB,EAAE,iBAAiB,EAAE,CAAM;IAEhD,MAAM,CAAC,KAAK,EAAE,QAAQ,EAAE,EAAE,OAAO,EAAE,eAAe,GAAG,OAAO,CAAC,cAAc,EAAE,CAAC;IAkBpF;;;;;OAKG;IACH,OAAO,CAAC,uBAAuB;IAwD/B;;;;;;;OAOG;IACH,OAAO,CAAC,yBAAyB;IAyCjC;;;;;OAKG;IACH,OAAO,CAAC,4BAA4B;IAqBpC,kEAAkE;IAClE,OAAO,CAAC,mBAAmB;IAY3B,mEAAmE;IACnE,OAAO,CAAC,gBAAgB;IA2BxB;;;;;OAKG;IACH,OAAO,CAAC,yBAAyB;IA6DjC;;OAEG;IACH,OAAO,CAAC,iBAAiB;IA4CzB;;OAEG;IACH,OAAO,CAAC,cAAc;CAGvB"}