@openclaw/synology-chat 2026.2.22 → 2026.5.2-beta.1

package/src/setup-surface.ts

@@ -0,0 +1,338 @@
+import {
+  createAllowFromSection,
+  createStandardChannelSetupStatus,
+  DEFAULT_ACCOUNT_ID,
+  formatDocsLink,
+  mergeAllowFromEntries,
+  normalizeAccountId,
+  setSetupChannelEnabled,
+  splitSetupEntries,
+  type ChannelSetupAdapter,
+  type ChannelSetupWizard,
+  type OpenClawConfig,
+} from "openclaw/plugin-sdk/setup";
+import { listAccountIds, resolveAccount } from "./accounts.js";
+import type { SynologyChatAccountRaw, SynologyChatChannelConfig } from "./types.js";
+
+const channel = "synology-chat" as const;
+const DEFAULT_WEBHOOK_PATH = "/webhook/synology";
+
+const SYNOLOGY_SETUP_HELP_LINES = [
+  "1) Create an incoming webhook in Synology Chat and copy its URL",
+  "2) Create an outgoing webhook and copy its secret token",
+  `3) Point the outgoing webhook to https://<gateway-host>${DEFAULT_WEBHOOK_PATH}`,
+  "4) Keep allowed user IDs handy for DM allowlisting",
+  `Docs: ${formatDocsLink("/channels/synology-chat", "channels/synology-chat")}`,
+];
+
+const SYNOLOGY_ALLOW_FROM_HELP_LINES = [
+  "Allowlist Synology Chat DMs by numeric user id.",
+  "Examples:",
+  "- 123456",
+  "- synology-chat:123456",
+  "Multiple entries: comma-separated.",
+  `Docs: ${formatDocsLink("/channels/synology-chat", "channels/synology-chat")}`,
+];
+
+function normalizeOptionalString(value: unknown): string | undefined {
+  if (typeof value !== "string") {
+    return undefined;
+  }
+  const trimmed = value.trim();
+  return trimmed || undefined;
+}
+
+function getChannelConfig(cfg: OpenClawConfig): SynologyChatChannelConfig {
+  return (cfg.channels?.[channel] as SynologyChatChannelConfig | undefined) ?? {};
+}
+
+function getRawAccountConfig(cfg: OpenClawConfig, accountId: string): SynologyChatAccountRaw {
+  const channelConfig = getChannelConfig(cfg);
+  if (accountId === DEFAULT_ACCOUNT_ID) {
+    return channelConfig;
+  }
+  return channelConfig.accounts?.[accountId] ?? {};
+}
+
+function patchSynologyChatAccountConfig(params: {
+  cfg: OpenClawConfig;
+  accountId: string;
+  patch: Record<string, unknown>;
+  clearFields?: string[];
+  enabled?: boolean;
+}): OpenClawConfig {
+  const channelConfig = getChannelConfig(params.cfg);
+  if (params.accountId === DEFAULT_ACCOUNT_ID) {
+    const nextChannelConfig = { ...channelConfig } as Record<string, unknown>;
+    for (const field of params.clearFields ?? []) {
+      delete nextChannelConfig[field];
+    }
+    return {
+      ...params.cfg,
+      channels: {
+        ...params.cfg.channels,
+        [channel]: {
+          ...nextChannelConfig,
+          ...(params.enabled ? { enabled: true } : {}),
+          ...params.patch,
+        },
+      },
+    };
+  }
+
+  const nextAccounts = { ...channelConfig.accounts } as Record<string, Record<string, unknown>>;
+  const nextAccountConfig = { ...nextAccounts[params.accountId] };
+  for (const field of params.clearFields ?? []) {
+    delete nextAccountConfig[field];
+  }
+  nextAccounts[params.accountId] = {
+    ...nextAccountConfig,
+    ...(params.enabled ? { enabled: true } : {}),
+    ...params.patch,
+  };
+
+  return {
+    ...params.cfg,
+    channels: {
+      ...params.cfg.channels,
+      [channel]: {
+        ...channelConfig,
+        ...(params.enabled ? { enabled: true } : {}),
+        accounts: nextAccounts,
+      },
+    },
+  };
+}
+
+function isSynologyChatConfigured(cfg: OpenClawConfig, accountId: string): boolean {
+  const account = resolveAccount(cfg, accountId);
+  return Boolean(account.token.trim() && account.incomingUrl.trim());
+}
+
+function validateWebhookUrl(value: string): string | undefined {
+  try {
+    const parsed = new URL(value);
+    if (parsed.protocol !== "http:" && parsed.protocol !== "https:") {
+      return "Incoming webhook must use http:// or https://.";
+    }
+  } catch {
+    return "Incoming webhook must be a valid URL.";
+  }
+  return undefined;
+}
+
+function validateWebhookPath(value: string): string | undefined {
+  const trimmed = value.trim();
+  if (!trimmed) {
+    return undefined;
+  }
+  return trimmed.startsWith("/") ? undefined : "Webhook path must start with /.";
+}
+
+function parseSynologyUserId(value: string): string | null {
+  const cleaned = value.replace(/^synology(?:[-_]?chat)?:/i, "").trim();
+  return /^\d+$/.test(cleaned) ? cleaned : null;
+}
+
+function normalizeSynologyAllowedUserId(value: unknown): string {
+  if (
+    typeof value === "string" ||
+    typeof value === "number" ||
+    typeof value === "boolean" ||
+    typeof value === "bigint"
+  ) {
+    return `${value}`.trim();
+  }
+  return "";
+}
+
+function resolveExistingAllowedUserIds(cfg: OpenClawConfig, accountId: string): string[] {
+  const raw = getRawAccountConfig(cfg, accountId).allowedUserIds;
+  if (Array.isArray(raw)) {
+    return raw.map(normalizeSynologyAllowedUserId).filter(Boolean);
+  }
+  return normalizeSynologyAllowedUserId(raw)
+    .split(",")
+    .map((value) => value.trim())
+    .filter(Boolean);
+}
+
+export const synologyChatSetupAdapter: ChannelSetupAdapter = {
+  resolveAccountId: ({ accountId }) => normalizeAccountId(accountId) ?? DEFAULT_ACCOUNT_ID,
+  validateInput: ({ accountId, input }) => {
+    if (input.useEnv && accountId !== DEFAULT_ACCOUNT_ID) {
+      return "Synology Chat env credentials only support the default account.";
+    }
+    if (!input.useEnv && !input.token?.trim()) {
+      return "Synology Chat requires --token or --use-env.";
+    }
+    if (!input.url?.trim()) {
+      return "Synology Chat requires --url for the incoming webhook.";
+    }
+    const urlError = validateWebhookUrl(input.url.trim());
+    if (urlError) {
+      return urlError;
+    }
+    if (input.webhookPath?.trim()) {
+      return validateWebhookPath(input.webhookPath.trim()) ?? null;
+    }
+    return null;
+  },
+  applyAccountConfig: ({ cfg, accountId, input }) =>
+    patchSynologyChatAccountConfig({
+      cfg,
+      accountId,
+      enabled: true,
+      clearFields: input.useEnv ? ["token"] : undefined,
+      patch: {
+        ...(input.useEnv ? {} : { token: input.token?.trim() }),
+        incomingUrl: input.url?.trim(),
+        ...(input.webhookPath?.trim() ? { webhookPath: input.webhookPath.trim() } : {}),
+      },
+    }),
+};
+
+export const synologyChatSetupWizard: ChannelSetupWizard = {
+  channel,
+  status: createStandardChannelSetupStatus({
+    channelLabel: "Synology Chat",
+    configuredLabel: "configured",
+    unconfiguredLabel: "needs token + incoming webhook",
+    configuredHint: "configured",
+    unconfiguredHint: "needs token + incoming webhook",
+    configuredScore: 1,
+    unconfiguredScore: 0,
+    includeStatusLine: true,
+    resolveConfigured: ({ cfg, accountId }) =>
+      accountId
+        ? isSynologyChatConfigured(cfg, accountId)
+        : listAccountIds(cfg).some((candidateAccountId) =>
+            isSynologyChatConfigured(cfg, candidateAccountId),
+          ),
+    resolveExtraStatusLines: ({ cfg }) => [`Accounts: ${listAccountIds(cfg).length || 0}`],
+  }),
+  introNote: {
+    title: "Synology Chat webhook setup",
+    lines: SYNOLOGY_SETUP_HELP_LINES,
+  },
+  credentials: [
+    {
+      inputKey: "token",
+      providerHint: channel,
+      credentialLabel: "outgoing webhook token",
+      preferredEnvVar: "SYNOLOGY_CHAT_TOKEN",
+      helpTitle: "Synology Chat webhook token",
+      helpLines: SYNOLOGY_SETUP_HELP_LINES,
+      envPrompt: "SYNOLOGY_CHAT_TOKEN detected. Use env var?",
+      keepPrompt: "Synology Chat webhook token already configured. Keep it?",
+      inputPrompt: "Enter Synology Chat outgoing webhook token",
+      allowEnv: ({ accountId }) => accountId === DEFAULT_ACCOUNT_ID,
+      inspect: ({ cfg, accountId }) => {
+        const account = resolveAccount(cfg, accountId);
+        const raw = getRawAccountConfig(cfg, accountId);
+        return {
+          accountConfigured: isSynologyChatConfigured(cfg, accountId),
+          hasConfiguredValue: Boolean(normalizeOptionalString(raw.token)),
+          resolvedValue: normalizeOptionalString(account.token),
+          envValue:
+            accountId === DEFAULT_ACCOUNT_ID
+              ? normalizeOptionalString(process.env.SYNOLOGY_CHAT_TOKEN)
+              : undefined,
+        };
+      },
+      applyUseEnv: async ({ cfg, accountId }) =>
+        patchSynologyChatAccountConfig({
+          cfg,
+          accountId,
+          enabled: true,
+          clearFields: ["token"],
+          patch: {},
+        }),
+      applySet: async ({ cfg, accountId, resolvedValue }) =>
+        patchSynologyChatAccountConfig({
+          cfg,
+          accountId,
+          enabled: true,
+          patch: { token: resolvedValue },
+        }),
+    },
+  ],
+  textInputs: [
+    {
+      inputKey: "url",
+      message: "Incoming webhook URL",
+      placeholder:
+        "https://nas.example.com/webapi/entry.cgi?api=SYNO.Chat.External&method=incoming...",
+      helpTitle: "Synology Chat incoming webhook",
+      helpLines: [
+        "Use the incoming webhook URL from Synology Chat integrations.",
+        "This is the URL OpenClaw uses to send replies back to Chat.",
+      ],
+      currentValue: ({ cfg, accountId }) => getRawAccountConfig(cfg, accountId).incomingUrl?.trim(),
+      keepPrompt: (value) => `Incoming webhook URL set (${value}). Keep it?`,
+      validate: ({ value }) => validateWebhookUrl(value),
+      applySet: async ({ cfg, accountId, value }) =>
+        patchSynologyChatAccountConfig({
+          cfg,
+          accountId,
+          enabled: true,
+          patch: { incomingUrl: value.trim() },
+        }),
+    },
+    {
+      inputKey: "webhookPath",
+      message: "Outgoing webhook path (optional)",
+      placeholder: DEFAULT_WEBHOOK_PATH,
+      required: false,
+      applyEmptyValue: true,
+      helpTitle: "Synology Chat outgoing webhook path",
+      helpLines: [
+        `Default path: ${DEFAULT_WEBHOOK_PATH}`,
+        "Change this only if you need multiple Synology Chat webhook routes.",
+      ],
+      currentValue: ({ cfg, accountId }) => getRawAccountConfig(cfg, accountId).webhookPath?.trim(),
+      keepPrompt: (value) => `Outgoing webhook path set (${value}). Keep it?`,
+      validate: ({ value }) => validateWebhookPath(value),
+      applySet: async ({ cfg, accountId, value }) =>
+        patchSynologyChatAccountConfig({
+          cfg,
+          accountId,
+          enabled: true,
+          clearFields: value.trim() ? undefined : ["webhookPath"],
+          patch: value.trim() ? { webhookPath: value.trim() } : {},
+        }),
+    },
+  ],
+  allowFrom: createAllowFromSection({
+    helpTitle: "Synology Chat allowlist",
+    helpLines: SYNOLOGY_ALLOW_FROM_HELP_LINES,
+    message: "Allowed Synology Chat user ids",
+    placeholder: "123456, 987654",
+    invalidWithoutCredentialNote: "Synology Chat user ids must be numeric.",
+    parseInputs: splitSetupEntries,
+    parseId: parseSynologyUserId,
+    apply: async ({ cfg, accountId, allowFrom }) =>
+      patchSynologyChatAccountConfig({
+        cfg,
+        accountId,
+        enabled: true,
+        patch: {
+          dmPolicy: "allowlist",
+          allowedUserIds: mergeAllowFromEntries(
+            resolveExistingAllowedUserIds(cfg, accountId),
+            allowFrom,
+          ),
+        },
+      }),
+  }),
+  completionNote: {
+    title: "Synology Chat access control",
+    lines: [
+      `Default outgoing webhook path: ${DEFAULT_WEBHOOK_PATH}`,
+      'Set allowed user IDs, or manually switch `channels.synology-chat.dmPolicy` to `"open"` with `allowedUserIds: ["*"]` for public DMs.',
+      'With `dmPolicy="allowlist"`, an empty allowedUserIds list blocks the route from starting.',
+      `Docs: ${formatDocsLink("/channels/synology-chat", "channels/synology-chat")}`,
+    ],
+  },
+  disable: (cfg) => setSetupChannelEnabled(cfg, channel, false),
+};

package/src/test-http-utils.ts

@@ -0,0 +1,75 @@
+import { EventEmitter } from "node:events";
+import type { IncomingMessage, ServerResponse } from "node:http";
+
+function makeBaseReq(
+  method: string,
+  opts: { headers?: Record<string, string>; url?: string } = {},
+): IncomingMessage & { destroyed: boolean } {
+  const req = new EventEmitter() as IncomingMessage & { destroyed: boolean };
+  req.method = method;
+  req.headers = opts.headers ?? {};
+  req.url = opts.url ?? "/webhook/synology";
+  req.socket = { remoteAddress: "127.0.0.1" } as unknown as IncomingMessage["socket"];
+  req.destroyed = false;
+  req.destroy = ((_: Error | undefined) => {
+    if (req.destroyed) {
+      return req;
+    }
+    req.destroyed = true;
+    return req;
+  }) as IncomingMessage["destroy"];
+  return req;
+}
+
+export function makeReq(
+  method: string,
+  body: string,
+  opts: { headers?: Record<string, string>; url?: string } = {},
+): IncomingMessage {
+  const req = makeBaseReq(method, opts);
+  process.nextTick(() => {
+    if (req.destroyed) {
+      return;
+    }
+    req.emit("data", Buffer.from(body));
+    req.emit("end");
+  });
+  return req;
+}
+
+export function makeStalledReq(
+  method: string,
+  opts: { headers?: Record<string, string>; url?: string } = {},
+): IncomingMessage {
+  return makeBaseReq(method, opts);
+}
+
+export function makeRes(): ServerResponse & { _status: number; _body: string } {
+  const res = {
+    _status: 0,
+    _body: "",
+    writeHead(statusCode: number, _headers: Record<string, string>) {
+      res._status = statusCode;
+    },
+    end(body?: string) {
+      res._body = body ?? "";
+    },
+  } as unknown as ServerResponse & { _status: number; _body: string };
+  Object.defineProperty(res, "statusCode", {
+    configurable: true,
+    enumerable: true,
+    get() {
+      return res._status;
+    },
+    set(value: number) {
+      res._status = value;
+    },
+  });
+  return res;
+}
+
+export function makeFormBody(fields: Record<string, string>): string {
+  return Object.entries(fields)
+    .map(([k, v]) => `${encodeURIComponent(k)}=${encodeURIComponent(v)}`)
+    .join("&");
+}

package/src/types.ts

@@ -2,34 +2,30 @@
  * Type definitions for the Synology Chat channel plugin.
  */
 
-/** Raw channel config from openclaw.json channels.synology-chat */
-export interface SynologyChatChannelConfig {
+type SynologyChatConfigFields = {
   enabled?: boolean;
   token?: string;
   incomingUrl?: string;
   nasHost?: string;
   webhookPath?: string;
+  dangerouslyAllowNameMatching?: boolean;
+  dangerouslyAllowInheritedWebhookPath?: boolean;
   dmPolicy?: "open" | "allowlist" | "disabled";
   allowedUserIds?: string | string[];
   rateLimitPerMinute?: number;
   botName?: string;
   allowInsecureSsl?: boolean;
+};
+
+export type SynologyWebhookPathSource = "default" | "inherited-base" | "explicit";
+
+/** Raw channel config from openclaw.json channels.synology-chat */
+export interface SynologyChatChannelConfig extends SynologyChatConfigFields {
   accounts?: Record<string, SynologyChatAccountRaw>;
 }
 
 /** Raw per-account config (overrides base config) */
-export interface SynologyChatAccountRaw {
-  enabled?: boolean;
-  token?: string;
-  incomingUrl?: string;
-  nasHost?: string;
-  webhookPath?: string;
-  dmPolicy?: "open" | "allowlist" | "disabled";
-  allowedUserIds?: string | string[];
-  rateLimitPerMinute?: number;
-  botName?: string;
-  allowInsecureSsl?: boolean;
-}
+export interface SynologyChatAccountRaw extends SynologyChatConfigFields {}
 
 /** Fully resolved account config with defaults applied */
 export interface ResolvedSynologyChatAccount {
@@ -39,6 +35,9 @@ export interface ResolvedSynologyChatAccount {
   incomingUrl: string;
   nasHost: string;
   webhookPath: string;
+  webhookPathSource: SynologyWebhookPathSource;
+  dangerouslyAllowNameMatching: boolean;
+  dangerouslyAllowInheritedWebhookPath: boolean;
   dmPolicy: "open" | "allowlist" | "disabled";
   allowedUserIds: string[];
   rateLimitPerMinute: number;