@openclaw/msteams 2026.5.2 → 2026.5.3-beta.2

package/src/pending-uploads.test.ts

@@ -1,173 +0,0 @@
-import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
-import {
-  clearPendingUploads,
-  getPendingUpload,
-  getPendingUploadCount,
-  removePendingUpload,
-  setPendingUploadActivityId,
-  storePendingUpload,
-} from "./pending-uploads.js";
-
-describe("pending-uploads", () => {
-  beforeEach(() => {
-    vi.useFakeTimers();
-    clearPendingUploads();
-  });
-
-  afterEach(() => {
-    clearPendingUploads();
-    vi.useRealTimers();
-  });
-
-  describe("storePendingUpload", () => {
-    it("stores and retrieves a pending upload", () => {
-      const id = storePendingUpload({
-        buffer: Buffer.from("data"),
-        filename: "file.txt",
-        contentType: "text/plain",
-        conversationId: "conv-1",
-      });
-
-      const upload = getPendingUpload(id);
-      expect(upload).toBeDefined();
-      expect(upload?.filename).toBe("file.txt");
-      expect(upload?.conversationId).toBe("conv-1");
-    });
-
-    it("stores consentCardActivityId when provided", () => {
-      const id = storePendingUpload({
-        buffer: Buffer.from("data"),
-        filename: "file.txt",
-        conversationId: "conv-1",
-        consentCardActivityId: "activity-abc",
-      });
-
-      const upload = getPendingUpload(id);
-      expect(upload?.consentCardActivityId).toBe("activity-abc");
-    });
-
-    it("stores without consentCardActivityId when not provided", () => {
-      const id = storePendingUpload({
-        buffer: Buffer.from("data"),
-        filename: "file.txt",
-        conversationId: "conv-1",
-      });
-
-      const upload = getPendingUpload(id);
-      expect(upload?.consentCardActivityId).toBeUndefined();
-    });
-
-    it("auto-removes entry after TTL expires", () => {
-      const id = storePendingUpload({
-        buffer: Buffer.from("data"),
-        filename: "file.txt",
-        conversationId: "conv-1",
-      });
-
-      expect(getPendingUpload(id)).toBeDefined();
-      vi.advanceTimersByTime(5 * 60 * 1000 + 1);
-      // After TTL the in-memory check also gates access
-      expect(getPendingUpload(id)).toBeUndefined();
-    });
-  });
-
-  describe("removePendingUpload", () => {
-    it("removes the entry immediately", () => {
-      const id = storePendingUpload({
-        buffer: Buffer.from("data"),
-        filename: "file.txt",
-        conversationId: "conv-1",
-      });
-
-      removePendingUpload(id);
-      expect(getPendingUpload(id)).toBeUndefined();
-    });
-
-    it("clears the TTL timer so it does not fire after explicit removal", () => {
-      const id = storePendingUpload({
-        buffer: Buffer.from("data"),
-        filename: "file.txt",
-        conversationId: "conv-1",
-      });
-
-      expect(getPendingUploadCount()).toBe(1);
-      removePendingUpload(id);
-      expect(getPendingUploadCount()).toBe(0);
-
-      // Advance past TTL — timer should have been cleared and count stays 0
-      vi.advanceTimersByTime(5 * 60 * 1000 + 1);
-      expect(getPendingUploadCount()).toBe(0);
-    });
-
-    it("is a no-op for undefined id", () => {
-      storePendingUpload({
-        buffer: Buffer.from("data"),
-        filename: "file.txt",
-        conversationId: "conv-1",
-      });
-
-      expect(() => removePendingUpload(undefined)).not.toThrow();
-      expect(getPendingUploadCount()).toBe(1);
-    });
-
-    it("is a no-op for unknown id", () => {
-      expect(() => removePendingUpload("non-existent-id")).not.toThrow();
-    });
-  });
-
-  describe("clearPendingUploads", () => {
-    it("removes all entries and cancels timers", () => {
-      storePendingUpload({ buffer: Buffer.from("a"), filename: "a.txt", conversationId: "c1" });
-      storePendingUpload({ buffer: Buffer.from("b"), filename: "b.txt", conversationId: "c2" });
-      expect(getPendingUploadCount()).toBe(2);
-
-      clearPendingUploads();
-      expect(getPendingUploadCount()).toBe(0);
-
-      // TTL timers should have been cleared — no side-effects after advance
-      vi.advanceTimersByTime(5 * 60 * 1000 + 1);
-      expect(getPendingUploadCount()).toBe(0);
-    });
-  });
-
-  describe("setPendingUploadActivityId", () => {
-    it("sets the consentCardActivityId on an existing upload", () => {
-      const id = storePendingUpload({
-        buffer: Buffer.from("data"),
-        filename: "file.txt",
-        conversationId: "conv-1",
-      });
-
-      expect(getPendingUpload(id)?.consentCardActivityId).toBeUndefined();
-
-      setPendingUploadActivityId(id, "activity-xyz");
-      expect(getPendingUpload(id)?.consentCardActivityId).toBe("activity-xyz");
-    });
-
-    it("is a no-op for unknown upload id", () => {
-      expect(() => setPendingUploadActivityId("non-existent", "activity-xyz")).not.toThrow();
-    });
-  });
-
-  describe("getPendingUpload", () => {
-    it("returns undefined for undefined id", () => {
-      expect(getPendingUpload(undefined)).toBeUndefined();
-    });
-
-    it("returns undefined for unknown id", () => {
-      expect(getPendingUpload("no-such-id")).toBeUndefined();
-    });
-
-    it("returns undefined when entry is past TTL but timer has not yet fired", () => {
-      const id = storePendingUpload({
-        buffer: Buffer.from("data"),
-        filename: "file.txt",
-        conversationId: "conv-1",
-      });
-
-      // Manually advance time without firing timers to simulate stale entry
-      vi.setSystemTime(Date.now() + 5 * 60 * 1000 + 1);
-      expect(getPendingUpload(id)).toBeUndefined();
-    });
-  });
-});

package/src/pending-uploads.ts

@@ -1,121 +0,0 @@
-/**
- * In-memory storage for files awaiting user consent in the FileConsentCard flow.
- *
- * When sending large files (>=4MB) in personal chats, Teams requires user consent
- * before upload. This module stores the file data temporarily until the user
- * accepts or declines, or until the TTL expires.
- */
-
-import crypto from "node:crypto";
-
-export interface PendingUpload {
-  id: string;
-  buffer: Buffer;
-  filename: string;
-  contentType?: string;
-  conversationId: string;
-  /** Activity ID of the original FileConsentCard, used to replace it after upload */
-  consentCardActivityId?: string;
-  createdAt: number;
-}
-
-const pendingUploads = new Map<string, PendingUpload>();
-/** Timer handles keyed by upload ID, cleared on explicit removal to prevent ghost cleanup */
-const pendingUploadTimers = new Map<string, ReturnType<typeof setTimeout>>();
-
-/** TTL for pending uploads: 5 minutes */
-const PENDING_UPLOAD_TTL_MS = 5 * 60 * 1000;
-
-/**
- * Store a file pending user consent.
- * Returns the upload ID to include in the FileConsentCard context.
- */
-export function storePendingUpload(upload: Omit<PendingUpload, "id" | "createdAt">): string {
-  const id = crypto.randomUUID();
-  const entry: PendingUpload = {
-    ...upload,
-    id,
-    createdAt: Date.now(),
-  };
-  pendingUploads.set(id, entry);
-
-  // Auto-cleanup after TTL; timer ref stored so removePendingUpload can cancel it
-  const timer = setTimeout(() => {
-    pendingUploads.delete(id);
-    pendingUploadTimers.delete(id);
-  }, PENDING_UPLOAD_TTL_MS);
-  pendingUploadTimers.set(id, timer);
-
-  return id;
-}
-
-/**
- * Retrieve a pending upload by ID.
- * Returns undefined if not found or expired.
- */
-export function getPendingUpload(id?: string): PendingUpload | undefined {
-  if (!id) {
-    return undefined;
-  }
-  const entry = pendingUploads.get(id);
-  if (!entry) {
-    return undefined;
-  }
-
-  // Check if expired (in case timeout hasn't fired yet)
-  if (Date.now() - entry.createdAt > PENDING_UPLOAD_TTL_MS) {
-    pendingUploads.delete(id);
-    const timer = pendingUploadTimers.get(id);
-    if (timer !== undefined) {
-      clearTimeout(timer);
-      pendingUploadTimers.delete(id);
-    }
-    return undefined;
-  }
-
-  return entry;
-}
-
-/**
- * Remove a pending upload (after successful upload or user decline).
- * Also clears the TTL timer to prevent ghost Map deletions.
- */
-export function removePendingUpload(id?: string): void {
-  if (id) {
-    pendingUploads.delete(id);
-    const timer = pendingUploadTimers.get(id);
-    if (timer !== undefined) {
-      clearTimeout(timer);
-      pendingUploadTimers.delete(id);
-    }
-  }
-}
-
-/**
- * Set the consent card activity ID on an existing pending upload.
- * Called after the FileConsentCard is sent and we know its activity ID.
- */
-export function setPendingUploadActivityId(uploadId: string, activityId: string): void {
-  const entry = pendingUploads.get(uploadId);
-  if (entry) {
-    entry.consentCardActivityId = activityId;
-  }
-}
-
-/**
- * Get the count of pending uploads (for monitoring/debugging).
- */
-export function getPendingUploadCount(): number {
-  return pendingUploads.size;
-}
-
-/**
- * Clear all pending uploads (for testing).
- */
-export function clearPendingUploads(): void {
-  for (const timer of pendingUploadTimers.values()) {
-    clearTimeout(timer);
-  }
-  pendingUploadTimers.clear();
-  pendingUploads.clear();
-}

package/src/policy.test.ts

@@ -1,240 +0,0 @@
-import { describe, expect, it } from "vitest";
-import type { MSTeamsConfig } from "../runtime-api.js";
-import {
-  isMSTeamsGroupAllowed,
-  resolveMSTeamsReplyPolicy,
-  resolveMSTeamsRouteConfig,
-} from "./policy.js";
-
-function resolveNamedTeamRouteConfig(allowNameMatching = false) {
-  const cfg: MSTeamsConfig = {
-    teams: {
-      "My Team": {
-        requireMention: true,
-        channels: {
-          "General Chat": { requireMention: false },
-        },
-      },
-    },
-  };
-
-  return resolveMSTeamsRouteConfig({
-    cfg,
-    teamName: "My Team",
-    channelName: "General Chat",
-    conversationId: "ignored",
-    allowNameMatching,
-  });
-}
-
-describe("msteams policy", () => {
-  describe("resolveMSTeamsRouteConfig", () => {
-    it("returns team and channel config when present", () => {
-      const cfg: MSTeamsConfig = {
-        teams: {
-          team123: {
-            requireMention: false,
-            channels: {
-              chan456: { requireMention: true },
-            },
-          },
-        },
-      };
-
-      const res = resolveMSTeamsRouteConfig({
-        cfg,
-        teamId: "team123",
-        conversationId: "chan456",
-      });
-
-      if (!res.teamConfig || !res.channelConfig) {
-        throw new Error("expected matched team and channel config");
-      }
-      expect(res.teamConfig.requireMention).toBe(false);
-      expect(res.channelConfig.requireMention).toBe(true);
-      expect(res.allowlistConfigured).toBe(true);
-      expect(res.allowed).toBe(true);
-      expect(res.channelMatchKey).toBe("chan456");
-      expect(res.channelMatchSource).toBe("direct");
-    });
-
-    it("returns undefined configs when teamId is missing", () => {
-      const cfg: MSTeamsConfig = {
-        teams: { team123: { requireMention: false } },
-      };
-
-      const res = resolveMSTeamsRouteConfig({
-        cfg,
-        teamId: undefined,
-        conversationId: "chan",
-      });
-      expect(res.teamConfig).toBeUndefined();
-      expect(res.channelConfig).toBeUndefined();
-      expect(res.allowlistConfigured).toBe(true);
-      expect(res.allowed).toBe(false);
-    });
-
-    it("blocks team and channel name matches by default", () => {
-      const res = resolveNamedTeamRouteConfig();
-
-      expect(res.teamConfig).toBeUndefined();
-      expect(res.channelConfig).toBeUndefined();
-      expect(res.allowed).toBe(false);
-    });
-
-    it("matches team and channel by name when dangerous name matching is enabled", () => {
-      const res = resolveNamedTeamRouteConfig(true);
-
-      if (!res.teamConfig || !res.channelConfig) {
-        throw new Error("expected matched named team and channel config");
-      }
-      expect(res.teamConfig.requireMention).toBe(true);
-      expect(res.channelConfig.requireMention).toBe(false);
-      expect(res.allowed).toBe(true);
-    });
-  });
-
-  describe("resolveMSTeamsReplyPolicy", () => {
-    it("forces thread replies for direct messages", () => {
-      const policy = resolveMSTeamsReplyPolicy({
-        isDirectMessage: true,
-        globalConfig: { replyStyle: "top-level", requireMention: false },
-      });
-      expect(policy).toEqual({ requireMention: false, replyStyle: "thread" });
-    });
-
-    it("defaults to requireMention=true and replyStyle=thread", () => {
-      const policy = resolveMSTeamsReplyPolicy({
-        isDirectMessage: false,
-        globalConfig: {},
-      });
-      expect(policy).toEqual({ requireMention: true, replyStyle: "thread" });
-    });
-
-    it("defaults replyStyle to top-level when requireMention=false", () => {
-      const policy = resolveMSTeamsReplyPolicy({
-        isDirectMessage: false,
-        globalConfig: { requireMention: false },
-      });
-      expect(policy).toEqual({
-        requireMention: false,
-        replyStyle: "top-level",
-      });
-    });
-
-    it("prefers channel overrides over team and global defaults", () => {
-      const policy = resolveMSTeamsReplyPolicy({
-        isDirectMessage: false,
-        globalConfig: { requireMention: true },
-        teamConfig: { requireMention: true },
-        channelConfig: { requireMention: false },
-      });
-
-      // requireMention from channel -> false, and replyStyle defaults from requireMention -> top-level
-      expect(policy).toEqual({
-        requireMention: false,
-        replyStyle: "top-level",
-      });
-    });
-
-    it("inherits team mention settings when channel config is missing", () => {
-      const policy = resolveMSTeamsReplyPolicy({
-        isDirectMessage: false,
-        globalConfig: { requireMention: true },
-        teamConfig: { requireMention: false },
-      });
-      expect(policy).toEqual({
-        requireMention: false,
-        replyStyle: "top-level",
-      });
-    });
-
-    it("uses explicit replyStyle even when requireMention defaults would differ", () => {
-      const policy = resolveMSTeamsReplyPolicy({
-        isDirectMessage: false,
-        globalConfig: { requireMention: false, replyStyle: "thread" },
-      });
-      expect(policy).toEqual({ requireMention: false, replyStyle: "thread" });
-    });
-  });
-
-  describe("isMSTeamsGroupAllowed", () => {
-    it("allows when policy is open", () => {
-      expect(
-        isMSTeamsGroupAllowed({
-          groupPolicy: "open",
-          allowFrom: [],
-          senderId: "user-id",
-          senderName: "User",
-        }),
-      ).toBe(true);
-    });
-
-    it("blocks when policy is disabled", () => {
-      expect(
-        isMSTeamsGroupAllowed({
-          groupPolicy: "disabled",
-          allowFrom: ["user-id"],
-          senderId: "user-id",
-          senderName: "User",
-        }),
-      ).toBe(false);
-    });
-
-    it("blocks allowlist when empty", () => {
-      expect(
-        isMSTeamsGroupAllowed({
-          groupPolicy: "allowlist",
-          allowFrom: [],
-          senderId: "user-id",
-          senderName: "User",
-        }),
-      ).toBe(false);
-    });
-
-    it("allows allowlist when sender matches", () => {
-      expect(
-        isMSTeamsGroupAllowed({
-          groupPolicy: "allowlist",
-          allowFrom: ["User-Id"],
-          senderId: "user-id",
-          senderName: "User",
-        }),
-      ).toBe(true);
-    });
-
-    it("blocks sender-name allowlist matches by default", () => {
-      expect(
-        isMSTeamsGroupAllowed({
-          groupPolicy: "allowlist",
-          allowFrom: ["user"],
-          senderId: "other",
-          senderName: "User",
-        }),
-      ).toBe(false);
-    });
-
-    it("allows sender-name allowlist matches when explicitly enabled", () => {
-      expect(
-        isMSTeamsGroupAllowed({
-          groupPolicy: "allowlist",
-          allowFrom: ["user"],
-          senderId: "other",
-          senderName: "User",
-          allowNameMatching: true,
-        }),
-      ).toBe(true);
-    });
-
-    it("allows allowlist wildcard", () => {
-      expect(
-        isMSTeamsGroupAllowed({
-          groupPolicy: "allowlist",
-          allowFrom: ["*"],
-          senderId: "other",
-          senderName: "User",
-        }),
-      ).toBe(true);
-    });
-  });
-});