@openclaw/feishu 2026.3.2 → 2026.3.7

package/src/bot.stripBotMention.test.ts

@@ -1,38 +1,134 @@
 import { describe, expect, it } from "vitest";
-import { stripBotMention, type FeishuMessageEvent } from "./bot.js";
+import { parseFeishuMessageEvent } from "./bot.js";
 
-type Mentions = FeishuMessageEvent["message"]["mentions"];
+function makeEvent(
+  text: string,
+  mentions?: Array<{ key: string; name: string; id: { open_id?: string; user_id?: string } }>,
+  chatType: "p2p" | "group" = "p2p",
+) {
+  return {
+    sender: { sender_id: { user_id: "u1", open_id: "ou_sender" } },
+    message: {
+      message_id: "msg_1",
+      chat_id: "oc_chat1",
+      chat_type: chatType,
+      message_type: "text",
+      content: JSON.stringify({ text }),
+      mentions,
+    },
+  };
+}
 
-describe("stripBotMention", () => {
+const BOT_OPEN_ID = "ou_bot";
+
+describe("normalizeMentions (via parseFeishuMessageEvent)", () => {
   it("returns original text when mentions are missing", () => {
-    expect(stripBotMention("hello world", undefined)).toBe("hello world");
+    const ctx = parseFeishuMessageEvent(makeEvent("hello world", undefined) as any, BOT_OPEN_ID);
+    expect(ctx.content).toBe("hello world");
+  });
+
+  it("strips bot mention in p2p (addressing prefix, not semantic content)", () => {
+    const ctx = parseFeishuMessageEvent(
+      makeEvent("@_bot_1 hello", [
+        { key: "@_bot_1", name: "Bot", id: { open_id: "ou_bot" } },
+      ]) as any,
+      BOT_OPEN_ID,
+    );
+    expect(ctx.content).toBe("hello");
+  });
+
+  it("strips bot mention in group so slash commands work (#35994)", () => {
+    const ctx = parseFeishuMessageEvent(
+      makeEvent(
+        "@_bot_1 hello",
+        [{ key: "@_bot_1", name: "Bot", id: { open_id: "ou_bot" } }],
+        "group",
+      ) as any,
+      BOT_OPEN_ID,
+    );
+    expect(ctx.content).toBe("hello");
+  });
+
+  it("strips bot mention in group preserving slash command prefix (#35994)", () => {
+    const ctx = parseFeishuMessageEvent(
+      makeEvent(
+        "@_bot_1 /model",
+        [{ key: "@_bot_1", name: "Bot", id: { open_id: "ou_bot" } }],
+        "group",
+      ) as any,
+      BOT_OPEN_ID,
+    );
+    expect(ctx.content).toBe("/model");
+  });
+
+  it("strips bot mention but normalizes other mentions in p2p (mention-forward)", () => {
+    const ctx = parseFeishuMessageEvent(
+      makeEvent("@_bot_1 @_user_alice hello", [
+        { key: "@_bot_1", name: "Bot", id: { open_id: "ou_bot" } },
+        { key: "@_user_alice", name: "Alice", id: { open_id: "ou_alice" } },
+      ]) as any,
+      BOT_OPEN_ID,
+    );
+    expect(ctx.content).toBe('<at user_id="ou_alice">Alice</at> hello');
+  });
+
+  it("falls back to @name when open_id is absent", () => {
+    const ctx = parseFeishuMessageEvent(
+      makeEvent("@_user_1 hi", [
+        { key: "@_user_1", name: "Alice", id: { user_id: "uid_alice" } },
+      ]) as any,
+      BOT_OPEN_ID,
+    );
+    expect(ctx.content).toBe("@Alice hi");
   });
 
-  it("strips mention name and key for normal mentions", () => {
-    const mentions: Mentions = [{ key: "@_bot_1", name: "Bot", id: { open_id: "ou_bot" } }];
-    expect(stripBotMention("@Bot hello @_bot_1", mentions)).toBe("hello");
+  it("falls back to plain @name when no id is present", () => {
+    const ctx = parseFeishuMessageEvent(
+      makeEvent("@_unknown hey", [{ key: "@_unknown", name: "Nobody", id: {} }]) as any,
+      BOT_OPEN_ID,
+    );
+    expect(ctx.content).toBe("@Nobody hey");
   });
 
-  it("treats mention.name regex metacharacters as literal text", () => {
-    const mentions: Mentions = [{ key: "@_bot_1", name: ".*", id: { open_id: "ou_bot" } }];
-    expect(stripBotMention("@NotBot hello", mentions)).toBe("@NotBot hello");
+  it("treats mention key regex metacharacters as literal text", () => {
+    const ctx = parseFeishuMessageEvent(
+      makeEvent("hello world", [{ key: ".*", name: "Bot", id: { open_id: "ou_bot" } }]) as any,
+      BOT_OPEN_ID,
+    );
+    expect(ctx.content).toBe("hello world");
   });
 
-  it("treats mention.key regex metacharacters as literal text", () => {
-    const mentions: Mentions = [{ key: ".*", name: "Bot", id: { open_id: "ou_bot" } }];
-    expect(stripBotMention("hello world", mentions)).toBe("hello world");
+  it("normalizes multiple mentions in one pass", () => {
+    const ctx = parseFeishuMessageEvent(
+      makeEvent("@_bot_1 hi @_user_2", [
+        { key: "@_bot_1", name: "Bot One", id: { open_id: "ou_bot_1" } },
+        { key: "@_user_2", name: "User Two", id: { open_id: "ou_user_2" } },
+      ]) as any,
+      BOT_OPEN_ID,
+    );
+    expect(ctx.content).toBe(
+      '<at user_id="ou_bot_1">Bot One</at> hi <at user_id="ou_user_2">User Two</at>',
+    );
   });
 
-  it("trims once after all mention replacements", () => {
-    const mentions: Mentions = [{ key: "@_bot_1", name: "Bot", id: { open_id: "ou_bot" } }];
-    expect(stripBotMention("  @_bot_1 hello   ", mentions)).toBe("hello");
+  it("treats $ in display name as literal (no replacement-pattern interpolation)", () => {
+    const ctx = parseFeishuMessageEvent(
+      makeEvent("@_user_1 hi", [
+        { key: "@_user_1", name: "$& the user", id: { open_id: "ou_x" } },
+      ]) as any,
+      BOT_OPEN_ID,
+    );
+    // $ is preserved literally (no $& pattern substitution); & is not escaped in tag body
+    expect(ctx.content).toBe('<at user_id="ou_x">$& the user</at> hi');
   });
 
-  it("strips multiple mentions in one pass", () => {
-    const mentions: Mentions = [
-      { key: "@_bot_1", name: "Bot One", id: { open_id: "ou_bot_1" } },
-      { key: "@_bot_2", name: "Bot Two", id: { open_id: "ou_bot_2" } },
-    ];
-    expect(stripBotMention("@Bot One @_bot_1 hi @Bot Two @_bot_2", mentions)).toBe("hi");
+  it("escapes < and > in mention name to protect tag structure", () => {
+    const ctx = parseFeishuMessageEvent(
+      makeEvent("@_user_1 test", [
+        { key: "@_user_1", name: "<script>", id: { open_id: "ou_x" } },
+      ]) as any,
+      BOT_OPEN_ID,
+    );
+    expect(ctx.content).toBe('<at user_id="ou_x">&lt;script&gt;</at> test');
   });
 });