@openclaw/feishu 2026.3.13 → 2026.5.1-beta.1

package/src/bot.checkBotMentioned.test.ts

@@ -1,12 +1,12 @@
 import { describe, it, expect } from "vitest";
-import { parseFeishuMessageEvent } from "./bot.js";
+import { parseFeishuMessageEvent, type FeishuMessageEvent } from "./bot.js";
 
 // Helper to build a minimal FeishuMessageEvent for testing
 function makeEvent(
   chatType: "p2p" | "group" | "private",
   mentions?: Array<{ key: string; name: string; id: { open_id?: string } }>,
   text = "hello",
-) {
+): FeishuMessageEvent {
   return {
     sender: {
       sender_id: { user_id: "u1", open_id: "ou_sender" },
@@ -22,7 +22,7 @@ function makeEvent(
   };
 }
 
-function makePostEvent(content: unknown) {
+function makePostEvent(content: unknown): FeishuMessageEvent {
   return {
     sender: { sender_id: { user_id: "u1", open_id: "ou_sender" } },
     message: {
@@ -36,7 +36,7 @@ function makePostEvent(content: unknown) {
   };
 }
 
-function makeShareChatEvent(content: unknown) {
+function makeShareChatEvent(content: unknown): FeishuMessageEvent {
   return {
     sender: { sender_id: { user_id: "u1", open_id: "ou_sender" } },
     message: {
@@ -55,15 +55,15 @@ describe("parseFeishuMessageEvent – mentionedBot", () => {
 
   it("returns mentionedBot=false when there are no mentions", () => {
     const event = makeEvent("group", []);
-    const ctx = parseFeishuMessageEvent(event as any, BOT_OPEN_ID);
+    const ctx = parseFeishuMessageEvent(event, BOT_OPEN_ID);
     expect(ctx.mentionedBot).toBe(false);
   });
 
   it("falls back to sender user_id when open_id is missing", () => {
     const event = makeEvent("p2p", []);
-    (event as any).sender.sender_id = { user_id: "u_mobile_only" };
+    event.sender.sender_id = { user_id: "u_mobile_only" };
 
-    const ctx = parseFeishuMessageEvent(event as any, BOT_OPEN_ID);
+    const ctx = parseFeishuMessageEvent(event, BOT_OPEN_ID);
     expect(ctx.senderOpenId).toBe("u_mobile_only");
     expect(ctx.senderId).toBe("u_mobile_only");
   });
@@ -72,7 +72,7 @@ describe("parseFeishuMessageEvent – mentionedBot", () => {
     const event = makeEvent("group", [
       { key: "@_user_1", name: "Bot", id: { open_id: BOT_OPEN_ID } },
     ]);
-    const ctx = parseFeishuMessageEvent(event as any, BOT_OPEN_ID);
+    const ctx = parseFeishuMessageEvent(event, BOT_OPEN_ID);
     expect(ctx.mentionedBot).toBe(true);
   });
 
@@ -80,7 +80,7 @@ describe("parseFeishuMessageEvent – mentionedBot", () => {
     const event = makeEvent("group", [
       { key: "@_user_1", name: "OpenClaw Bot (Alias)", id: { open_id: BOT_OPEN_ID } },
     ]);
-    const ctx = parseFeishuMessageEvent(event as any, BOT_OPEN_ID, "OpenClaw Bot");
+    const ctx = parseFeishuMessageEvent(event, BOT_OPEN_ID, "OpenClaw Bot");
     expect(ctx.mentionedBot).toBe(true);
   });
 
@@ -88,15 +88,54 @@ describe("parseFeishuMessageEvent – mentionedBot", () => {
     const event = makeEvent("group", [
       { key: "@_user_1", name: "Alice", id: { open_id: "ou_alice" } },
     ]);
-    const ctx = parseFeishuMessageEvent(event as any, BOT_OPEN_ID);
+    const ctx = parseFeishuMessageEvent(event, BOT_OPEN_ID);
     expect(ctx.mentionedBot).toBe(false);
   });
 
+  it("returns mentionedBot=false for broadcast-only @_all text", () => {
+    const event = makeEvent("group", [], "@_all please review");
+    const ctx = parseFeishuMessageEvent(event, BOT_OPEN_ID);
+    expect(ctx.mentionedBot).toBe(false);
+  });
+
+  it("returns mentionedBot=false for broadcast-only @all mention metadata", () => {
+    const event = makeEvent("group", [{ key: "@_all", name: "all", id: { open_id: "all" } }]);
+    const ctx = parseFeishuMessageEvent(event, BOT_OPEN_ID);
+    expect(ctx.mentionedBot).toBe(false);
+  });
+
+  it("returns mentionedBot=false for @all even when botOpenId is the broadcast id", () => {
+    const event = makeEvent("group", [{ key: "@_all", name: "all", id: { open_id: "all" } }]);
+    const ctx = parseFeishuMessageEvent(event, "all");
+    expect(ctx.mentionedBot).toBe(false);
+  });
+
+  it("returns mentionedBot=true when bot is mentioned alongside @all", () => {
+    const event = makeEvent("group", [
+      { key: "@_all", name: "all", id: { open_id: "all" } },
+      { key: "@_bot_1", name: "Bot", id: { open_id: BOT_OPEN_ID } },
+    ]);
+    const ctx = parseFeishuMessageEvent(event, BOT_OPEN_ID);
+    expect(ctx.mentionedBot).toBe(true);
+    expect(ctx.mentionTargets).toBeUndefined();
+  });
+
+  it("does not include @all in mention-forward targets", () => {
+    const event = makeEvent("group", [
+      { key: "@_all", name: "all", id: { open_id: "all" } },
+      { key: "@_bot_1", name: "Bot", id: { open_id: BOT_OPEN_ID } },
+      { key: "@_user_1", name: "Alice", id: { open_id: "ou_alice" } },
+    ]);
+    const ctx = parseFeishuMessageEvent(event, BOT_OPEN_ID);
+    expect(ctx.mentionedBot).toBe(true);
+    expect(ctx.mentionTargets).toEqual([{ openId: "ou_alice", name: "Alice", key: "@_user_1" }]);
+  });
+
   it("returns mentionedBot=false when botOpenId is undefined (unknown bot)", () => {
     const event = makeEvent("group", [
       { key: "@_user_1", name: "Alice", id: { open_id: "ou_alice" } },
     ]);
-    const ctx = parseFeishuMessageEvent(event as any, undefined);
+    const ctx = parseFeishuMessageEvent(event, undefined);
     expect(ctx.mentionedBot).toBe(false);
   });
 
@@ -104,7 +143,7 @@ describe("parseFeishuMessageEvent – mentionedBot", () => {
     const event = makeEvent("group", [
       { key: "@_user_1", name: "Alice", id: { open_id: "ou_alice" } },
     ]);
-    const ctx = parseFeishuMessageEvent(event as any, "");
+    const ctx = parseFeishuMessageEvent(event, "");
     expect(ctx.mentionedBot).toBe(false);
   });
 
@@ -114,7 +153,7 @@ describe("parseFeishuMessageEvent – mentionedBot", () => {
       [{ key: "@_bot_1", name: ".*", id: { open_id: BOT_OPEN_ID } }],
       "@NotBot hello",
     );
-    const ctx = parseFeishuMessageEvent(event as any, BOT_OPEN_ID);
+    const ctx = parseFeishuMessageEvent(event, BOT_OPEN_ID);
     expect(ctx.content).toBe("@NotBot hello");
   });
 
@@ -124,7 +163,7 @@ describe("parseFeishuMessageEvent – mentionedBot", () => {
       [{ key: ".*", name: "Bot", id: { open_id: BOT_OPEN_ID } }],
       "hello world",
     );
-    const ctx = parseFeishuMessageEvent(event as any, BOT_OPEN_ID);
+    const ctx = parseFeishuMessageEvent(event, BOT_OPEN_ID);
     expect(ctx.content).toBe("hello world");
   });
 
@@ -136,7 +175,7 @@ describe("parseFeishuMessageEvent – mentionedBot", () => {
         [{ tag: "text", text: "What does this document say" }],
       ],
     });
-    const ctx = parseFeishuMessageEvent(event as any, BOT_OPEN_ID);
+    const ctx = parseFeishuMessageEvent(event, BOT_OPEN_ID);
     expect(ctx.mentionedBot).toBe(true);
   });
 
@@ -144,7 +183,7 @@ describe("parseFeishuMessageEvent – mentionedBot", () => {
     const event = makePostEvent({
       content: [[{ tag: "text", text: "hello" }]],
     });
-    const ctx = parseFeishuMessageEvent(event as any, "ou_bot_123");
+    const ctx = parseFeishuMessageEvent(event, "ou_bot_123");
     expect(ctx.mentionedBot).toBe(false);
   });
 
@@ -155,10 +194,43 @@ describe("parseFeishuMessageEvent – mentionedBot", () => {
         [{ tag: "text", text: "hello" }],
       ],
     });
-    const ctx = parseFeishuMessageEvent(event as any, "ou_bot_123");
+    const ctx = parseFeishuMessageEvent(event, "ou_bot_123");
+    expect(ctx.mentionedBot).toBe(false);
+  });
+
+  it("returns mentionedBot=false for post message with broadcast-only @all", () => {
+    const event = makePostEvent({
+      content: [
+        [{ tag: "at", user_id: "all", user_name: "all" }],
+        [{ tag: "text", text: "hello" }],
+      ],
+    });
+    const ctx = parseFeishuMessageEvent(event, BOT_OPEN_ID);
     expect(ctx.mentionedBot).toBe(false);
   });
 
+  it("returns mentionedBot=false for post @all even when botOpenId is the broadcast id", () => {
+    const event = makePostEvent({
+      content: [[{ tag: "at", user_id: "all", user_name: "all" }]],
+    });
+    const ctx = parseFeishuMessageEvent(event, "all");
+    expect(ctx.mentionedBot).toBe(false);
+  });
+
+  it("returns mentionedBot=true for post message with bot mention and broadcast @all", () => {
+    const event = makePostEvent({
+      content: [
+        [
+          { tag: "at", user_id: "all", user_name: "all" },
+          { tag: "text", text: " " },
+          { tag: "at", user_id: BOT_OPEN_ID, user_name: "claw" },
+        ],
+      ],
+    });
+    const ctx = parseFeishuMessageEvent(event, BOT_OPEN_ID);
+    expect(ctx.mentionedBot).toBe(true);
+  });
+
   it("preserves post code and code_block content", () => {
     const event = makePostEvent({
       content: [
@@ -169,7 +241,7 @@ describe("parseFeishuMessageEvent – mentionedBot", () => {
         [{ tag: "code_block", language: "ts", text: "const x = 1;" }],
       ],
     });
-    const ctx = parseFeishuMessageEvent(event as any, "ou_bot_123");
+    const ctx = parseFeishuMessageEvent(event, "ou_bot_123");
     expect(ctx.content).toContain("before `inline()`");
     expect(ctx.content).toContain("```ts\nconst x = 1;\n```");
   });
@@ -179,7 +251,7 @@ describe("parseFeishuMessageEvent – mentionedBot", () => {
       body: "Merged and Forwarded Message",
       share_chat_id: "sc_abc123",
     });
-    const ctx = parseFeishuMessageEvent(event as any, "ou_bot_123");
+    const ctx = parseFeishuMessageEvent(event, "ou_bot_123");
     expect(ctx.content).toBe("Merged and Forwarded Message");
   });
 
@@ -187,7 +259,7 @@ describe("parseFeishuMessageEvent – mentionedBot", () => {
     const event = makeShareChatEvent({
       share_chat_id: "sc_abc123",
     });
-    const ctx = parseFeishuMessageEvent(event as any, "ou_bot_123");
+    const ctx = parseFeishuMessageEvent(event, "ou_bot_123");
     expect(ctx.content).toBe("[Forwarded message: sc_abc123]");
   });
 });

package/src/bot.helpers.test.ts

@@ -0,0 +1,118 @@
+import { describe, expect, it } from "vitest";
+import type { ClawdbotConfig } from "../runtime-api.js";
+import { parseMessageContent } from "./bot-content.js";
+import {
+  buildBroadcastSessionKey,
+  buildFeishuAgentBody,
+  resolveBroadcastAgents,
+  toMessageResourceType,
+} from "./bot.js";
+
+describe("buildFeishuAgentBody", () => {
+  it("builds message id, speaker, quoted content, mentions, and permission notice in order", () => {
+    const body = buildFeishuAgentBody({
+      ctx: {
+        content: "hello world",
+        senderName: "Sender Name",
+        senderOpenId: "ou-sender",
+        messageId: "msg-42",
+        mentionTargets: [{ openId: "ou-target", name: "Target User", key: "@_user_1" }],
+      },
+      quotedContent: "previous message",
+      permissionErrorForAgent: {
+        code: 99991672,
+        message: "permission denied",
+        grantUrl: "https://open.feishu.cn/app/cli_test",
+      },
+    });
+
+    expect(body).toBe(
+      '[message_id: msg-42]\nSender Name: [Replying to: "previous message"]\n\nhello world\n\n[System: Your reply will automatically @mention: Target User. Do not write @xxx yourself.]\n\n[System: The bot encountered a Feishu API permission error. Please inform the user about this issue and provide the permission grant URL for the admin to authorize. Permission grant URL: https://open.feishu.cn/app/cli_test]',
+    );
+  });
+});
+
+describe("toMessageResourceType", () => {
+  it("maps image to image", () => {
+    expect(toMessageResourceType("image")).toBe("image");
+  });
+
+  it("maps audio to file", () => {
+    expect(toMessageResourceType("audio")).toBe("file");
+  });
+
+  it("maps video/file/sticker to file", () => {
+    expect(toMessageResourceType("video")).toBe("file");
+    expect(toMessageResourceType("file")).toBe("file");
+    expect(toMessageResourceType("sticker")).toBe("file");
+  });
+});
+
+describe("parseMessageContent media placeholders", () => {
+  it("uses an audio placeholder instead of leaking raw file_key JSON", () => {
+    expect(
+      parseMessageContent(JSON.stringify({ file_key: "file_audio", duration: 1200 }), "audio"),
+    ).toBe("<media:audio>");
+  });
+
+  it("prefers Feishu-provided audio transcript text when present", () => {
+    expect(
+      parseMessageContent(
+        JSON.stringify({ file_key: "file_audio", speech_to_text: " spoken words " }),
+        "audio",
+      ),
+    ).toBe("spoken words");
+  });
+
+  it("keeps media filenames as placeholder context without raw payload fields", () => {
+    expect(
+      parseMessageContent(JSON.stringify({ file_key: "file_doc", file_name: "q1.pdf" }), "file"),
+    ).toBe("<media:document> (q1.pdf)");
+  });
+});
+
+describe("resolveBroadcastAgents", () => {
+  it("returns agent list when broadcast config has the peerId", () => {
+    const cfg: ClawdbotConfig = { broadcast: { oc_group123: ["susan", "main"] } };
+    expect(resolveBroadcastAgents(cfg, "oc_group123")).toEqual(["susan", "main"]);
+  });
+
+  it("returns null when no broadcast config", () => {
+    const cfg = {} as ClawdbotConfig;
+    expect(resolveBroadcastAgents(cfg, "oc_group123")).toBeNull();
+  });
+
+  it("returns null when peerId not in broadcast", () => {
+    const cfg: ClawdbotConfig = { broadcast: { oc_other: ["susan"] } };
+    expect(resolveBroadcastAgents(cfg, "oc_group123")).toBeNull();
+  });
+
+  it("returns null when agent list is empty", () => {
+    const cfg: ClawdbotConfig = { broadcast: { oc_group123: [] } };
+    expect(resolveBroadcastAgents(cfg, "oc_group123")).toBeNull();
+  });
+});
+
+describe("buildBroadcastSessionKey", () => {
+  it("replaces agent ID prefix in session key", () => {
+    expect(buildBroadcastSessionKey("agent:main:feishu:group:oc_group123", "main", "susan")).toBe(
+      "agent:susan:feishu:group:oc_group123",
+    );
+  });
+
+  it("handles compound peer IDs", () => {
+    expect(
+      buildBroadcastSessionKey(
+        "agent:main:feishu:group:oc_group123:sender:ou_user1",
+        "main",
+        "susan",
+      ),
+    ).toBe("agent:susan:feishu:group:oc_group123:sender:ou_user1");
+  });
+
+  it("returns base key unchanged when prefix does not match", () => {
+    expect(buildBroadcastSessionKey("custom:key:format", "main", "susan")).toBe(
+      "custom:key:format",
+    );
+  });
+});

package/src/bot.stripBotMention.test.ts

@@ -1,11 +1,11 @@
 import { describe, expect, it } from "vitest";
-import { parseFeishuMessageEvent } from "./bot.js";
+import { parseFeishuMessageEvent, type FeishuMessageEvent } from "./bot.js";
 
 function makeEvent(
   text: string,
   mentions?: Array<{ key: string; name: string; id: { open_id?: string; user_id?: string } }>,
   chatType: "p2p" | "group" = "p2p",
-) {
+): FeishuMessageEvent {
   return {
     sender: { sender_id: { user_id: "u1", open_id: "ou_sender" } },
     message: {
@@ -23,15 +23,13 @@ const BOT_OPEN_ID = "ou_bot";
 
 describe("normalizeMentions (via parseFeishuMessageEvent)", () => {
   it("returns original text when mentions are missing", () => {
-    const ctx = parseFeishuMessageEvent(makeEvent("hello world", undefined) as any, BOT_OPEN_ID);
+    const ctx = parseFeishuMessageEvent(makeEvent("hello world", undefined), BOT_OPEN_ID);
     expect(ctx.content).toBe("hello world");
   });
 
   it("strips bot mention in p2p (addressing prefix, not semantic content)", () => {
     const ctx = parseFeishuMessageEvent(
-      makeEvent("@_bot_1 hello", [
-        { key: "@_bot_1", name: "Bot", id: { open_id: "ou_bot" } },
-      ]) as any,
+      makeEvent("@_bot_1 hello", [{ key: "@_bot_1", name: "Bot", id: { open_id: "ou_bot" } }]),
       BOT_OPEN_ID,
     );
     expect(ctx.content).toBe("hello");
@@ -43,7 +41,7 @@ describe("normalizeMentions (via parseFeishuMessageEvent)", () => {
         "@_bot_1 hello",
         [{ key: "@_bot_1", name: "Bot", id: { open_id: "ou_bot" } }],
         "group",
-      ) as any,
+      ),
       BOT_OPEN_ID,
     );
     expect(ctx.content).toBe("hello");
@@ -55,7 +53,7 @@ describe("normalizeMentions (via parseFeishuMessageEvent)", () => {
         "@_bot_1 /model",
         [{ key: "@_bot_1", name: "Bot", id: { open_id: "ou_bot" } }],
         "group",
-      ) as any,
+      ),
       BOT_OPEN_ID,
     );
     expect(ctx.content).toBe("/model");
@@ -66,7 +64,7 @@ describe("normalizeMentions (via parseFeishuMessageEvent)", () => {
       makeEvent("@_bot_1 @_user_alice hello", [
         { key: "@_bot_1", name: "Bot", id: { open_id: "ou_bot" } },
         { key: "@_user_alice", name: "Alice", id: { open_id: "ou_alice" } },
-      ]) as any,
+      ]),
       BOT_OPEN_ID,
     );
     expect(ctx.content).toBe('<at user_id="ou_alice">Alice</at> hello');
@@ -74,9 +72,7 @@ describe("normalizeMentions (via parseFeishuMessageEvent)", () => {
 
   it("falls back to @name when open_id is absent", () => {
     const ctx = parseFeishuMessageEvent(
-      makeEvent("@_user_1 hi", [
-        { key: "@_user_1", name: "Alice", id: { user_id: "uid_alice" } },
-      ]) as any,
+      makeEvent("@_user_1 hi", [{ key: "@_user_1", name: "Alice", id: { user_id: "uid_alice" } }]),
       BOT_OPEN_ID,
     );
     expect(ctx.content).toBe("@Alice hi");
@@ -84,7 +80,7 @@ describe("normalizeMentions (via parseFeishuMessageEvent)", () => {
 
   it("falls back to plain @name when no id is present", () => {
     const ctx = parseFeishuMessageEvent(
-      makeEvent("@_unknown hey", [{ key: "@_unknown", name: "Nobody", id: {} }]) as any,
+      makeEvent("@_unknown hey", [{ key: "@_unknown", name: "Nobody", id: {} }]),
       BOT_OPEN_ID,
     );
     expect(ctx.content).toBe("@Nobody hey");
@@ -92,7 +88,7 @@ describe("normalizeMentions (via parseFeishuMessageEvent)", () => {
 
   it("treats mention key regex metacharacters as literal text", () => {
     const ctx = parseFeishuMessageEvent(
-      makeEvent("hello world", [{ key: ".*", name: "Bot", id: { open_id: "ou_bot" } }]) as any,
+      makeEvent("hello world", [{ key: ".*", name: "Bot", id: { open_id: "ou_bot" } }]),
       BOT_OPEN_ID,
     );
     expect(ctx.content).toBe("hello world");
@@ -103,7 +99,7 @@ describe("normalizeMentions (via parseFeishuMessageEvent)", () => {
       makeEvent("@_bot_1 hi @_user_2", [
         { key: "@_bot_1", name: "Bot One", id: { open_id: "ou_bot_1" } },
         { key: "@_user_2", name: "User Two", id: { open_id: "ou_user_2" } },
-      ]) as any,
+      ]),
       BOT_OPEN_ID,
     );
     expect(ctx.content).toBe(
@@ -113,9 +109,7 @@ describe("normalizeMentions (via parseFeishuMessageEvent)", () => {
 
   it("treats $ in display name as literal (no replacement-pattern interpolation)", () => {
     const ctx = parseFeishuMessageEvent(
-      makeEvent("@_user_1 hi", [
-        { key: "@_user_1", name: "$& the user", id: { open_id: "ou_x" } },
-      ]) as any,
+      makeEvent("@_user_1 hi", [{ key: "@_user_1", name: "$& the user", id: { open_id: "ou_x" } }]),
       BOT_OPEN_ID,
     );
     // $ is preserved literally (no $& pattern substitution); & is not escaped in tag body
@@ -124,9 +118,7 @@ describe("normalizeMentions (via parseFeishuMessageEvent)", () => {
 
   it("escapes < and > in mention name to protect tag structure", () => {
     const ctx = parseFeishuMessageEvent(
-      makeEvent("@_user_1 test", [
-        { key: "@_user_1", name: "<script>", id: { open_id: "ou_x" } },
-      ]) as any,
+      makeEvent("@_user_1 test", [{ key: "@_user_1", name: "<script>", id: { open_id: "ou_x" } }]),
       BOT_OPEN_ID,
     );
     expect(ctx.content).toBe('<at user_id="ou_x">&lt;script&gt;</at> test');