@openclaw/codex 2026.5.2-beta.2 → 2026.5.3-beta.1

package/src/app-server/config.test.ts

@@ -1,431 +0,0 @@
-import fs from "node:fs/promises";
-import { describe, expect, it } from "vitest";
-import {
-  CODEX_APP_SERVER_CONFIG_KEYS,
-  CODEX_COMPUTER_USE_CONFIG_KEYS,
-  codexAppServerStartOptionsKey,
-  readCodexPluginConfig,
-  resolveCodexAppServerRuntimeOptions,
-  resolveCodexComputerUseConfig,
-} from "./config.js";
-
-describe("Codex app-server config", () => {
-  it("parses typed plugin config before falling back to environment knobs", () => {
-    const runtime = resolveCodexAppServerRuntimeOptions({
-      pluginConfig: {
-        appServer: {
-          mode: "guardian",
-          transport: "websocket",
-          url: "ws://127.0.0.1:39175",
-          headers: { "X-Test": "yes" },
-          approvalPolicy: "on-request",
-          sandbox: "danger-full-access",
-          approvalsReviewer: "guardian_subagent",
-          serviceTier: "flex",
-        },
-      },
-      env: {
-        OPENCLAW_CODEX_APP_SERVER_APPROVAL_POLICY: "never",
-        OPENCLAW_CODEX_APP_SERVER_SANDBOX: "read-only",
-      },
-    });
-
-    expect(runtime).toEqual(
-      expect.objectContaining({
-        approvalPolicy: "on-request",
-        sandbox: "danger-full-access",
-        approvalsReviewer: "guardian_subagent",
-        serviceTier: "flex",
-        start: expect.objectContaining({
-          transport: "websocket",
-          url: "ws://127.0.0.1:39175",
-          headers: { "X-Test": "yes" },
-        }),
-      }),
-    );
-  });
-
-  it("ignores app-server environment clearing for websocket transports", () => {
-    const runtime = resolveCodexAppServerRuntimeOptions({
-      pluginConfig: {
-        appServer: {
-          transport: "websocket",
-          url: "ws://127.0.0.1:39175",
-          clearEnv: ["OPENAI_API_KEY"],
-        },
-      },
-      env: {},
-    });
-
-    expect(runtime.start).not.toHaveProperty("clearEnv");
-  });
-
-  it("normalizes app-server environment variables to clear", () => {
-    const runtime = resolveCodexAppServerRuntimeOptions({
-      pluginConfig: {
-        appServer: {
-          clearEnv: [" OPENAI_API_KEY ", "", "  "],
-        },
-      },
-      env: {},
-    });
-
-    expect(runtime.start).toEqual(
-      expect.objectContaining({
-        clearEnv: ["OPENAI_API_KEY"],
-      }),
-    );
-  });
-
-  it("drops invalid legacy service tiers without discarding the rest of the config", () => {
-    const runtime = resolveCodexAppServerRuntimeOptions({
-      pluginConfig: {
-        appServer: {
-          mode: "guardian",
-          approvalPolicy: "on-request",
-          sandbox: "read-only",
-          serviceTier: "priority",
-        },
-      },
-      env: {},
-    });
-
-    expect(runtime).toEqual(
-      expect.objectContaining({
-        approvalPolicy: "on-request",
-        sandbox: "read-only",
-        approvalsReviewer: "auto_review",
-      }),
-    );
-    expect(runtime).not.toHaveProperty("serviceTier");
-  });
-
-  it("rejects malformed plugin config instead of treating freeform strings as control values", () => {
-    expect(
-      readCodexPluginConfig({
-        appServer: {
-          approvalPolicy: "always",
-        },
-      }),
-    ).toEqual({});
-  });
-
-  it("requires a websocket url when websocket transport is configured", () => {
-    expect(() =>
-      resolveCodexAppServerRuntimeOptions({
-        pluginConfig: { appServer: { transport: "websocket" } },
-        env: {},
-      }),
-    ).toThrow("appServer.url is required");
-  });
-
-  it("defaults native Codex approvals to unchained local execution", () => {
-    const runtime = resolveCodexAppServerRuntimeOptions({
-      pluginConfig: {},
-      env: {},
-    });
-
-    expect(runtime).toEqual(
-      expect.objectContaining({
-        approvalPolicy: "never",
-        sandbox: "danger-full-access",
-        approvalsReviewer: "user",
-        start: expect.objectContaining({
-          command: "codex",
-          commandSource: "managed",
-        }),
-      }),
-    );
-  });
-
-  it("parses dynamic tool profile controls", () => {
-    expect(
-      readCodexPluginConfig({
-        codexDynamicToolsProfile: "openclaw-compat",
-        codexDynamicToolsExclude: ["custom_tool"],
-      }),
-    ).toMatchObject({
-      codexDynamicToolsProfile: "openclaw-compat",
-      codexDynamicToolsExclude: ["custom_tool"],
-    });
-  });
-
-  it("treats configured and environment commands as explicit overrides", () => {
-    expect(
-      resolveCodexAppServerRuntimeOptions({
-        pluginConfig: { appServer: { command: "/opt/codex/bin/codex" } },
-        env: { OPENCLAW_CODEX_APP_SERVER_BIN: "/usr/local/bin/codex" },
-      }).start,
-    ).toEqual(
-      expect.objectContaining({
-        command: "/opt/codex/bin/codex",
-        commandSource: "config",
-      }),
-    );
-
-    expect(
-      resolveCodexAppServerRuntimeOptions({
-        pluginConfig: {},
-        env: { OPENCLAW_CODEX_APP_SERVER_BIN: "/usr/local/bin/codex" },
-      }).start,
-    ).toEqual(
-      expect.objectContaining({
-        command: "/usr/local/bin/codex",
-        commandSource: "env",
-      }),
-    );
-  });
-
-  it("resolves Computer Use setup from plugin config and environment fallbacks", () => {
-    expect(
-      resolveCodexComputerUseConfig({
-        pluginConfig: {
-          computerUse: {
-            autoInstall: true,
-            marketplaceName: "desktop-tools",
-          },
-        },
-        env: {
-          OPENCLAW_CODEX_COMPUTER_USE_PLUGIN_NAME: "env-fallback-plugin",
-        },
-      }),
-    ).toEqual({
-      enabled: true,
-      autoInstall: true,
-      marketplaceDiscoveryTimeoutMs: 60_000,
-      pluginName: "env-fallback-plugin",
-      mcpServerName: "computer-use",
-      marketplaceName: "desktop-tools",
-    });
-
-    expect(
-      resolveCodexComputerUseConfig({
-        pluginConfig: {},
-        env: {
-          OPENCLAW_CODEX_COMPUTER_USE: "1",
-          OPENCLAW_CODEX_COMPUTER_USE_MARKETPLACE_SOURCE: "github:example/plugins",
-          OPENCLAW_CODEX_COMPUTER_USE_AUTO_INSTALL: "true",
-          OPENCLAW_CODEX_COMPUTER_USE_MARKETPLACE_DISCOVERY_TIMEOUT_MS: "30000",
-        },
-      }),
-    ).toEqual(
-      expect.objectContaining({
-        enabled: true,
-        autoInstall: true,
-        marketplaceDiscoveryTimeoutMs: 30_000,
-        marketplaceSource: "github:example/plugins",
-      }),
-    );
-  });
-
-  it("allows plugin config to opt in to guardian-reviewed local execution", () => {
-    const runtime = resolveCodexAppServerRuntimeOptions({
-      pluginConfig: {
-        appServer: {
-          mode: "guardian",
-        },
-      },
-      env: {},
-    });
-
-    expect(runtime).toEqual(
-      expect.objectContaining({
-        approvalPolicy: "on-request",
-        sandbox: "workspace-write",
-        approvalsReviewer: "auto_review",
-      }),
-    );
-  });
-
-  it("allows environment mode fallback to opt in to guardian-reviewed local execution", () => {
-    const runtime = resolveCodexAppServerRuntimeOptions({
-      pluginConfig: {},
-      env: { OPENCLAW_CODEX_APP_SERVER_MODE: "guardian" },
-    });
-
-    expect(runtime).toEqual(
-      expect.objectContaining({
-        approvalPolicy: "on-request",
-        sandbox: "workspace-write",
-        approvalsReviewer: "auto_review",
-      }),
-    );
-  });
-
-  it("accepts the latest auto_review reviewer and legacy guardian_subagent alias", () => {
-    expect(
-      resolveCodexAppServerRuntimeOptions({
-        pluginConfig: { appServer: { approvalsReviewer: "auto_review" } },
-        env: {},
-      }).approvalsReviewer,
-    ).toBe("auto_review");
-    expect(
-      resolveCodexAppServerRuntimeOptions({
-        pluginConfig: { appServer: { approvalsReviewer: "guardian_subagent" } },
-        env: {},
-      }).approvalsReviewer,
-    ).toBe("guardian_subagent");
-  });
-
-  it("ignores removed OPENCLAW_CODEX_APP_SERVER_GUARDIAN fallback", () => {
-    const runtime = resolveCodexAppServerRuntimeOptions({
-      pluginConfig: {},
-      env: { OPENCLAW_CODEX_APP_SERVER_GUARDIAN: "1" },
-    });
-
-    expect(runtime).toEqual(
-      expect.objectContaining({
-        approvalPolicy: "never",
-        sandbox: "danger-full-access",
-        approvalsReviewer: "user",
-      }),
-    );
-  });
-
-  it("lets explicit policy fields override guardian mode", () => {
-    const runtime = resolveCodexAppServerRuntimeOptions({
-      pluginConfig: {
-        appServer: {
-          mode: "guardian",
-          approvalPolicy: "on-failure",
-          sandbox: "danger-full-access",
-          approvalsReviewer: "user",
-        },
-      },
-      env: {},
-    });
-
-    expect(runtime).toEqual(
-      expect.objectContaining({
-        approvalPolicy: "on-failure",
-        sandbox: "danger-full-access",
-        approvalsReviewer: "user",
-      }),
-    );
-  });
-
-  it("derives distinct shared-client keys for distinct auth tokens without exposing them", () => {
-    const first = codexAppServerStartOptionsKey({
-      transport: "websocket",
-      command: "codex",
-      args: [],
-      url: "ws://127.0.0.1:39175",
-      authToken: "tok_first",
-      headers: {},
-    });
-    const second = codexAppServerStartOptionsKey({
-      transport: "websocket",
-      command: "codex",
-      args: [],
-      url: "ws://127.0.0.1:39175",
-      authToken: "tok_second",
-      headers: {},
-    });
-
-    expect(first).not.toEqual(second);
-    expect(
-      codexAppServerStartOptionsKey({
-        transport: "websocket",
-        command: "codex",
-        args: [],
-        url: "ws://127.0.0.1:39175",
-        authToken: "tok_first",
-        headers: {},
-      }),
-    ).toEqual(first);
-    expect(first).not.toContain("tok_first");
-    expect(second).not.toContain("tok_second");
-  });
-
-  it("derives distinct shared-client keys for distinct env values without exposing them", () => {
-    const first = codexAppServerStartOptionsKey({
-      transport: "stdio",
-      command: "codex",
-      args: ["app-server"],
-      headers: {},
-      env: { OPENAI_API_KEY: "sk-first" },
-    });
-    const second = codexAppServerStartOptionsKey({
-      transport: "stdio",
-      command: "codex",
-      args: ["app-server"],
-      headers: {},
-      env: { OPENAI_API_KEY: "sk-second" },
-    });
-
-    expect(first).not.toEqual(second);
-    expect(
-      codexAppServerStartOptionsKey({
-        transport: "stdio",
-        command: "codex",
-        args: ["app-server"],
-        headers: {},
-        env: { OPENAI_API_KEY: "sk-first" },
-      }),
-    ).toEqual(first);
-    expect(first).not.toContain("sk-first");
-    expect(second).not.toContain("sk-second");
-  });
-
-  it("derives distinct shared-client keys for distinct agent dirs", () => {
-    const startOptions = {
-      transport: "stdio" as const,
-      command: "codex",
-      args: ["app-server"],
-      headers: {},
-    };
-
-    expect(codexAppServerStartOptionsKey(startOptions, { agentDir: "/tmp/agent-a" })).not.toEqual(
-      codexAppServerStartOptionsKey(startOptions, { agentDir: "/tmp/agent-b" }),
-    );
-  });
-
-  it("keeps runtime config keys aligned with manifest schema and UI hints", async () => {
-    const manifest = JSON.parse(
-      await fs.readFile(new URL("../../openclaw.plugin.json", import.meta.url), "utf8"),
-    ) as {
-      configSchema: {
-        properties: {
-          appServer: { properties: Record<string, unknown> };
-          computerUse: { properties: Record<string, unknown> };
-        };
-      };
-      uiHints: Record<string, unknown>;
-    };
-    const manifestKeys = Object.keys(
-      manifest.configSchema.properties.appServer.properties,
-    ).toSorted();
-
-    expect(manifestKeys).toEqual([...CODEX_APP_SERVER_CONFIG_KEYS].toSorted());
-    for (const key of CODEX_APP_SERVER_CONFIG_KEYS) {
-      expect(manifest.uiHints[`appServer.${key}`]).toBeTruthy();
-    }
-    const computerUseManifestKeys = Object.keys(
-      manifest.configSchema.properties.computerUse.properties,
-    ).toSorted();
-    expect(computerUseManifestKeys).toEqual([...CODEX_COMPUTER_USE_CONFIG_KEYS].toSorted());
-    for (const key of CODEX_COMPUTER_USE_CONFIG_KEYS) {
-      expect(manifest.uiHints[`computerUse.${key}`]).toBeTruthy();
-    }
-  });
-
-  it("does not schema-default mode-derived policy fields", async () => {
-    const manifest = JSON.parse(
-      await fs.readFile(new URL("../../openclaw.plugin.json", import.meta.url), "utf8"),
-    ) as {
-      configSchema: {
-        properties: {
-          appServer: {
-            properties: Record<string, { default?: unknown }>;
-          };
-        };
-      };
-    };
-    const appServerProperties = manifest.configSchema.properties.appServer.properties;
-
-    expect(appServerProperties.command?.default).toBeUndefined();
-    expect(appServerProperties.approvalPolicy?.default).toBeUndefined();
-    expect(appServerProperties.sandbox?.default).toBeUndefined();
-    expect(appServerProperties.approvalsReviewer?.default).toBeUndefined();
-  });
-});