@openclaw-cloud/agent-controller 0.2.6 → 0.2.7

package/__tests__/board-handler.test.ts

@@ -1,323 +0,0 @@
-import { BoardHandler } from '../src/handlers/board-handler';
-import type { AgentApi } from '../src/api';
-import type { BoardInfo, CardDetail, BoardEvent } from '../src/types';
-import childProcess from 'node:child_process';
-
-jest.mock('node:child_process');
-const mockExec = childProcess.exec as unknown as jest.Mock;
-
-function mockApi(overrides: Partial<AgentApi> = {}): AgentApi {
-  return {
-    get: jest.fn(),
-    post: jest.fn(),
-    publishResponse: jest.fn().mockResolvedValue(undefined),
-    publishHeartbeat: jest.fn().mockResolvedValue(undefined),
-    ...overrides,
-  };
-}
-
-function makeBoardInfo(opts: Partial<{
-  boardId: string;
-  workspaceId: string;
-  myColumnIds: string[];
-  columns: BoardInfo['board']['columns'];
-}> = {}): BoardInfo {
-  return {
-    board: {
-      id: opts.boardId ?? 'board-1',
-      workspaceId: opts.workspaceId ?? 'ws-1',
-      myColumnIds: opts.myColumnIds ?? ['col-1'],
-      columns: opts.columns ?? [{
-        id: 'col-1',
-        name: 'To Do',
-        type: 'agent',
-        position: 0,
-        cards: [],
-      }],
-    },
-  };
-}
-
-function makeCardDetail(opts: Partial<CardDetail['card']> = {}): CardDetail {
-  return {
-    card: {
-      id: opts.id ?? 'card-1',
-      title: opts.title ?? 'Test task',
-      description: opts.description ?? 'Do the thing',
-      priority: opts.priority ?? 'medium',
-      columnId: opts.columnId ?? 'col-1',
-      columnName: opts.columnName ?? 'To Do',
-      assignedAgentId: opts.assignedAgentId ?? null,
-    },
-  };
-}
-
-function makeResponse(status: number, body: string = ''): Response {
-  return {
-    ok: status >= 200 && status < 300,
-    status,
-    text: () => Promise.resolve(body),
-  } as Response;
-}
-
-describe('BoardHandler', () => {
-  let api: AgentApi;
-  let handler: BoardHandler;
-
-  beforeEach(() => {
-    jest.clearAllMocks();
-    mockExec.mockImplementation((_cmd: string, _opts: unknown, cb: Function) => {
-      cb(null, Buffer.from('ok'), Buffer.from(''));
-    });
-    api = mockApi();
-    handler = new BoardHandler(api);
-  });
-
-  describe('initialize', () => {
-    it('sets boardId, workspaceId and myColumnIds from API response', async () => {
-      const info = makeBoardInfo({ boardId: 'b-42', workspaceId: 'ws-99', myColumnIds: ['c-1', 'c-2'] });
-      (api.get as jest.Mock).mockResolvedValue(info);
-
-      const result = await handler.initialize();
-
-      // initialize() returns workspaceId for channel subscription
-      expect(result).toBe('ws-99');
-      expect(handler.getBoardId()).toBe('b-42');
-      expect(api.get).toHaveBeenCalledWith('/api/agent/board');
-    });
-
-    it('claims unassigned card in my column during init (backfill)', async () => {
-      const info = makeBoardInfo({
-        columns: [{
-          id: 'col-1', name: 'To Do', type: 'agent', position: 0,
-          cards: [{ id: 'card-99', title: 'Backfill', assignedAgentId: null }],
-        }],
-      });
-      (api.get as jest.Mock).mockResolvedValue(info);
-      (api.post as jest.Mock).mockResolvedValue(makeResponse(200));
-      // Mock card detail for startTask
-      (api.get as jest.Mock).mockResolvedValueOnce(info).mockResolvedValueOnce(makeCardDetail({ id: 'card-99' }));
-
-      await handler.initialize();
-
-      expect(api.post).toHaveBeenCalledWith('/api/agent/board/cards/card-99/claim');
-    });
-
-    it('returns null on API error', async () => {
-      (api.get as jest.Mock).mockRejectedValue(new Error('network fail'));
-
-      const result = await handler.initialize();
-
-      expect(result).toBeNull();
-      expect(handler.getBoardId()).toBeNull();
-    });
-  });
-
-  describe('onBoardEvent', () => {
-    beforeEach(async () => {
-      const info = makeBoardInfo();
-      (api.get as jest.Mock).mockResolvedValue(info);
-      await handler.initialize();
-      jest.clearAllMocks();
-    });
-
-    it('claims card when card:entered in my column and idle', async () => {
-      (api.post as jest.Mock).mockResolvedValue(makeResponse(200));
-      (api.get as jest.Mock).mockResolvedValue(makeCardDetail());
-
-      const event: BoardEvent = { event: 'card:entered', cardId: 'card-5', columnId: 'col-1' };
-      await handler.onBoardEvent(event);
-
-      expect(api.post).toHaveBeenCalledWith('/api/agent/board/cards/card-5/claim');
-    });
-
-    it('ignores card:entered for column not in myColumnIds', async () => {
-      const event: BoardEvent = { event: 'card:entered', cardId: 'card-5', columnId: 'other-col' };
-      await handler.onBoardEvent(event);
-
-      expect(api.post).not.toHaveBeenCalled();
-    });
-
-    it('ignores card:entered when already working', async () => {
-      // First: claim a card to set state to working
-      (api.post as jest.Mock).mockResolvedValue(makeResponse(200));
-      (api.get as jest.Mock).mockResolvedValue(makeCardDetail());
-      await handler.onBoardEvent({ event: 'card:entered', cardId: 'card-1', columnId: 'col-1' });
-
-      jest.clearAllMocks();
-
-      // Second: new card enters, should be ignored
-      await handler.onBoardEvent({ event: 'card:entered', cardId: 'card-2', columnId: 'col-1' });
-      expect(api.post).not.toHaveBeenCalled();
-    });
-
-    it('ignores card:claimed, card:moved, card:commented events', async () => {
-      for (const event of ['card:claimed', 'card:moved', 'card:commented'] as const) {
-        await handler.onBoardEvent({ event, cardId: 'card-1' });
-      }
-      expect(api.post).not.toHaveBeenCalled();
-      expect(api.get).not.toHaveBeenCalled();
-    });
-  });
-
-  describe('tryClaimCard', () => {
-    beforeEach(async () => {
-      (api.get as jest.Mock).mockResolvedValue(makeBoardInfo());
-      await handler.initialize();
-      jest.clearAllMocks();
-    });
-
-    it('sets state to working on successful claim (200)', async () => {
-      (api.post as jest.Mock).mockResolvedValue(makeResponse(200));
-      (api.get as jest.Mock).mockResolvedValue(makeCardDetail({ id: 'card-10' }));
-
-      await handler.tryClaimCard('card-10');
-
-      expect(handler.getBoardStatus()).toEqual({ state: 'working', cardId: 'card-10' });
-    });
-
-    it('stays idle on 409 (already claimed)', async () => {
-      (api.post as jest.Mock).mockResolvedValue(makeResponse(409));
-
-      await handler.tryClaimCard('card-10');
-
-      expect(handler.getBoardStatus()).toEqual({ state: 'idle', cardId: null });
-    });
-
-    it('stays idle on 500 error', async () => {
-      (api.post as jest.Mock).mockResolvedValue(makeResponse(500, 'Internal error'));
-
-      await handler.tryClaimCard('card-10');
-
-      expect(handler.getBoardStatus()).toEqual({ state: 'idle', cardId: null });
-    });
-
-    it('stays idle on network error', async () => {
-      (api.post as jest.Mock).mockRejectedValue(new Error('connection refused'));
-
-      await handler.tryClaimCard('card-10');
-
-      expect(handler.getBoardStatus()).toEqual({ state: 'idle', cardId: null });
-    });
-  });
-
-  describe('startTask', () => {
-    beforeEach(async () => {
-      (api.get as jest.Mock).mockResolvedValue(makeBoardInfo());
-      await handler.initialize();
-      jest.clearAllMocks();
-    });
-
-    it('fetches card detail and calls openclaw exec', async () => {
-      const detail = makeCardDetail({ id: 'card-20', title: 'Build feature', description: 'Some desc', priority: 'high' });
-      (api.get as jest.Mock).mockResolvedValue(detail);
-
-      await handler.startTask('card-20');
-
-      expect(api.get).toHaveBeenCalledWith('/api/agent/board/cards/card-20');
-      expect(mockExec).toHaveBeenCalledTimes(1);
-      const cmd = mockExec.mock.calls[0][0] as string;
-      expect(cmd).toContain('openclaw system event');
-      expect(cmd).toContain('Build feature');
-      expect(cmd).toContain('Priority: high');
-    });
-
-    it('handles API error gracefully', async () => {
-      (api.get as jest.Mock).mockRejectedValue(new Error('not found'));
-
-      await handler.startTask('card-missing');
-
-      expect(mockExec).not.toHaveBeenCalled();
-    });
-  });
-
-  describe('completeTask', () => {
-    it('resets state to idle and triggers checkQueue', async () => {
-      const info = makeBoardInfo();
-      (api.get as jest.Mock).mockResolvedValue(info);
-      await handler.initialize();
-
-      // Claim a card first
-      (api.post as jest.Mock).mockResolvedValue(makeResponse(200));
-      (api.get as jest.Mock).mockResolvedValueOnce(makeCardDetail()).mockResolvedValueOnce(info);
-
-      await handler.tryClaimCard('card-1');
-      expect(handler.getBoardStatus().state).toBe('working');
-
-      handler.completeTask('card-1');
-      expect(handler.getBoardStatus()).toEqual({ state: 'idle', cardId: null });
-    });
-  });
-
-  describe('checkQueue', () => {
-    beforeEach(async () => {
-      (api.get as jest.Mock).mockResolvedValue(makeBoardInfo());
-      await handler.initialize();
-      jest.clearAllMocks();
-    });
-
-    it('sorts candidates by priority then createdAt', async () => {
-      const info = makeBoardInfo({
-        columns: [{
-          id: 'col-1', name: 'To Do', type: 'agent', position: 0,
-          cards: [
-            { id: 'low-old', title: 'Low old', priority: 'low', assignedAgentId: null, createdAt: '2026-01-01' },
-            { id: 'critical-new', title: 'Critical', priority: 'critical', assignedAgentId: null, createdAt: '2026-02-01' },
-            { id: 'high-old', title: 'High old', priority: 'high', assignedAgentId: null, createdAt: '2026-01-15' },
-          ],
-        }],
-      });
-      (api.get as jest.Mock).mockResolvedValue(info);
-      (api.post as jest.Mock).mockResolvedValue(makeResponse(200));
-      (api.get as jest.Mock).mockResolvedValueOnce(info).mockResolvedValueOnce(makeCardDetail({ id: 'critical-new' }));
-
-      await handler.checkQueue();
-
-      // Should try to claim the critical card first
-      expect(api.post).toHaveBeenCalledWith('/api/agent/board/cards/critical-new/claim');
-    });
-
-    it('does nothing when no unassigned cards', async () => {
-      const info = makeBoardInfo({
-        columns: [{
-          id: 'col-1', name: 'To Do', type: 'agent', position: 0,
-          cards: [
-            { id: 'card-1', title: 'Taken', assignedAgentId: 'agent-1' },
-          ],
-        }],
-      });
-      (api.get as jest.Mock).mockResolvedValue(info);
-
-      await handler.checkQueue();
-
-      expect(api.post).not.toHaveBeenCalled();
-    });
-
-    it('skips cards in columns not in myColumnIds', async () => {
-      const info = makeBoardInfo({
-        myColumnIds: ['col-1'],
-        columns: [
-          { id: 'col-1', name: 'Mine', type: 'agent', position: 0, cards: [] },
-          { id: 'col-2', name: 'Not mine', type: 'human', position: 1, cards: [
-            { id: 'card-x', title: 'Other', assignedAgentId: null },
-          ]},
-        ],
-      });
-      (api.get as jest.Mock).mockResolvedValue(info);
-
-      await handler.checkQueue();
-
-      expect(api.post).not.toHaveBeenCalled();
-    });
-  });
-
-  describe('getters', () => {
-    it('getBoardStatus returns idle by default', () => {
-      expect(handler.getBoardStatus()).toEqual({ state: 'idle', cardId: null });
-    });
-
-    it('getBoardId returns null before initialize', () => {
-      expect(handler.getBoardId()).toBeNull();
-    });
-  });
-});

package/__tests__/chat.test.ts

@@ -1,191 +0,0 @@
-import { handleChatListSessions, handleChatHistory, handleChatSend } from '../src/handlers/chat';
-import type { AgentCommand } from '../src/types';
-
-jest.mock('../src/openclaw/index');
-
-import { getChatProvider } from '../src/openclaw/index';
-
-const mockGetChatProvider = getChatProvider as jest.Mock;
-
-function makeCommand(
-  type: AgentCommand['type'],
-  payload: Record<string, unknown> = {},
-  id = 'cmd-1',
-): AgentCommand {
-  return { id, type, payload };
-}
-
-describe('handleChatListSessions', () => {
-  let publish: jest.Mock;
-
-  beforeEach(() => {
-    jest.clearAllMocks();
-    publish = jest.fn().mockResolvedValue(undefined);
-  });
-
-  it('publishes error when provider is null', async () => {
-    mockGetChatProvider.mockReturnValue(null);
-    const cmd = makeCommand('chat_list_sessions');
-    await handleChatListSessions(cmd, publish);
-    expect(publish).toHaveBeenCalledWith(
-      expect.objectContaining({
-        type: 'chat_sessions_response',
-        correlationId: 'cmd-1',
-        sessions: [],
-        error: expect.stringContaining('not initialized'),
-      }),
-    );
-  });
-
-  it('publishes sessions on success', async () => {
-    const sessions = [{ key: 'sess-1', sessionId: 'sid-1', kind: 'direct', updatedAt: 0 }];
-    mockGetChatProvider.mockReturnValue({
-      listSessions: jest.fn().mockResolvedValue(sessions),
-    });
-    const cmd = makeCommand('chat_list_sessions');
-    await handleChatListSessions(cmd, publish);
-    expect(publish).toHaveBeenCalledWith({
-      type: 'chat_sessions_response',
-      correlationId: 'cmd-1',
-      sessions,
-    });
-  });
-
-  it('publishes error when provider.listSessions throws', async () => {
-    mockGetChatProvider.mockReturnValue({
-      listSessions: jest.fn().mockRejectedValue(new Error('db error')),
-    });
-    const cmd = makeCommand('chat_list_sessions');
-    await handleChatListSessions(cmd, publish);
-    expect(publish).toHaveBeenCalledWith(
-      expect.objectContaining({
-        type: 'chat_sessions_response',
-        sessions: [],
-        error: 'db error',
-      }),
-    );
-  });
-});
-
-describe('handleChatHistory', () => {
-  let publish: jest.Mock;
-
-  beforeEach(() => {
-    jest.clearAllMocks();
-    publish = jest.fn().mockResolvedValue(undefined);
-  });
-
-  it('publishes messages on success', async () => {
-    const messages = [{ role: 'user', content: 'hello', timestamp: '2026-01-01T00:00:00Z' }];
-    mockGetChatProvider.mockReturnValue({
-      getHistory: jest.fn().mockResolvedValue(messages),
-    });
-    const cmd = makeCommand('chat_history', { sessionKey: 'sess-1', limit: 50 });
-    await handleChatHistory(cmd, publish);
-    expect(publish).toHaveBeenCalledWith({
-      type: 'chat_history_response',
-      correlationId: 'cmd-1',
-      messages,
-    });
-  });
-
-  it('publishes error when provider is null', async () => {
-    mockGetChatProvider.mockReturnValue(null);
-    const cmd = makeCommand('chat_history', { sessionKey: 'sess-1' });
-    await handleChatHistory(cmd, publish);
-    expect(publish).toHaveBeenCalledWith(
-      expect.objectContaining({
-        type: 'chat_history_response',
-        messages: [],
-        error: expect.stringContaining('not initialized'),
-      }),
-    );
-  });
-
-  it('publishes error when provider.getHistory throws', async () => {
-    mockGetChatProvider.mockReturnValue({
-      getHistory: jest.fn().mockRejectedValue(new Error('history error')),
-    });
-    const cmd = makeCommand('chat_history', { sessionKey: 'sess-1' });
-    await handleChatHistory(cmd, publish);
-    expect(publish).toHaveBeenCalledWith(
-      expect.objectContaining({
-        type: 'chat_history_response',
-        messages: [],
-        error: 'history error',
-      }),
-    );
-  });
-});
-
-describe('handleChatSend', () => {
-  let publish: jest.Mock;
-
-  beforeEach(() => {
-    jest.clearAllMocks();
-    publish = jest.fn().mockResolvedValue(undefined);
-  });
-
-  it('always sends typing indicator before checking provider', async () => {
-    mockGetChatProvider.mockReturnValue(null);
-    const cmd = makeCommand('chat_send', { sessionKey: 'sess-1', text: 'hi' });
-    await handleChatSend(cmd, publish, 'agent-1');
-    expect(publish).toHaveBeenCalledWith({ type: 'chat_typing', agentId: 'agent-1', state: true });
-  });
-
-  it('publishes error response when provider is null', async () => {
-    mockGetChatProvider.mockReturnValue(null);
-    const cmd = makeCommand('chat_send', { sessionKey: 'sess-1', text: 'hi' });
-    await handleChatSend(cmd, publish, 'agent-1');
-    const published = (publish as jest.Mock).mock.calls.map((c) => c[0]);
-    expect(published).toContainEqual(
-      expect.objectContaining({
-        type: 'chat_response',
-        correlationId: 'cmd-1',
-        error: expect.stringContaining('not initialized'),
-      }),
-    );
-  });
-
-  it('calls onDelta and onDone via sendMessage callbacks', async () => {
-    const sendMessage = jest.fn().mockImplementation(async (params: any) => {
-      await params.onDelta('partial');
-      await params.onDone('full response');
-    });
-    mockGetChatProvider.mockReturnValue({ sendMessage });
-    const cmd = makeCommand('chat_send', { sessionKey: 'sess-1', text: 'hi' });
-    await handleChatSend(cmd, publish, 'agent-1');
-    const published = (publish as jest.Mock).mock.calls.map((c) => c[0]);
-    expect(published).toContainEqual(
-      expect.objectContaining({ type: 'chat_delta', correlationId: 'cmd-1', text: 'partial' }),
-    );
-    expect(published).toContainEqual(
-      expect.objectContaining({ type: 'chat_response', correlationId: 'cmd-1', text: 'full response' }),
-    );
-  });
-
-  it('publishes error via onError callback', async () => {
-    const sendMessage = jest.fn().mockImplementation(async (params: any) => {
-      await params.onError('stream error');
-    });
-    mockGetChatProvider.mockReturnValue({ sendMessage });
-    const cmd = makeCommand('chat_send', { sessionKey: 'sess-1', text: 'hi' });
-    await handleChatSend(cmd, publish, 'agent-1');
-    const published = (publish as jest.Mock).mock.calls.map((c) => c[0]);
-    expect(published).toContainEqual(
-      expect.objectContaining({ type: 'chat_response', error: 'stream error' }),
-    );
-  });
-
-  it('publishes error when provider.sendMessage throws', async () => {
-    mockGetChatProvider.mockReturnValue({
-      sendMessage: jest.fn().mockRejectedValue(new Error('send failed')),
-    });
-    const cmd = makeCommand('chat_send', { sessionKey: 'sess-1', text: 'hi' });
-    await handleChatSend(cmd, publish, 'agent-1');
-    const published = (publish as jest.Mock).mock.calls.map((c) => c[0]);
-    expect(published).toContainEqual(
-      expect.objectContaining({ type: 'chat_response', error: 'send failed' }),
-    );
-  });
-});

package/__tests__/config.test.ts

@@ -1,100 +0,0 @@
-import { handleConfig } from '../src/handlers/config';
-import type { AgentCommand } from '../src/types';
-import childProcess from 'node:child_process';
-import fs from 'node:fs/promises';
-
-jest.mock('node:child_process');
-jest.mock('node:fs/promises');
-
-const mockExec = childProcess.exec as unknown as jest.Mock;
-const mockMkdir = fs.mkdir as jest.Mock;
-const mockWriteFile = fs.writeFile as jest.Mock;
-
-function fakeExec(error: Error | null, stdout = '', stderr = '') {
-  mockExec.mockImplementation((_cmd: string, _opts: unknown, cb: Function) => {
-    cb(error, Buffer.from(stdout), Buffer.from(stderr));
-  });
-}
-
-describe('handleConfig', () => {
-  beforeEach(() => {
-    jest.clearAllMocks();
-    mockMkdir.mockResolvedValue(undefined);
-    mockWriteFile.mockResolvedValue(undefined);
-  });
-
-  it('rejects missing filename', async () => {
-    const cmd: AgentCommand = { id: '1', type: 'config', payload: { content: 'some: config' } };
-    const res = await handleConfig(cmd);
-    expect(res.success).toBe(false);
-    expect(res.error).toContain('Missing');
-  });
-
-  it('rejects missing content', async () => {
-    const cmd: AgentCommand = { id: '2', type: 'config', payload: { filename: 'test.yml' } };
-    const res = await handleConfig(cmd);
-    expect(res.success).toBe(false);
-    expect(res.error).toContain('Missing');
-  });
-
-  it('creates directory, writes file, and runs restart on success', async () => {
-    fakeExec(null, 'restarted', '');
-    const cmd: AgentCommand = {
-      id: '3',
-      type: 'config',
-      payload: { filename: 'agent.yml', content: 'key: val' },
-    };
-    const res = await handleConfig(cmd);
-
-    expect(fs.mkdir).toHaveBeenCalledWith('/etc/openclaw', { recursive: true });
-    expect(fs.writeFile).toHaveBeenCalledWith(
-      expect.stringContaining('agent.yml'),
-      'key: val',
-      'utf-8',
-    );
-    expect(mockExec).toHaveBeenCalledWith(
-      'openclaw gateway restart',
-      expect.any(Object),
-      expect.any(Function),
-    );
-    expect(res.success).toBe(true);
-    expect(res.data?.path).toContain('agent.yml');
-  });
-
-  it('returns error when writeFile fails', async () => {
-    mockWriteFile.mockRejectedValue(new Error('EACCES: permission denied'));
-    const cmd: AgentCommand = {
-      id: '4',
-      type: 'config',
-      payload: { filename: 'agent.yml', content: 'key: val' },
-    };
-    const res = await handleConfig(cmd);
-    expect(res.success).toBe(false);
-    expect(res.error).toContain('EACCES');
-  });
-
-  it('returns success:false with error message when restart fails', async () => {
-    fakeExec(new Error('restart failed'), '', 'stderr output');
-    const cmd: AgentCommand = {
-      id: '5',
-      type: 'config',
-      payload: { filename: 'agent.yml', content: 'key: val' },
-    };
-    const res = await handleConfig(cmd);
-    expect(res.success).toBe(false);
-    expect(res.error).toBe('restart failed');
-    expect(res.data?.path).toContain('agent.yml');
-  });
-
-  it('strips directory traversal from filename', async () => {
-    fakeExec(null, '', '');
-    const cmd: AgentCommand = {
-      id: '6',
-      type: 'config',
-      payload: { filename: '../../../etc/passwd', content: 'root:x:0:0' },
-    };
-    const res = await handleConfig(cmd);
-    // path.basename strips the directory part
-    expect(res.data?.path).toBe('/etc/openclaw/passwd');
-  });
-});