npm - @openchambery/web - Versions diffs - 1.19.3-beta.1 → 1.19.3-beta.3 - Mend

@openchambery/web 1.19.3-beta.1 → 1.19.3-beta.3

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (58) hide show

package/dist/index.html CHANGED Viewed

@@ -552,7 +552,7 @@
         opacity: 0.72;
       }
     </style>
-    <script type="module" crossorigin src="/assets/main-DnRyoiLh.js"></script>
+    <script type="module" crossorigin src="/assets/main-Dsi8GlJE.js"></script>
     <link rel="modulepreload" crossorigin href="/assets/rolldown-runtime-C0FnF6B9.js">
     <link rel="modulepreload" crossorigin href="/assets/vendor-base-ui-CnHfUmDN.js">
     <link rel="modulepreload" crossorigin href="/assets/vendor-zustand-B4dlGEM2.js">
@@ -569,8 +569,8 @@
     <link rel="modulepreload" crossorigin href="/assets/terminalApi-Bnx0KvaV.js">
     <link rel="modulepreload" crossorigin href="/assets/types-BuiqMmh_.js">
     <link rel="modulepreload" crossorigin href="/assets/capgoAdapter-DCowZ2ab.js">
-    <link rel="modulepreload" crossorigin href="/assets/runtimeConfig-UeQ6crFG.js">
-    <link rel="stylesheet" crossorigin href="/assets/src-BM9HiQZr.css">
+    <link rel="modulepreload" crossorigin href="/assets/runtimeConfig-DnLjqksJ.js">
+    <link rel="stylesheet" crossorigin href="/assets/src-eGuNWxHc.css">
   </head>
   <body class="h-full bg-background text-foreground">
     <!-- Keep the startup layer outside #root. React replaces every child of

package/dist/mini-chat.html CHANGED Viewed

@@ -74,7 +74,7 @@
       }
     </style>
-    <script type="module" crossorigin src="/assets/miniChat-B4adskso.js"></script>
+    <script type="module" crossorigin src="/assets/miniChat-BoUvYKIn.js"></script>
     <link rel="modulepreload" crossorigin href="/assets/rolldown-runtime-C0FnF6B9.js">
     <link rel="modulepreload" crossorigin href="/assets/vendor-base-ui-CnHfUmDN.js">
     <link rel="modulepreload" crossorigin href="/assets/vendor-zustand-B4dlGEM2.js">
@@ -91,8 +91,8 @@
     <link rel="modulepreload" crossorigin href="/assets/terminalApi-Bnx0KvaV.js">
     <link rel="modulepreload" crossorigin href="/assets/types-BuiqMmh_.js">
     <link rel="modulepreload" crossorigin href="/assets/capgoAdapter-DCowZ2ab.js">
-    <link rel="modulepreload" crossorigin href="/assets/runtimeConfig-UeQ6crFG.js">
-    <link rel="stylesheet" crossorigin href="/assets/src-BM9HiQZr.css">
+    <link rel="modulepreload" crossorigin href="/assets/runtimeConfig-DnLjqksJ.js">
+    <link rel="stylesheet" crossorigin href="/assets/src-eGuNWxHc.css">
   </head>
   <body class="h-full bg-background text-foreground">
     <div id="root" class="h-full">

package/dist/mobile.html CHANGED Viewed

@@ -63,7 +63,7 @@
       })();
     </script>
-    <script type="module" crossorigin src="/assets/mobile-C7W32Ulc.js"></script>
+    <script type="module" crossorigin src="/assets/mobile-C9pZYY0E.js"></script>
     <link rel="modulepreload" crossorigin href="/assets/rolldown-runtime-C0FnF6B9.js">
     <link rel="modulepreload" crossorigin href="/assets/vendor-base-ui-CnHfUmDN.js">
     <link rel="modulepreload" crossorigin href="/assets/vendor-zustand-B4dlGEM2.js">
@@ -80,8 +80,8 @@
     <link rel="modulepreload" crossorigin href="/assets/terminalApi-Bnx0KvaV.js">
     <link rel="modulepreload" crossorigin href="/assets/types-BuiqMmh_.js">
     <link rel="modulepreload" crossorigin href="/assets/capgoAdapter-DCowZ2ab.js">
-    <link rel="modulepreload" crossorigin href="/assets/runtimeConfig-UeQ6crFG.js">
-    <link rel="stylesheet" crossorigin href="/assets/src-BM9HiQZr.css">
+    <link rel="modulepreload" crossorigin href="/assets/runtimeConfig-DnLjqksJ.js">
+    <link rel="stylesheet" crossorigin href="/assets/src-eGuNWxHc.css">
   </head>
   <body class="h-full bg-background text-foreground">
     <div id="root" class="h-full"></div>

package/package.json CHANGED Viewed

@@ -1,6 +1,6 @@
 {
   "name": "@openchambery/web",
-  "version": "1.19.3-beta.1",
+  "version": "1.19.3-beta.3",
   "private": false,
   "type": "module",
   "main": "./server/index.js",

package/server/lib/scheduled-tasks/DOCUMENTATION.md CHANGED Viewed

@@ -223,22 +223,24 @@ SSE events keep the existing `openchamber:scheduled-task-ran` shape.
 ## Post-run continuation
-After a run has finalized (including as `error`) with a session, the user may
-continue chatting in that same history session. When that session later becomes
-idle and a single outcome snapshot is success, the runtime corrects **only
-task state**:
-- `lastStatus` → `success`
-- clear `lastError`
-- keep/set `lastSessionId`
+After a run has finalized with a session, the user may continue chatting in
+that same history session. `observeSessionEvent` corrects **only task state**
+(history rows are not rewritten, `finishRun` is not called again):
+- `session.status` busy/retry while `lastStatus` is `error` or `success` →
+  `lastStatus` `running`, clear `lastError`, keep/set `lastSessionId`
+- later `session.idle` (or idle `session.status`) with a success snapshot →
+  `lastStatus` `success`
 - do not change `lastRunAt` / `lastDurationMs` / `nextRunAt`
-- do not call `finishRun` again (the history row stays the original run snapshot)
-Correction is event-driven via `observeSessionEvent` (`session.idle` or idle
-`session.status`). A live run (`runningTaskKeys`) owns settlement; the observer
-is a no-op while the task is running, if `lastStatus` is already `success` or
-`running`, or if the snapshot is still error/busy/unknown. Observer failures
-are logged and must not throw out of the event bus.
+A live run (`runningTaskKeys`) owns settlement; the observer is a no-op while
+the task is in `runningTaskKeys`. Idle correction is a no-op if `lastStatus`
+is already `success`, or if the snapshot is still error/busy/unknown. Observer
+failures are logged and must not throw out of the event bus.
+Run start also emits `scheduled-task-ran` with `status: running` as soon as
+task state is persisted, so the outer task list can show in-progress before
+the session is attached.
 ## Watchdog cancel / upstream abort

package/server/lib/scheduled-tasks/runtime.js CHANGED Viewed

@@ -390,21 +390,26 @@ const snapshotSessionOutcome = async ({
   return { outcome: 'busy' };
 };
-const parseSessionEventIdle = (event) => {
+const parseSessionEventPhase = (event) => {
   const payload = event?.payload?.payload ?? event?.payload;
   const properties = payload?.properties;
   const sessionID = typeof properties?.sessionID === 'string' ? properties.sessionID : '';
   if (!sessionID) {
-    return { idle: false, sessionID: '' };
+    return { phase: '', sessionID: '' };
   }
   if (payload?.type === 'session.idle') {
-    return { idle: true, sessionID };
+    return { phase: 'idle', sessionID };
   }
   if (payload?.type === 'session.status') {
     const type = properties?.status?.type ?? properties?.info?.type;
-    return { idle: type === 'idle', sessionID };
+    if (type === 'idle') {
+      return { phase: 'idle', sessionID };
+    }
+    if (type === 'busy' || type === 'retry') {
+      return { phase: 'busy', sessionID };
+    }
   }
-  return { idle: false, sessionID };
+  return { phase: '', sessionID };
 };
 export const createScheduledTasksRuntime = (deps) => {
@@ -1291,6 +1296,15 @@ export const createScheduledTasksRuntime = (deps) => {
           if (runningState.task) {
             updateInMemoryTask(projectID, runningState.task);
           }
+          try {
+            emitTaskRunEvent?.({
+              projectID,
+              taskID,
+              ranAt: runStartedAt,
+              status: 'running',
+            });
+          } catch {
+          }
         } catch (error) {
           errorMessage = safeErrorMessage(error);
           logger.warn?.('[ScheduledTasks] failed to persist running state', {
@@ -1586,9 +1600,22 @@ export const createScheduledTasksRuntime = (deps) => {
     };
   };
-  const handleSessionIdleCorrection = async (event) => {
-    const { idle, sessionID } = parseSessionEventIdle(event);
-    if (!idle || !sessionID) {
+  const emitContinuationStatus = (projectID, taskID, sessionID, status) => {
+    try {
+      emitTaskRunEvent?.({
+        projectID,
+        taskID,
+        ranAt: Date.now(),
+        status,
+        sessionID,
+      });
+    } catch {
+    }
+  };
+  const handleSessionContinuation = async (event) => {
+    const { phase, sessionID } = parseSessionEventPhase(event);
+    if (!phase || !sessionID) {
       return;
     }
@@ -1605,10 +1632,28 @@ export const createScheduledTasksRuntime = (deps) => {
     const task = tasksByProject.get(projectID)?.get(taskID);
     const lastStatus = task?.state?.lastStatus;
-    if (lastStatus === 'success' || lastStatus === 'running') {
+    if (phase === 'busy') {
+      if (lastStatus !== 'error' && lastStatus !== 'success') {
+        return;
+      }
+      const stateResult = await projectConfigRuntime.updateScheduledTaskState(projectID, taskID, {
+        lastStatus: 'running',
+        lastError: undefined,
+        lastSessionId: sessionID,
+        updatedAt: Date.now(),
+      });
+      if (stateResult.task) {
+        updateInMemoryTask(projectID, stateResult.task);
+      }
+      emitContinuationStatus(projectID, taskID, sessionID, 'running');
       return;
     }
-    if (lastStatus !== 'error') {
+    if (lastStatus === 'success') {
+      return;
+    }
+    if (lastStatus !== 'error' && lastStatus !== 'running') {
       return;
     }
@@ -1637,7 +1682,8 @@ export const createScheduledTasksRuntime = (deps) => {
       return;
     }
     const latest = tasksByProject.get(projectID)?.get(taskID);
-    if (latest?.state?.lastStatus !== 'error') {
+    const latestStatus = latest?.state?.lastStatus;
+    if (latestStatus !== 'error' && latestStatus !== 'running') {
       return;
     }
@@ -1651,20 +1697,11 @@ export const createScheduledTasksRuntime = (deps) => {
       updateInMemoryTask(projectID, stateResult.task);
     }
-    try {
-      emitTaskRunEvent?.({
-        projectID,
-        taskID,
-        ranAt: Date.now(),
-        status: 'success',
-        sessionID,
-      });
-    } catch {
-    }
+    emitContinuationStatus(projectID, taskID, sessionID, 'success');
   };
   const observeSessionEvent = (event) => {
-    return handleSessionIdleCorrection(event).catch((error) => {
+    return handleSessionContinuation(event).catch((error) => {
       logger.warn?.('[ScheduledTasks] observeSessionEvent failed', {
         error: safeErrorMessage(error),
       });

package/server/lib/scheduled-tasks/runtime.test.js CHANGED Viewed

@@ -1039,6 +1039,79 @@ describe('scheduled-tasks run history and session lifecycle', () => {
     expect(Object.hasOwn(finalPatch, 'lastSessionId')).toBe(false);
   });
+  it('marks lastStatus running when a history session continues, then success on idle', async () => {
+    const history = createHistoryStore();
+    const client = createSuccessfulClient({ settlement: 'assistant-error' });
+    const fetchMock = vi.fn(async (url) => {
+      if (String(url).includes('prompt_async')) {
+        return { ok: true, text: async () => '' };
+      }
+      throw new Error(`unexpected fetch ${url}`);
+    });
+    vi.stubGlobal('fetch', fetchMock);
+    const emitTaskRunEvent = vi.fn();
+    const updateScheduledTaskState = vi.fn(async (_projectID, _taskID, state) => ({
+      task: { ...scheduledTask, state: { ...scheduledTask.state, ...state } },
+    }));
+    const runtime = createRuntime(updateScheduledTaskState, {
+      runHistoryStore: history,
+      waitForOpenCodeReady: vi.fn(async () => {}),
+      emitTaskRunEvent,
+    });
+    await runtime.syncProject('project-1');
+    const result = await runtime.runNow('project-1', 'task-1');
+    expect(result.status).toBe('error');
+    expect(history.finishRun).toHaveBeenCalledTimes(1);
+    await runtime.observeSessionEvent({
+      payload: {
+        type: 'session.status',
+        properties: { sessionID: 'ses_1', status: { type: 'busy' } },
+      },
+    });
+    expect(history.finishRun).toHaveBeenCalledTimes(1);
+    const runningPatch = updateScheduledTaskState.mock.calls.at(-1)[2];
+    expect(runningPatch).toEqual(expect.objectContaining({
+      lastStatus: 'running',
+      lastError: undefined,
+      lastSessionId: 'ses_1',
+    }));
+    expect(Object.hasOwn(runningPatch, 'lastRunAt')).toBe(false);
+    expect(emitTaskRunEvent).toHaveBeenCalledWith(expect.objectContaining({
+      projectID: 'project-1',
+      taskID: 'task-1',
+      status: 'running',
+      sessionID: 'ses_1',
+    }));
+    client.messages.mockImplementation(async () => ({
+      data: [{
+        info: {
+          id: 'msg_ok',
+          role: 'assistant',
+          time: { completed: Date.now() },
+        },
+      }],
+    }));
+    await runtime.observeSessionEvent({
+      payload: {
+        type: 'session.idle',
+        properties: { sessionID: 'ses_1' },
+      },
+    });
+    expect(updateScheduledTaskState.mock.calls.at(-1)[2]).toEqual(expect.objectContaining({
+      lastStatus: 'success',
+      lastSessionId: 'ses_1',
+    }));
+    expect(history.finishRun).toHaveBeenCalledTimes(1);
+    vi.unstubAllGlobals();
+  });
   it('corrects lastStatus error → success on idle after a continuation, without rewriting history', async () => {
     const history = createHistoryStore();
     const client = createSuccessfulClient({ settlement: 'assistant-error' });
@@ -1143,6 +1216,15 @@ describe('scheduled-tasks run history and session lifecycle', () => {
     expect(history.finishRun).not.toHaveBeenCalled();
     const successEmitsBefore = emitTaskRunEvent.mock.calls.filter((call) => call[0].status === 'success').length;
+    const continuationRunningBefore = updateScheduledTaskState.mock.calls.filter((call) => (
+      call[2].lastStatus === 'running' && !Object.hasOwn(call[2], 'lastRunAt')
+    )).length;
+    await runtime.observeSessionEvent({
+      payload: {
+        type: 'session.status',
+        properties: { sessionID: 'ses_1', status: { type: 'busy' } },
+      },
+    });
     await runtime.observeSessionEvent({
       payload: {
         type: 'session.idle',
@@ -1152,6 +1234,9 @@ describe('scheduled-tasks run history and session lifecycle', () => {
     expect(history.finishRun).not.toHaveBeenCalled();
     expect(updateScheduledTaskState.mock.calls.map((call) => call[2].lastStatus)).not.toContain('success');
     expect(emitTaskRunEvent.mock.calls.filter((call) => call[0].status === 'success')).toHaveLength(successEmitsBefore);
+    expect(updateScheduledTaskState.mock.calls.filter((call) => (
+      call[2].lastStatus === 'running' && !Object.hasOwn(call[2], 'lastRunAt')
+    ))).toHaveLength(continuationRunningBefore);
     await vi.advanceTimersByTimeAsync(1_000);
     const result = await runPromise;
@@ -1183,7 +1268,9 @@ describe('scheduled-tasks run history and session lifecycle', () => {
     });
     await runtime.syncProject('project-1');
     const result = await runtime.runNow('project-1', 'task-1');
     expect(result.ok).toBe(true);
+    expect(emitTaskRunEvent.mock.calls.map((call) => call[0].status)[0]).toBe('running');
     expect(history.finishRun).toHaveBeenCalledTimes(1);
     const stateWritesAfterRun = updateScheduledTaskState.mock.calls.length;
     const successEmitsAfterRun = emitTaskRunEvent.mock.calls.filter((call) => call[0].status === 'success').length;