@openchambery/web 1.18.1 → 1.18.2-beta.10

package/server/lib/session-turn-pages/routes.test.js

@@ -320,6 +320,99 @@ describe('registerSessionTurnPageRoutes', () => {
     expect(part.state.output).toBeUndefined();
   });
 
+  it('projects message summary.diffs to L1 count/marker before serializing a turn-page response', async () => {
+    const patch = 'diff-body-'.repeat(20_000);
+    const loadPage = vi.fn(async () => ({
+      ok: true,
+      records: [{
+        info: {
+          id: 'msg_u1',
+          role: 'user',
+          summary: {
+            diffs: [{
+              file: 'src/large.ts',
+              status: 'modified',
+              additions: 9,
+              deletions: 3,
+              patch,
+            }],
+          },
+        },
+        parts: [],
+      }],
+      turnCount: 1,
+      cursor: null,
+      complete: true,
+    }));
+    const { app, route } = registry();
+    registerSessionTurnPageRoutes(app, { sessionTurnPageService: { loadPage } });
+    const res = response();
+
+    await route('GET', ROUTE)({
+      params: { sessionID: 'ses_1' },
+      query: { turns: '3' },
+      headers: {},
+    }, res);
+
+    expect(res.statusCode).toBe(200);
+    expect(res.body.records[0].info.summary).toEqual({
+      diffCount: 1,
+      hasDiffs: true,
+    });
+    expect(res.body.records[0].info.summary.diffs).toBeUndefined();
+    expect(JSON.stringify(res.body)).not.toContain(patch);
+    expect(JSON.stringify(res.body)).not.toContain('src/large.ts');
+  });
+
+  it('keeps L1 turn-page serialization under 64KiB for a 463-file / ~14MB patch summary', async () => {
+    const patchBody = 'P'.repeat(Math.floor((14 * 1024 * 1024) / 463));
+    const diffs = Array.from({ length: 463 }, (_, i) => ({
+      file: `src/generated/file-${i}.ts`,
+      status: 'modified',
+      additions: i % 7,
+      deletions: i % 3,
+      patch: `${patchBody}-${i}`,
+      before: `before-${i}`,
+      after: `after-${i}`,
+    }));
+    const loadPage = vi.fn(async () => ({
+      ok: true,
+      records: [{
+        info: {
+          id: 'msg_huge',
+          role: 'user',
+          summary: { title: 'huge', diffs },
+        },
+        parts: [{ id: 'prt_1', type: 'text', text: 'ok' }],
+      }],
+      turnCount: 1,
+      cursor: null,
+      complete: true,
+    }));
+    const { app, route } = registry();
+    registerSessionTurnPageRoutes(app, { sessionTurnPageService: { loadPage } });
+    const res = response();
+
+    await route('GET', ROUTE)({
+      params: { sessionID: 'ses_huge' },
+      query: { turns: '1' },
+      headers: {},
+    }, res);
+
+    expect(res.statusCode).toBe(200);
+    const serialized = JSON.stringify(res.body);
+    expect(res.body.records[0].info.summary).toEqual({
+      title: 'huge',
+      diffCount: 463,
+      hasDiffs: true,
+    });
+    expect(res.body.records[0].info.summary.diffs).toBeUndefined();
+    expect(serialized).not.toContain('"diffs"');
+    expect(serialized).not.toContain(patchBody.slice(0, 64));
+    expect(serialized).not.toContain('src/generated/file-0.ts');
+    expect(Buffer.byteLength(serialized, 'utf8')).toBeLessThan(64 * 1024);
+  });
+
   it('projects file parts on first packet and prepend the same way', async () => {
     const png = Buffer.concat([
       Buffer.from([0x89, 0x50, 0x4E, 0x47, 0x0D, 0x0A, 0x1A, 0x0A]),
@@ -479,3 +572,269 @@ describe('registerSessionTurnPageRoutes', () => {
     await pending;
   });
 });
+
+const EXACT_MESSAGE_ROUTE = '/api/session/:sessionID/message/:messageID';
+const CHANGES_ROUTE = '/api/openchamber/sessions/:sessionID/changes';
+
+describe('registerSessionTurnPageRoutes — exact message GET', () => {
+  it('registers GET /api/session/:sessionID/message/:messageID', () => {
+    const { app, route } = registry();
+    registerSessionTurnPageRoutes(app, {
+      sessionTurnPageService: { loadPage: vi.fn() },
+      fetchExactMessage: vi.fn(),
+    });
+    expect(route('GET', EXACT_MESSAGE_ROUTE)).toEqual(expect.any(Function));
+  });
+
+  it('returns original message shape with L1 summary projection only', async () => {
+    const patch = '@@ huge @@\n' + 'x'.repeat(2000);
+    const fetchExactMessage = vi.fn(async () => ({
+      info: {
+        id: 'msg_1',
+        role: 'user',
+        summary: {
+          title: 'turn',
+          diffs: [{
+            file: 'a.ts',
+            status: 'modified',
+            additions: 2,
+            deletions: 1,
+            patch,
+          }],
+        },
+      },
+      parts: [{ id: 'prt_1', type: 'text', text: 'hello' }],
+    }));
+    const { app, route } = registry();
+    registerSessionTurnPageRoutes(app, {
+      sessionTurnPageService: { loadPage: vi.fn() },
+      fetchExactMessage,
+    });
+    const res = response();
+
+    await route('GET', EXACT_MESSAGE_ROUTE)({
+      params: { sessionID: 'ses_1', messageID: 'msg_1' },
+      query: { directory: '/repo' },
+      headers: {},
+    }, res);
+
+    expect(res.statusCode).toBe(200);
+    expect(fetchExactMessage).toHaveBeenCalledWith(expect.objectContaining({
+      sessionID: 'ses_1',
+      messageID: 'msg_1',
+      directory: '/repo',
+    }));
+    expect(res.body).toEqual({
+      info: {
+        id: 'msg_1',
+        role: 'user',
+        summary: {
+          title: 'turn',
+          diffCount: 1,
+          hasDiffs: true,
+        },
+      },
+      parts: [{ id: 'prt_1', type: 'text', text: 'hello' }],
+    });
+    expect(JSON.stringify(res.body)).not.toContain(patch);
+    expect(JSON.stringify(res.body)).not.toContain('a.ts');
+  });
+
+  it('rejects oversize messageID / sessionID with 400', async () => {
+    const fetchExactMessage = vi.fn();
+    const { app, route } = registry();
+    registerSessionTurnPageRoutes(app, {
+      sessionTurnPageService: { loadPage: vi.fn() },
+      fetchExactMessage,
+    });
+    const handler = route('GET', EXACT_MESSAGE_ROUTE);
+
+    const oversize = 'm'.repeat(513);
+    const res = response();
+    await handler({
+      params: { sessionID: 'ses_1', messageID: oversize },
+      query: {},
+      headers: {},
+    }, res);
+    expect(res.statusCode).toBe(400);
+    expect(res.body.code).toBe('invalid_message');
+    expect(fetchExactMessage).not.toHaveBeenCalled();
+  });
+
+  it('maps not_found to HTTP 404', async () => {
+    const fetchExactMessage = vi.fn(async () => {
+      const error = new Error('not_found');
+      error.code = 'not_found';
+      throw error;
+    });
+    const { app, route } = registry();
+    registerSessionTurnPageRoutes(app, {
+      sessionTurnPageService: { loadPage: vi.fn() },
+      fetchExactMessage,
+    });
+    const res = response();
+    await route('GET', EXACT_MESSAGE_ROUTE)({
+      params: { sessionID: 'ses_1', messageID: 'msg_missing' },
+      query: {},
+      headers: {},
+    }, res);
+    expect(res.statusCode).toBe(404);
+    expect(res.body.code).toBe('not_found');
+  });
+});
+
+describe('registerSessionTurnPageRoutes — changes API', () => {
+  it('registers GET /api/openchamber/sessions/:sessionID/changes', () => {
+    const { app, route } = registry();
+    registerSessionTurnPageRoutes(app, {
+      sessionTurnPageService: { loadPage: vi.fn() },
+      sessionChangesService: { loadChanges: vi.fn() },
+    });
+    expect(route('GET', CHANGES_ROUTE)).toEqual(expect.any(Function));
+  });
+
+  it('returns L2 file list without patch bodies when file is omitted', async () => {
+    const loadChanges = vi.fn(async () => ({
+      ok: true,
+      body: {
+        files: [{
+          file: 'src/a.ts',
+          status: 'modified',
+          additions: 3,
+          deletions: 1,
+        }],
+      },
+    }));
+    const { app, route } = registry();
+    registerSessionTurnPageRoutes(app, {
+      sessionTurnPageService: { loadPage: vi.fn() },
+      sessionChangesService: { loadChanges },
+    });
+    const res = response();
+
+    await route('GET', CHANGES_ROUTE)({
+      params: { sessionID: 'ses_1' },
+      query: { messageID: 'msg_1', directory: '/repo' },
+      headers: {},
+    }, res);
+
+    expect(res.statusCode).toBe(200);
+    expect(loadChanges).toHaveBeenCalledWith(expect.objectContaining({
+      sessionID: 'ses_1',
+      messageID: 'msg_1',
+      directory: '/repo',
+      file: undefined,
+    }));
+    expect(res.body).toEqual({
+      files: [{
+        file: 'src/a.ts',
+        status: 'modified',
+        additions: 3,
+        deletions: 1,
+      }],
+    });
+    expect(JSON.stringify(res.body)).not.toContain('patch');
+    expect(res.body.info).toBeUndefined();
+    expect(res.body.parts).toBeUndefined();
+  });
+
+  it('returns L3 single-file diff when file is provided', async () => {
+    const loadChanges = vi.fn(async () => ({
+      ok: true,
+      body: {
+        diff: {
+          file: 'src/a.ts',
+          status: 'modified',
+          additions: 3,
+          deletions: 1,
+          patch: '@@ -1 +1 @@\n+line',
+        },
+      },
+    }));
+    const { app, route } = registry();
+    registerSessionTurnPageRoutes(app, {
+      sessionTurnPageService: { loadPage: vi.fn() },
+      sessionChangesService: { loadChanges },
+    });
+    const res = response();
+
+    await route('GET', CHANGES_ROUTE)({
+      params: { sessionID: 'ses_1' },
+      query: { messageID: 'msg_1', file: 'src/a.ts' },
+      headers: {},
+    }, res);
+
+    expect(res.statusCode).toBe(200);
+    expect(loadChanges).toHaveBeenCalledWith(expect.objectContaining({
+      file: 'src/a.ts',
+    }));
+    expect(res.body.diff.file).toBe('src/a.ts');
+    expect(res.body.diff.patch).toContain('+line');
+    expect(res.body.files).toBeUndefined();
+  });
+
+  it('rejects missing messageID and control-character file with 400', async () => {
+    const loadChanges = vi.fn();
+    const { app, route } = registry();
+    registerSessionTurnPageRoutes(app, {
+      sessionTurnPageService: { loadPage: vi.fn() },
+      sessionChangesService: { loadChanges },
+    });
+    const handler = route('GET', CHANGES_ROUTE);
+
+    const missing = response();
+    await handler({
+      params: { sessionID: 'ses_1' },
+      query: {},
+      headers: {},
+    }, missing);
+    expect(missing.statusCode).toBe(400);
+    expect(missing.body.code).toBe('invalid_message');
+
+    const badFile = response();
+    await handler({
+      params: { sessionID: 'ses_1' },
+      query: { messageID: 'msg_1', file: 'src/\0evil.ts' },
+      headers: {},
+    }, badFile);
+    expect(badFile.statusCode).toBe(400);
+    expect(badFile.body.code).toBe('invalid_file');
+    expect(loadChanges).not.toHaveBeenCalled();
+  });
+
+  it('maps change_not_found to HTTP 404 with stable code', async () => {
+    const loadChanges = vi.fn(async () => ({ ok: false, error: 'change_not_found' }));
+    const { app, route } = registry();
+    registerSessionTurnPageRoutes(app, {
+      sessionTurnPageService: { loadPage: vi.fn() },
+      sessionChangesService: { loadChanges },
+    });
+    const res = response();
+    await route('GET', CHANGES_ROUTE)({
+      params: { sessionID: 'ses_1' },
+      query: { messageID: 'msg_1', file: 'missing.ts' },
+      headers: {},
+    }, res);
+    expect(res.statusCode).toBe(404);
+    expect(res.body).toEqual({
+      error: 'change file not found',
+      code: 'change_not_found',
+    });
+  });
+
+  it('maps aborted to HTTP 499', async () => {
+    const loadChanges = vi.fn(async () => ({ ok: false, error: 'aborted' }));
+    const { app, route } = registry();
+    registerSessionTurnPageRoutes(app, {
+      sessionTurnPageService: { loadPage: vi.fn() },
+      sessionChangesService: { loadChanges },
+    });
+    const res = response();
+    await route('GET', CHANGES_ROUTE)({
+      params: { sessionID: 'ses_1' },
+      query: { messageID: 'msg_1' },
+      headers: {},
+    }, res);
+    expect(res.statusCode).toBe(499);
+  });
+});

package/server/lib/session-turn-pages/service.js

@@ -16,6 +16,8 @@
  * (true only when nothing older was trimmed from the scanned window).
  */
 
+import { projectMessageSummaryDiffCounts } from '../event-stream/diff-summary.js';
+
 const ASSISTANT_SESSION_DIVIDER_PREFIX = 'oc_asst_session_divider:';
 
 const DEFAULT_MAX_SCAN_PAGES = 50;
@@ -457,22 +459,42 @@ const isUserRecord = (record) => {
 };
 
 /**
- * Summarize tool/reasoning parts so a first packet does not have to carry the
- * bodies of a long tool-heavy turn.
+ * L1: project message `summary.diffs` arrays to `{ diffCount, hasDiffs }` and
+ * remove the file array. Preserves every other message / summary field.
+ */
+export const projectMessageDiffSummaries = (records) => {
+  if (!Array.isArray(records) || records.length === 0) return records;
+
+  let changedAny = false;
+  const projected = records.map((record) => {
+    if (!record || typeof record !== 'object') return record;
+    const info = projectMessageSummaryDiffCounts(record.info);
+    if (info === record.info) return record;
+    changedAny = true;
+    return { ...record, info };
+  });
+
+  return changedAny ? projected : records;
+};
+
+/**
+ * Summarize message diff snapshots and tool/reasoning parts so a first packet
+ * does not have to carry bodies from a long tool-heavy turn.
  *
  * Runs after `selectTurnRecords`, so `turnCount`, `complete`, and cursor
- * encoding are all derived from unprojected records and cannot shift. User rows
- * and assistant text pass through untouched, and records that gain nothing from
+ * encoding are all derived from unprojected records and cannot shift. User and
+ * assistant text pass through untouched, and records that gain nothing from
  * projection keep their original object reference.
  *
  * @param {unknown[]} records
  * @returns {unknown[]}
  */
 export const projectSlimParts = (records) => {
-  if (!Array.isArray(records) || records.length === 0) return records;
+  const summaryProjected = projectMessageDiffSummaries(records);
+  if (!Array.isArray(summaryProjected) || summaryProjected.length === 0) return summaryProjected;
 
   let changedAny = false;
-  const projected = records.map((record) => {
+  const projected = summaryProjected.map((record) => {
     if (!record || typeof record !== 'object') return record;
     const userRow = isUserRecord(record);
 
@@ -503,7 +525,7 @@ export const projectSlimParts = (records) => {
     return { ...record, parts: nextParts };
   });
 
-  return changedAny ? projected : records;
+  return changedAny ? projected : summaryProjected;
 };
 
 const countAuthoredBoundaries = (records) =>

package/server/lib/session-turn-pages/service.test.js

@@ -172,6 +172,36 @@ describe('projectSlimParts', () => {
     },
   });
 
+  it('projects message summary.diffs to L1 count/marker even when parts are empty', () => {
+    const patch = 'diff-body-'.repeat(20_000);
+    const [projected] = projectSlimParts([{
+      info: {
+        id: 'msg_diff',
+        role: 'user',
+        summary: {
+          title: 'kept',
+          diffs: [{
+            file: 'src/large.ts',
+            status: 'modified',
+            additions: 12,
+            deletions: 4,
+            patch,
+          }],
+        },
+      },
+      parts: [],
+    }]);
+
+    expect(projected.info.summary).toEqual({
+      title: 'kept',
+      diffCount: 1,
+      hasDiffs: true,
+    });
+    expect(projected.info.summary.diffs).toBeUndefined();
+    expect(JSON.stringify(projected)).not.toContain(patch);
+    expect(JSON.stringify(projected)).not.toContain('src/large.ts');
+  });
+
   it('drops tool output and metadata but keeps identity and status', () => {
     const [record] = projectSlimParts([
       { info: { id: 'msg_a1', role: 'assistant' }, parts: [toolPart('prt_1', 'x'.repeat(5000))] },