@openchamber/web 1.18.4 → 1.20.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +1 -0
- package/dist/assets/{CodeMirrorCommentWidgets-4qZbrEXU.js → CodeMirrorCommentWidgets-C36E738Y.js} +1 -1
- package/dist/assets/{CommitSection-MJmntVPJ.js → CommitSection-C-F3AX6D.js} +1 -1
- package/dist/assets/{DiagramEditor-jnG3Hbxg.js → DiagramEditor-BPECg1jS.js} +1 -1
- package/dist/assets/DiagramView-D0YNMix8.js +1 -0
- package/dist/assets/DiffView-BHWaMYCC.js +4 -0
- package/dist/assets/FilesView-NMBCW2Tm.js +14 -0
- package/dist/assets/{GitView-DBFrDDBv.js → GitView-Rp8P1KEI.js} +4 -4
- package/dist/assets/{JsonTreeView-DLW2Wy1g.js → JsonTreeView-KnXFN2A-.js} +1 -1
- package/dist/assets/MarkdownImageGallery-BMn3mtor.js +1 -0
- package/dist/assets/MarkdownRendererImpl-kD6N03pH.js +12 -0
- package/dist/assets/OnboardingScreen-CenIeD4v.js +1 -0
- package/dist/assets/{PatchDiff-BuLPx7AN.js → PatchDiff-BzVOVog8.js} +1 -1
- package/dist/assets/{PierreDiffViewer-BHm4Yr0X.js → PierreDiffViewer-Dlby4XqT.js} +2 -2
- package/dist/assets/PlanView-Czu1KMJa.js +4 -0
- package/dist/assets/SessionSwitcherDropdown-IETz58DB.js +1 -0
- package/dist/assets/SettingsView-B6vmuf-c.js +28 -0
- package/dist/assets/SettingsWindow-CauZpdD3.js +1 -0
- package/dist/assets/ToolOutputDialog-BB1c--Zr.js +15 -0
- package/dist/assets/ToolPartDiffPreview-DaOIDISD.js +8 -0
- package/dist/assets/{VirtualizedFileDiff-CwGocYQd.js → VirtualizedFileDiff-lESMT-2b.js} +4 -4
- package/dist/assets/{WalkthroughView-5DyvN03T.js → WalkthroughView-CaSYE0lw.js} +2 -2
- package/dist/assets/{computeVirtualFileMetrics-Da00Jg7M.js → computeVirtualFileMetrics-DkRR5b75.js} +2 -2
- package/dist/assets/contextPanelEmbeddedChat-BEARQjgn.js +1 -0
- package/dist/assets/de-DFdX3ABv.js +9 -0
- package/dist/assets/document-attachments-DFAWlG3U.js +31 -0
- package/dist/assets/es-iC-FKvV9.js +15 -0
- package/dist/assets/fr-BBbi_1AL.js +13 -0
- package/dist/assets/index-BiEgzzkg.js +1 -0
- package/dist/assets/index-Cwmuwk3V.js +7 -0
- package/dist/assets/index-GNm1wgUH.css +1 -0
- package/dist/assets/{isDiffPlainText-D9YpoLrV.js → isDiffPlainText-BG53Ixxy.js} +1 -1
- package/dist/assets/{isFilePlainText-gTibdNIe.js → isFilePlainText-BbV-39jl.js} +1 -1
- package/dist/assets/ja-DQLQJL2J.js +15 -0
- package/dist/assets/ko-BeElEB4Y.js +15 -0
- package/dist/assets/{lua-BgMRiT3U.js → lua-VAEuO923.js} +1 -1
- package/dist/assets/main-Dpzo18z7.js +2 -0
- package/dist/assets/main-WMjtYzJs.js +921 -0
- package/dist/assets/markdownCore--tDmyI_v.js +2 -0
- package/dist/assets/miniChat-ldEghBLB.js +2 -0
- package/dist/assets/mobile-Dk-VGreF.js +2 -0
- package/dist/assets/{patchFileDiff-KNkxM1C1.js → patchFileDiff-BcFaMtMu.js} +1 -1
- package/dist/assets/pl-CLHt2_vV.js +15 -0
- package/dist/assets/pt-BR-C_MPUq7e.js +15 -0
- package/dist/assets/renderElectronMiniChatApp-DIgCOmXY.js +2 -0
- package/dist/assets/renderMobileApp-CDfHS5rr.js +25 -0
- package/dist/assets/runtimeEndpointReset-ovNbaZ-x.js +15 -0
- package/dist/assets/scheduledTasksApi-BFSlqgnG.js +1 -0
- package/dist/assets/{shikiHighlight-C7LTbwFx.js → shikiHighlight-DCT2Sq_z.js} +1 -1
- package/dist/assets/uk-PhsC-c4-.js +15 -0
- package/dist/assets/{useAppFontEffects-BikB6enL.js → useAppFontEffects-B53Rb6m7.js} +168 -164
- package/dist/assets/useInlineCommentController-DSfrIBKT.js +2 -0
- package/dist/assets/{vendor-base-ui-D_V6hAcE.js → vendor-base-ui-DsHmyMwp.js} +1 -1
- package/dist/assets/vendor-codemirror-autocomplete-DzPz9Wgq.js +1 -0
- package/dist/assets/vendor-codemirror-commands-B7H_j0iU.js +1 -0
- package/dist/assets/{vendor-codemirror-lang-angular-CgY7_gQ1.js → vendor-codemirror-lang-angular-DEPs2M5t.js} +1 -1
- package/dist/assets/{vendor-codemirror-lang-cpp-B5Ta4enQ.js → vendor-codemirror-lang-cpp-DhkseaMo.js} +1 -1
- package/dist/assets/{vendor-codemirror-lang-css-VgNqFSH-.js → vendor-codemirror-lang-css-O0cZX78y.js} +1 -1
- package/dist/assets/{vendor-codemirror-lang-go-LxLz62pp.js → vendor-codemirror-lang-go-fMdQYcON.js} +1 -1
- package/dist/assets/vendor-codemirror-lang-html-CfgK872x.js +1 -0
- package/dist/assets/{vendor-codemirror-lang-java-Bksi1PH4.js → vendor-codemirror-lang-java-CQj4S3zl.js} +1 -1
- package/dist/assets/vendor-codemirror-lang-javascript-Cc2ZYbgX.js +13 -0
- package/dist/assets/{vendor-codemirror-lang-jinja-C7npuDD7.js → vendor-codemirror-lang-jinja-BmZZv8g-.js} +1 -1
- package/dist/assets/{vendor-codemirror-lang-json-ryCw7nab.js → vendor-codemirror-lang-json-CMBS2tG9.js} +1 -1
- package/dist/assets/{vendor-codemirror-lang-less-BxsZJD6N.js → vendor-codemirror-lang-less-C6Eo8hVS.js} +1 -1
- package/dist/assets/{vendor-codemirror-lang-liquid-De6qch10.js → vendor-codemirror-lang-liquid-DSTR47-H.js} +1 -1
- package/dist/assets/vendor-codemirror-lang-markdown-BPGOH9ye.js +1 -0
- package/dist/assets/{vendor-codemirror-lang-php-Cm1es33p.js → vendor-codemirror-lang-php-DD9udfPH.js} +1 -1
- package/dist/assets/{vendor-codemirror-lang-python-N414WYK-.js → vendor-codemirror-lang-python-HahnQaAS.js} +1 -1
- package/dist/assets/{vendor-codemirror-lang-rust-C_WuUStH.js → vendor-codemirror-lang-rust-nLTovbjv.js} +1 -1
- package/dist/assets/{vendor-codemirror-lang-sass-8UHTCAOM.js → vendor-codemirror-lang-sass-pL2Yc72v.js} +1 -1
- package/dist/assets/{vendor-codemirror-lang-sql-CV3sMA5D.js → vendor-codemirror-lang-sql-BVBnan19.js} +1 -1
- package/dist/assets/{vendor-codemirror-lang-vue-DzvC1Dhk.js → vendor-codemirror-lang-vue-BqGzJVm1.js} +1 -1
- package/dist/assets/{vendor-codemirror-lang-wast-jlr-LDdA.js → vendor-codemirror-lang-wast-B0_m5DqU.js} +1 -1
- package/dist/assets/{vendor-codemirror-lang-xml-CrO63OVp.js → vendor-codemirror-lang-xml-Dj3voadT.js} +1 -1
- package/dist/assets/{vendor-codemirror-lang-yaml-dxi6CISW.js → vendor-codemirror-lang-yaml-yu-9Z5u7.js} +1 -1
- package/dist/assets/vendor-codemirror-language-BgPj_McA.js +3 -0
- package/dist/assets/{vendor-codemirror-language-data-CLHw8NWn.js → vendor-codemirror-language-data-vch3tJ4c.js} +2 -2
- package/dist/assets/vendor-codemirror-search-BmS-GmcX.js +2 -0
- package/dist/assets/{vendor-codemirror-state-CNWM3Q8V.js → vendor-codemirror-state-C9awkmn-.js} +5 -5
- package/dist/assets/vendor-codemirror-view-CiLROUVV.js +4 -0
- package/dist/assets/vendor-replit-codemirror-vim-B2DJlAhT.js +6 -0
- package/dist/assets/vendor-replit-codemirror-vim-core-FHzKdNUS.js +34 -0
- package/dist/assets/vendor-zod-C9ioTTSo.js +39 -0
- package/dist/assets/{web-components-GMc3oR3i.js → web-components-pcwCTWjC.js} +4 -4
- package/dist/assets/zh-CN-wF-NOFHM.js +15 -0
- package/dist/assets/zh-TW-4m4-A7rT.js +15 -0
- package/dist/index.html +5 -4
- package/dist/mini-chat.html +4 -3
- package/dist/mobile.html +4 -3
- package/package.json +3 -5
- package/server/index.js +152 -3
- package/server/lib/agent-memory/actions.js +243 -0
- package/server/lib/agent-memory/actions.test.js +343 -0
- package/server/lib/agent-memory/feature-flag.js +19 -0
- package/server/lib/agent-memory/feature-flag.test.js +38 -0
- package/server/lib/agent-memory/project-resolution.js +65 -0
- package/server/lib/agent-memory/project-resolution.test.js +94 -0
- package/server/lib/agent-memory/routes.http.test.js +270 -0
- package/server/lib/agent-memory/routes.js +169 -0
- package/server/lib/agent-memory/runtime.js +432 -0
- package/server/lib/agent-memory/runtime.test.js +344 -0
- package/server/lib/agent-memory/threat-patterns.js +61 -0
- package/server/lib/agent-memory/threat-patterns.test.js +61 -0
- package/server/lib/agent-tool/DOCUMENTATION.md +14 -0
- package/server/lib/agent-tool/runtime.js +63 -13
- package/server/lib/agent-tool/runtime.test.js +85 -2
- package/server/lib/context-obligatory/runtime.js +34 -3
- package/server/lib/context-obligatory/runtime.test.js +114 -0
- package/server/lib/dictation/DOCUMENTATION.md +32 -8
- package/server/lib/dictation/local/sherpa-recognizer.js +35 -78
- package/server/lib/dictation/local/worker-process.js +2 -2
- package/server/lib/dictation/openai-compatible-session.js +3 -2
- package/server/lib/dictation/stream-manager.js +77 -34
- package/server/lib/dictation/stream-manager.test.js +60 -2
- package/server/lib/fs/DOCUMENTATION.md +3 -0
- package/server/lib/fs/routes.js +149 -32
- package/server/lib/fs/routes.test.js +301 -0
- package/server/lib/git/DOCUMENTATION.md +8 -0
- package/server/lib/git/routes.js +43 -0
- package/server/lib/git/service.js +206 -72
- package/server/lib/git/service.test.js +222 -0
- package/server/lib/github/DOCUMENTATION.md +14 -3
- package/server/lib/github/pr-status.js +188 -83
- package/server/lib/github/pr-status.test.js +182 -0
- package/server/lib/github/routes.js +36 -30
- package/server/lib/notifications/template-runtime.js +2 -3
- package/server/lib/openchamber-control/action-resolution.test.js +65 -0
- package/server/lib/openchamber-control/actions.js +78 -0
- package/server/lib/openchamber-control/service.js +7 -0
- package/server/lib/openchamber-sessions/routes.js +14 -0
- package/server/lib/opencode/DOCUMENTATION.md +12 -6
- package/server/lib/opencode/claude-cli-auth.js +60 -0
- package/server/lib/opencode/claude-cli-auth.test.js +54 -0
- package/server/lib/opencode/feature-routes-runtime.js +16 -9
- package/server/lib/opencode/lifecycle.js +202 -26
- package/server/lib/opencode/lifecycle.test.js +179 -1
- package/server/lib/opencode/plugins.js +12 -3
- package/server/lib/opencode/plugins.test.js +18 -0
- package/server/lib/opencode/providers.js +9 -4
- package/server/lib/opencode/providers.test.js +27 -0
- package/server/lib/opencode/proxy-agent-wiring.test.js +152 -0
- package/server/lib/opencode/proxy.js +116 -6
- package/server/lib/opencode/proxy.test.js +158 -1
- package/server/lib/opencode/restart-session-recovery.test.js +59 -0
- package/server/lib/opencode/routes.js +4 -1
- package/server/lib/opencode/session-runtime.js +39 -2
- package/server/lib/opencode/session-runtime.test.js +74 -0
- package/server/lib/opencode/settings-helpers.js +26 -0
- package/server/lib/opencode/settings-helpers.test.js +57 -0
- package/server/lib/opencode/settings-normalization-runtime.js +3 -0
- package/server/lib/opencode/settings-normalization-runtime.test.js +16 -0
- package/server/lib/opencode/settings-runtime.js +83 -10
- package/server/lib/opencode/settings-runtime.test.js +85 -0
- package/server/lib/opencode/shared.js +120 -16
- package/server/lib/opencode/shared.test.js +185 -1
- package/server/lib/opencode/skill-routes.js +29 -73
- package/server/lib/opencode/skill-routes.test.js +2 -5
- package/server/lib/project-context/DOCUMENTATION.md +160 -0
- package/server/lib/project-context/routes.http.test.js +264 -0
- package/server/lib/project-context/routes.js +237 -0
- package/server/lib/project-context/runtime.js +672 -0
- package/server/lib/project-context/runtime.test.js +498 -0
- package/server/lib/projects/project-config.js +7 -2
- package/server/lib/quota/DOCUMENTATION.md +17 -2
- package/server/lib/quota/providers/claude/auth.js +113 -0
- package/server/lib/quota/providers/claude/auth.test.js +117 -0
- package/server/lib/quota/providers/claude/index.js +151 -0
- package/server/lib/quota/providers/claude/index.test.js +147 -0
- package/server/lib/quota/providers/claude/transforms.js +127 -0
- package/server/lib/quota/providers/claude/transforms.test.js +82 -0
- package/server/lib/quota/providers/command-code.js +90 -0
- package/server/lib/quota/providers/command-code.test.js +85 -0
- package/server/lib/quota/providers/index.js +30 -2
- package/server/lib/quota/providers/index.test.js +10 -1
- package/server/lib/quota/providers/zai.js +26 -6
- package/server/lib/quota/providers/zai.test.js +33 -0
- package/server/lib/quota/utils/formatters.js +2 -1
- package/server/lib/scheduled-tasks/runtime.js +21 -2
- package/server/lib/session-knowledge/DOCUMENTATION.md +89 -0
- package/server/lib/session-knowledge/routes.js +107 -0
- package/server/lib/session-knowledge/runtime.js +331 -0
- package/server/lib/session-knowledge/runtime.test.js +275 -0
- package/server/lib/skills-catalog/DOCUMENTATION.md +18 -45
- package/server/lib/skills-catalog/cache.js +120 -1
- package/server/lib/skills-catalog/cache.test.js +77 -0
- package/server/lib/skills-catalog/curated-sources.js +21 -5
- package/server/lib/skills-catalog/curated-sources.test.js +10 -0
- package/server/lib/skills-catalog/disk-cache.js +52 -0
- package/server/lib/skills-catalog/github-meta.js +139 -0
- package/server/lib/skills-catalog/github-meta.test.js +71 -0
- package/server/lib/skills-catalog/source.js +0 -5
- package/server/lib/small-model/DOCUMENTATION.md +74 -6
- package/server/lib/small-model/call.js +46 -12
- package/server/lib/small-model/call.test.js +79 -0
- package/server/lib/small-model/index.js +57 -6
- package/server/lib/small-model/index.test.js +102 -2
- package/server/lib/small-model/routes.js +4 -2
- package/server/lib/small-model/runtime-providers.js +156 -0
- package/server/lib/small-model/runtime-providers.test.js +112 -0
- package/dist/assets/DiagramView-CFXxgg_a.js +0 -1
- package/dist/assets/DiffView-DZIoOnV7.js +0 -4
- package/dist/assets/FilesView-BKL6YlKG.js +0 -14
- package/dist/assets/MarkdownImageGallery-DKIylIK7.js +0 -1
- package/dist/assets/MarkdownRendererImpl-CLv8hxvv.js +0 -12
- package/dist/assets/OnboardingScreen-D2Y6djMw.js +0 -1
- package/dist/assets/PlanView-ZYEJn8A_.js +0 -4
- package/dist/assets/SessionSwitcherDropdown-rro-SsaO.js +0 -1
- package/dist/assets/SettingsView-5RmswFZe.js +0 -28
- package/dist/assets/SettingsWindow-BZhAYFdS.js +0 -1
- package/dist/assets/ToolOutputDialog-Za6V4VMJ.js +0 -15
- package/dist/assets/ToolPartDiffPreview-BL-9ixyC.js +0 -8
- package/dist/assets/contextPanelEmbeddedChat-B-bSg3P5.js +0 -1
- package/dist/assets/de-u7gSnqWs.js +0 -9
- package/dist/assets/document-attachments-CX_YaDsu.js +0 -30
- package/dist/assets/es-T9O7aAOr.js +0 -15
- package/dist/assets/fr-Oor7ewbE.js +0 -13
- package/dist/assets/index-BzIpNlNE.css +0 -1
- package/dist/assets/index-C0yNhuZw.js +0 -1
- package/dist/assets/index-DRpChWux.js +0 -7
- package/dist/assets/ja-DHpqbVmr.js +0 -15
- package/dist/assets/ko-CwLkS3nx.js +0 -15
- package/dist/assets/main-D7UcL3VQ.js +0 -2
- package/dist/assets/main-DPMd2iKS.js +0 -915
- package/dist/assets/markdownCore-DDrHVneM.js +0 -2
- package/dist/assets/miniChat-O_GVoEbc.js +0 -2
- package/dist/assets/mobile-Br4TtAqc.js +0 -2
- package/dist/assets/pl-CcZILN8q.js +0 -15
- package/dist/assets/pt-BR-DYHhVK6o.js +0 -15
- package/dist/assets/renderElectronMiniChatApp-CJpdxTT1.js +0 -2
- package/dist/assets/renderMobileApp-toj9cXoh.js +0 -25
- package/dist/assets/runtimeEndpointReset-BVmispdD.js +0 -13
- package/dist/assets/scheduledTasksApi-ByKya3Un.js +0 -1
- package/dist/assets/uk-BA2kZR38.js +0 -15
- package/dist/assets/useInlineCommentController-CYPvYJDt.js +0 -2
- package/dist/assets/vendor-codemirror-autocomplete-BjbBRsUA.js +0 -1
- package/dist/assets/vendor-codemirror-commands-ARAOgp1x.js +0 -1
- package/dist/assets/vendor-codemirror-lang-html-B3Qe3OpS.js +0 -1
- package/dist/assets/vendor-codemirror-lang-javascript-Bbw3D7r0.js +0 -13
- package/dist/assets/vendor-codemirror-lang-markdown-FGQydhTc.js +0 -1
- package/dist/assets/vendor-codemirror-language-DUOssd4j.js +0 -3
- package/dist/assets/vendor-codemirror-search-8kyQdB3f.js +0 -2
- package/dist/assets/vendor-codemirror-view-DSzLbZiS.js +0 -4
- package/dist/assets/vendor-replit-codemirror-vim-B0Ecqnlh.js +0 -39
- package/dist/assets/zh-CN-dlOQK6v9.js +0 -15
- package/dist/assets/zh-TW-BnqQ-WL5.js +0 -15
- package/server/lib/quota/providers/claude.js +0 -107
- package/server/lib/skills-catalog/clawdhub/api.js +0 -126
- package/server/lib/skills-catalog/clawdhub/install.js +0 -238
- package/server/lib/skills-catalog/clawdhub/install.test.js +0 -100
- package/server/lib/skills-catalog/clawdhub/scan.js +0 -61
|
@@ -179,6 +179,80 @@ describe('session runtime', () => {
|
|
|
179
179
|
expect(runtime.getActiveSessionCount()).toBe(0);
|
|
180
180
|
});
|
|
181
181
|
|
|
182
|
+
it('interrupts busy sessions after restart and broadcasts terminal events once', () => {
|
|
183
|
+
const events = [];
|
|
184
|
+
const runtime = createSessionRuntime({
|
|
185
|
+
writeSseEvent() {},
|
|
186
|
+
getNotificationClients: () => new Set(),
|
|
187
|
+
broadcastEvent: (event) => events.push(event),
|
|
188
|
+
});
|
|
189
|
+
runtimes.push(runtime);
|
|
190
|
+
const status = (sessionID, type) => runtime.processOpenCodeSsePayload({
|
|
191
|
+
type: 'session.status',
|
|
192
|
+
properties: { sessionID, status: { type } },
|
|
193
|
+
});
|
|
194
|
+
|
|
195
|
+
status('session-busy-1', 'busy');
|
|
196
|
+
status('session-busy-2', 'retry');
|
|
197
|
+
status('session-busy-3', 'busy');
|
|
198
|
+
status('session-idle', 'idle');
|
|
199
|
+
expect(runtime.getActiveSessionCount()).toBe(3);
|
|
200
|
+
events.length = 0;
|
|
201
|
+
|
|
202
|
+
expect(runtime.interruptBusySessionsAfterRestart()).toEqual({
|
|
203
|
+
sessionIds: ['session-busy-1', 'session-busy-2', 'session-busy-3'],
|
|
204
|
+
});
|
|
205
|
+
|
|
206
|
+
expect(runtime.getActiveSessionCount()).toBe(0);
|
|
207
|
+
expect(runtime.getSessionActivitySnapshot()).toEqual({
|
|
208
|
+
'session-busy-1': { type: 'idle' },
|
|
209
|
+
'session-busy-2': { type: 'idle' },
|
|
210
|
+
'session-busy-3': { type: 'idle' },
|
|
211
|
+
'session-idle': { type: 'idle' },
|
|
212
|
+
});
|
|
213
|
+
expect(runtime.getSessionStateSnapshot()).toEqual({
|
|
214
|
+
'session-busy-1': expect.objectContaining({
|
|
215
|
+
status: 'idle',
|
|
216
|
+
metadata: expect.objectContaining({
|
|
217
|
+
message: 'Interrupted by OpenCode restart',
|
|
218
|
+
reason: 'opencode-restart',
|
|
219
|
+
}),
|
|
220
|
+
}),
|
|
221
|
+
'session-busy-2': expect.objectContaining({ status: 'idle' }),
|
|
222
|
+
'session-busy-3': expect.objectContaining({ status: 'idle' }),
|
|
223
|
+
'session-idle': expect.objectContaining({ status: 'idle' }),
|
|
224
|
+
});
|
|
225
|
+
|
|
226
|
+
const terminalEvents = events.filter((event) => (
|
|
227
|
+
event.type === 'openchamber:session-status' || event.type === 'session.error'
|
|
228
|
+
));
|
|
229
|
+
expect(terminalEvents).toHaveLength(6);
|
|
230
|
+
for (const sessionId of ['session-busy-1', 'session-busy-2', 'session-busy-3']) {
|
|
231
|
+
expect(terminalEvents).toContainEqual({
|
|
232
|
+
type: 'openchamber:session-status',
|
|
233
|
+
properties: expect.objectContaining({
|
|
234
|
+
sessionID: sessionId,
|
|
235
|
+
status: 'idle',
|
|
236
|
+
}),
|
|
237
|
+
});
|
|
238
|
+
expect(terminalEvents).toContainEqual({
|
|
239
|
+
type: 'session.error',
|
|
240
|
+
properties: {
|
|
241
|
+
sessionID: sessionId,
|
|
242
|
+
error: {
|
|
243
|
+
name: 'MessageAbortedError',
|
|
244
|
+
message: 'The running turn was interrupted when OpenCode restarted.',
|
|
245
|
+
},
|
|
246
|
+
},
|
|
247
|
+
});
|
|
248
|
+
}
|
|
249
|
+
expect(terminalEvents.some((event) => event.properties.sessionID === 'session-idle')).toBe(false);
|
|
250
|
+
|
|
251
|
+
events.length = 0;
|
|
252
|
+
expect(runtime.interruptBusySessionsAfterRestart()).toEqual({ sessionIds: [] });
|
|
253
|
+
expect(events).toEqual([]);
|
|
254
|
+
});
|
|
255
|
+
|
|
182
256
|
it('restores activity when busy interrupts cooldown without timer underflow', () => {
|
|
183
257
|
vi.useFakeTimers();
|
|
184
258
|
const runtime = createSessionRuntime({
|
|
@@ -1,3 +1,5 @@
|
|
|
1
|
+
import { isAgentMemoryFeatureAvailable } from '../agent-memory/feature-flag.js';
|
|
2
|
+
|
|
1
3
|
export const createSettingsHelpers = (dependencies) => {
|
|
2
4
|
const {
|
|
3
5
|
normalizePathForPersistence,
|
|
@@ -27,6 +29,9 @@ export const createSettingsHelpers = (dependencies) => {
|
|
|
27
29
|
const PWA_ORIENTATION_VALUES = new Set(['system', 'portrait', 'landscape']);
|
|
28
30
|
const MOBILE_KEYBOARD_MODE_VALUES = new Set(['native', 'resize-content']);
|
|
29
31
|
const TERMINAL_SHELL_VALUES = new Set(['auto', 'bash', 'zsh', 'sh', 'fish', 'pwsh', 'powershell', 'cmd', 'dash', 'ksh', 'nu']);
|
|
32
|
+
const SIDEBAR_PROJECT_DISPLAY_MODE_VALUES = new Set(['all', 'single']);
|
|
33
|
+
const SIDEBAR_SESSION_GROUPING_MODE_VALUES = new Set(['by-worktree', 'flat']);
|
|
34
|
+
const SIDEBAR_PROJECT_SORT_ORDER_VALUES = new Set(['manual', 'a-z', 'z-a', 'date-added', 'recent']);
|
|
30
35
|
const HIDDEN_MODELS_MAX = 1024;
|
|
31
36
|
const RECENT_EFFORTS_MAX_KEYS = 128;
|
|
32
37
|
const RECENT_EFFORTS_MAX_VARIANTS_PER_KEY = 5;
|
|
@@ -241,6 +246,18 @@ export const createSettingsHelpers = (dependencies) => {
|
|
|
241
246
|
if (typeof candidate.activeProjectId === 'string' && candidate.activeProjectId.length > 0) {
|
|
242
247
|
result.activeProjectId = candidate.activeProjectId;
|
|
243
248
|
}
|
|
249
|
+
if (SIDEBAR_PROJECT_DISPLAY_MODE_VALUES.has(candidate.sidebarProjectDisplayMode)) {
|
|
250
|
+
result.sidebarProjectDisplayMode = candidate.sidebarProjectDisplayMode;
|
|
251
|
+
}
|
|
252
|
+
if (SIDEBAR_SESSION_GROUPING_MODE_VALUES.has(candidate.sidebarSessionGroupingMode)) {
|
|
253
|
+
result.sidebarSessionGroupingMode = candidate.sidebarSessionGroupingMode;
|
|
254
|
+
}
|
|
255
|
+
if (SIDEBAR_PROJECT_SORT_ORDER_VALUES.has(candidate.sidebarProjectSortOrder)) {
|
|
256
|
+
result.sidebarProjectSortOrder = candidate.sidebarProjectSortOrder;
|
|
257
|
+
}
|
|
258
|
+
if (typeof candidate.sidebarShowRecentSection === 'boolean') {
|
|
259
|
+
result.sidebarShowRecentSection = candidate.sidebarShowRecentSection;
|
|
260
|
+
}
|
|
244
261
|
|
|
245
262
|
if (Array.isArray(candidate.securityScopedBookmarks)) {
|
|
246
263
|
result.securityScopedBookmarks = normalizeStringArray(candidate.securityScopedBookmarks);
|
|
@@ -375,6 +392,9 @@ export const createSettingsHelpers = (dependencies) => {
|
|
|
375
392
|
const normalizedDays = Math.max(1, Math.min(365, Math.round(candidate.autoDeleteAfterDays)));
|
|
376
393
|
result.autoDeleteAfterDays = normalizedDays;
|
|
377
394
|
}
|
|
395
|
+
if (candidate.sessionRetentionAction === 'archive' || candidate.sessionRetentionAction === 'delete') {
|
|
396
|
+
result.sessionRetentionAction = candidate.sessionRetentionAction;
|
|
397
|
+
}
|
|
378
398
|
if (candidate.tunnelBootstrapTtlMs === null) {
|
|
379
399
|
result.tunnelBootstrapTtlMs = null;
|
|
380
400
|
} else if (typeof candidate.tunnelBootstrapTtlMs === 'number' && Number.isFinite(candidate.tunnelBootstrapTtlMs)) {
|
|
@@ -508,6 +528,9 @@ export const createSettingsHelpers = (dependencies) => {
|
|
|
508
528
|
if (typeof candidate.agentControlToolEnabled === 'boolean') {
|
|
509
529
|
result.agentControlToolEnabled = candidate.agentControlToolEnabled;
|
|
510
530
|
}
|
|
531
|
+
if (typeof candidate.agentMemoryToolEnabled === 'boolean') {
|
|
532
|
+
result.agentMemoryToolEnabled = candidate.agentMemoryToolEnabled;
|
|
533
|
+
}
|
|
511
534
|
if (typeof candidate.optimizeSystemPrompt === 'boolean') {
|
|
512
535
|
result.optimizeSystemPrompt = candidate.optimizeSystemPrompt;
|
|
513
536
|
}
|
|
@@ -905,6 +928,9 @@ export const createSettingsHelpers = (dependencies) => {
|
|
|
905
928
|
return {
|
|
906
929
|
...sanitized,
|
|
907
930
|
hasManagedRemoteTunnelToken,
|
|
931
|
+
// Tells the client whether agent memory exists in this build at all, so
|
|
932
|
+
// its settings row and panel tab can be absent rather than merely off.
|
|
933
|
+
agentMemoryFeatureAvailable: isAgentMemoryFeatureAvailable(),
|
|
908
934
|
...(pwaAppName ? { pwaAppName } : {}),
|
|
909
935
|
pwaOrientation,
|
|
910
936
|
mobileKeyboardMode,
|
|
@@ -66,6 +66,28 @@ describe('settings helpers', () => {
|
|
|
66
66
|
expect(helpers.sanitizeSettingsUpdate({ draftStartersVisible: 'false' })).toEqual({});
|
|
67
67
|
});
|
|
68
68
|
|
|
69
|
+
it('sanitizes shared sidebar display preferences', () => {
|
|
70
|
+
const helpers = createTestHelpers();
|
|
71
|
+
|
|
72
|
+
expect(helpers.sanitizeSettingsUpdate({
|
|
73
|
+
sidebarProjectDisplayMode: 'single',
|
|
74
|
+
sidebarSessionGroupingMode: 'flat',
|
|
75
|
+
sidebarProjectSortOrder: 'z-a',
|
|
76
|
+
sidebarShowRecentSection: false,
|
|
77
|
+
})).toEqual({
|
|
78
|
+
sidebarProjectDisplayMode: 'single',
|
|
79
|
+
sidebarSessionGroupingMode: 'flat',
|
|
80
|
+
sidebarProjectSortOrder: 'z-a',
|
|
81
|
+
sidebarShowRecentSection: false,
|
|
82
|
+
});
|
|
83
|
+
expect(helpers.sanitizeSettingsUpdate({
|
|
84
|
+
sidebarProjectDisplayMode: 'grid',
|
|
85
|
+
sidebarSessionGroupingMode: 'project',
|
|
86
|
+
sidebarProjectSortOrder: 'random',
|
|
87
|
+
sidebarShowRecentSection: 'false',
|
|
88
|
+
})).toEqual({});
|
|
89
|
+
});
|
|
90
|
+
|
|
69
91
|
it('accepts only booleans for wide chat layout', () => {
|
|
70
92
|
const helpers = createTestHelpers();
|
|
71
93
|
|
|
@@ -466,4 +488,39 @@ describe('settings helpers', () => {
|
|
|
466
488
|
expect(sanitized.recentModels).toEqual(payload.recentModels);
|
|
467
489
|
});
|
|
468
490
|
});
|
|
491
|
+
|
|
492
|
+
describe('session retention settings persistence', () => {
|
|
493
|
+
it('round-trips sessionRetentionAction archive and delete through the sanitizer', () => {
|
|
494
|
+
const helpers = createTestHelpersWithRealSanitizers();
|
|
495
|
+
|
|
496
|
+
expect(helpers.sanitizeSettingsUpdate({ sessionRetentionAction: 'archive' })).toEqual({
|
|
497
|
+
sessionRetentionAction: 'archive',
|
|
498
|
+
});
|
|
499
|
+
expect(helpers.sanitizeSettingsUpdate({ sessionRetentionAction: 'delete' })).toEqual({
|
|
500
|
+
sessionRetentionAction: 'delete',
|
|
501
|
+
});
|
|
502
|
+
});
|
|
503
|
+
|
|
504
|
+
it('rejects invalid sessionRetentionAction values', () => {
|
|
505
|
+
const helpers = createTestHelpersWithRealSanitizers();
|
|
506
|
+
|
|
507
|
+
expect(helpers.sanitizeSettingsUpdate({ sessionRetentionAction: 'remove' })).toEqual({});
|
|
508
|
+
expect(helpers.sanitizeSettingsUpdate({ sessionRetentionAction: true })).toEqual({});
|
|
509
|
+
});
|
|
510
|
+
|
|
511
|
+
it('survives a full settings payload containing sessionRetentionAction (regression)', () => {
|
|
512
|
+
const helpers = createTestHelpersWithRealSanitizers();
|
|
513
|
+
const payload = {
|
|
514
|
+
autoDeleteEnabled: true,
|
|
515
|
+
autoDeleteAfterDays: 60,
|
|
516
|
+
sessionRetentionAction: 'delete',
|
|
517
|
+
};
|
|
518
|
+
|
|
519
|
+
const sanitized = helpers.sanitizeSettingsUpdate(payload);
|
|
520
|
+
|
|
521
|
+
expect(sanitized.autoDeleteEnabled).toBe(true);
|
|
522
|
+
expect(sanitized.autoDeleteAfterDays).toBe(60);
|
|
523
|
+
expect(sanitized.sessionRetentionAction).toBe('delete');
|
|
524
|
+
});
|
|
525
|
+
});
|
|
469
526
|
});
|
|
@@ -155,6 +155,7 @@ export const createSettingsNormalizationRuntime = (dependencies) => {
|
|
|
155
155
|
const iconBackground = normalizeIconBackground(candidate.iconBackground);
|
|
156
156
|
const color = typeof candidate.color === 'string' ? candidate.color.trim() : '';
|
|
157
157
|
const defaultModel = typeof candidate.defaultModel === 'string' ? candidate.defaultModel.trim() : '';
|
|
158
|
+
const defaultVariant = typeof candidate.defaultVariant === 'string' ? candidate.defaultVariant.trim() : '';
|
|
158
159
|
const addedAt = Number.isFinite(candidate.addedAt) ? Number(candidate.addedAt) : null;
|
|
159
160
|
const lastOpenedAt = Number.isFinite(candidate.lastOpenedAt)
|
|
160
161
|
? Number(candidate.lastOpenedAt)
|
|
@@ -175,6 +176,8 @@ export const createSettingsNormalizationRuntime = (dependencies) => {
|
|
|
175
176
|
...(iconBackground ? { iconBackground } : {}),
|
|
176
177
|
...(color ? { color } : {}),
|
|
177
178
|
...(defaultModel && defaultModel.includes('/') ? { defaultModel } : {}),
|
|
179
|
+
// A variant is meaningless without the model it belongs to.
|
|
180
|
+
...(defaultModel && defaultModel.includes('/') && defaultVariant ? { defaultVariant } : {}),
|
|
178
181
|
...(Number.isFinite(addedAt) && addedAt >= 0 ? { addedAt } : {}),
|
|
179
182
|
...(Number.isFinite(lastOpenedAt) && lastOpenedAt >= 0 ? { lastOpenedAt } : {}),
|
|
180
183
|
};
|
|
@@ -106,6 +106,22 @@ describe('settings normalization runtime - symlink resolution', () => {
|
|
|
106
106
|
expect(result[0].path).toBe('/resolved/missing/path');
|
|
107
107
|
});
|
|
108
108
|
|
|
109
|
+
it('keeps a default thinking level next to its model and drops it alone', () => {
|
|
110
|
+
const runtime = createTestRuntime({
|
|
111
|
+
realpathSync: (p) => p,
|
|
112
|
+
path: { resolve: (p) => p, sep: '/', dirname: (p) => p.split('/').slice(0, -1).join('/') || '/' },
|
|
113
|
+
});
|
|
114
|
+
|
|
115
|
+
const projects = [
|
|
116
|
+
{ id: 'proj1', path: '/a', defaultModel: 'anthropic/claude-opus-5', defaultVariant: 'high' },
|
|
117
|
+
{ id: 'proj2', path: '/b', defaultVariant: 'high' },
|
|
118
|
+
];
|
|
119
|
+
|
|
120
|
+
const result = runtime.sanitizeProjects(projects);
|
|
121
|
+
expect(result[0].defaultVariant).toBe('high');
|
|
122
|
+
expect(result[1].defaultVariant).toBe(undefined);
|
|
123
|
+
});
|
|
124
|
+
|
|
109
125
|
it('deduplicates projects that resolve to the same realpath', () => {
|
|
110
126
|
const runtime = createTestRuntime({
|
|
111
127
|
realpathSync: (p) => p.startsWith('/symlink') ? '/real/project' : p,
|
|
@@ -212,6 +212,56 @@ export const createSettingsRuntime = (deps) => {
|
|
|
212
212
|
}
|
|
213
213
|
};
|
|
214
214
|
|
|
215
|
+
/**
|
|
216
|
+
* Merge the server-owned `context.json` (notes/todos/plans) across a project
|
|
217
|
+
* id change.
|
|
218
|
+
*
|
|
219
|
+
* `moveDirectoryContents` only renames a file when the destination is free,
|
|
220
|
+
* so without this step an existing `<newId>/context.json` would silently
|
|
221
|
+
* discard everything stored under `<oldId>`. Every list is merged by identity
|
|
222
|
+
* so neither side loses entries.
|
|
223
|
+
*
|
|
224
|
+
* A version 1 context stored notes as a single string. It is left untouched
|
|
225
|
+
* here: `project-context` converts it on read, and converting in two places
|
|
226
|
+
* would mean two definitions of the same migration.
|
|
227
|
+
*/
|
|
228
|
+
const mergeProjectContextFiles = async (oldStorageDir, newStorageDir) => {
|
|
229
|
+
const oldContextPath = path.join(oldStorageDir, 'context.json');
|
|
230
|
+
const newContextPath = path.join(newStorageDir, 'context.json');
|
|
231
|
+
|
|
232
|
+
const [oldContext, newContext] = await Promise.all([
|
|
233
|
+
readJsonFile(oldContextPath).catch(() => null),
|
|
234
|
+
readJsonFile(newContextPath).catch(() => null),
|
|
235
|
+
]);
|
|
236
|
+
|
|
237
|
+
if (!oldContext || !newContext) {
|
|
238
|
+
// Nothing to reconcile: the plain directory move handles a single side.
|
|
239
|
+
return;
|
|
240
|
+
}
|
|
241
|
+
|
|
242
|
+
const mergeNotes = () => {
|
|
243
|
+
// One side may still be a version 1 string; keep whichever is a list, and
|
|
244
|
+
// prefer the destination when both are strings.
|
|
245
|
+
const oldIsList = Array.isArray(oldContext.notes);
|
|
246
|
+
const newIsList = Array.isArray(newContext.notes);
|
|
247
|
+
if (oldIsList && newIsList) {
|
|
248
|
+
return mergeByKey(oldContext.notes, newContext.notes, (item) => item.id);
|
|
249
|
+
}
|
|
250
|
+
if (newIsList) return newContext.notes;
|
|
251
|
+
if (oldIsList) return oldContext.notes;
|
|
252
|
+
return newContext.notes || oldContext.notes || '';
|
|
253
|
+
};
|
|
254
|
+
|
|
255
|
+
await writeJsonFile(newContextPath, {
|
|
256
|
+
...oldContext,
|
|
257
|
+
...newContext,
|
|
258
|
+
notes: mergeNotes(),
|
|
259
|
+
todos: mergeByKey(oldContext.todos, newContext.todos, (item) => item.id),
|
|
260
|
+
plans: mergeByKey(oldContext.plans, newContext.plans, (item) => item.id || item.file),
|
|
261
|
+
});
|
|
262
|
+
await fsPromises.rm(oldContextPath, { force: true });
|
|
263
|
+
};
|
|
264
|
+
|
|
215
265
|
const migrateProjectScopedStorage = async ({ oldId, newId, projectPath }) => {
|
|
216
266
|
if (!oldId || !newId || oldId === newId) {
|
|
217
267
|
return;
|
|
@@ -232,6 +282,7 @@ export const createSettingsRuntime = (deps) => {
|
|
|
232
282
|
await writeJsonFile(newConfigPath, merged);
|
|
233
283
|
}
|
|
234
284
|
|
|
285
|
+
await mergeProjectContextFiles(oldStorageDir, newStorageDir);
|
|
235
286
|
await moveDirectoryContents(oldStorageDir, newStorageDir);
|
|
236
287
|
await fsPromises.rm(oldConfigPath, { force: true });
|
|
237
288
|
};
|
|
@@ -496,25 +547,41 @@ export const createSettingsRuntime = (deps) => {
|
|
|
496
547
|
// briefly opens the target file. Preserve atomic rename everywhere it works,
|
|
497
548
|
// but fall back to a direct replacement so settings persistence does not
|
|
498
549
|
// get permanently wedged on Windows desktop installs.
|
|
499
|
-
|
|
500
|
-
|
|
550
|
+
try {
|
|
551
|
+
await fsPromises.copyFile(tmp, target);
|
|
552
|
+
} finally {
|
|
553
|
+
await fsPromises.rm(tmp, { force: true }).catch(() => {});
|
|
554
|
+
}
|
|
555
|
+
};
|
|
556
|
+
|
|
557
|
+
const cleanupOrphanedSettingsTempFiles = async (directory) => {
|
|
558
|
+
try {
|
|
559
|
+
const entries = await fsPromises.readdir(directory, { withFileTypes: true });
|
|
560
|
+
const cleanupTasks = entries
|
|
561
|
+
.filter((entry) => entry.isFile() && entry.name.startsWith('settings.json.tmp-'))
|
|
562
|
+
.map((entry) => fsPromises.rm(path.join(directory, entry.name), { force: true }).catch(() => {}));
|
|
563
|
+
await Promise.all(cleanupTasks);
|
|
564
|
+
} catch {
|
|
565
|
+
// Best-effort cleanup: errors reading directory must not fail settings operations
|
|
566
|
+
}
|
|
501
567
|
};
|
|
502
568
|
|
|
503
569
|
const writeSettingsToDisk = async (settings) => {
|
|
570
|
+
const settingsDirectory = path.dirname(SETTINGS_FILE_PATH);
|
|
571
|
+
await fsPromises.mkdir(settingsDirectory, { recursive: true, mode: 0o700 });
|
|
572
|
+
if (process.platform !== 'win32') await fsPromises.chmod(settingsDirectory, 0o700);
|
|
573
|
+
// Atomic write: Electron main and ssh-manager read this file via plain
|
|
574
|
+
// readFile + JSON.parse and silently coerce parse errors to {}. A
|
|
575
|
+
// partial read during a non-atomic writeFile would make their next
|
|
576
|
+
// read-modify-write wipe the settings file.
|
|
577
|
+
const tmp = `${SETTINGS_FILE_PATH}.tmp-${process.pid}-${Date.now()}-${Math.random().toString(36).slice(2, 8)}`;
|
|
504
578
|
try {
|
|
505
|
-
const settingsDirectory = path.dirname(SETTINGS_FILE_PATH);
|
|
506
|
-
await fsPromises.mkdir(settingsDirectory, { recursive: true, mode: 0o700 });
|
|
507
|
-
if (process.platform !== 'win32') await fsPromises.chmod(settingsDirectory, 0o700);
|
|
508
|
-
// Atomic write: Electron main and ssh-manager read this file via plain
|
|
509
|
-
// readFile + JSON.parse and silently coerce parse errors to {}. A
|
|
510
|
-
// partial read during a non-atomic writeFile would make their next
|
|
511
|
-
// read-modify-write wipe the settings file.
|
|
512
|
-
const tmp = `${SETTINGS_FILE_PATH}.tmp-${process.pid}-${Date.now()}-${Math.random().toString(36).slice(2, 8)}`;
|
|
513
579
|
await fsPromises.writeFile(tmp, JSON.stringify(settings, null, 2), { encoding: 'utf8', mode: 0o600 });
|
|
514
580
|
if (process.platform !== 'win32') await fsPromises.chmod(tmp, 0o600);
|
|
515
581
|
await replaceFile(tmp, SETTINGS_FILE_PATH);
|
|
516
582
|
if (process.platform !== 'win32') await fsPromises.chmod(SETTINGS_FILE_PATH, 0o600);
|
|
517
583
|
} catch (error) {
|
|
584
|
+
await fsPromises.rm(tmp, { force: true }).catch(() => {});
|
|
518
585
|
console.warn('Failed to write settings file:', error);
|
|
519
586
|
throw error;
|
|
520
587
|
}
|
|
@@ -803,7 +870,13 @@ export const createSettingsRuntime = (deps) => {
|
|
|
803
870
|
return { settings: next, changed: true };
|
|
804
871
|
};
|
|
805
872
|
|
|
873
|
+
let hasCleanedOrphanedTempFiles = false;
|
|
874
|
+
|
|
806
875
|
const readSettingsFromDiskMigrated = async () => {
|
|
876
|
+
if (!hasCleanedOrphanedTempFiles) {
|
|
877
|
+
hasCleanedOrphanedTempFiles = true;
|
|
878
|
+
await cleanupOrphanedSettingsTempFiles(path.dirname(SETTINGS_FILE_PATH));
|
|
879
|
+
}
|
|
807
880
|
const current = await readSettingsFromDisk();
|
|
808
881
|
const migration1 = await migrateSettingsFromLegacyLastDirectory(current);
|
|
809
882
|
const migration2 = await migrateSettingsFromLegacyThemePreferences(migration1.settings);
|
|
@@ -39,6 +39,24 @@ const createRuntime = async () => {
|
|
|
39
39
|
};
|
|
40
40
|
|
|
41
41
|
describe('settings runtime', () => {
|
|
42
|
+
it('round-trips shared sidebar preferences through settings.json', async () => {
|
|
43
|
+
const { runtime, settingsFilePath, cleanup } = await createRuntime();
|
|
44
|
+
const preferences = {
|
|
45
|
+
sidebarProjectDisplayMode: 'single',
|
|
46
|
+
sidebarSessionGroupingMode: 'flat',
|
|
47
|
+
sidebarProjectSortOrder: 'date-added',
|
|
48
|
+
sidebarShowRecentSection: false,
|
|
49
|
+
};
|
|
50
|
+
try {
|
|
51
|
+
await runtime.persistSettings(preferences);
|
|
52
|
+
|
|
53
|
+
await expect(runtime.readSettingsFromDisk()).resolves.toEqual(preferences);
|
|
54
|
+
await expect(fsPromises.readFile(settingsFilePath, 'utf8')).resolves.toBe(JSON.stringify(preferences, null, 2));
|
|
55
|
+
} finally {
|
|
56
|
+
await cleanup();
|
|
57
|
+
}
|
|
58
|
+
});
|
|
59
|
+
|
|
42
60
|
it.skipIf(process.platform === 'win32')('writes settings with restrictive directory and file permissions', async () => {
|
|
43
61
|
const { runtime, settingsFilePath, tempRoot, cleanup } = await createRuntime();
|
|
44
62
|
try {
|
|
@@ -133,4 +151,71 @@ describe('settings runtime', () => {
|
|
|
133
151
|
await fsPromises.rm(tempRoot, { recursive: true, force: true });
|
|
134
152
|
}
|
|
135
153
|
});
|
|
154
|
+
|
|
155
|
+
it('cleans up orphaned settings.json.tmp files during startup migration', async () => {
|
|
156
|
+
const { runtime, settingsFilePath, tempRoot, cleanup } = await createRuntime();
|
|
157
|
+
try {
|
|
158
|
+
const settingsDir = path.dirname(settingsFilePath);
|
|
159
|
+
const orphan1 = path.join(settingsDir, 'settings.json.tmp-1234-11111-abc');
|
|
160
|
+
const orphan2 = path.join(settingsDir, 'settings.json.tmp-5678-22222-def');
|
|
161
|
+
const unrelated = path.join(settingsDir, 'other-file.json');
|
|
162
|
+
|
|
163
|
+
await fsPromises.writeFile(orphan1, '{"broken": true}', 'utf8');
|
|
164
|
+
await fsPromises.writeFile(orphan2, '{"broken": true}', 'utf8');
|
|
165
|
+
await fsPromises.writeFile(unrelated, '{"keep": true}', 'utf8');
|
|
166
|
+
await fsPromises.writeFile(settingsFilePath, '{"theme": "light"}', 'utf8');
|
|
167
|
+
|
|
168
|
+
await runtime.readSettingsFromDiskMigrated();
|
|
169
|
+
|
|
170
|
+
const files = await fsPromises.readdir(settingsDir);
|
|
171
|
+
expect(files).toContain('settings.json');
|
|
172
|
+
expect(files).toContain('other-file.json');
|
|
173
|
+
expect(files).not.toContain('settings.json.tmp-1234-11111-abc');
|
|
174
|
+
expect(files).not.toContain('settings.json.tmp-5678-22222-def');
|
|
175
|
+
} finally {
|
|
176
|
+
await cleanup();
|
|
177
|
+
}
|
|
178
|
+
});
|
|
179
|
+
|
|
180
|
+
it('removes temp file when writeSettingsToDisk encounters a write error', async () => {
|
|
181
|
+
const tempRoot = await fsPromises.mkdtemp(path.join(os.tmpdir(), 'oc-settings-runtime-'));
|
|
182
|
+
const settingsFilePath = path.join(tempRoot, 'settings.json');
|
|
183
|
+
let capturedTmp = null;
|
|
184
|
+
const wrappedFs = {
|
|
185
|
+
...fsPromises,
|
|
186
|
+
rename: async (src, dst) => {
|
|
187
|
+
capturedTmp = src;
|
|
188
|
+
const error = new Error('unexpected disk failure');
|
|
189
|
+
error.code = 'EIO';
|
|
190
|
+
throw error;
|
|
191
|
+
},
|
|
192
|
+
};
|
|
193
|
+
const runtime = createSettingsRuntime({
|
|
194
|
+
fsPromises: wrappedFs,
|
|
195
|
+
path,
|
|
196
|
+
crypto,
|
|
197
|
+
SETTINGS_FILE_PATH: settingsFilePath,
|
|
198
|
+
sanitizeProjects: (projects) => Array.isArray(projects) ? projects : [],
|
|
199
|
+
sanitizeSettingsUpdate: (settings) => settings,
|
|
200
|
+
mergePersistedSettings: (_current, changes) => changes,
|
|
201
|
+
normalizeSettingsPaths: (settings) => ({ settings, changed: false }),
|
|
202
|
+
normalizeStringArray: (values) => Array.isArray(values) ? values.filter((value) => typeof value === 'string') : [],
|
|
203
|
+
formatSettingsResponse: (settings) => settings,
|
|
204
|
+
resolveDirectoryCandidate: (value) => value,
|
|
205
|
+
normalizeManagedRemoteTunnelHostname: (value) => value,
|
|
206
|
+
normalizeManagedRemoteTunnelPresets: (value) => value,
|
|
207
|
+
normalizeManagedRemoteTunnelPresetTokens: (value) => value,
|
|
208
|
+
syncManagedRemoteTunnelConfigWithPresets: async () => {},
|
|
209
|
+
upsertManagedRemoteTunnelToken: async () => {},
|
|
210
|
+
});
|
|
211
|
+
|
|
212
|
+
try {
|
|
213
|
+
await expect(runtime.writeSettingsToDisk({ theme: 'dark' })).rejects.toThrow('unexpected disk failure');
|
|
214
|
+
expect(capturedTmp).toBeTruthy();
|
|
215
|
+
const files = await fsPromises.readdir(tempRoot);
|
|
216
|
+
expect(files.some((f) => f.startsWith('settings.json.tmp-'))).toBe(false);
|
|
217
|
+
} finally {
|
|
218
|
+
await fsPromises.rm(tempRoot, { recursive: true, force: true });
|
|
219
|
+
}
|
|
220
|
+
});
|
|
136
221
|
});
|