@openchamber/web 1.18.2 → 1.18.4
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/bin/lib/commands-models.js +1 -1
- package/dist/assets/{CodeMirrorCommentWidgets-CxcJ5x9h.js → CodeMirrorCommentWidgets-4qZbrEXU.js} +1 -1
- package/dist/assets/{CommitSection-C9sBBYAJ.js → CommitSection-MJmntVPJ.js} +1 -1
- package/dist/assets/{DiagramEditor-C7nUw7p3.js → DiagramEditor-jnG3Hbxg.js} +1 -1
- package/dist/assets/{DiagramView-cYxZP-HS.js → DiagramView-CFXxgg_a.js} +1 -1
- package/dist/assets/{DiffView-1zd0slLu.js → DiffView-DZIoOnV7.js} +2 -2
- package/dist/assets/FilesView-BKL6YlKG.js +14 -0
- package/dist/assets/{GitView-OSVIn5V1.js → GitView-DBFrDDBv.js} +1 -1
- package/dist/assets/{JsonTreeView-Kgepz4pR.js → JsonTreeView-DLW2Wy1g.js} +1 -1
- package/dist/assets/MarkdownImageGallery-DKIylIK7.js +1 -0
- package/dist/assets/MarkdownRendererImpl-CLv8hxvv.js +12 -0
- package/dist/assets/OnboardingScreen-D2Y6djMw.js +1 -0
- package/dist/assets/{PatchDiff-Cddz02Ya.js → PatchDiff-BuLPx7AN.js} +1 -1
- package/dist/assets/{PierreDiffViewer-B5k0KvPW.js → PierreDiffViewer-BHm4Yr0X.js} +2 -2
- package/dist/assets/{PlanView-BYgHBHDt.js → PlanView-ZYEJn8A_.js} +3 -3
- package/dist/assets/{SessionSwitcherDropdown-ig2OT22Z.js → SessionSwitcherDropdown-rro-SsaO.js} +1 -1
- package/dist/assets/SettingsView-5RmswFZe.js +28 -0
- package/dist/assets/{SettingsWindow-CNHM8ifT.js → SettingsWindow-BZhAYFdS.js} +1 -1
- package/dist/assets/{ToolOutputDialog-DrGeYq2p.js → ToolOutputDialog-Za6V4VMJ.js} +7 -7
- package/dist/assets/{ToolPartDiffPreview-BRmPpe94.js → ToolPartDiffPreview-BL-9ixyC.js} +1 -1
- package/dist/assets/{VirtualizedFileDiff-Dcu8Q-5P.js → VirtualizedFileDiff-CwGocYQd.js} +1 -1
- package/dist/assets/{WalkthroughView-HStEYdD2.js → WalkthroughView-5DyvN03T.js} +2 -2
- package/dist/assets/{computeVirtualFileMetrics-DQE7R9IY.js → computeVirtualFileMetrics-Da00Jg7M.js} +2 -2
- package/dist/assets/contextPanelEmbeddedChat-B-bSg3P5.js +1 -0
- package/dist/assets/de-u7gSnqWs.js +9 -0
- package/dist/assets/es-T9O7aAOr.js +15 -0
- package/dist/assets/fr-Oor7ewbE.js +13 -0
- package/dist/assets/index-BzIpNlNE.css +1 -0
- package/dist/assets/{index-BgQEgA2a.js → index-C0yNhuZw.js} +1 -1
- package/dist/assets/index-DRpChWux.js +7 -0
- package/dist/assets/{isDiffPlainText-XyBCe4eD.js → isDiffPlainText-D9YpoLrV.js} +1 -1
- package/dist/assets/{isFilePlainText-JbqDfa3n.js → isFilePlainText-gTibdNIe.js} +1 -1
- package/dist/assets/ja-DHpqbVmr.js +15 -0
- package/dist/assets/ko-CwLkS3nx.js +15 -0
- package/dist/assets/{main-LfcbGv7C.js → main-D7UcL3VQ.js} +2 -2
- package/dist/assets/main-DPMd2iKS.js +915 -0
- package/dist/assets/markdownCore-DDrHVneM.js +2 -0
- package/dist/assets/{miniChat-CUp_elRz.js → miniChat-O_GVoEbc.js} +2 -2
- package/dist/assets/{mobile-CBSN7BsH.js → mobile-Br4TtAqc.js} +2 -2
- package/dist/assets/{patchFileDiff-DCIXUHRJ.js → patchFileDiff-KNkxM1C1.js} +2 -2
- package/dist/assets/{pl-tHTP6XQx.js → pl-CcZILN8q.js} +4 -4
- package/dist/assets/pt-BR-DYHhVK6o.js +15 -0
- package/dist/assets/{renderElectronMiniChatApp-eZl-5STF.js → renderElectronMiniChatApp-CJpdxTT1.js} +2 -2
- package/dist/assets/renderMobileApp-toj9cXoh.js +25 -0
- package/dist/assets/runtimeEndpointReset-BVmispdD.js +13 -0
- package/dist/assets/scheduledTasksApi-ByKya3Un.js +1 -0
- package/dist/assets/{shikiHighlight-eU8abJ3T.js → shikiHighlight-C7LTbwFx.js} +1 -1
- package/dist/assets/uk-BA2kZR38.js +15 -0
- package/dist/assets/{useAppFontEffects-Bbpz77To.js → useAppFontEffects-BikB6enL.js} +138 -138
- package/dist/assets/useInlineCommentController-CYPvYJDt.js +2 -0
- package/dist/assets/{vendor-codemirror-language-data-Dzt9rWZZ.js → vendor-codemirror-language-data-CLHw8NWn.js} +2 -2
- package/dist/assets/{vendor-marked-i_gIkIP3.js → vendor-marked-CX41MkDF.js} +1 -1
- package/dist/assets/{web-components-DGvnI0zx.js → web-components-GMc3oR3i.js} +1 -1
- package/dist/assets/zh-CN-dlOQK6v9.js +15 -0
- package/dist/assets/zh-TW-BnqQ-WL5.js +15 -0
- package/dist/index.html +4 -4
- package/dist/mini-chat.html +3 -3
- package/dist/mobile.html +3 -3
- package/package.json +2 -2
- package/server/index.js +65 -19
- package/server/lib/agent-tool/DOCUMENTATION.md +21 -6
- package/server/lib/agent-tool/runtime.js +90 -16
- package/server/lib/agent-tool/runtime.test.js +86 -0
- package/server/lib/browser-control/DOCUMENTATION.md +50 -0
- package/server/lib/browser-control/broker.js +154 -0
- package/server/lib/browser-control/broker.test.js +191 -0
- package/server/lib/browser-control/routes.js +48 -0
- package/server/lib/browser-control/routes.test.js +108 -0
- package/server/lib/dev-servers/parse.js +203 -0
- package/server/lib/dev-servers/parse.test.js +174 -0
- package/server/lib/dev-servers/routes.js +135 -0
- package/server/lib/dev-tunnel/DOCUMENTATION.md +57 -0
- package/server/lib/dev-tunnel/client.js +193 -0
- package/server/lib/dev-tunnel/runtime.js +189 -0
- package/server/lib/dev-tunnel/tunnel.test.js +291 -0
- package/server/lib/git/credentials.js +0 -33
- package/server/lib/github/DOCUMENTATION.md +1 -1
- package/server/lib/markdown-image-grants/DOCUMENTATION.md +36 -0
- package/server/lib/markdown-image-grants/routes.js +340 -0
- package/server/lib/markdown-image-grants/routes.test.js +221 -0
- package/server/lib/openchamber-control/DOCUMENTATION.md +9 -0
- package/server/lib/openchamber-control/actions.js +33 -1
- package/server/lib/openchamber-control/screenshots.js +83 -0
- package/server/lib/openchamber-control/screenshots.test.js +84 -0
- package/server/lib/openchamber-control/service.js +141 -2
- package/server/lib/openchamber-control/service.test.js +55 -0
- package/server/lib/opencode/core-routes.js +31 -52
- package/server/lib/opencode/core-routes.test.js +37 -9
- package/server/lib/opencode/feature-routes-runtime.js +15 -0
- package/server/lib/opencode/server-startup-runtime.js +22 -1
- package/server/lib/opencode/server-startup-runtime.test.js +44 -0
- package/server/lib/opencode/settings-helpers.js +3 -9
- package/server/lib/projects/project-config.js +181 -2
- package/server/lib/projects/project-config.test.js +295 -0
- package/server/lib/quota/DOCUMENTATION.md +4 -2
- package/server/lib/quota/credentials/providers.js +0 -7
- package/server/lib/quota/credentials/store.js +11 -1
- package/server/lib/quota/credentials/store.test.js +9 -1
- package/server/lib/quota/providers/opencode-go.js +35 -35
- package/server/lib/quota/providers/opencode-go.test.js +52 -7
- package/server/lib/quota/routes.js +0 -2
- package/server/lib/relay/DOCUMENTATION.md +2 -0
- package/server/lib/relay/tunnel-host.js +157 -33
- package/server/lib/relay/tunnel-host.test.js +147 -0
- package/server/lib/scheduled-tasks/DOCUMENTATION.md +49 -0
- package/server/lib/scheduled-tasks/issue-2710-double-execution.test.js +488 -0
- package/server/lib/scheduled-tasks/routes.js +6 -0
- package/server/lib/scheduled-tasks/runtime.js +369 -108
- package/server/lib/scheduled-tasks/service.js +7 -1
- package/server/lib/scheduled-tasks/service.test.js +20 -0
- package/server/lib/walkthrough/index.js +0 -2
- package/server/sse-routes.test.js +3 -0
- package/dist/assets/FilesView-WkxsWHBE.js +0 -14
- package/dist/assets/MarkdownRendererImpl-CKAsRfIk.js +0 -12
- package/dist/assets/OnboardingScreen-BCgYA7J5.js +0 -1
- package/dist/assets/SettingsView-e7Fmxnz8.js +0 -28
- package/dist/assets/contextPanelEmbeddedChat-5VGWIT_J.js +0 -1
- package/dist/assets/de-B6t6T54h.js +0 -9
- package/dist/assets/es-DH9NUKge.js +0 -15
- package/dist/assets/fr-Do4t2KmA.js +0 -13
- package/dist/assets/index-B45s9aAX.css +0 -1
- package/dist/assets/index-CNrN5qDs.js +0 -7
- package/dist/assets/ja-DJT9EM80.js +0 -15
- package/dist/assets/ko-CfWRq2p4.js +0 -15
- package/dist/assets/main-B4oBRI9u.js +0 -193
- package/dist/assets/markdownCore-A3_L34oS.js +0 -2
- package/dist/assets/pt-BR-BDEzzltP.js +0 -15
- package/dist/assets/renderMobileApp-DA7wpIBi.js +0 -23
- package/dist/assets/runtimeEndpointReset-D5izT-u5.js +0 -13
- package/dist/assets/scheduledTasksApi-CTJdfSWc.js +0 -1
- package/dist/assets/uk-B6Q32nyk.js +0 -15
- package/dist/assets/useInlineCommentController-D7zs7-BQ.js +0 -2
- package/dist/assets/vendor-zumer-snapdom-Btyu_Xi2.js +0 -8
- package/dist/assets/zh-CN-7MGcwGaC.js +0 -15
- package/dist/assets/zh-TW-CFPfqxlL.js +0 -15
- package/server/lib/preview/proxy-runtime.js +0 -1604
- package/server/lib/preview/proxy-runtime.test.js +0 -528
- package/server/lib/quota/opencode-go-credentials.js +0 -11
- package/server/lib/quota/opencode-go-credentials.test.js +0 -32
- package/server/lib/quota/routes.test.js +0 -40
|
@@ -0,0 +1,488 @@
|
|
|
1
|
+
import { describe, expect, it, vi, beforeEach, afterEach } from 'vitest';
|
|
2
|
+
|
|
3
|
+
/**
|
|
4
|
+
* Regression for https://github.com/openchamber/openchamber/issues/2710
|
|
5
|
+
* "Scheduled daily task executes twice at the configured time"
|
|
6
|
+
*
|
|
7
|
+
* Root cause: each OpenChamber server process keeps its own timers. Two
|
|
8
|
+
* instances that share the same on-disk project config (CLI serve on port 3000
|
|
9
|
+
* + Electron on 57123, or a startup login service + desktop) each arm a timer
|
|
10
|
+
* for the same occurrence and both dispatch.
|
|
11
|
+
*
|
|
12
|
+
* Fix: scheduled runs claim the occurrence in shared project config
|
|
13
|
+
* (`lastScheduledFor` + advanced `nextRunAt`) under a cross-process write lock
|
|
14
|
+
* before creating a session, so the second instance skips.
|
|
15
|
+
*/
|
|
16
|
+
|
|
17
|
+
const sdk = vi.hoisted(() => ({
|
|
18
|
+
sessionCreates: [],
|
|
19
|
+
createOpencodeClient: () => ({
|
|
20
|
+
session: {
|
|
21
|
+
create: async () => {
|
|
22
|
+
sdk.sessionCreates.push(Date.now());
|
|
23
|
+
return { data: { id: `sess-${sdk.sessionCreates.length}` } };
|
|
24
|
+
},
|
|
25
|
+
},
|
|
26
|
+
command: { list: async () => ({ data: [] }) },
|
|
27
|
+
}),
|
|
28
|
+
}));
|
|
29
|
+
|
|
30
|
+
vi.mock('@opencode-ai/sdk/v2', () => ({
|
|
31
|
+
createOpencodeClient: sdk.createOpencodeClient,
|
|
32
|
+
}));
|
|
33
|
+
|
|
34
|
+
import { createScheduledTasksRuntime } from './runtime.js';
|
|
35
|
+
|
|
36
|
+
const UTC = (y, mo, d, h, mi, s = 0) => Date.UTC(y, mo, d, h, mi, s);
|
|
37
|
+
const MINUTE = 60_000;
|
|
38
|
+
const HOUR = 3_600_000;
|
|
39
|
+
|
|
40
|
+
const makeTask = (schedule) => ({
|
|
41
|
+
id: 'task-1',
|
|
42
|
+
name: 'Daily Sync',
|
|
43
|
+
enabled: true,
|
|
44
|
+
schedule: { timezone: 'UTC', ...schedule },
|
|
45
|
+
execution: { prompt: 'Summarize open issues', providerID: 'openai', modelID: 'gpt-4o' },
|
|
46
|
+
state: { createdAt: UTC(2026, 0, 1, 0, 0, 0), updatedAt: UTC(2026, 0, 1, 0, 0, 0) },
|
|
47
|
+
});
|
|
48
|
+
|
|
49
|
+
/**
|
|
50
|
+
* Shared on-disk store stand-in. Both runtimes must see the same task state so
|
|
51
|
+
* occurrence claiming can serialize dispatches the way real project config does.
|
|
52
|
+
*/
|
|
53
|
+
const createSharedProjectConfigRuntime = (initialTask) => {
|
|
54
|
+
let currentTask = structuredClone(initialTask);
|
|
55
|
+
|
|
56
|
+
const applyPatch = (patch) => {
|
|
57
|
+
const nextState = {
|
|
58
|
+
...(currentTask.state || {}),
|
|
59
|
+
...patch,
|
|
60
|
+
updatedAt: Date.now(),
|
|
61
|
+
};
|
|
62
|
+
// Mirror normalizeState: explicit undefined clears optional numeric fields.
|
|
63
|
+
for (const key of ['nextRunAt', 'lastRunAt', 'lastDurationMs', 'lastScheduledFor', 'lastError', 'lastSessionId']) {
|
|
64
|
+
if (Object.prototype.hasOwnProperty.call(patch, key) && patch[key] === undefined) {
|
|
65
|
+
delete nextState[key];
|
|
66
|
+
}
|
|
67
|
+
}
|
|
68
|
+
currentTask = {
|
|
69
|
+
...currentTask,
|
|
70
|
+
state: nextState,
|
|
71
|
+
};
|
|
72
|
+
return currentTask;
|
|
73
|
+
};
|
|
74
|
+
|
|
75
|
+
return {
|
|
76
|
+
listScheduledTasks: vi.fn(async () => [structuredClone(currentTask)]),
|
|
77
|
+
reconcileLoopTasks: vi.fn(async () => [structuredClone(currentTask)]),
|
|
78
|
+
updateScheduledTaskState: vi.fn(async (_pid, _tid, patch) => {
|
|
79
|
+
const task = applyPatch(patch);
|
|
80
|
+
return { task: structuredClone(task), updated: true };
|
|
81
|
+
}),
|
|
82
|
+
updateScheduledTaskStateIf: vi.fn(async (_pid, _tid, predicate, patch) => {
|
|
83
|
+
if (!predicate(currentTask)) {
|
|
84
|
+
return { task: structuredClone(currentTask), updated: false };
|
|
85
|
+
}
|
|
86
|
+
const task = applyPatch(patch);
|
|
87
|
+
return { task: structuredClone(task), updated: true };
|
|
88
|
+
}),
|
|
89
|
+
upsertScheduledTask: vi.fn(async (_pid, input) => {
|
|
90
|
+
currentTask = structuredClone(input);
|
|
91
|
+
return { task: structuredClone(currentTask) };
|
|
92
|
+
}),
|
|
93
|
+
};
|
|
94
|
+
};
|
|
95
|
+
|
|
96
|
+
const createRuntimeDeps = (projectConfigRuntime) => ({
|
|
97
|
+
projectConfigRuntime,
|
|
98
|
+
listProjects: vi.fn(async () => [{ id: 'p1', path: '/repo' }]),
|
|
99
|
+
buildOpenCodeUrl: () => 'http://127.0.0.1:9999/',
|
|
100
|
+
getOpenCodeAuthHeaders: () => ({}),
|
|
101
|
+
waitForOpenCodeReady: async () => {},
|
|
102
|
+
emitTaskRunEvent: vi.fn(),
|
|
103
|
+
setSessionAutoAccept: async () => {},
|
|
104
|
+
logger: { info: () => {}, warn: () => {}, error: () => {} },
|
|
105
|
+
});
|
|
106
|
+
|
|
107
|
+
const startInstances = async (count, task) => {
|
|
108
|
+
const projectConfigRuntime = createSharedProjectConfigRuntime(task);
|
|
109
|
+
const runtimes = [];
|
|
110
|
+
for (let i = 0; i < count; i += 1) {
|
|
111
|
+
const runtime = createScheduledTasksRuntime(createRuntimeDeps(projectConfigRuntime));
|
|
112
|
+
await runtime.start();
|
|
113
|
+
runtimes.push(runtime);
|
|
114
|
+
}
|
|
115
|
+
return { runtimes, projectConfigRuntime };
|
|
116
|
+
};
|
|
117
|
+
|
|
118
|
+
describe('issue 2710: daily scheduled task double execution at the configured time', () => {
|
|
119
|
+
beforeEach(() => {
|
|
120
|
+
vi.useFakeTimers();
|
|
121
|
+
sdk.sessionCreates.length = 0;
|
|
122
|
+
globalThis.fetch = vi.fn(async () => ({ ok: true, text: async () => '' }));
|
|
123
|
+
});
|
|
124
|
+
|
|
125
|
+
afterEach(() => {
|
|
126
|
+
vi.useRealTimers();
|
|
127
|
+
vi.restoreAllMocks();
|
|
128
|
+
});
|
|
129
|
+
|
|
130
|
+
it('ONE instance fires a daily 15:00 task exactly once at 15:00', async () => {
|
|
131
|
+
vi.setSystemTime(UTC(2026, 0, 1, 14, 0, 0));
|
|
132
|
+
const { runtimes } = await startInstances(1, makeTask({ kind: 'daily', times: ['15:00'] }));
|
|
133
|
+
await vi.advanceTimersByTimeAsync(HOUR + 3_000);
|
|
134
|
+
|
|
135
|
+
expect(sdk.sessionCreates.length).toBe(1);
|
|
136
|
+
const firedAt = new Date(sdk.sessionCreates[0]);
|
|
137
|
+
expect(firedAt.getUTCHours()).toBe(15);
|
|
138
|
+
|
|
139
|
+
runtimes.forEach((runtime) => runtime.stop());
|
|
140
|
+
});
|
|
141
|
+
|
|
142
|
+
it('ONE instance firing daily 15:00 across 4 days never double-fires', async () => {
|
|
143
|
+
vi.setSystemTime(UTC(2026, 0, 1, 14, 0, 0));
|
|
144
|
+
const { runtimes } = await startInstances(1, makeTask({ kind: 'daily', times: ['15:00'] }));
|
|
145
|
+
await vi.advanceTimersByTimeAsync((4 * 24 * HOUR) + 3_000);
|
|
146
|
+
|
|
147
|
+
expect(sdk.sessionCreates.length).toBe(4);
|
|
148
|
+
const byHourBucket = new Map();
|
|
149
|
+
for (const timestamp of sdk.sessionCreates) {
|
|
150
|
+
const date = new Date(timestamp);
|
|
151
|
+
expect(date.getUTCHours()).toBe(15);
|
|
152
|
+
expect(date.getUTCMinutes()).toBe(0);
|
|
153
|
+
const bucket = Math.floor(timestamp / HOUR);
|
|
154
|
+
byHourBucket.set(bucket, (byHourBucket.get(bucket) || 0) + 1);
|
|
155
|
+
}
|
|
156
|
+
for (const count of byHourBucket.values()) {
|
|
157
|
+
expect(count).toBe(1);
|
|
158
|
+
}
|
|
159
|
+
|
|
160
|
+
runtimes.forEach((runtime) => runtime.stop());
|
|
161
|
+
});
|
|
162
|
+
|
|
163
|
+
it('TWO instances fire a daily 15:00 task exactly ONCE (occurrence claim)', async () => {
|
|
164
|
+
vi.setSystemTime(UTC(2026, 0, 1, 14, 0, 0));
|
|
165
|
+
const { runtimes, projectConfigRuntime } = await startInstances(
|
|
166
|
+
2,
|
|
167
|
+
makeTask({ kind: 'daily', times: ['15:00'] }),
|
|
168
|
+
);
|
|
169
|
+
await vi.advanceTimersByTimeAsync(HOUR + 3_000);
|
|
170
|
+
|
|
171
|
+
expect(sdk.sessionCreates.length).toBe(1);
|
|
172
|
+
const firedAt = new Date(sdk.sessionCreates[0]);
|
|
173
|
+
expect(firedAt.getUTCHours()).toBe(15);
|
|
174
|
+
expect(firedAt.getUTCMinutes()).toBe(0);
|
|
175
|
+
expect(projectConfigRuntime.updateScheduledTaskStateIf).toHaveBeenCalled();
|
|
176
|
+
|
|
177
|
+
runtimes.forEach((runtime) => runtime.stop());
|
|
178
|
+
});
|
|
179
|
+
|
|
180
|
+
it('TWO instances fire a weekly task exactly once', async () => {
|
|
181
|
+
// 2026-01-04 is a Sunday. Weekly Mon/Wed/Fri 09:00.
|
|
182
|
+
vi.setSystemTime(UTC(2026, 0, 4, 8, 0, 0));
|
|
183
|
+
const { runtimes } = await startInstances(2, makeTask({
|
|
184
|
+
kind: 'weekly',
|
|
185
|
+
times: ['09:00'],
|
|
186
|
+
weekdays: [1, 3, 5],
|
|
187
|
+
}));
|
|
188
|
+
await vi.advanceTimersByTimeAsync((25 * HOUR) + 3_000);
|
|
189
|
+
|
|
190
|
+
expect(sdk.sessionCreates.length).toBe(1);
|
|
191
|
+
|
|
192
|
+
runtimes.forEach((runtime) => runtime.stop());
|
|
193
|
+
});
|
|
194
|
+
|
|
195
|
+
it('TWO instances fire a cron task exactly once', async () => {
|
|
196
|
+
vi.setSystemTime(UTC(2026, 0, 1, 14, 3, 0));
|
|
197
|
+
const { runtimes } = await startInstances(2, makeTask({ kind: 'cron', cron: '*/5 * * * *' }));
|
|
198
|
+
await vi.advanceTimersByTimeAsync(3 * MINUTE);
|
|
199
|
+
|
|
200
|
+
expect(sdk.sessionCreates.length).toBe(1);
|
|
201
|
+
|
|
202
|
+
runtimes.forEach((runtime) => runtime.stop());
|
|
203
|
+
});
|
|
204
|
+
|
|
205
|
+
it('TWO instances fire a once task exactly once', async () => {
|
|
206
|
+
vi.setSystemTime(UTC(2026, 0, 1, 8, 0, 0));
|
|
207
|
+
const { runtimes } = await startInstances(2, makeTask({
|
|
208
|
+
kind: 'once',
|
|
209
|
+
date: '2026-01-01',
|
|
210
|
+
time: '09:00',
|
|
211
|
+
}));
|
|
212
|
+
await vi.advanceTimersByTimeAsync(HOUR + 3_000);
|
|
213
|
+
|
|
214
|
+
expect(sdk.sessionCreates.length).toBe(1);
|
|
215
|
+
|
|
216
|
+
runtimes.forEach((runtime) => runtime.stop());
|
|
217
|
+
});
|
|
218
|
+
|
|
219
|
+
it('claim failure releases the running slot and does not reject unhandled', async () => {
|
|
220
|
+
vi.setSystemTime(UTC(2026, 0, 1, 14, 0, 0));
|
|
221
|
+
const projectConfigRuntime = createSharedProjectConfigRuntime(
|
|
222
|
+
makeTask({ kind: 'daily', times: ['15:00'] }),
|
|
223
|
+
);
|
|
224
|
+
projectConfigRuntime.updateScheduledTaskStateIf = vi.fn(async () => {
|
|
225
|
+
throw new Error('timeout acquiring project config lock for p1');
|
|
226
|
+
});
|
|
227
|
+
const runtime = createScheduledTasksRuntime(createRuntimeDeps(projectConfigRuntime));
|
|
228
|
+
await runtime.start();
|
|
229
|
+
|
|
230
|
+
await vi.advanceTimersByTimeAsync(HOUR + 3_000);
|
|
231
|
+
|
|
232
|
+
expect(sdk.sessionCreates.length).toBe(0);
|
|
233
|
+
expect(runtime.getStatus().runningScheduledTasksCount).toBe(0);
|
|
234
|
+
expect(runtime.getStatus().hasRunningScheduledTasks).toBe(false);
|
|
235
|
+
|
|
236
|
+
// Manual runNow must not be stuck behind a permanently "running" claim failure.
|
|
237
|
+
const manual = await runtime.runNow('p1', 'task-1');
|
|
238
|
+
expect(manual.ok).toBe(true);
|
|
239
|
+
expect(sdk.sessionCreates.length).toBe(1);
|
|
240
|
+
|
|
241
|
+
runtime.stop();
|
|
242
|
+
});
|
|
243
|
+
|
|
244
|
+
it('completion state write failure releases the running slot', async () => {
|
|
245
|
+
vi.setSystemTime(UTC(2026, 0, 1, 14, 0, 0));
|
|
246
|
+
const projectConfigRuntime = createSharedProjectConfigRuntime(
|
|
247
|
+
makeTask({ kind: 'daily', times: ['15:00'] }),
|
|
248
|
+
);
|
|
249
|
+
const originalUpdate = projectConfigRuntime.updateScheduledTaskState;
|
|
250
|
+
let completionWrites = 0;
|
|
251
|
+
projectConfigRuntime.updateScheduledTaskState = vi.fn(async (pid, tid, patch) => {
|
|
252
|
+
// syncTaskSchedule + claim path may write; fail the post-run completion write.
|
|
253
|
+
if (patch?.lastStatus === 'success' || patch?.lastStatus === 'error') {
|
|
254
|
+
completionWrites += 1;
|
|
255
|
+
throw new Error('timeout acquiring project config lock for p1');
|
|
256
|
+
}
|
|
257
|
+
return originalUpdate(pid, tid, patch);
|
|
258
|
+
});
|
|
259
|
+
|
|
260
|
+
const runtime = createScheduledTasksRuntime(createRuntimeDeps(projectConfigRuntime));
|
|
261
|
+
await runtime.start();
|
|
262
|
+
await vi.advanceTimersByTimeAsync(HOUR + 3_000);
|
|
263
|
+
|
|
264
|
+
// Initial completion write + best-effort retry.
|
|
265
|
+
expect(completionWrites).toBeGreaterThanOrEqual(2);
|
|
266
|
+
expect(sdk.sessionCreates.length).toBe(1);
|
|
267
|
+
expect(runtime.getStatus().runningScheduledTasksCount).toBe(0);
|
|
268
|
+
|
|
269
|
+
const manual = await runtime.runNow('p1', 'task-1');
|
|
270
|
+
expect(manual.ok).toBe(true);
|
|
271
|
+
expect(manual.sessionID).toBeTruthy();
|
|
272
|
+
expect(runtime.getStatus().runningScheduledTasksCount).toBe(0);
|
|
273
|
+
|
|
274
|
+
runtime.stop();
|
|
275
|
+
});
|
|
276
|
+
|
|
277
|
+
it('manual run completion write failure returns session and clears running status', async () => {
|
|
278
|
+
vi.setSystemTime(UTC(2026, 0, 1, 14, 0, 0));
|
|
279
|
+
const projectConfigRuntime = createSharedProjectConfigRuntime(
|
|
280
|
+
makeTask({ kind: 'daily', times: ['15:00'] }),
|
|
281
|
+
);
|
|
282
|
+
const runtime = createScheduledTasksRuntime(createRuntimeDeps(projectConfigRuntime));
|
|
283
|
+
await runtime.start();
|
|
284
|
+
|
|
285
|
+
const originalUpdate = projectConfigRuntime.updateScheduledTaskState;
|
|
286
|
+
projectConfigRuntime.updateScheduledTaskState = vi.fn(async (pid, tid, patch) => {
|
|
287
|
+
if (patch?.lastStatus === 'success' || patch?.lastStatus === 'error') {
|
|
288
|
+
throw new Error('timeout acquiring project config lock for p1');
|
|
289
|
+
}
|
|
290
|
+
return originalUpdate(pid, tid, patch);
|
|
291
|
+
});
|
|
292
|
+
|
|
293
|
+
const manual = await runtime.runNow('p1', 'task-1');
|
|
294
|
+
expect(manual.ok).toBe(true);
|
|
295
|
+
expect(manual.sessionID).toBeTruthy();
|
|
296
|
+
expect(manual.reason).toBe('completion-state-failed');
|
|
297
|
+
expect(manual.persistError).toMatch(/timeout acquiring project config lock/);
|
|
298
|
+
expect(manual.task?.state?.lastStatus).toBe('success');
|
|
299
|
+
expect(runtime.getStatus().runningScheduledTasksCount).toBe(0);
|
|
300
|
+
|
|
301
|
+
runtime.stop();
|
|
302
|
+
});
|
|
303
|
+
|
|
304
|
+
it('manual start state write failure releases the running slot', async () => {
|
|
305
|
+
vi.setSystemTime(UTC(2026, 0, 1, 14, 0, 0));
|
|
306
|
+
const projectConfigRuntime = createSharedProjectConfigRuntime(
|
|
307
|
+
makeTask({ kind: 'daily', times: ['15:00'] }),
|
|
308
|
+
);
|
|
309
|
+
const runtime = createScheduledTasksRuntime(createRuntimeDeps(projectConfigRuntime));
|
|
310
|
+
await runtime.start();
|
|
311
|
+
|
|
312
|
+
projectConfigRuntime.updateScheduledTaskState = vi.fn(async () => {
|
|
313
|
+
throw new Error('timeout acquiring project config lock for p1');
|
|
314
|
+
});
|
|
315
|
+
|
|
316
|
+
const manual = await runtime.runNow('p1', 'task-1');
|
|
317
|
+
expect(manual.ok).toBe(false);
|
|
318
|
+
expect(manual.reason).toBe('start-state-failed');
|
|
319
|
+
expect(sdk.sessionCreates.length).toBe(0);
|
|
320
|
+
expect(runtime.getStatus().runningScheduledTasksCount).toBe(0);
|
|
321
|
+
|
|
322
|
+
runtime.stop();
|
|
323
|
+
});
|
|
324
|
+
|
|
325
|
+
it('armed instance still fires when another instance syncs inside the due-slack window', async () => {
|
|
326
|
+
// Instance A arms for 15:00 outside the slack window. Instance B then starts
|
|
327
|
+
// inside TASK_DUE_SLACK_MS and syncTaskSchedule advances disk nextRunAt to
|
|
328
|
+
// tomorrow. A must still claim today's occurrence.
|
|
329
|
+
vi.setSystemTime(UTC(2026, 0, 1, 14, 0, 0));
|
|
330
|
+
const task = makeTask({ kind: 'daily', times: ['15:00'] });
|
|
331
|
+
const projectConfigRuntime = createSharedProjectConfigRuntime(task);
|
|
332
|
+
|
|
333
|
+
const runtimeA = createScheduledTasksRuntime(createRuntimeDeps(projectConfigRuntime));
|
|
334
|
+
await runtimeA.start();
|
|
335
|
+
|
|
336
|
+
// Enter the due-slack window (T-5s .. T) and sync a second instance.
|
|
337
|
+
await vi.advanceTimersByTimeAsync(HOUR - 2_000);
|
|
338
|
+
const runtimeB = createScheduledTasksRuntime(createRuntimeDeps(projectConfigRuntime));
|
|
339
|
+
await runtimeB.start();
|
|
340
|
+
|
|
341
|
+
await vi.advanceTimersByTimeAsync(5_000);
|
|
342
|
+
|
|
343
|
+
expect(sdk.sessionCreates.length).toBe(1);
|
|
344
|
+
|
|
345
|
+
runtimeA.stop();
|
|
346
|
+
runtimeB.stop();
|
|
347
|
+
});
|
|
348
|
+
|
|
349
|
+
it('armed instance still fires on a later day when lastScheduledFor is already set', async () => {
|
|
350
|
+
// After day 1 has claimed, lastScheduledFor is finite. On day 2 a second
|
|
351
|
+
// instance syncing inside the due-slack window must not suppress the armed fire.
|
|
352
|
+
vi.setSystemTime(UTC(2026, 0, 1, 14, 0, 0));
|
|
353
|
+
const task = makeTask({ kind: 'daily', times: ['15:00'] });
|
|
354
|
+
const projectConfigRuntime = createSharedProjectConfigRuntime(task);
|
|
355
|
+
|
|
356
|
+
const runtimeA = createScheduledTasksRuntime(createRuntimeDeps(projectConfigRuntime));
|
|
357
|
+
await runtimeA.start();
|
|
358
|
+
await vi.advanceTimersByTimeAsync(HOUR + 3_000);
|
|
359
|
+
expect(sdk.sessionCreates.length).toBe(1);
|
|
360
|
+
|
|
361
|
+
// Advance to day-2 afternoon, still outside slack, so A re-arms for 15:00.
|
|
362
|
+
await vi.advanceTimersByTimeAsync((23 * HOUR) - 3_000);
|
|
363
|
+
// Enter day-2 due-slack window and sync instance B (advances nextRunAt).
|
|
364
|
+
await vi.advanceTimersByTimeAsync(HOUR - 2_000);
|
|
365
|
+
const runtimeB = createScheduledTasksRuntime(createRuntimeDeps(projectConfigRuntime));
|
|
366
|
+
await runtimeB.start();
|
|
367
|
+
|
|
368
|
+
await vi.advanceTimersByTimeAsync(5_000);
|
|
369
|
+
|
|
370
|
+
expect(sdk.sessionCreates.length).toBe(2);
|
|
371
|
+
|
|
372
|
+
runtimeA.stop();
|
|
373
|
+
runtimeB.stop();
|
|
374
|
+
});
|
|
375
|
+
|
|
376
|
+
it('once-task loser does not spin-rearm a past nextRunAt while the winner runs', async () => {
|
|
377
|
+
vi.setSystemTime(UTC(2026, 0, 1, 8, 0, 0));
|
|
378
|
+
|
|
379
|
+
let releaseFetch;
|
|
380
|
+
const fetchGate = new Promise((resolve) => {
|
|
381
|
+
releaseFetch = resolve;
|
|
382
|
+
});
|
|
383
|
+
globalThis.fetch = vi.fn(async () => {
|
|
384
|
+
await fetchGate;
|
|
385
|
+
return { ok: true, text: async () => '' };
|
|
386
|
+
});
|
|
387
|
+
|
|
388
|
+
const { runtimes, projectConfigRuntime } = await startInstances(2, makeTask({
|
|
389
|
+
kind: 'once',
|
|
390
|
+
date: '2026-01-01',
|
|
391
|
+
time: '09:00',
|
|
392
|
+
}));
|
|
393
|
+
|
|
394
|
+
await vi.advanceTimersByTimeAsync(HOUR + 3_000);
|
|
395
|
+
|
|
396
|
+
// Winner claimed and is blocked in prompt_async; exactly one session.
|
|
397
|
+
expect(sdk.sessionCreates.length).toBe(1);
|
|
398
|
+
const claimsAfterFire = projectConfigRuntime.updateScheduledTaskStateIf.mock.calls.length;
|
|
399
|
+
expect(claimsAfterFire).toBeGreaterThanOrEqual(1);
|
|
400
|
+
|
|
401
|
+
// Advance through many jitter windows. Loser must not keep re-entering claim.
|
|
402
|
+
await vi.advanceTimersByTimeAsync(60_000);
|
|
403
|
+
expect(projectConfigRuntime.updateScheduledTaskStateIf.mock.calls.length).toBe(claimsAfterFire);
|
|
404
|
+
expect(sdk.sessionCreates.length).toBe(1);
|
|
405
|
+
|
|
406
|
+
releaseFetch();
|
|
407
|
+
await Promise.resolve();
|
|
408
|
+
await vi.advanceTimersByTimeAsync(5_000);
|
|
409
|
+
|
|
410
|
+
expect(sdk.sessionCreates.length).toBe(1);
|
|
411
|
+
expect(runtimes.every((runtime) => runtime.getStatus().runningScheduledTasksCount === 0)).toBe(true);
|
|
412
|
+
|
|
413
|
+
runtimes.forEach((runtime) => runtime.stop());
|
|
414
|
+
});
|
|
415
|
+
|
|
416
|
+
it('claim-failed re-arms the next occurrence, not an immediate retry of the past slot', async () => {
|
|
417
|
+
vi.setSystemTime(UTC(2026, 0, 1, 14, 0, 0));
|
|
418
|
+
const projectConfigRuntime = createSharedProjectConfigRuntime(
|
|
419
|
+
makeTask({ kind: 'daily', times: ['15:00'] }),
|
|
420
|
+
);
|
|
421
|
+
|
|
422
|
+
let claimAttempts = 0;
|
|
423
|
+
const originalClaim = projectConfigRuntime.updateScheduledTaskStateIf;
|
|
424
|
+
projectConfigRuntime.updateScheduledTaskStateIf = vi.fn(async (pid, tid, predicate, patch) => {
|
|
425
|
+
// Claim patches set lastScheduledFor; failure-recording patches set lastStatus error.
|
|
426
|
+
if (Object.prototype.hasOwnProperty.call(patch || {}, 'lastScheduledFor')) {
|
|
427
|
+
claimAttempts += 1;
|
|
428
|
+
throw new Error('timeout acquiring project config lock for p1');
|
|
429
|
+
}
|
|
430
|
+
return originalClaim(pid, tid, predicate, patch);
|
|
431
|
+
});
|
|
432
|
+
|
|
433
|
+
const runtime = createScheduledTasksRuntime(createRuntimeDeps(projectConfigRuntime));
|
|
434
|
+
await runtime.start();
|
|
435
|
+
|
|
436
|
+
await vi.advanceTimersByTimeAsync(HOUR + 3_000);
|
|
437
|
+
expect(claimAttempts).toBe(1);
|
|
438
|
+
|
|
439
|
+
// Must not immediately retry the same past occurrence on a ~jitter cadence.
|
|
440
|
+
await vi.advanceTimersByTimeAsync(30_000);
|
|
441
|
+
expect(claimAttempts).toBe(1);
|
|
442
|
+
|
|
443
|
+
// Next calendar occurrence (tomorrow 15:00) may attempt once more.
|
|
444
|
+
await vi.advanceTimersByTimeAsync(24 * HOUR);
|
|
445
|
+
expect(claimAttempts).toBe(2);
|
|
446
|
+
|
|
447
|
+
runtime.stop();
|
|
448
|
+
});
|
|
449
|
+
|
|
450
|
+
it('once claim failure records an error status instead of leaving the task silently inert', async () => {
|
|
451
|
+
vi.setSystemTime(UTC(2026, 0, 1, 8, 0, 0));
|
|
452
|
+
const projectConfigRuntime = createSharedProjectConfigRuntime(makeTask({
|
|
453
|
+
kind: 'once',
|
|
454
|
+
date: '2026-01-01',
|
|
455
|
+
time: '09:00',
|
|
456
|
+
}));
|
|
457
|
+
|
|
458
|
+
const originalClaim = projectConfigRuntime.updateScheduledTaskStateIf;
|
|
459
|
+
projectConfigRuntime.updateScheduledTaskStateIf = vi.fn(async (pid, tid, predicate, patch) => {
|
|
460
|
+
if (Object.prototype.hasOwnProperty.call(patch || {}, 'lastScheduledFor')) {
|
|
461
|
+
throw new Error('timeout acquiring project config lock for p1');
|
|
462
|
+
}
|
|
463
|
+
return originalClaim(pid, tid, predicate, patch);
|
|
464
|
+
});
|
|
465
|
+
|
|
466
|
+
const runtime = createScheduledTasksRuntime(createRuntimeDeps(projectConfigRuntime));
|
|
467
|
+
await runtime.start();
|
|
468
|
+
await vi.advanceTimersByTimeAsync(HOUR + 3_000);
|
|
469
|
+
|
|
470
|
+
expect(sdk.sessionCreates.length).toBe(0);
|
|
471
|
+
const tasks = await projectConfigRuntime.listScheduledTasks('p1');
|
|
472
|
+
expect(tasks[0].state.lastStatus).toBe('error');
|
|
473
|
+
expect(tasks[0].state.lastError).toMatch(/Scheduled claim failed/);
|
|
474
|
+
expect(tasks[0].enabled).toBe(true);
|
|
475
|
+
|
|
476
|
+
// No silent delay-0 spin after the failed once claim.
|
|
477
|
+
const errorWrites = projectConfigRuntime.updateScheduledTaskStateIf.mock.calls
|
|
478
|
+
.filter(([, , , patch]) => patch?.lastStatus === 'error')
|
|
479
|
+
.length;
|
|
480
|
+
await vi.advanceTimersByTimeAsync(30_000);
|
|
481
|
+
const errorWritesAfter = projectConfigRuntime.updateScheduledTaskStateIf.mock.calls
|
|
482
|
+
.filter(([, , , patch]) => patch?.lastStatus === 'error')
|
|
483
|
+
.length;
|
|
484
|
+
expect(errorWritesAfter).toBe(errorWrites);
|
|
485
|
+
|
|
486
|
+
runtime.stop();
|
|
487
|
+
});
|
|
488
|
+
});
|
|
@@ -145,6 +145,12 @@ export const registerScheduledTaskRoutes = (app, dependencies) => {
|
|
|
145
145
|
res.setHeader('X-Accel-Buffering', 'no');
|
|
146
146
|
res.flushHeaders?.();
|
|
147
147
|
|
|
148
|
+
// Whether a client can drive a browser view is a property of that client,
|
|
149
|
+
// not of this server: a desktop shell and a browser tab can be connected to
|
|
150
|
+
// the same server at once. Recording it on the connection keeps the answer
|
|
151
|
+
// current without any enable/disable setting to go stale.
|
|
152
|
+
res.openchamberBrowserCapable = req.query?.browser === '1';
|
|
153
|
+
|
|
148
154
|
const clients = getOpenChamberEventClients();
|
|
149
155
|
clients.add(res);
|
|
150
156
|
|