@openchamber/web 1.14.1 → 1.16.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/bin/cli.test.js +8 -0
- package/bin/lib/DOCUMENTATION.md +3 -0
- package/bin/lib/cli-args.js +10 -0
- package/bin/lib/commands-connect-url.js +169 -22
- package/dist/assets/{DiagramView-Cb58svCq.js → DiagramView-he_RFVx5.js} +1 -1
- package/dist/assets/MarkdownRendererImpl-CdBIHSPZ.js +11 -0
- package/dist/assets/{MultiRunWindow-BPSxV_B7.js → MultiRunWindow-B_C-tvVq.js} +1 -1
- package/dist/assets/OnboardingScreen-BBnTt-9w.js +1 -0
- package/dist/assets/SessionSwitcherDropdown-CWWrCFzr.js +1 -0
- package/dist/assets/SettingsWindow-CjqLdpTE.js +1 -0
- package/dist/assets/{TerminalView-fTYjnQkh.js → TerminalView-DQcdegHp.js} +1 -1
- package/dist/assets/es-r0_jT91q.js +15 -0
- package/dist/assets/fr-Bo8rtAJ1.js +13 -0
- package/dist/assets/index-8J6waVO6.js +2 -0
- package/dist/assets/index-DEMqM4Lz.css +1 -0
- package/dist/assets/ja-BPWtkG-c.js +15 -0
- package/dist/assets/ko-Bv0k-0E3.js +15 -0
- package/dist/assets/main-B-GA5Tg5.js +237 -0
- package/dist/assets/main-Dfm-VKZ9.js +2 -0
- package/dist/assets/miniChat-CfmCFFfu.js +2 -0
- package/dist/assets/mobile-CXJqeDlm.js +2 -0
- package/dist/assets/pl-CiTP50bz.js +15 -0
- package/dist/assets/pt-BR-DadIjX5L.js +15 -0
- package/dist/assets/renderElectronMiniChatApp-DS7Dy2ii.js +2 -0
- package/dist/assets/renderMobileApp-o7Fs9EBx.js +16 -0
- package/dist/assets/runtimeEndpointReset-MTaPPm4F.js +167 -0
- package/dist/assets/uk-2RpsWGoZ.js +15 -0
- package/dist/assets/{useAppFontEffects-BUUJYbAZ.js → useAppFontEffects-DkPuAMXD.js} +196 -133
- package/dist/assets/{vendor-.bun-C6iL44L9.js → vendor-.bun-BE757pvp.js} +1 -1
- package/dist/assets/zh-CN-BwKWaTuz.js +15 -0
- package/dist/assets/zh-TW--f_BqBpD.js +15 -0
- package/dist/index.html +4 -4
- package/dist/mini-chat.html +4 -4
- package/dist/mobile.html +4 -4
- package/package.json +2 -2
- package/server/index.js +236 -2
- package/server/lib/client-auth/pairing.js +308 -0
- package/server/lib/client-auth/pairing.test.js +142 -0
- package/server/lib/client-auth/remote-clients.js +65 -3
- package/server/lib/notifications/DOCUMENTATION.md +1 -1
- package/server/lib/notifications/apns-runtime.js +11 -16
- package/server/lib/notifications/runtime.js +135 -33
- package/server/lib/opencode/DOCUMENTATION.md +1 -0
- package/server/lib/opencode/agents.js +3 -0
- package/server/lib/opencode/bootstrap-runtime.js +15 -0
- package/server/lib/opencode/core-routes.js +321 -8
- package/server/lib/opencode/core-routes.test.js +329 -9
- package/server/lib/opencode/feature-routes-runtime.js +6 -0
- package/server/lib/opencode/network-runtime.js +14 -1
- package/server/lib/opencode/network-runtime.test.js +29 -9
- package/server/lib/opencode/proxy.js +47 -6
- package/server/lib/opencode/settings-helpers.js +24 -0
- package/server/lib/opencode/settings-helpers.test.js +25 -0
- package/server/lib/opencode/settings-normalization-runtime.js +21 -4
- package/server/lib/opencode/settings-normalization-runtime.test.js +21 -0
- package/server/lib/opencode/settings-runtime.js +25 -0
- package/server/lib/opencode/shutdown-runtime.js +2 -0
- package/server/lib/opencode/tunnel-auth.js +4 -9
- package/server/lib/package-manager.js +18 -5
- package/server/lib/permission-auto-accept/DOCUMENTATION.md +34 -0
- package/server/lib/permission-auto-accept/runtime.js +263 -0
- package/server/lib/permission-auto-accept/runtime.test.js +137 -0
- package/server/lib/projects/project-config.js +8 -0
- package/server/lib/quota/DOCUMENTATION.md +5 -2
- package/server/lib/quota/credentials/providers.js +43 -0
- package/server/lib/quota/credentials/store.js +48 -0
- package/server/lib/quota/credentials/store.test.js +26 -0
- package/server/lib/quota/opencode-go-credentials.js +11 -0
- package/server/lib/quota/opencode-go-credentials.test.js +32 -0
- package/server/lib/quota/providers/codex.js +7 -4
- package/server/lib/quota/providers/codex.test.js +48 -0
- package/server/lib/quota/providers/cursor.js +28 -39
- package/server/lib/quota/providers/index.js +7 -0
- package/server/lib/quota/providers/ollama-cloud.js +23 -42
- package/server/lib/quota/providers/ollama-cloud.test.js +12 -0
- package/server/lib/quota/providers/opencode-go.js +70 -0
- package/server/lib/quota/providers/opencode-go.test.js +17 -0
- package/server/lib/quota/routes.js +78 -7
- package/server/lib/quota/routes.test.js +40 -0
- package/server/lib/relay/DOCUMENTATION.md +98 -0
- package/server/lib/relay/cross-compat.test.js +135 -0
- package/server/lib/relay/e2ee.js +341 -0
- package/server/lib/relay/e2ee.test.js +124 -0
- package/server/lib/relay/host-client.js +389 -0
- package/server/lib/relay/host-client.test.js +280 -0
- package/server/lib/relay/host-lock.js +101 -0
- package/server/lib/relay/host-lock.test.js +129 -0
- package/server/lib/relay/identity.js +93 -0
- package/server/lib/relay/identity.test.js +78 -0
- package/server/lib/relay/service.js +334 -0
- package/server/lib/relay/signing-key.js +73 -0
- package/server/lib/relay/tunnel-codec.js +373 -0
- package/server/lib/relay/tunnel-codec.test.js +58 -0
- package/server/lib/relay/tunnel-host.js +462 -0
- package/server/lib/scheduled-tasks/runtime.js +104 -0
- package/server/lib/session-goal/DOCUMENTATION.md +176 -0
- package/server/lib/session-goal/objectives.js +61 -0
- package/server/lib/session-goal/routes.js +36 -0
- package/server/lib/session-goal/runtime.js +764 -0
- package/server/lib/ui-auth/DOCUMENTATION.md +6 -0
- package/server/lib/ui-auth/ui-auth.js +10 -0
- package/server/opencode-proxy.test.js +38 -0
- package/dist/assets/MarkdownRendererImpl-D2yCDL5A.js +0 -7
- package/dist/assets/OnboardingScreen-Sl-6JgaP.js +0 -1
- package/dist/assets/SessionSwitcherDropdown-4FWg9xMC.js +0 -1
- package/dist/assets/SettingsWindow-CY8q4msv.js +0 -1
- package/dist/assets/es-bWcuDy_2.js +0 -15
- package/dist/assets/fr-DzRs3OzV.js +0 -13
- package/dist/assets/index-KnWk9fmM.css +0 -1
- package/dist/assets/index-ZJTzZ0_U.js +0 -2
- package/dist/assets/ja-BqUX_UD3.js +0 -15
- package/dist/assets/ko-BQo10SNx.js +0 -15
- package/dist/assets/main-BDoqLlQB.js +0 -236
- package/dist/assets/main-DUGyTrDt.js +0 -2
- package/dist/assets/miniChat-DNDiX8GA.js +0 -2
- package/dist/assets/mobile-DnghtOCb.js +0 -2
- package/dist/assets/pl-Bgx_ATJT.js +0 -15
- package/dist/assets/pt-BR-B1yXRvoX.js +0 -15
- package/dist/assets/renderElectronMiniChatApp-BB4C1K7t.js +0 -2
- package/dist/assets/renderMobileApp-CZgaXKi5.js +0 -16
- package/dist/assets/runtimeEndpointReset-By39StyB.js +0 -167
- package/dist/assets/uk-C9k8SP8q.js +0 -15
- package/dist/assets/zh-CN-Bri-Vo5y.js +0 -15
- package/dist/assets/zh-TW-DAUGzmYG.js +0 -15
|
@@ -1,9 +1,14 @@
|
|
|
1
|
-
import { describe, it, expect, vi } from 'vitest';
|
|
1
|
+
import { describe, it, expect, vi, afterEach } from 'vitest';
|
|
2
2
|
import express from 'express';
|
|
3
3
|
import request from 'supertest';
|
|
4
|
+
import { createTunnelAuth } from './tunnel-auth.js';
|
|
4
5
|
import { registerAuthAndAccessRoutes, registerCommonRequestMiddleware, registerServerStatusRoutes } from './core-routes.js';
|
|
5
6
|
|
|
6
7
|
describe('core-routes', () => {
|
|
8
|
+
afterEach(() => {
|
|
9
|
+
vi.useRealTimers();
|
|
10
|
+
});
|
|
11
|
+
|
|
7
12
|
it('should call gracefulShutdown with exitProcess: true on /api/system/shutdown', async () => {
|
|
8
13
|
const app = express();
|
|
9
14
|
let shutdownOpts = null;
|
|
@@ -225,6 +230,206 @@ describe('core-routes', () => {
|
|
|
225
230
|
}
|
|
226
231
|
});
|
|
227
232
|
|
|
233
|
+
const createPairingRouteApp = (overrides = {}) => {
|
|
234
|
+
const app = express();
|
|
235
|
+
const dependencies = {
|
|
236
|
+
express,
|
|
237
|
+
tunnelAuthController: {
|
|
238
|
+
classifyRequestScope: () => 'local',
|
|
239
|
+
requireTunnelSession: vi.fn(),
|
|
240
|
+
getTunnelSessionFromRequest: vi.fn(),
|
|
241
|
+
clearTunnelSessionCookie: vi.fn(),
|
|
242
|
+
exchangeBootstrapToken: vi.fn(),
|
|
243
|
+
},
|
|
244
|
+
uiAuthController: {
|
|
245
|
+
resolveAuthContext: vi.fn(async () => ({ type: 'session', token: 'session-token' })),
|
|
246
|
+
requireAuth: vi.fn((_req, _res, next) => next()),
|
|
247
|
+
requireSessionAuth: vi.fn((_req, _res, next) => next()),
|
|
248
|
+
handleSessionStatus: vi.fn(),
|
|
249
|
+
handleSessionCreate: vi.fn(),
|
|
250
|
+
handleUrlAuthToken: vi.fn(),
|
|
251
|
+
handlePasskeyStatus: vi.fn(),
|
|
252
|
+
handlePasskeyAuthenticationOptions: vi.fn(),
|
|
253
|
+
handlePasskeyAuthenticationVerify: vi.fn(),
|
|
254
|
+
handlePasskeyRegistrationOptions: vi.fn(),
|
|
255
|
+
handlePasskeyRegistrationVerify: vi.fn(),
|
|
256
|
+
handlePasskeyList: vi.fn(),
|
|
257
|
+
handlePasskeyRevoke: vi.fn(),
|
|
258
|
+
handleResetAuth: vi.fn(),
|
|
259
|
+
},
|
|
260
|
+
remoteClientAuthRuntime: {
|
|
261
|
+
listClients: vi.fn(async () => []),
|
|
262
|
+
createClient: vi.fn(),
|
|
263
|
+
revokeClient: vi.fn(),
|
|
264
|
+
purgeRevokedClients: vi.fn(),
|
|
265
|
+
},
|
|
266
|
+
clientPairingRuntime: {
|
|
267
|
+
createPairingSession: vi.fn(async () => ({ pairing: { id: 'pair_1', secret: 'secret', expiresAt: '2099-01-01T00:00:00.000Z', fingerprint: 'ABCD-1234' } })),
|
|
268
|
+
cancelPairingSession: vi.fn(async () => ({ cancelled: true })),
|
|
269
|
+
redeemPairingSession: vi.fn(async () => ({
|
|
270
|
+
pairing: { fingerprint: 'ABCD-1234' },
|
|
271
|
+
client: { id: 'client-1', label: 'Phone', authMethod: 'pairing' },
|
|
272
|
+
token: 'oc_client_token',
|
|
273
|
+
})),
|
|
274
|
+
},
|
|
275
|
+
readSettingsFromDiskMigrated: vi.fn(async () => ({})),
|
|
276
|
+
normalizeTunnelSessionTtlMs: vi.fn(),
|
|
277
|
+
...overrides,
|
|
278
|
+
};
|
|
279
|
+
registerAuthAndAccessRoutes(app, dependencies);
|
|
280
|
+
return { app, dependencies };
|
|
281
|
+
};
|
|
282
|
+
|
|
283
|
+
it('creates pairing sessions behind owner auth and returns no-store payload data', async () => {
|
|
284
|
+
const { app, dependencies } = createPairingRouteApp();
|
|
285
|
+
|
|
286
|
+
const response = await request(app)
|
|
287
|
+
.post('/api/client-auth/pairing/sessions')
|
|
288
|
+
.set('Host', 'runtime.example')
|
|
289
|
+
.send({ label: 'Pair phone', allowedClientKinds: ['mobile'] })
|
|
290
|
+
.expect(201);
|
|
291
|
+
|
|
292
|
+
expect(response.headers['cache-control']).toBe('no-store');
|
|
293
|
+
expect(response.body.pairing).toMatchObject({ id: 'pair_1', secret: 'secret' });
|
|
294
|
+
expect(response.body.server.candidates).toEqual([{ type: 'lan', url: 'http://runtime.example', priority: 10 }]);
|
|
295
|
+
expect(dependencies.clientPairingRuntime.createPairingSession).toHaveBeenCalledWith({
|
|
296
|
+
label: 'Pair phone',
|
|
297
|
+
allowedClientKinds: ['mobile'],
|
|
298
|
+
createdByClientId: null,
|
|
299
|
+
usesRelay: false,
|
|
300
|
+
});
|
|
301
|
+
});
|
|
302
|
+
|
|
303
|
+
it('advertises the caller-supplied serverUrl as the direct candidate over the request origin', async () => {
|
|
304
|
+
const { app } = createPairingRouteApp();
|
|
305
|
+
|
|
306
|
+
const response = await request(app)
|
|
307
|
+
.post('/api/client-auth/pairing/sessions')
|
|
308
|
+
.set('Host', 'runtime.example')
|
|
309
|
+
.send({ label: 'Pair phone', serverUrl: 'http://192.168.1.20:2606' })
|
|
310
|
+
.expect(201);
|
|
311
|
+
|
|
312
|
+
expect(response.body.server.candidates).toEqual([
|
|
313
|
+
{ type: 'lan', url: 'http://192.168.1.20:2606', priority: 10 },
|
|
314
|
+
]);
|
|
315
|
+
});
|
|
316
|
+
|
|
317
|
+
it('folds in a relay candidate when the host relay is enabled', async () => {
|
|
318
|
+
const relayCandidate = {
|
|
319
|
+
type: 'relay',
|
|
320
|
+
relayUrl: 'wss://relay.example/ws',
|
|
321
|
+
serverId: 'srv_1',
|
|
322
|
+
hostEncPubJwk: { kty: 'EC', crv: 'P-256', x: 'aaa', y: 'bbb' },
|
|
323
|
+
priority: 30,
|
|
324
|
+
};
|
|
325
|
+
const { app } = createPairingRouteApp({ getRelayPairingCandidate: vi.fn(async () => relayCandidate) });
|
|
326
|
+
|
|
327
|
+
const response = await request(app)
|
|
328
|
+
.post('/api/client-auth/pairing/sessions')
|
|
329
|
+
.set('Host', 'runtime.example')
|
|
330
|
+
.send({ label: 'Pair phone' })
|
|
331
|
+
.expect(201);
|
|
332
|
+
|
|
333
|
+
expect(response.body.server.candidates).toEqual([
|
|
334
|
+
{ type: 'lan', url: 'http://runtime.example', priority: 10 },
|
|
335
|
+
relayCandidate,
|
|
336
|
+
]);
|
|
337
|
+
});
|
|
338
|
+
|
|
339
|
+
it('still returns the direct candidate when the relay candidate lookup throws', async () => {
|
|
340
|
+
const { app } = createPairingRouteApp({
|
|
341
|
+
getRelayPairingCandidate: vi.fn(async () => { throw new Error('relay status read failed'); }),
|
|
342
|
+
});
|
|
343
|
+
|
|
344
|
+
const response = await request(app)
|
|
345
|
+
.post('/api/client-auth/pairing/sessions')
|
|
346
|
+
.set('Host', 'runtime.example')
|
|
347
|
+
.send({ label: 'Pair phone' })
|
|
348
|
+
.expect(201);
|
|
349
|
+
|
|
350
|
+
expect(response.body.server.candidates).toEqual([{ type: 'lan', url: 'http://runtime.example', priority: 10 }]);
|
|
351
|
+
});
|
|
352
|
+
|
|
353
|
+
it('requires owner auth before creating or cancelling pairing sessions', async () => {
|
|
354
|
+
const { app, dependencies } = createPairingRouteApp({
|
|
355
|
+
uiAuthController: {
|
|
356
|
+
resolveAuthContext: vi.fn(async () => null),
|
|
357
|
+
requireAuth: vi.fn((_req, res) => res.status(401).json({ error: 'Unauthorized' })),
|
|
358
|
+
requireSessionAuth: vi.fn((_req, res) => res.status(401).json({ error: 'Unauthorized' })),
|
|
359
|
+
},
|
|
360
|
+
});
|
|
361
|
+
|
|
362
|
+
await request(app).post('/api/client-auth/pairing/sessions').send({}).expect(401);
|
|
363
|
+
await request(app).delete('/api/client-auth/pairing/sessions/pair_1').expect(401);
|
|
364
|
+
expect(dependencies.clientPairingRuntime.createPairingSession).not.toHaveBeenCalled();
|
|
365
|
+
expect(dependencies.clientPairingRuntime.cancelPairingSession).not.toHaveBeenCalled();
|
|
366
|
+
});
|
|
367
|
+
|
|
368
|
+
it('redeems pairing sessions with no-store response and generic errors', async () => {
|
|
369
|
+
const { app, dependencies } = createPairingRouteApp();
|
|
370
|
+
|
|
371
|
+
const response = await request(app)
|
|
372
|
+
.post('/api/client-auth/pairing/redeem')
|
|
373
|
+
.set('Host', 'runtime.example')
|
|
374
|
+
.send({ pairingId: 'pair_1', secret: 'secret', clientKind: 'mobile', deviceName: 'Phone' })
|
|
375
|
+
.expect(200);
|
|
376
|
+
|
|
377
|
+
expect(response.headers['cache-control']).toBe('no-store');
|
|
378
|
+
expect(response.body).toMatchObject({
|
|
379
|
+
ok: true,
|
|
380
|
+
server: { label: 'OpenChamber', url: 'http://runtime.example', fingerprint: 'ABCD-1234' },
|
|
381
|
+
client: { id: 'client-1', authMethod: 'pairing' },
|
|
382
|
+
clientToken: 'oc_client_token',
|
|
383
|
+
});
|
|
384
|
+
expect(dependencies.clientPairingRuntime.redeemPairingSession).toHaveBeenCalledWith(expect.objectContaining({
|
|
385
|
+
pairingId: 'pair_1',
|
|
386
|
+
secret: 'secret',
|
|
387
|
+
clientKind: 'mobile',
|
|
388
|
+
deviceName: 'Phone',
|
|
389
|
+
}));
|
|
390
|
+
|
|
391
|
+
dependencies.clientPairingRuntime.redeemPairingSession.mockRejectedValueOnce(new Error('Invalid or expired pairing session'));
|
|
392
|
+
await request(app)
|
|
393
|
+
.post('/api/client-auth/pairing/redeem')
|
|
394
|
+
.send({ pairingId: 'pair_2', secret: 'wrong' })
|
|
395
|
+
.expect(400, { error: 'Invalid or expired pairing session' });
|
|
396
|
+
});
|
|
397
|
+
|
|
398
|
+
it('rate limits pairing redeem attempts by socket address and pairingId, then resets after the window', async () => {
|
|
399
|
+
vi.useFakeTimers();
|
|
400
|
+
vi.setSystemTime(new Date('2026-01-01T00:00:00Z'));
|
|
401
|
+
const { app, dependencies } = createPairingRouteApp();
|
|
402
|
+
app.set('trust proxy', true);
|
|
403
|
+
dependencies.clientPairingRuntime.redeemPairingSession.mockRejectedValue(new Error('Invalid or expired pairing session'));
|
|
404
|
+
|
|
405
|
+
// The X-Forwarded-For headers below are deliberate spoof attempts: the rate
|
|
406
|
+
// limiter buckets by socket address (not forwarded headers), so rotating the
|
|
407
|
+
// header must NOT reset the counter or evade the lockout.
|
|
408
|
+
for (let index = 0; index < 10; index += 1) {
|
|
409
|
+
await request(app)
|
|
410
|
+
.post('/api/client-auth/pairing/redeem')
|
|
411
|
+
.set('X-Forwarded-For', `203.0.113.${index}`)
|
|
412
|
+
.send({ pairingId: 'pair_rate', secret: `wrong-${index}` })
|
|
413
|
+
.expect(400, { error: 'Invalid or expired pairing session' });
|
|
414
|
+
}
|
|
415
|
+
|
|
416
|
+
const locked = await request(app)
|
|
417
|
+
.post('/api/client-auth/pairing/redeem')
|
|
418
|
+
.set('X-Forwarded-For', '203.0.113.10')
|
|
419
|
+
.send({ pairingId: 'pair_rate', secret: 'wrong-locked' })
|
|
420
|
+
.expect(429, { error: 'Invalid or expired pairing session' });
|
|
421
|
+
expect(locked.headers['retry-after']).toBe('300');
|
|
422
|
+
expect(dependencies.clientPairingRuntime.redeemPairingSession).toHaveBeenCalledTimes(10);
|
|
423
|
+
|
|
424
|
+
vi.setSystemTime(new Date('2026-01-01T00:05:01Z'));
|
|
425
|
+
await request(app)
|
|
426
|
+
.post('/api/client-auth/pairing/redeem')
|
|
427
|
+
.set('X-Forwarded-For', '203.0.113.10')
|
|
428
|
+
.send({ pairingId: 'pair_rate', secret: 'wrong-after-reset' })
|
|
429
|
+
.expect(400, { error: 'Invalid or expired pairing session' });
|
|
430
|
+
expect(dependencies.clientPairingRuntime.redeemPairingSession).toHaveBeenCalledTimes(11);
|
|
431
|
+
});
|
|
432
|
+
|
|
228
433
|
it('should let preview proxy credentials reach preview proxy validation', async () => {
|
|
229
434
|
const app = express();
|
|
230
435
|
const requireAuth = vi.fn((_req, res) => res.status(401).type('text/plain').send('Authentication required'));
|
|
@@ -364,11 +569,59 @@ describe('client auth routes', () => {
|
|
|
364
569
|
|
|
365
570
|
const listedAfterPurge = await request(app).get('/api/client-auth/clients');
|
|
366
571
|
expect(listedAfterPurge.body.clients).toHaveLength(0);
|
|
367
|
-
expect(dependencies.testHooks.requireSessionAuth).toHaveBeenCalled();
|
|
368
|
-
expect(dependencies.testHooks.requireAuth).not.toHaveBeenCalled();
|
|
369
572
|
});
|
|
370
573
|
|
|
371
|
-
it('
|
|
574
|
+
it('reports current connection candidates with server identity for paired devices', async () => {
|
|
575
|
+
const app = express();
|
|
576
|
+
const relayCandidate = {
|
|
577
|
+
type: 'relay',
|
|
578
|
+
relayUrl: 'wss://relay.example/ws',
|
|
579
|
+
serverId: 'server-abc',
|
|
580
|
+
hostEncPubJwk: { kty: 'EC', crv: 'P-256', x: 'x', y: 'y' },
|
|
581
|
+
priority: 30,
|
|
582
|
+
};
|
|
583
|
+
const dependencies = {
|
|
584
|
+
...createDependencies({ resolveAuthContext: async () => ({ type: 'client', clientId: 'client-1' }) }),
|
|
585
|
+
getDirectCandidateUrls: () => ['http://192.168.1.20:3000', 'http://10.0.0.5:3000', 'not-a-url'],
|
|
586
|
+
getRelayPairingCandidate: async () => relayCandidate,
|
|
587
|
+
getServerId: async () => 'server-abc',
|
|
588
|
+
getServerLabel: () => 'my-host',
|
|
589
|
+
};
|
|
590
|
+
registerAuthAndAccessRoutes(app, dependencies);
|
|
591
|
+
|
|
592
|
+
const response = await request(app).get('/api/client-auth/connection/candidates');
|
|
593
|
+
expect(response.status).toBe(200);
|
|
594
|
+
expect(response.headers['cache-control']).toBe('no-store');
|
|
595
|
+
expect(response.body.serverId).toBe('server-abc');
|
|
596
|
+
expect(response.body.label).toBe('my-host');
|
|
597
|
+
expect(response.body.candidates).toEqual([
|
|
598
|
+
{ type: 'lan', url: 'http://192.168.1.20:3000', priority: 10 },
|
|
599
|
+
{ type: 'lan', url: 'http://10.0.0.5:3000', priority: 10 },
|
|
600
|
+
relayCandidate,
|
|
601
|
+
]);
|
|
602
|
+
});
|
|
603
|
+
|
|
604
|
+
it('omits serverId and relay candidate when unavailable and survives failures', async () => {
|
|
605
|
+
const app = express();
|
|
606
|
+
const dependencies = {
|
|
607
|
+
...createDependencies(),
|
|
608
|
+
getDirectCandidateUrls: () => {
|
|
609
|
+
throw new Error('scan failed');
|
|
610
|
+
},
|
|
611
|
+
getRelayPairingCandidate: async () => {
|
|
612
|
+
throw new Error('relay status failed');
|
|
613
|
+
},
|
|
614
|
+
getServerId: async () => null,
|
|
615
|
+
};
|
|
616
|
+
registerAuthAndAccessRoutes(app, dependencies);
|
|
617
|
+
|
|
618
|
+
const response = await request(app).get('/api/client-auth/connection/candidates');
|
|
619
|
+
expect(response.status).toBe(200);
|
|
620
|
+
expect(response.body).not.toHaveProperty('serverId');
|
|
621
|
+
expect(response.body.candidates).toEqual([]);
|
|
622
|
+
});
|
|
623
|
+
|
|
624
|
+
it('scopes non-desktop client credentials to list and revoke only themselves', async () => {
|
|
372
625
|
const app = express();
|
|
373
626
|
let authContext = { type: 'session' };
|
|
374
627
|
const dependencies = createDependencies({
|
|
@@ -383,20 +636,57 @@ describe('client auth routes', () => {
|
|
|
383
636
|
.post('/api/client-auth/clients')
|
|
384
637
|
.send({ label: 'Other device' });
|
|
385
638
|
|
|
386
|
-
|
|
639
|
+
// A regular (non-desktop-local) client token only sees and manages itself.
|
|
640
|
+
authContext = { type: 'client', clientId: other.body.client.id, client: other.body.client };
|
|
387
641
|
|
|
388
642
|
const listed = await request(app).get('/api/client-auth/clients');
|
|
389
643
|
expect(listed.status).toBe(200);
|
|
390
|
-
expect(listed.body.clients).toEqual([
|
|
644
|
+
expect(listed.body.clients).toEqual([other.body.client]);
|
|
391
645
|
|
|
392
|
-
const denied = await request(app).delete(`/api/client-auth/clients/${
|
|
646
|
+
const denied = await request(app).delete(`/api/client-auth/clients/${current.body.client.id}`);
|
|
393
647
|
expect(denied.status).toBe(403);
|
|
394
648
|
expect(denied.body.revoked).toBe(false);
|
|
395
649
|
|
|
396
|
-
const
|
|
650
|
+
const deniedPurge = await request(app).delete('/api/client-auth/clients');
|
|
651
|
+
expect(deniedPurge.status).toBe(403);
|
|
652
|
+
|
|
653
|
+
const revoked = await request(app).delete(`/api/client-auth/clients/${other.body.client.id}`);
|
|
397
654
|
expect(revoked.status).toBe(200);
|
|
398
655
|
expect(revoked.body.revoked).toBe(true);
|
|
399
|
-
expect(revoked.body.client.id).toBe(
|
|
656
|
+
expect(revoked.body.client.id).toBe(other.body.client.id);
|
|
657
|
+
});
|
|
658
|
+
|
|
659
|
+
it('lets the local desktop client list and revoke every device', async () => {
|
|
660
|
+
const app = express();
|
|
661
|
+
let authContext = { type: 'session' };
|
|
662
|
+
const dependencies = createDependencies({
|
|
663
|
+
resolveAuthContext: async () => authContext,
|
|
664
|
+
});
|
|
665
|
+
registerAuthAndAccessRoutes(app, dependencies);
|
|
666
|
+
|
|
667
|
+
const desktop = await request(app)
|
|
668
|
+
.post('/api/client-auth/clients')
|
|
669
|
+
.send({ label: 'OpenChamber Desktop', clientKind: 'desktop-local' });
|
|
670
|
+
const other = await request(app)
|
|
671
|
+
.post('/api/client-auth/clients')
|
|
672
|
+
.send({ label: 'Other device' });
|
|
673
|
+
|
|
674
|
+
// The trusted desktop shell client manages all devices like a UI session.
|
|
675
|
+
authContext = { type: 'client', clientId: desktop.body.client.id, client: desktop.body.client };
|
|
676
|
+
|
|
677
|
+
const listed = await request(app).get('/api/client-auth/clients');
|
|
678
|
+
expect(listed.status).toBe(200);
|
|
679
|
+
const listedIds = listed.body.clients.map((client) => client.id).sort();
|
|
680
|
+
expect(listedIds).toEqual([desktop.body.client.id, other.body.client.id].sort());
|
|
681
|
+
|
|
682
|
+
const revoked = await request(app).delete(`/api/client-auth/clients/${other.body.client.id}`);
|
|
683
|
+
expect(revoked.status).toBe(200);
|
|
684
|
+
expect(revoked.body.revoked).toBe(true);
|
|
685
|
+
expect(revoked.body.client.id).toBe(other.body.client.id);
|
|
686
|
+
|
|
687
|
+
const purged = await request(app).delete('/api/client-auth/clients');
|
|
688
|
+
expect(purged.status).toBe(200);
|
|
689
|
+
expect(purged.body.purged).toBe(1);
|
|
400
690
|
});
|
|
401
691
|
|
|
402
692
|
it('allows only the local desktop client token to create remote client tokens', async () => {
|
|
@@ -440,4 +730,34 @@ describe('client auth routes', () => {
|
|
|
440
730
|
expect(dependencies.testHooks.requireSessionAuth).toHaveBeenCalledTimes(2);
|
|
441
731
|
expect(dependencies.testHooks.requireAuth).not.toHaveBeenCalled();
|
|
442
732
|
});
|
|
733
|
+
|
|
734
|
+
it('treats private LAN hosts as local even when a tunnel is active', async () => {
|
|
735
|
+
const app = express();
|
|
736
|
+
const dependencies = createDependencies();
|
|
737
|
+
const tunnelAuthController = createTunnelAuth();
|
|
738
|
+
tunnelAuthController.setActiveTunnel({ tunnelId: 'tunnel-1', publicUrl: 'https://tunnel.example.com' });
|
|
739
|
+
dependencies.tunnelAuthController = tunnelAuthController;
|
|
740
|
+
dependencies.uiAuthController.handlePasskeyStatus = vi.fn((_req, res) => {
|
|
741
|
+
res.json({ enabled: true, hasPasskeys: true, passkeyCount: 1, rpID: 'example.com' });
|
|
742
|
+
});
|
|
743
|
+
|
|
744
|
+
registerAuthAndAccessRoutes(app, dependencies);
|
|
745
|
+
|
|
746
|
+
await request(app)
|
|
747
|
+
.get('/auth/passkey/status')
|
|
748
|
+
.set('Host', '192.168.1.5:57123')
|
|
749
|
+
.expect(200, { enabled: true, hasPasskeys: true, passkeyCount: 1, rpID: 'example.com' });
|
|
750
|
+
|
|
751
|
+
expect(dependencies.uiAuthController.handlePasskeyStatus).toHaveBeenCalledTimes(1);
|
|
752
|
+
});
|
|
753
|
+
|
|
754
|
+
it('does not trust a private Host header from a public socket peer', () => {
|
|
755
|
+
const tunnelAuthController = createTunnelAuth();
|
|
756
|
+
tunnelAuthController.setActiveTunnel({ tunnelId: 'tunnel-1', publicUrl: 'https://tunnel.example.com' });
|
|
757
|
+
|
|
758
|
+
expect(tunnelAuthController.classifyRequestScope({
|
|
759
|
+
headers: { host: '192.168.1.5:57123' },
|
|
760
|
+
socket: { remoteAddress: '203.0.113.10' },
|
|
761
|
+
})).toBe('unknown-public');
|
|
762
|
+
});
|
|
443
763
|
});
|
|
@@ -1,10 +1,12 @@
|
|
|
1
1
|
import { registerFsRoutes } from '../fs/routes.js';
|
|
2
2
|
import { registerQuotaRoutes } from '../quota/routes.js';
|
|
3
3
|
import { registerSmallModelRoutes } from '../small-model/routes.js';
|
|
4
|
+
import { registerSessionGoalRoutes } from '../session-goal/routes.js';
|
|
4
5
|
import { registerGitHubRoutes } from '../github/routes.js';
|
|
5
6
|
import { registerGitRoutes } from '../git/routes.js';
|
|
6
7
|
import { registerMagicPromptRoutes } from '../magic-prompts/routes.js';
|
|
7
8
|
import { registerSessionFoldersRoutes } from '../session-folders/routes.js';
|
|
9
|
+
import { registerPermissionAutoAcceptRoutes } from '../permission-auto-accept/runtime.js';
|
|
8
10
|
import { registerConfigEntityRoutes } from './config-entity-routes.js';
|
|
9
11
|
import { registerSettingsUtilityRoutes } from './core-routes.js';
|
|
10
12
|
import { registerProjectIconRoutes } from './project-icon-routes.js';
|
|
@@ -97,6 +99,7 @@ export const createFeatureRoutesRuntime = (dependencies) => {
|
|
|
97
99
|
scheduledTasksRuntime,
|
|
98
100
|
getOpenChamberEventClients,
|
|
99
101
|
writeSseEvent,
|
|
102
|
+
permissionAutoAcceptRuntime,
|
|
100
103
|
} = routeDependencies;
|
|
101
104
|
|
|
102
105
|
registerSettingsUtilityRoutes(app, {
|
|
@@ -105,6 +108,8 @@ export const createFeatureRoutesRuntime = (dependencies) => {
|
|
|
105
108
|
clientReloadDelayMs,
|
|
106
109
|
});
|
|
107
110
|
|
|
111
|
+
registerPermissionAutoAcceptRoutes(app, permissionAutoAcceptRuntime);
|
|
112
|
+
|
|
108
113
|
registerOpenCodeRoutes(app, {
|
|
109
114
|
crypto,
|
|
110
115
|
clientReloadDelayMs,
|
|
@@ -236,6 +241,7 @@ export const createFeatureRoutesRuntime = (dependencies) => {
|
|
|
236
241
|
|
|
237
242
|
registerQuotaRoutes(app, { getQuotaProviders });
|
|
238
243
|
registerSmallModelRoutes(app, { getSmallModelService });
|
|
244
|
+
registerSessionGoalRoutes(app);
|
|
239
245
|
registerGitHubRoutes(app);
|
|
240
246
|
registerGitRoutes(app);
|
|
241
247
|
registerMagicPromptRoutes(app, {
|
|
@@ -2,8 +2,21 @@ export const createOpenCodeNetworkRuntime = (deps) => {
|
|
|
2
2
|
const {
|
|
3
3
|
state,
|
|
4
4
|
getOpenCodeAuthHeaders,
|
|
5
|
+
configuredOpenCodeHostname = '127.0.0.1',
|
|
5
6
|
} = deps;
|
|
6
7
|
|
|
8
|
+
const resolveConnectHostname = () => {
|
|
9
|
+
const raw = typeof configuredOpenCodeHostname === 'string' ? configuredOpenCodeHostname.trim() : '';
|
|
10
|
+
const hostname = raw || '127.0.0.1';
|
|
11
|
+
if (hostname === '0.0.0.0' || hostname === '::' || hostname === '[::]') {
|
|
12
|
+
return '127.0.0.1';
|
|
13
|
+
}
|
|
14
|
+
if (hostname.startsWith('[') && hostname.endsWith(']')) {
|
|
15
|
+
return hostname;
|
|
16
|
+
}
|
|
17
|
+
return hostname.includes(':') ? `[${hostname}]` : hostname;
|
|
18
|
+
};
|
|
19
|
+
|
|
7
20
|
const normalizeApiPrefix = (prefix) => {
|
|
8
21
|
if (!prefix) {
|
|
9
22
|
return '';
|
|
@@ -77,7 +90,7 @@ export const createOpenCodeNetworkRuntime = (deps) => {
|
|
|
77
90
|
const normalizedPath = path.startsWith('/') ? path : `/${path}`;
|
|
78
91
|
const prefix = normalizeApiPrefix(prefixOverride !== undefined ? prefixOverride : '');
|
|
79
92
|
const fullPath = `${prefix}${normalizedPath}`;
|
|
80
|
-
const base = state.openCodeBaseUrl ?? `http
|
|
93
|
+
const base = state.openCodeBaseUrl ?? `http://${resolveConnectHostname()}:${state.openCodePort}`;
|
|
81
94
|
return `${base}${fullPath}`;
|
|
82
95
|
};
|
|
83
96
|
|
|
@@ -2,36 +2,56 @@ import { afterEach, describe, expect, it, vi } from 'vitest';
|
|
|
2
2
|
|
|
3
3
|
import { createOpenCodeNetworkRuntime } from './network-runtime.js';
|
|
4
4
|
|
|
5
|
-
const
|
|
5
|
+
const originalFetch = globalThis.fetch;
|
|
6
|
+
|
|
7
|
+
const createRuntime = (overrides = {}) => createOpenCodeNetworkRuntime({
|
|
6
8
|
state: {
|
|
7
9
|
openCodePort: 4096,
|
|
8
10
|
openCodeBaseUrl: null,
|
|
9
11
|
openCodeApiPrefix: '',
|
|
10
12
|
openCodeApiPrefixDetected: false,
|
|
11
13
|
openCodeApiDetectionTimer: null,
|
|
14
|
+
...overrides.state,
|
|
12
15
|
},
|
|
13
16
|
getOpenCodeAuthHeaders: () => ({}),
|
|
17
|
+
configuredOpenCodeHostname: overrides.configuredOpenCodeHostname,
|
|
14
18
|
});
|
|
15
19
|
|
|
16
20
|
describe('OpenCode network runtime', () => {
|
|
17
21
|
afterEach(() => {
|
|
18
22
|
vi.useRealTimers();
|
|
19
|
-
|
|
23
|
+
globalThis.fetch = originalFetch;
|
|
20
24
|
});
|
|
21
25
|
|
|
22
|
-
it('
|
|
23
|
-
vi.
|
|
24
|
-
vi.setSystemTime(0);
|
|
25
|
-
vi.stubGlobal('fetch', vi.fn(async () => {
|
|
26
|
+
it('returns false when readiness fetch rejects', async () => {
|
|
27
|
+
globalThis.fetch = vi.fn(async () => {
|
|
26
28
|
throw new Error('offline');
|
|
27
|
-
})
|
|
29
|
+
});
|
|
28
30
|
|
|
29
31
|
const runtime = createRuntime();
|
|
30
32
|
const readyPromise = runtime.waitForReady('http://127.0.0.1:4096', 1);
|
|
31
33
|
|
|
32
|
-
await vi.advanceTimersByTimeAsync(100);
|
|
33
34
|
await expect(readyPromise).resolves.toBe(false);
|
|
35
|
+
});
|
|
36
|
+
|
|
37
|
+
it('builds managed OpenCode URLs against IPv4 loopback by default', () => {
|
|
38
|
+
const runtime = createRuntime();
|
|
39
|
+
|
|
40
|
+
expect(runtime.buildOpenCodeUrl('/provider')).toBe('http://127.0.0.1:4096/provider');
|
|
41
|
+
});
|
|
42
|
+
|
|
43
|
+
it('keeps external OpenCode base URLs authoritative', () => {
|
|
44
|
+
const runtime = createRuntime({
|
|
45
|
+
state: { openCodeBaseUrl: 'http://remote.example:4096' },
|
|
46
|
+
});
|
|
47
|
+
|
|
48
|
+
expect(runtime.buildOpenCodeUrl('/provider')).toBe('http://remote.example:4096/provider');
|
|
49
|
+
});
|
|
34
50
|
|
|
35
|
-
|
|
51
|
+
it('normalizes wildcard and IPv6 OpenCode bind hosts for local connects', () => {
|
|
52
|
+
expect(createRuntime({ configuredOpenCodeHostname: '0.0.0.0' }).buildOpenCodeUrl('/provider'))
|
|
53
|
+
.toBe('http://127.0.0.1:4096/provider');
|
|
54
|
+
expect(createRuntime({ configuredOpenCodeHostname: '::1' }).buildOpenCodeUrl('/provider'))
|
|
55
|
+
.toBe('http://[::1]:4096/provider');
|
|
36
56
|
});
|
|
37
57
|
});
|
|
@@ -181,6 +181,7 @@ export const registerOpenCodeProxy = (app, deps) => {
|
|
|
181
181
|
os,
|
|
182
182
|
path,
|
|
183
183
|
OPEN_CODE_READY_GRACE_MS,
|
|
184
|
+
LONG_REQUEST_TIMEOUT_MS,
|
|
184
185
|
getRuntime,
|
|
185
186
|
getOpenCodeAuthHeaders,
|
|
186
187
|
buildOpenCodeUrl,
|
|
@@ -291,11 +292,46 @@ export const registerOpenCodeProxy = (app, deps) => {
|
|
|
291
292
|
return externalBase;
|
|
292
293
|
}
|
|
293
294
|
|
|
294
|
-
|
|
295
|
-
|
|
295
|
+
return FALLBACK_PROXY_TARGET;
|
|
296
|
+
};
|
|
297
|
+
|
|
298
|
+
const normalizeProxyTimeout = (value) => {
|
|
299
|
+
return Number.isFinite(value) && value > 0 ? value : 4 * 60 * 1000;
|
|
300
|
+
};
|
|
301
|
+
|
|
302
|
+
const PROXY_REQUEST_TIMEOUT_MS = normalizeProxyTimeout(LONG_REQUEST_TIMEOUT_MS);
|
|
303
|
+
const PROXY_TIMEOUT_MARKER = Symbol('openchamberProxyTimedOut');
|
|
304
|
+
|
|
305
|
+
const isProxyTimeoutError = (error) => {
|
|
306
|
+
const code = typeof error?.code === 'string' ? error.code : '';
|
|
307
|
+
const message = typeof error?.message === 'string' ? error.message.toLowerCase() : '';
|
|
308
|
+
return code === 'ETIMEDOUT'
|
|
309
|
+
|| code === 'ESOCKETTIMEDOUT'
|
|
310
|
+
|| message.includes('timeout')
|
|
311
|
+
|| message.includes('timed out');
|
|
312
|
+
};
|
|
313
|
+
|
|
314
|
+
const sendProxyErrorResponse = (res, statusCode) => {
|
|
315
|
+
if (!res || res.headersSent || res.writableEnded || typeof res.status !== 'function') {
|
|
316
|
+
return false;
|
|
296
317
|
}
|
|
318
|
+
res.status(statusCode).json({ error: statusCode === 504 ? 'OpenCode upstream timed out' : 'OpenCode service unavailable' });
|
|
319
|
+
return true;
|
|
320
|
+
};
|
|
297
321
|
|
|
298
|
-
|
|
322
|
+
const applyProxyResponseDeadline = (req, res, next) => {
|
|
323
|
+
const timeout = setTimeout(() => {
|
|
324
|
+
req[PROXY_TIMEOUT_MARKER] = true;
|
|
325
|
+
if (sendProxyErrorResponse(res, 504)) {
|
|
326
|
+
res.once('finish', () => req.destroy?.());
|
|
327
|
+
}
|
|
328
|
+
}, PROXY_REQUEST_TIMEOUT_MS);
|
|
329
|
+
timeout.unref?.();
|
|
330
|
+
|
|
331
|
+
const clear = () => clearTimeout(timeout);
|
|
332
|
+
res.once('finish', clear);
|
|
333
|
+
res.once('close', clear);
|
|
334
|
+
next();
|
|
299
335
|
};
|
|
300
336
|
|
|
301
337
|
const forwardSseRequest = async (req, res) => {
|
|
@@ -665,6 +701,8 @@ export const registerOpenCodeProxy = (app, deps) => {
|
|
|
665
701
|
target: resolveProxyTarget(),
|
|
666
702
|
changeOrigin: true,
|
|
667
703
|
pathRewrite: { '^/api': '' },
|
|
704
|
+
timeout: PROXY_REQUEST_TIMEOUT_MS,
|
|
705
|
+
proxyTimeout: PROXY_REQUEST_TIMEOUT_MS,
|
|
668
706
|
// Dynamic target — port can change after restart
|
|
669
707
|
router: () => resolveProxyTarget(),
|
|
670
708
|
on: {
|
|
@@ -700,11 +738,13 @@ export const registerOpenCodeProxy = (app, deps) => {
|
|
|
700
738
|
}
|
|
701
739
|
}
|
|
702
740
|
},
|
|
703
|
-
error: (err,
|
|
741
|
+
error: (err, req, res) => {
|
|
704
742
|
console.error('[proxy] OpenCode proxy error:', err.message);
|
|
705
|
-
if (
|
|
706
|
-
|
|
743
|
+
if (req?.[PROXY_TIMEOUT_MARKER]) {
|
|
744
|
+
return;
|
|
707
745
|
}
|
|
746
|
+
const statusCode = isProxyTimeoutError(err) ? 504 : 503;
|
|
747
|
+
sendProxyErrorResponse(res, statusCode);
|
|
708
748
|
},
|
|
709
749
|
},
|
|
710
750
|
});
|
|
@@ -724,5 +764,6 @@ export const registerOpenCodeProxy = (app, deps) => {
|
|
|
724
764
|
next();
|
|
725
765
|
});
|
|
726
766
|
|
|
767
|
+
app.use('/api', applyProxyResponseDeadline);
|
|
727
768
|
app.use('/api', apiProxy);
|
|
728
769
|
};
|
|
@@ -181,6 +181,21 @@ export const createSettingsHelpers = (dependencies) => {
|
|
|
181
181
|
if (typeof candidate.desktopKeepAwakeEnabled === 'boolean') {
|
|
182
182
|
result.desktopKeepAwakeEnabled = candidate.desktopKeepAwakeEnabled;
|
|
183
183
|
}
|
|
184
|
+
if (typeof candidate.desktopMinimizeToTrayEnabled === 'boolean') {
|
|
185
|
+
result.desktopMinimizeToTrayEnabled = candidate.desktopMinimizeToTrayEnabled;
|
|
186
|
+
}
|
|
187
|
+
if (candidate.permissionAutoAccept && typeof candidate.permissionAutoAccept === 'object' && !Array.isArray(candidate.permissionAutoAccept)) {
|
|
188
|
+
const sessions = {};
|
|
189
|
+
const sourceSessions = candidate.permissionAutoAccept.sessions;
|
|
190
|
+
if (sourceSessions && typeof sourceSessions === 'object' && !Array.isArray(sourceSessions)) {
|
|
191
|
+
for (const [sessionId, enabled] of Object.entries(sourceSessions)) {
|
|
192
|
+
if (sessionId && typeof enabled === 'boolean') sessions[sessionId] = enabled;
|
|
193
|
+
}
|
|
194
|
+
}
|
|
195
|
+
result.permissionAutoAccept = {
|
|
196
|
+
sessions,
|
|
197
|
+
};
|
|
198
|
+
}
|
|
184
199
|
if (typeof candidate.desktopUiPassword === 'string') {
|
|
185
200
|
result.desktopUiPassword = candidate.desktopUiPassword.trim();
|
|
186
201
|
}
|
|
@@ -251,6 +266,15 @@ export const createSettingsHelpers = (dependencies) => {
|
|
|
251
266
|
if (typeof candidate.sessionSuggestionEnabled === 'boolean') {
|
|
252
267
|
result.sessionSuggestionEnabled = candidate.sessionSuggestionEnabled;
|
|
253
268
|
}
|
|
269
|
+
if (typeof candidate.sessionGoalEnabled === 'boolean') {
|
|
270
|
+
result.sessionGoalEnabled = candidate.sessionGoalEnabled;
|
|
271
|
+
}
|
|
272
|
+
if (typeof candidate.sessionGoalDefaultBudgetEnabled === 'boolean') {
|
|
273
|
+
result.sessionGoalDefaultBudgetEnabled = candidate.sessionGoalDefaultBudgetEnabled;
|
|
274
|
+
}
|
|
275
|
+
if (typeof candidate.sessionGoalDefaultBudget === 'number' && Number.isFinite(candidate.sessionGoalDefaultBudget) && candidate.sessionGoalDefaultBudget > 0) {
|
|
276
|
+
result.sessionGoalDefaultBudget = Math.floor(candidate.sessionGoalDefaultBudget);
|
|
277
|
+
}
|
|
254
278
|
if (typeof candidate.collapsibleThinkingBlocks === 'boolean') {
|
|
255
279
|
result.collapsibleThinkingBlocks = candidate.collapsibleThinkingBlocks;
|
|
256
280
|
}
|
|
@@ -100,6 +100,31 @@ describe('settings helpers', () => {
|
|
|
100
100
|
});
|
|
101
101
|
});
|
|
102
102
|
|
|
103
|
+
it('accepts desktopMinimizeToTrayEnabled as a persisted shared setting', () => {
|
|
104
|
+
const helpers = createTestHelpers();
|
|
105
|
+
|
|
106
|
+
expect(helpers.sanitizeSettingsUpdate({ desktopMinimizeToTrayEnabled: true })).toEqual({
|
|
107
|
+
desktopMinimizeToTrayEnabled: true,
|
|
108
|
+
});
|
|
109
|
+
expect(helpers.sanitizeSettingsUpdate({ desktopMinimizeToTrayEnabled: false })).toEqual({
|
|
110
|
+
desktopMinimizeToTrayEnabled: false,
|
|
111
|
+
});
|
|
112
|
+
});
|
|
113
|
+
|
|
114
|
+
it('sanitizes the persisted permission auto-accept policy', () => {
|
|
115
|
+
const helpers = createTestHelpers();
|
|
116
|
+
|
|
117
|
+
expect(helpers.sanitizeSettingsUpdate({
|
|
118
|
+
permissionAutoAccept: {
|
|
119
|
+
sessions: { root: true, child: false, invalid: 'true' },
|
|
120
|
+
},
|
|
121
|
+
})).toEqual({
|
|
122
|
+
permissionAutoAccept: {
|
|
123
|
+
sessions: { root: true, child: false },
|
|
124
|
+
},
|
|
125
|
+
});
|
|
126
|
+
});
|
|
127
|
+
|
|
103
128
|
it('accepts desktopUiPassword as a persisted shared setting', () => {
|
|
104
129
|
const helpers = createTestHelpers();
|
|
105
130
|
|