@openagents-org/agent-launcher 0.2.164 → 0.2.166

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@openagents-org/agent-launcher",
-  "version": "0.2.164",
+  "version": "0.2.166",
   "description": "OpenAgents Launcher \u2014 install, configure, and run AI coding agents from your terminal",
   "main": "src/index.js",
   "bin": {

package/src/cli.js

@@ -1,5 +1,9 @@
 'use strict';
 
+// Before ./index so the daemon and every `agn` subprocess inherit the same
+// no-stray-console-window default on Windows. See win-console.js.
+require('./win-console').installWindowsHideDefault();
+
 const { AgentConnector, Daemon } = require('./index');
 const { hasCredentialMetadata, formatAuthGuidance } = require('./auth-guidance');
 
@@ -436,11 +440,13 @@ async function cmdNode(connector, flags, positional) {
     print('Connecting this device to your workspace...');
     try {
       const res = await connector.redeemNodePairingCode(code, info);
-      nodeCfg.saveNode({
+      // recordPairing, not saveNode: this device can be a node in several
+      // workspaces at once, and a bare save would drop the others' pairings.
+      nodeCfg.recordPairing(info.nodeKey, {
         node_id: res.nodeId,
-        node_key: info.nodeKey,
         workspace_id: res.workspaceId,
         workspace_slug: res.workspaceSlug,
+        workspace_name: res.workspaceName,
         endpoint: connector.workspace.endpoint,
         token: res.token,
       });
@@ -480,12 +486,14 @@ async function cmdNode(connector, flags, positional) {
   }
 
   if (sub === 'status') {
-    const n = nodeCfg.loadNode();
-    if (n && n.node_id) {
-      print(`Node connected: ${n.node_id}`);
-      print(`  Workspace: ${n.workspace_slug || n.workspace_id}`);
-    } else {
+    const pairings = nodeCfg.listPairings().filter((p) => p.node_id);
+    if (!pairings.length) {
       print('No node connected. Run: agn node connect <pairing-code>');
+      return;
+    }
+    print(`Node connected to ${pairings.length} workspace(s):`);
+    for (const p of pairings) {
+      print(`  ${p.workspace_slug || p.workspace_id} — node ${p.node_id}`);
     }
     return;
   }

package/src/daemon.js

@@ -31,7 +31,7 @@ class Daemon {
     this._statusInterval = null;
     this._cmdInterval = null;
     this._nodeHeartbeatInterval = null;  // device-level heartbeat (connect-a-node)
-    this._nodeClient = null;             // lazily-created WorkspaceClient for the node
+    this._nodeClients = new Map();       // workspace_id -> WorkspaceClient, one per pairing
     this._runningCommands = new Set();   // node-command ids currently executing
     this._runtimes = [];                 // detected agent runtimes for the node view
     this._runtimesInterval = null;
@@ -39,34 +39,78 @@ class Daemon {
   }
 
   /**
-   * Heartbeat this device (node) to its workspace, independent of any agent, so
-   * the workspace's "connected devices" view stays live even with zero agents.
-   * Best-effort: node liveness is non-critical to agent operation.
+   * Heartbeat this device (node) to EVERY workspace it is paired to,
+   * independent of any agent, so each workspace's "connected devices" view
+   * stays live even with zero agents there.
+   *
+   * One device legitimately belongs to several workspaces at once — the node
+   * row is per (workspace, device) — so this iterates the pairing list rather
+   * than the single top-level record. Each pairing gets its own roster, scoped
+   * to that workspace's agents. Best-effort: node liveness is non-critical to
+   * agent operation, and one workspace being unreachable must not stop the
+   * others from reporting, so the pairings are heartbeated concurrently and
+   * failures are contained per pairing.
    */
   async _nodeHeartbeat() {
+    const nodeCfg = require('./node-config');
+    const pairings = nodeCfg.listPairings().filter((p) => p && p.node_id && p.token);
+    if (!pairings.length) return;  // no node connected
+    const info = { ...nodeCfg.gatherDeviceInfo(), runtimes: this._runtimes, fs: this._buildFs() };
+    await Promise.all(pairings.map((p) => this._nodeHeartbeatOne(nodeCfg, p, info)));
+  }
+
+  /** The WorkspaceClient for one pairing, created on first use and reused. */
+  _nodeClientFor(n) {
+    let client = this._nodeClients.get(n.workspace_id);
+    if (!client) {
+      client = new WorkspaceClient(n.endpoint);
+      this._nodeClients.set(n.workspace_id, client);
+    }
+    return client;
+  }
+
+  /** One pairing's heartbeat. Never throws — see _nodeHeartbeat. */
+  async _nodeHeartbeatOne(nodeCfg, n, info) {
+    let resp;
     try {
-      const nodeCfg = require('./node-config');
-      const n = nodeCfg.loadNode();
-      if (!n || !n.node_id || !n.token) return;  // no node connected
-      if (!this._nodeClient) {
-        this._nodeClient = new WorkspaceClient(n.endpoint);
+      resp = await this._nodeClientFor(n).nodeHeartbeat(n.node_id, n.token, { ...info, agents: this._buildRoster(n) });
+    } catch (err) {
+      // A 404 is the workspace's definitive word that this node (or that whole
+      // workspace) no longer exists — an owner unpaired the device. Nothing
+      // local can revive it, so forget THAT pairing: keep the device key for a
+      // future re-pair, and leave every other workspace's pairing alone.
+      // Without this the launcher kept showing "connected" long after a remote
+      // removal, since node.json was only ever reconciled by the UI on demand.
+      // Transient failures (timeouts, 5xx, auth blips) say nothing about the
+      // row's existence, so those are swallowed and retried next tick.
+      if (err && err.status === 404) {
+        try { nodeCfg.clearPairing(n.workspace_id); } catch {}
+        this._nodeClients.delete(n.workspace_id);
+        this._log(`node ${n.node_id} no longer recognized by workspace ${n.workspace_slug || n.workspace_id} — pairing cleared`);
       }
-      const info = { ...nodeCfg.gatherDeviceInfo(), agents: this._buildRoster(), runtimes: this._runtimes, fs: this._buildFs() };
-      const resp = await this._nodeClient.nodeHeartbeat(n.node_id, n.token, info);
-      // The heartbeat response is our push channel: run any queued remote
-      // agent-management commands the workspace enqueued for this node. Fire
-      // them off without blocking the heartbeat loop (an install can take
-      // minutes — awaiting here would stall liveness and stack up commands).
-      const commands = (resp && resp.commands) || [];
-      for (const cmd of commands) {
-        const id = cmd.commandId;
-        if (!id || this._runningCommands.has(id)) continue;
-        this._runningCommands.add(id);
-        this._runNodeCommand(n, cmd).finally(() => this._runningCommands.delete(id));
-      }
-    } catch {
-      // ignore — will retry next interval
+      return;  // nothing more to do for this pairing this tick
     }
+    // The heartbeat response is our push channel: run any queued remote
+    // agent-management commands the workspace enqueued for this node. Fire
+    // them off without blocking the heartbeat loop (an install can take
+    // minutes — awaiting here would stall liveness and stack up commands).
+    const commands = (resp && resp.commands) || [];
+    for (const cmd of commands) {
+      const id = cmd.commandId;
+      if (!id || this._runningCommands.has(id)) continue;
+      this._runningCommands.add(id);
+      this._runNodeCommand(n, cmd).finally(() => this._runningCommands.delete(id));
+    }
+  }
+
+  /**
+   * True if agent `a` is bound to the node's currently-connected workspace.
+   * A missing network never matches (guards against undefined === undefined
+   * leaking local-only agents when a node field is also unset).
+   */
+  _agentOnNodeWorkspace(a, node) {
+    if (!a || !a.network || !node) return false;
+    return a.network === node.workspace_slug || a.network === node.workspace_id;
   }
 
   /**
@@ -74,11 +118,18 @@ class Daemon {
    * from config (the source of truth for what's configured) and augmented with
    * live process state, so a removed agent drops off immediately rather than
    * lingering as a stale 'stopped' process entry.
+   *
+   * SECURITY: scoped to the node's currently-connected workspace. An agent
+   * connected to a DIFFERENT workspace (or a local-only agent with no network)
+   * must never leak into — or be controllable from — a workspace it was never
+   * added to. Each agent belongs to exactly one workspace; this node reports
+   * only the agents that belong to the one it's paired with right now.
    */
-  _buildRoster() {
+  _buildRoster(node) {
     const roster = [];
     try {
       for (const a of this.config.getAgents()) {
+        if (!this._agentOnNodeWorkspace(a, node)) continue;
         const proc = this._processes[a.name];
         // Model: per-agent env override, else the type-level saved model. Working
         // dir: the agent's configured path. Both power the workspace agent cards.
@@ -172,7 +223,18 @@ class Daemon {
     let ok = false;
     let message = '';
     let data = null;
+    // SECURITY: a workspace may only act on agents bound to it. Reject commands
+    // that target an existing agent connected to a different workspace, so a
+    // newly-paired workspace can't start/stop/remove/reconfigure agents that
+    // belong to another one (they surface in no roster of ours either).
+    const AGENT_SCOPED = new Set(['start_agent', 'stop_agent', 'remove_agent', 'configure_agent']);
     try {
+      if (AGENT_SCOPED.has(action)) {
+        const existing = this.config.getAgent(name);
+        if (!existing || !this._agentOnNodeWorkspace(existing, n)) {
+          throw new Error(`Agent '${name}' is not managed by this workspace`);
+        }
+      }
       if (action === 'create_agent') {
         const type = (args.type || '').trim();
         // Working directory: use the one the user picked, else a managed folder
@@ -245,7 +307,9 @@ class Daemon {
       message = e.message || String(e);
     }
     try {
-      await this._nodeClient.nodeCommandResult(cmd.commandId, n.token, { ok, message, data });
+      // Report back to the workspace that issued the command — with several
+      // pairings live, the result must not go out over another one's client.
+      await this._nodeClientFor(n).nodeCommandResult(cmd.commandId, n.token, { ok, message, data });
     } catch {
       // best-effort; the command stays 'running' if we can't report back
     }
@@ -265,6 +329,10 @@ class Daemon {
         // Run from home so a created agent's default working dir is sensible
         // (not the ~/.openagents config dir).
         cwd: os.homedir(),
+        // The daemon has no console of its own (it is spawned DETACHED), so a
+        // child without this gets a fresh console window — the blank black box
+        // that used to appear every time _refreshRuntimes() ran.
+        windowsHide: true,
       });
       let stdout = '';
       let stderr = '';
@@ -921,6 +989,9 @@ class Daemon {
       stdio: ['ignore', 'pipe', 'pipe'],
       env: getEnhancedEnv(opts.env),
       cwd: opts.cwd,
+      // Windows: cmd.exe would otherwise open a console window per agent (the
+      // daemon has none to inherit) and leave it up for the agent's lifetime.
+      windowsHide: true,
     };
 
     if (IS_WINDOWS) {

package/src/index.js

@@ -1,5 +1,9 @@
 'use strict';
 
+// Must run before anything captures a child_process reference: on Windows it
+// keeps every spawn from popping a stray console window. See win-console.js.
+require('./win-console').installWindowsHideDefault();
+
 const { Config } = require('./config');
 const { EnvManager } = require('./env');
 const { Registry } = require('./registry');

package/src/node-config.js

@@ -40,6 +40,72 @@ function getOrCreateNodeKey() {
   return key;
 }
 
+/**
+ * Every workspace this device is paired to, most recent first.
+ *
+ * All of them are live: the server-side node row is keyed per (workspace,
+ * node_key), so one device holds a membership in each workspace it paired with
+ * and the daemon heartbeats every one. Records written before `pairings`
+ * existed carry a single top-level pairing, which is reconstructed here.
+ */
+function listPairings() {
+  const record = loadNode();
+  if (!record) return [];
+  if (record.pairings && record.pairings.length) return record.pairings;
+  return record.workspace_id ? [record] : [];
+}
+
+/**
+ * Add a pairing, or refresh it if this workspace is already paired.
+ *
+ * Additive on purpose: pairing a second workspace must NOT take the device away
+ * from the ones it already belongs to (each issues its own node row). The newest
+ * pairing is mirrored at the top level, which is what a daemon predating
+ * multi-pairing reads. Mirrors the launcher's writer (`node-pairing.ts`).
+ */
+function recordPairing(nodeKey, pairing) {
+  const stamped = { ...pairing, paired_at: new Date().toISOString() };
+  const pairings = [
+    stamped,
+    ...listPairings().filter((p) => p.workspace_id !== pairing.workspace_id),
+  ];
+  saveNode({ node_key: nodeKey, ...stamped, pairings });
+}
+
+/**
+ * Forget one workspace's pairing — that workspace no longer recognizes this node.
+ *
+ * Keeps `node_key` (so a re-pair reuses the same device id) and drops just the
+ * one entry: the server-side node row for THAT workspace is gone and can only
+ * be replaced by a fresh code, while every other pairing is still good. The top
+ * level is re-pointed at whichever pairing is now first, since that is what a
+ * daemon predating multi-pairing reads. Mirrors the launcher's writer
+ * (`node-pairing.ts`) so the two stay schema-compatible.
+ *
+ * @param workspaceId which pairing to drop; defaults to the top-level one.
+ * @returns the pairing that was dropped, or null if there was no such pairing.
+ */
+function clearPairing(workspaceId) {
+  const record = loadNode();
+  if (!record) return null;
+  const target = workspaceId || record.workspace_id;
+  if (!target) return null;
+
+  const pairings = listPairings();
+  const dropped = pairings.find((p) => p.workspace_id === target);
+  if (!dropped) return null;
+
+  const remaining = pairings.filter((p) => p.workspace_id !== target);
+  saveNode({ node_key: record.node_key, ...remaining[0], pairings: remaining });
+  return {
+    node_id: dropped.node_id,
+    workspace_id: dropped.workspace_id,
+    workspace_slug: dropped.workspace_slug,
+    workspace_name: dropped.workspace_name,
+    endpoint: dropped.endpoint,
+  };
+}
+
 /** Best-effort device type from the platform (user/UI can override). */
 function inferDeviceType() {
   const p = os.platform();
@@ -64,6 +130,9 @@ function gatherDeviceInfo() {
 module.exports = {
   loadNode,
   saveNode,
+  listPairings,
+  recordPairing,
+  clearPairing,
   getOrCreateNodeKey,
   inferDeviceType,
   gatherDeviceInfo,

package/src/win-console.js

@@ -0,0 +1,85 @@
+'use strict';
+
+/**
+ * Stop Windows from popping a console window for every child process we spawn.
+ *
+ * Neither process that runs this code owns a console: the daemon is spawned
+ * DETACHED (`agn up --foreground`), and the launcher's Electron main process is
+ * a GUI app. On Windows, when a console-less process launches a console
+ * executable *without* CREATE_NO_WINDOW, the OS allocates a brand-new console
+ * for the child — an empty black cmd/Windows-Terminal window that pops to the
+ * foreground and steals focus. With stdio piped nothing is ever drawn in it,
+ * so what the user sees is a blank window appearing out of nowhere.
+ *
+ * That is the "命令框 keeps popping up" report: `_refreshRuntimes()` shells out
+ * to `agn runtimes --json` every two minutes, and the probe it runs keeps the
+ * window on screen for as long as it takes to check every installed CLI.
+ *
+ * Node exposes CREATE_NO_WINDOW as the `windowsHide` spawn option and most call
+ * sites pass it — but there are ~60 of them across the adapters and a single
+ * miss brings the window back. So the default lives here, applied once at the
+ * process entry points (src/index.js, src/cli.js) before any module has
+ * captured a reference to child_process.
+ *
+ * Two things this deliberately does NOT do:
+ *   - override an explicit `windowsHide: false` — the launcher opens a real
+ *     terminal for CLI sign-in that way, and that window is the point; and
+ *   - break interactive output: libuv only applies CREATE_NO_WINDOW when no
+ *     stdio handle is inherited, so `agn` run from a terminal (stdio 'inherit')
+ *     is unaffected by this and still prints where the user can see it.
+ */
+
+const childProcess = require('child_process');
+
+const PATCHED = Symbol.for('openagents.windowsHideDefault');
+const WRAPPED = ['spawn', 'spawnSync', 'exec', 'execSync', 'execFile', 'execFileSync'];
+
+/**
+ * Return a copy of `args` whose options object carries `windowsHide: true`.
+ *
+ * Every child_process signature ends with `[options][, callback]`, so the
+ * options object — if there is one — is the last non-function argument. The
+ * caller's object is copied rather than mutated: callers reuse option objects
+ * and must not see ours leak into their state.
+ */
+function withWindowsHide(args) {
+  const out = args.slice();
+  const cbIdx = typeof out[out.length - 1] === 'function' ? out.length - 1 : -1;
+  const optIdx = cbIdx === -1 ? out.length - 1 : cbIdx - 1;
+  const opts = optIdx >= 0 ? out[optIdx] : undefined;
+
+  if (opts && typeof opts === 'object' && !Array.isArray(opts)) {
+    if ('windowsHide' in opts) return args;  // explicit wins, either way
+    out[optIdx] = { ...opts, windowsHide: true };
+    return out;
+  }
+  // No options argument at all — insert one ahead of any callback.
+  out.splice(cbIdx === -1 ? out.length : cbIdx, 0, { windowsHide: true });
+  return out;
+}
+
+/**
+ * Default `windowsHide: true` for this process's child_process calls.
+ * No-op off Windows, and idempotent.
+ */
+function installWindowsHideDefault() {
+  if (process.platform !== 'win32') return;
+  if (childProcess[PATCHED]) return;
+
+  for (const name of WRAPPED) {
+    const original = childProcess[name];
+    if (typeof original !== 'function') continue;
+    const wrapper = function (...args) {
+      return original.apply(this, withWindowsHide(args));
+    };
+    // Keep util.promisify(exec) and friends working.
+    for (const sym of Object.getOwnPropertySymbols(original)) {
+      wrapper[sym] = original[sym];
+    }
+    Object.defineProperty(wrapper, 'name', { value: name });
+    childProcess[name] = wrapper;
+  }
+  childProcess[PATCHED] = true;
+}
+
+module.exports = { installWindowsHideDefault, withWindowsHide };

package/src/workspace-client.js

@@ -969,6 +969,10 @@ class WorkspaceClient {
                 // Preserve structured error details (error_code, hint,
                 // quota occupancy, ...) so tool handlers can surface them.
                 if (parsed.data && typeof parsed.data === 'object') err.data = parsed.data;
+                // The HTTP status lets callers tell a definitive rejection
+                // (e.g. 404 "not found") from a transient one (5xx/timeout);
+                // the node heartbeat uses it to clear a removed pairing.
+                err.status = res.statusCode;
                 reject(err);
               }
             } else {