@openagents-org/agent-launcher 0.2.152 → 0.2.153

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@openagents-org/agent-launcher",
-  "version": "0.2.152",
+  "version": "0.2.153",
   "description": "OpenAgents Launcher \u2014 install, configure, and run AI coding agents from your terminal",
   "main": "src/index.js",
   "bin": {

package/src/installer.js

@@ -4,7 +4,7 @@ const fs = require('fs');
 const os = require('os');
 const path = require('path');
 const { execSync, exec } = require('child_process');
-const { whichBinary, getEnhancedEnv, getRuntimePrefix, clearBinaryLookupCache, aiderBinDirs } = require('./paths');
+const { whichBinary, getEnhancedEnv, getRuntimePrefix, clearBinaryLookupCache, aiderBinDirs, resolveBinaryInKnownDirs } = require('./paths');
 const { EnvManager } = require('./env');
 const { readinessReason, REASON } = require('./adapters/health-status');
 
@@ -394,6 +394,44 @@ class Installer {
     return found ? { path: found } : null;
   }
 
+  /**
+   * Confirm a real cursor-agent binary landed, for verify-before-mark.
+   *
+   * Cursor's Windows one-liner (`irm 'https://cursor.com/install?win32=true' |
+   * iex`) downloads the CLI with Invoke-WebRequest. When that download fails —
+   * an "unexpected EOF or 0 bytes" IOException is what users behind a filtering
+   * network get — PowerShell treats it as NON-terminating: the script carries
+   * on, prints "Start using Cursor Agent" and "Happy coding!", and exits 0. All
+   * that's left on disk is an empty %LOCALAPPDATA%\cursor-agent\versions\.
+   *
+   * Same defect hermes and amp already guard against here. Without this the
+   * marker gets written, the launcher reports Cursor installed, offers a
+   * sign-in, and the only way the user finds out is a terminal saying
+   * "'cursor-agent' is not recognized".
+   */
+  _verifyCursorBinary() {
+    try { clearBinaryLookupCache(); } catch {}
+    const resolved = this._whichBinary('cursor');
+    if (resolved && fs.existsSync(resolved)) return { path: resolved };
+    return null;
+  }
+
+  _cursorBinaryNotFoundMessage() {
+    const localAppData =
+      process.env.LOCALAPPDATA || path.join(os.homedir(), 'AppData', 'Local');
+    const isWin = process.platform === 'win32';
+    const expected = isWin
+      ? path.join(localAppData, 'cursor-agent')
+      : path.join(os.homedir(), '.local', 'bin', 'cursor-agent');
+    return (
+      'Cursor install command completed, but the cursor-agent binary could not be found\n' +
+      "(its installer prints \"Happy coding!\" and exits 0 even when the download failed —\n" +
+      'look for "unexpected EOF" or a network error in the log above).\n\n' +
+      `Expected under:\n${expected}\n\n` +
+      'Retry the install, or check that cursor.com is reachable from this network.'
+    );
+  }
+
   _hermesBinaryNotFoundMessage() {
     const isWin = process.platform === 'win32';
     const localAppData = process.env.LOCALAPPDATA || path.join(os.homedir(), 'AppData', 'Local');
@@ -1066,6 +1104,18 @@ class Installer {
             }
             if (onData) onData(`\nHermes CLI resolved: ${hermes.path}\n`);
           }
+          // Cursor-only: same failure shape as hermes above — its installer
+          // exits 0 after a failed download. See _verifyCursorBinary.
+          if (agentType === 'cursor') {
+            const cursor = this._verifyCursorBinary();
+            if (!cursor) {
+              const msg = this._cursorBinaryNotFoundMessage();
+              if (onData) onData(`\n${msg}\n`);
+              reject(new Error(msg));
+              return;
+            }
+            if (onData) onData(`\nCursor CLI resolved: ${cursor.path}\n`);
+          }
           this._markInstalled(agentType);
           if (onData) onData(`\nDone! ${agentType} is now installed.\n`);
           resolve({ success: true, command: displayCmd });
@@ -1296,7 +1346,14 @@ class Installer {
     // runnable. Generic and backward-compatible — only runs after PATH misses.
     const pkgBin = this._resolvePackageBin(agentType, entry, binary);
     if (pkgBin) return pkgBin;
-    return null;
+    // Last: check the known install dirs on disk. A PATH lookup misses a CLI
+    // whose installer only edited the *registry* PATH (Cursor, Amp, Hermes on
+    // Windows) until the process restarts, and the launcher — which resolves
+    // through here — then reports a working install as missing and offers a
+    // terminal running a bare command that cannot resolve either. Each adapter
+    // already does this search; this puts it in the one place the launcher
+    // actually calls.
+    return resolveBinaryInKnownDirs([binary, ...aliases], agentType);
   }
 
   /**

package/src/paths.js

@@ -517,12 +517,69 @@ function aiderBinDirs() {
   return dirs;
 }
 
+/** Executable suffixes to try for a bare binary name, per platform. */
+const BIN_EXTS = IS_WINDOWS ? ['.cmd', '.exe', '.bat', ''] : [''];
+
+/**
+ * Last-resort binary lookup: walk the directories we already know agent CLIs
+ * land in and check the filesystem directly, instead of asking the shell.
+ *
+ * `where`/`which` is not enough on Windows. The Cursor, Amp and Hermes
+ * installers edit the *registry* PATH, which an already-running process never
+ * inherits — so a perfectly good install is invisible to a PATH lookup until
+ * the machine (or at least the app) is restarted. Every adapter grew its own
+ * tiered search to cope; the launcher had none, so it alone reported "can't
+ * find it" and then opened a terminal running a bare command that could only
+ * fail with "'cursor-agent' is not recognized".
+ *
+ * Deliberately reuses getExtraBinDirs() rather than a second hardcoded list:
+ * that list already IS the curated set, and a copy of it is exactly how the
+ * launcher and the adapters drifted apart in the first place.
+ *
+ * Runs only after a PATH lookup has already missed, so it can add resolutions
+ * but never change one that already works.
+ *
+ * @param {string|string[]} names  binary name(s), e.g. ['cursor-agent','agent']
+ * @param {string} [agentType]     adds that agent's isolated runtime bin dir
+ * @returns {string|null} absolute path, or null
+ */
+function resolveBinaryInKnownDirs(names, agentType) {
+  const list = (Array.isArray(names) ? names : [names]).filter(Boolean);
+  if (!list.length) return null;
+
+  const dirs = [];
+  const push = (d) => { if (d && !dirs.includes(d)) dirs.push(d); };
+
+  // The agent's own isolated runtime first — it is the copy this launcher
+  // installed, and should win over anything the user happens to have globally.
+  if (agentType) push(path.join(getRuntimePrefix(agentType), 'node_modules', '.bin'));
+  push(path.join(HOME, '.openagents', 'nodejs', 'node_modules', '.bin'));
+  try { push(path.dirname(process.execPath)); } catch {}
+  for (const d of getExtraBinDirs()) push(d);
+
+  for (const dir of dirs) {
+    for (const name of list) {
+      for (const ext of BIN_EXTS) {
+        const candidate = path.join(dir, `${name}${ext}`);
+        try {
+          if (fs.existsSync(candidate) && fs.statSync(candidate).isFile()) return candidate;
+        } catch {
+          /* unreadable path — keep looking */
+        }
+      }
+    }
+  }
+  return null;
+}
+
+
 module.exports = {
   getExtraBinDirs,
   getEnhancedPATH,
   getEnhancedEnv,
   whichBinary,
   whereBinary,
+  resolveBinaryInKnownDirs,
   clearBinaryLookupCache,
   getRuntimePrefix,
   getCorePrefix,