@open-xchange/vite-plugin-ox-manifests 0.4.4-pre1 → 0.4.4-pre2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@open-xchange/vite-plugin-ox-manifests",
-  "version": "0.4.4-pre1",
+  "version": "0.4.4-pre2",
   "description": "A vite plugin to concat and serve ox manifests",
   "main": "index.js",
   "type": "module",

package/src/plugins/settings.js

@@ -17,7 +17,7 @@ function getRequirements (entry) {
     const moduleInfo = this.getModuleInfo(first)
     if (moduleInfo.isEntry) {
       if (moduleInfo.meta?.manifests) {
-        entryPoints.push.apply(entryPoints, moduleInfo.meta.manifests.map(manifest => ({ requires: true, ...manifest })))
+        entryPoints.push.apply(entryPoints, moduleInfo.meta.manifests.map(manifest => ({ requires: 'true', ...manifest })))
         continue
       }
     }

package/test/settings-with-requirements/index.js

@@ -1,3 +1,4 @@
 import { settings } from './settings'
+import { settings as other } from './other-settings'
 
-console.log('Hello world', settings)
+console.log('Hello world', settings, other)

package/test/settings-with-requirements/main.test.js

@@ -22,8 +22,30 @@ describe('Settings like in core, with requirements', function () {
     })
     const manifestFile = getFileFromBundle('manifest', bundle)
     const manifests = JSON.parse(manifestFile.source)
-    expect(Object.keys(manifests)).toHaveLength(2)
+    expect(Object.keys(manifests)).toHaveLength(4)
     expect(manifests['settings.js'].meta.manifests[0].namespace).toEqual('settings')
     expect(manifests['settings.js'].meta.manifests[0].requires).toEqual('cap')
   })
+
+  it('merges requirements for manifests', async () => {
+    const bundle = await build({
+      root: path.dirname(new URL(import.meta.url).pathname),
+      logLevel: 'silent',
+      build: {
+        write: false,
+        rollupOptions: {
+          input: {},
+          external: ['@/io.ox/core/settings']
+        }
+      },
+      plugins: [vitePluginOxManifests({
+
+      })]
+    })
+
+    const manifestFile = getFileFromBundle('manifest', bundle)
+    const manifests = JSON.parse(manifestFile.source)
+    expect(Object.keys(manifests)).toHaveLength(4)
+    expect(manifests['other-settings.js'].meta.manifests[0].requires).toBeUndefined()
+  })
 })

package/test/settings-with-requirements/manifest.json

@@ -1,5 +1,8 @@
-{
+[{
   "namespace": "test",
   "path": "index",
   "requires": "cap"
-}
+}, {
+  "namespace": "test",
+  "path": "other"
+}]

package/test/settings-with-requirements/other-settings.js

@@ -0,0 +1,3 @@
+import { Settings } from '@/io.ox/core/settings'
+
+export const settings = new Settings('other', () => {})

package/test/settings-with-requirements/other.js

@@ -0,0 +1,3 @@
+import { settings as other } from './other-settings'
+
+console.log('Hello world', other)