@open-xchange/vite-plugin-ox-manifests 0.4.2 → 0.4.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@open-xchange/vite-plugin-ox-manifests",
-  "version": "0.4.2",
+  "version": "0.4.3",
   "description": "A vite plugin to concat and serve ox manifests",
   "main": "index.js",
   "type": "module",

package/src/plugins/gettext.js

@@ -54,9 +54,11 @@ export default function () {
         const chunk = bundle[file]
         if (!chunk.facadeModuleId) continue
 
-        Object.keys(chunk.modules).forEach(id => {
+        const modules = Object.keys(chunk.modules)
+        if (modules.length === 0) modules.push(chunk.facadeModuleId)
+        modules.forEach(id => {
           const meta = this.getModuleInfo(id)?.meta
-          if (!meta?.gettext?.dictionary === true) return
+          if (meta?.gettext?.dictionary !== true) return
 
           meta.manifests = meta.manifests || []
           meta.manifests.push({ namespace: 'i18n' })

package/test/gettext-chunked/another_chunk.js

@@ -0,0 +1,4 @@
+import gt from 'gettext'
+
+export const five = 5
+export default gt('five')

package/test/gettext-chunked/i18n/de_DE.po

@@ -0,0 +1,16 @@
+msgid ""
+msgstr ""
+"Project-Id-Version: \n"
+"PO-Revision-Date: 2014-01-15 14:13+0100\n"
+"Last-Translator: Julian Bäume <julian.baeume@open-xchange.com>\n"
+"Language-Team: German <julian.baeume@open-xchange.com>\n"
+"Language: de_DE\n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: 8bit\n"
+"Plural-Forms: nplurals=2; plural=(n != 1);\n"
+"X-Generator: Lokalize 1.5\n"
+
+#: module:i18n
+msgid "Hello world!"
+msgstr "Hallo Welt!"

package/test/gettext-chunked/i18n/en_US.po

@@ -0,0 +1,16 @@
+msgid ""
+msgstr ""
+"Project-Id-Version: \n"
+"PO-Revision-Date: 2014-01-15 14:13+0100\n"
+"Last-Translator: Julian Bäume <julian.baeume@open-xchange.com>\n"
+"Language-Team: German <julian.baeume@open-xchange.com>\n"
+"Language: en_US\n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: 8bit\n"
+"Plural-Forms: nplurals=2; plural=(n != 1);\n"
+"X-Generator: Lokalize 1.5\n"
+
+#: module:i18n
+msgid "Hello world!"
+msgstr ""

package/test/gettext-chunked/main.test.js

@@ -0,0 +1,68 @@
+import { describe, it, expect, afterEach } from '@jest/globals'
+import { build, createServer } from 'vite'
+import path from 'path'
+import vitePluginOxManifests from '../../index'
+import rollupPluginPo2Json from '@open-xchange/rollup-plugin-po2json'
+import { getFileFromBundle, getPort } from '../util'
+import axios from 'axios'
+
+const PORT = getPort()
+const __dirname = path.dirname(new URL(import.meta.url).pathname)
+
+describe('Dictionary in modules with dynamic imports', function () {
+  let server
+
+  afterEach(async function () {
+    if (server) {
+      await server.close()
+      server = null
+    }
+  })
+
+  it('works', async function () {
+    const bundle = await build({
+      root: __dirname,
+      logLevel: 'silent',
+      build: {
+        write: false,
+        rollupOptions: {
+          input: { }
+        }
+      },
+      plugins: [rollupPluginPo2Json({
+        poFiles: __dirname + '/i18n/*.po'
+      }), vitePluginOxManifests({
+
+      })]
+    })
+
+    const manifestFile = getFileFromBundle('manifest', bundle)
+    const manifests = JSON.parse(manifestFile.source)
+    expect(Object.keys(manifests)).toHaveLength(6)
+    expect(manifests['register.js'].meta.manifests[0].namespace).toEqual('test')
+    expect(manifests['../../i18n.js'].meta.gettext.dictionary).toEqual(true)
+    expect(manifests['../../i18n.js'].meta.manifests[0].namespace).toEqual('i18n')
+  })
+
+  it('works in dev mode', async function () {
+    server = await createServer({
+      root: __dirname,
+      logLevel: 'silent',
+      plugins: [rollupPluginPo2Json({
+        poFiles: __dirname + '/i18n/*.po'
+      }), vitePluginOxManifests({
+
+      })]
+    })
+    await server.listen(PORT)
+
+    const res = await axios({ baseURL: `http://127.0.0.1:${PORT}/api/manifest.json` })
+    const manifests = res.data
+
+    expect(manifests).toHaveLength(2)
+    expect(manifests[0].namespace).toEqual('i18n')
+    expect(manifests[0].path).toEqual('i18n')
+    expect(manifests[1].namespace).toEqual('test')
+    expect(manifests[1].path).toContain('register')
+  })
+})

package/test/gettext-chunked/manifest.json

@@ -0,0 +1,3 @@
+{
+    "namespace": "test"
+}

package/test/gettext-chunked/register.js

@@ -0,0 +1,6 @@
+import gt from 'gettext'
+
+export async function doSomethingDynamic () {
+  const { five } = await import('./another_chunk.js')
+  console.log(gt('Hello world!'), five)
+}