@open-xchange/vite-plugin-ox-manifests 0.3.1 → 0.4.0

package/README.md

@@ -25,8 +25,6 @@ return {
 You can provide the following options to the plugin:
 
 * watch `<boolean>` If set to true, it will watch any changes to manifest.json files and will automatically reload the vite-dev-server. Default: `true`
-* appsuiteUrl `<string>` If this string is provided, the dev-server will try to fetch manifests from that location and will merge them together with local manifests. Duplicate entries will be removed. Useful for plugin development which require core manifests. Default: `undefined`
-* manifestApiPath `<string>` The path where this plugin looks for manifests is `appsuiteUrl + manifestApiPath`. If developing against a common Kubernetes based App Suite deployment, this most like does not have to be changed.  Default: `'/api/manifest.json'`
 * entryPoints `<string> | <glob pattern>` Convenience method to specify additional entry points for the production build. The glob pattern will be resolved and injected into the `build.input` options of vite. Can be specified as a glob-pattern. Default: `undefined`
 * manifestsAsEntryPoints `<boolean>` If set to true, this will inject every entrypoint that is defined by a manifest.json file into the `build.input` options of vite. Default: `true`
 * transformAbsolutePaths `<boolean>` If set to true, every absolute path will be transformed into a relative path. This is especially useful, if the production path is not clear at build time. E.g. if you do not know, whether appsuite will be served under `/appsuite`. Default: `true`

package/index.js

@@ -3,7 +3,6 @@ import manifestsPlugin from './src/plugins/manifests.js'
 import relativePathsPlugin from './src/plugins/relative-paths.js'
 import settingsPlugin from './src/plugins/settings.js'
 import servePlugin from './src/plugins/serve.js'
-import serverManifestPlugin from './src/plugins/server-manifests.js'
 import gettextPlugin from './src/plugins/gettext.js'
 import { deepMergeObject } from './src/util.js'
 
@@ -12,7 +11,6 @@ import { deepMergeObject } from './src/util.js'
  *
  * @param {object} [options]
  * @param {boolean} [options.watch=false] - If set to true, this plugin will watch manifest changes and reload the ui
- * @param {string} [options.appsuiteUrl] - When used in dev-mode, the dev-server can merge the local manifests with the manifest-files from the appsuiteUrl server.
  * @param {string} [options.entryPoints] - Convenience method to specify additional entry points for the production build. Can be specified as a glob-pattern.
  * @param {boolean} [options.manifestsAsEntryPoints=true] - Specifies, that every path in a manifest is used as an entry-point for the production build.
  * @param {boolean} [options.transformAbsolutePaths=true] - If this is set to true, every path in the html-files is transformed to a relative path. Additionally, every preloaded file will also be loaded relative to the index.html
@@ -21,7 +19,6 @@ import { deepMergeObject } from './src/util.js'
  */
 export default function ({
   watch = false,
-  appsuiteUrl,
   entryPoints,
   manifestsAsEntryPoints = true,
   transformAbsolutePaths = true,
@@ -30,7 +27,6 @@ export default function ({
 } = {}) {
   const options = {
     watch,
-    appsuiteUrl,
     entryPoints,
     manifestsAsEntryPoints,
     transformAbsolutePaths,
@@ -43,7 +39,6 @@ export default function ({
     settingsPlugin(options),
     relativePathsPlugin(options),
     servePlugin(options),
-    serverManifestPlugin(options),
     gettextPlugin(options),
     // manifest plugin last
     manifestsPlugin(options)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@open-xchange/vite-plugin-ox-manifests",
-  "version": "0.3.1",
+  "version": "0.4.0",
   "description": "A vite plugin to concat and serve ox manifests",
   "main": "index.js",
   "type": "module",

package/src/plugins/gettext.js

@@ -44,7 +44,7 @@ export default function () {
 
     getManifests () {
       if (resolvedConfig.mode !== 'production') {
-        return manifests.map(({ namespace, path }) => ({ namespace, raw: `/@id/${path}`, path }))
+        return manifests.map(({ namespace, path }) => ({ namespace, raw: `/@id/${path}.js`, path }))
       }
       return manifests
     },

package/src/plugins/server-manifests.js

@@ -1,25 +0,0 @@
-import axios from 'axios'
-
-export default function ({ appsuiteUrl } = {}) {
-  let cache
-  return {
-    async getManifests () {
-      if (!appsuiteUrl) return []
-
-      if (cache) return cache
-
-      try {
-        let res
-        try {
-          res = await axios.get(new URL('/api/manifest.json', appsuiteUrl).href)
-        } catch (e) {
-          res = await axios.get(new URL('/manifests', appsuiteUrl).href)
-        }
-        return (cache = res.data)
-      } catch (e) {
-        console.error('Could not fetch server manifests', e)
-        return []
-      }
-    }
-  }
-}

package/test/server-manifests/main.test.js

@@ -1,130 +0,0 @@
-import { describe, it, expect, afterEach, jest } from '@jest/globals'
-import { createServer } from 'vite'
-import path from 'path'
-import vitePluginOxManifests from '../../index'
-import axios from 'axios'
-import express from 'express'
-import { getPort } from '../util'
-
-const PORT = getPort()
-const SERVER_PORT = getPort()
-
-describe('Server manifest scenario', function () {
-  let server, expressServer
-
-  afterEach(async function () {
-    if (server) {
-      await server.close()
-      server = null
-    }
-    if (expressServer) {
-      await expressServer.close()
-      expressServer = null
-    }
-  })
-
-  it('works in dev mode', async function () {
-    server = await createServer({
-      root: path.dirname(new URL(import.meta.url).pathname),
-      logLevel: 'silent',
-      plugins: [vitePluginOxManifests({
-        appsuiteUrl: `http://localhost:${SERVER_PORT}`
-      })]
-    })
-    await server.listen(PORT)
-
-    const app = express()
-    expressServer = app.listen(SERVER_PORT)
-    app.get('/api/manifest.json', (req, res) => {
-      res.json([{ namespace: 'server' }])
-    })
-
-    const res = await axios({ baseURL: `http://localhost:${PORT}/api/manifest.json` })
-    const manifests = res.data
-
-    expect(manifests).toHaveLength(2)
-    expect(manifests[1].namespace).toEqual('test')
-    expect(manifests[1].path).toContain('register')
-    expect(manifests[0].namespace).toEqual('server')
-  })
-
-  it('only fetches manifests once from server', async function () {
-    server = await createServer({
-      root: path.dirname(new URL(import.meta.url).pathname),
-      logLevel: 'silent',
-      plugins: [vitePluginOxManifests({
-        appsuiteUrl: `http://localhost:${SERVER_PORT}`
-      })]
-    })
-    await server.listen(PORT)
-
-    const app = express()
-    expressServer = app.listen(SERVER_PORT)
-    const respond = jest.fn((req, res) => {
-      res.json([{ namespace: 'server' }])
-    })
-    app.get('/api/manifest.json', respond)
-
-    expect(respond).not.toBeCalled()
-
-    await axios({ baseURL: `http://localhost:${PORT}/api/manifest.json` })
-
-    expect(respond).toBeCalledTimes(1)
-
-    await axios({ baseURL: `http://localhost:${PORT}/api/manifest.json` })
-
-    expect(respond).toBeCalledTimes(1)
-  })
-
-  it('overwrites existing manfests from server', async function () {
-    server = await createServer({
-      root: path.dirname(new URL(import.meta.url).pathname),
-      logLevel: 'silent',
-      plugins: [vitePluginOxManifests({
-        appsuiteUrl: `http://localhost:${SERVER_PORT}`
-      })]
-    })
-    await server.listen(PORT)
-
-    const app = express()
-    expressServer = app.listen(SERVER_PORT)
-    app.get('/api/manifest.json', (req, res) => {
-      // same as from client, but with additional property
-      res.json([{ namespace: 'test', path: 'register', other: 'test' }])
-    })
-
-    const res = await axios({ baseURL: `http://localhost:${PORT}/api/manifest.json` })
-    const manifests = res.data
-
-    expect(manifests).toHaveLength(1)
-    expect(manifests[0].namespace).toEqual('test')
-    expect(manifests[0].path).toEqual('register')
-    expect(manifests[0].other).toBeUndefined()
-  })
-
-  it('exposes manifest and dependencies using new API', async () => {
-    server = await createServer({
-      root: path.dirname(new URL(import.meta.url).pathname),
-      logLevel: 'silent',
-      plugins: [vitePluginOxManifests({
-        appsuiteUrl: `http://localhost:${SERVER_PORT}`
-      })]
-    })
-    await server.listen(PORT)
-    const app = express()
-    expressServer = app.listen(SERVER_PORT)
-    app.get('/api/manifest.json', (req, res) => {
-      // same as from client, but with additional property
-      res.json([{ namespace: 'test', path: 'register', other: 'test' }])
-    })
-
-    const { data: manifests } = await axios({ baseURL: `http://localhost:${PORT}/manifests` })
-    expect(manifests).toHaveLength(1)
-    expect(manifests[0].namespace).toEqual('test')
-    expect(manifests[0].path).toEqual('register')
-    expect(manifests[0].other).toBeUndefined()
-
-    const { data } = await axios({ baseURL: `http://localhost:${PORT}/dependencies` })
-    expect(data).toStrictEqual({})
-  })
-})

package/test/server-manifests/manifest.json

@@ -1,3 +0,0 @@
-{
-  "namespace": "test"
-}

package/test/server-manifests/register.js

@@ -1 +0,0 @@
-console.log('Hello world')