@open-xchange/soap-client 0.1.4 → 0.1.5

package/CHANGELOG.md

@@ -4,6 +4,16 @@ All notable changes to this project will be documented in this file.
 
 ## [Unreleased]
 
+## [0.1.5] - 2026-05-26
+
+### Fixed
+
+- Retry the WSDL fetch on transient network errors (ECONNRESET / ETIMEDOUT / etc.). The per-method `pRetry` wrapper was already handling SOAP method calls, but `SOAP.createClientAsync()` itself (which fetches the WSDL via axios under the hood) was unretried, so a single TLS hiccup during bootstrap would kill the whole test run.
+
+### Changed
+
+- Retry policy tuned to ride out a recovery window of up to ~3 minutes per call: 10 retries (11 attempts total) with exponential backoff from 1s up to 30s, capped, with jitter. Previous 3-retry / 10s-cap budget was useful for one-packet blips but ran out before a recovering service could come back. The same policy now applies to both the WSDL fetch and per-method SOAP calls (factored into a shared constant). Permanent SOAP faults (already-exists, auth failure, etc.) still abort immediately via `shouldAbortRetry`.
+
 ## [0.1.4] - 2026-05-21
 
 ### Fixed
@@ -103,7 +113,8 @@ All notable changes to this project will be documented in this file.
 
 - Initial release: extract SOAP client into its own library
 
-[unreleased]: https://gitlab.com/openxchange/appsuite/web-foundation/tools/-/compare/soap-client-0.1.4...main
+[unreleased]: https://gitlab.com/openxchange/appsuite/web-foundation/tools/-/compare/soap-client-0.1.5...main
+[0.1.5]: https://gitlab.com/openxchange/appsuite/web-foundation/tools/-/compare/soap-client-0.1.4...soap-client-0.1.5
 [0.1.4]: https://gitlab.com/openxchange/appsuite/web-foundation/tools/-/compare/soap-client-0.1.3...soap-client-0.1.4
 [0.1.3]: https://gitlab.com/openxchange/appsuite/web-foundation/tools/-/compare/soap-client-0.1.2...soap-client-0.1.3
 [0.1.2]: https://gitlab.com/openxchange/appsuite/web-foundation/tools/-/compare/soap-client-0.1.1...soap-client-0.1.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@open-xchange/soap-client",
-  "version": "0.1.4",
+  "version": "0.1.5",
   "description": "SOAP client for OX App Suite",
   "main": "index.js",
   "type": "module",
@@ -22,10 +22,10 @@
   "dependencies": {
     "commander": "^14.0.3",
     "p-retry": "^8.0.0",
-    "soap": "^1.9.1"
+    "soap": "^1.9.3"
   },
   "devDependencies": {
-    "vitest": "^4.1.5",
+    "vitest": "^4.1.7",
     "@open-xchange/lint": "0.3.0"
   },
   "scripts": {

package/soap.js

@@ -25,6 +25,21 @@ import pRetry, { AbortError as RetryAbortError } from 'p-retry'
 // Set AbortError correctly
 const AbortError = RetryAbortError
 
+// Shared retry policy for both the WSDL fetch and per-method SOAP calls.
+// Designed to ride out a service recovery window of up to ~3 minutes:
+// fast retries for the first ~30s catch transient blips cheaply, then the
+// schedule settles into 30s polling so a recovering service is picked up
+// within one poll. Note: each pRetry cycle is independent, so back-to-back
+// failures (WSDL + method) can spend up to ~6 minutes total — keep the CI
+// job timeout above that or recovery won't be observable.
+const RETRY_OPTIONS = {
+  retries: 10,        // 11 attempts total
+  factor: 2,          // exponential growth, doubling each attempt
+  minTimeout: 1000,   // first wait = 1s
+  maxTimeout: 30000,  // cap at 30s once growth exceeds it
+  randomize: true     // jitter to avoid thundering herd across parallel shards
+}
+
 for (const envFile of ['.env', '.env.defaults']) {
   try { process.loadEnvFile(envFile) } catch {}
 }
@@ -213,13 +228,23 @@ async function createClientAsync (type) {
   performance.mark(startMark)
   const endpoint = `${provisioningUrl}/webservices/${type}`
   const url = `${endpoint}/?wsdl`
-  const client = await SOAP.createClientAsync(url, {
+  // The WSDL fetch itself can hit transient network errors (ECONNRESET,
+  // ETIMEDOUT, ...). Without retry here, a single TLS hiccup during
+  // bootstrap kills the whole job before any per-method pRetry below has
+  // a chance to run.
+  const client = await pRetry(() => SOAP.createClientAsync(url, {
     endpoint,
     suppressStack: true,
     wsdl_options: {
       forever: true
     },
     gzip: true
+  }), {
+    ...RETRY_OPTIONS,
+    onFailedAttempt: async error => {
+      if (shouldAbortRetry(error)) throw new AbortError(error)
+      console.log(`Retrying WSDL fetch (${type}) in ${error.retriesLeft} attempts (${describeError(error)})`)
+    }
   })
 
   // https://stackoverflow.com/questions/30740415/namespace-for-array-field-in-node-soap-client-node-js
@@ -246,10 +271,7 @@ async function createClientAsync (type) {
 
           try {
             const result = await pRetry(() => origMethod.apply(this, [soapOptions, { timeout: 30000, ...clientOptions }, ...args]), {
-              retries: 3,
-              minTimeout: 1000,  // Start with 1 second delay between retries
-              maxTimeout: 10000, // Cap retry delay at 10 seconds
-              randomize: true,   // Add jitter to spread out concurrent retries
+              ...RETRY_OPTIONS,
               onFailedAttempt: async error => {
                 if (shouldAbortRetry(error)) throw new AbortError(error)
                 console.log(`Retrying ${String(prop)} in ${error.retriesLeft} attempts (${describeError(error)})`)