@open-xchange/linter-presets 0.0.3 → 0.0.4

package/CHANGELOG.md

@@ -19,3 +19,7 @@
 - changed: [ESLint] environment `env.plugin` renamed to `env.eslint`
 - fixed: [StyleLint] support for LESS files
 - chore: update dependencies
+
+## [0.0.4] - 2024-07-10
+
+- fixed: [ESLint] file exists detection in rule `env-project/no-invalid-modules`

package/lib/eslint/rules/no-invalid-modules.js

@@ -21,11 +21,10 @@
 
 import { createRequire } from "node:module";
 import { posix, dirname, extname } from "node:path";
-import { existsSync } from "node:fs";
 
 import { packageUpSync } from "package-up";
 
-import { Schema, makeArray, toPosixPath, matchModuleName, getModuleName } from "../shared/rule-utils.js";
+import { Schema, makeArray, toPosixPath, isFile, matchModuleName, getModuleName } from "../shared/rule-utils.js";
 
 // constants ==================================================================
 
@@ -106,10 +105,10 @@ export default {
 
         // returns an existing alias key used by the passed module name
         const resolveAlias = moduleName => {
-            const [key, rest] = moduleName.split("/", 2);
-            const aliasPath = (key && rest) ? aliasMap.get(key) : undefined;
+            const [key, ...rest] = moduleName.split("/");
+            const aliasPath = (key && rest[0]) ? aliasMap.get(key) : undefined;
             const aliasKey = aliasPath ? key : "";
-            const modulePath = aliasPath ? posix.join(aliasPath, rest) : moduleName;
+            const modulePath = aliasPath ? posix.join(aliasPath, ...rest) : moduleName;
             return { aliasKey, modulePath };
         };
 
@@ -117,9 +116,9 @@ export default {
         const fileExists = resolvedName => {
             // check modules with explicit extension
             const resolvedPath = posix.join(rootDir, resolvedName);
-            if (extname(resolvedName)) { return existsSync(resolvedPath); }
+            if (extname(resolvedName)) { return isFile(resolvedPath); }
             // search for a file with a known extension
-            return FILE_EXTENSIONS.some(ext => existsSync(resolvedPath + "." + ext));
+            return FILE_EXTENSIONS.some(ext => isFile(resolvedPath + "." + ext));
         };
 
         // returns whether the passed module name is an installed NPM package

package/lib/eslint/shared/rule-utils.js

@@ -20,6 +20,7 @@
  */
 
 import { posix, sep } from "node:path";
+import { lstatSync } from "node:fs";
 
 import pm from "picomatch";
 
@@ -101,6 +102,24 @@ export function toPosixPath(path) {
     return path.replaceAll(sep, posix.sep);
 }
 
+/**
+ * Returns whether the passed path refers to an existing file.
+ *
+ * @param {string} path
+ *  The path to be checked.
+ *
+ * @returns {boolean}
+ *  Whether the passed path refers to an existing file (returns `false` for
+ *  existing directories).
+ */
+export function isFile(path) {
+    try {
+        return lstatSync(path).isFile();
+    } catch {
+        return false;
+    }
+}
+
 /**
  * Returns whether a module name matches the specified glob patterns.
  *

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@open-xchange/linter-presets",
-    "version": "0.0.3",
+    "version": "0.0.4",
     "description": "Configuration presets for ESLint and StyleLint",
     "repository": "https://gitlab.open-xchange.com/fspd/npm-packages/linter-presets",
     "license": "MIT",