@open-turo/eslint-config-typescript 9.0.16 → 9.0.18

package/.pre-commit-config.yaml

@@ -1,6 +1,6 @@
 repos:
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.6.0
+    rev: v5.0.0
     hooks:
       - id: check-json
       - id: check-yaml
@@ -18,6 +18,6 @@ repos:
         stages: [commit-msg]
         additional_dependencies: ["@open-turo/commitlint-config-conventional"]
   - repo: https://github.com/rhysd/actionlint
-    rev: v1.7.1
+    rev: v1.7.3
     hooks:
       - id: actionlint

package/index.js

@@ -72,22 +72,22 @@ module.exports = {
     "simple-import-sort/imports": "error",
     "simple-import-sort/exports": "error",
     "sort-destructure-keys/sort-destructure-keys": "error",
-    /**
-     * List of sonarjs rules we turned off after release of eslint-plugin-sonarjs v2
-     * Some rules are too restrictive for common use cases,
-     * and others are already covered by other plugins used here.
-     */
-    "sonarjs/different-types-comparison": "off",
+    // This rule is not helpful in TypeScript files, and in JavaScript we often return different types from functions, so this is not a strictness level we want to enforce.
     "sonarjs/function-return-type": "off",
-    "sonarjs/no-clear-text-protocols": "warn",
+    // We may want to catch errors but not use the error object directly, just trigger error handling fallbacks within the catch block.
     "sonarjs/no-ignored-exceptions": "off",
-    "sonarjs/no-misused-promises": "off",
-    "sonarjs/no-nested-functions": "off",
+    "sonarjs/no-nested-functions": ["warn", { threshold: 5 }],
+    // Overlaps with @typescript-eslint/prefer-nullish-coalescing
     "sonarjs/prefer-nullish-coalescing": "off",
+    // Overlaps with @typescript-eslint/no-unused-vars
     "sonarjs/sonar-no-unused-vars": "off",
+    // Overlaps with @typescript-eslint/prefer-optional-chain
     "sonarjs/sonar-prefer-optional-chain": "off",
+    // Useful for guarding against prop mutation in React, but too much of a lift as very rarely do we apply readonly/ReadonlyArray<T> to type definitions
     "sonarjs/sonar-prefer-read-only-props": "off",
+    // Noisy rule: if we wanted stricter linting of TODOs, we could use unicorn/expiring-todo-comments
     "sonarjs/todo-tag": "off",
+    // A useful rule to consider for libraries to better document (and export) type definitions, but noisy in app usages (especially around redux type definitions)
     "sonarjs/use-type-alias": "off",
     /**
      * {@link https://typescript-eslint.io/rules/consistent-type-imports | TypeScript ESLint: consistent-type-imports docs}

package/legacy.js

@@ -73,22 +73,22 @@ module.exports = {
     "simple-import-sort/imports": "error",
     "simple-import-sort/exports": "error",
     "sort-destructure-keys/sort-destructure-keys": "error",
-    /**
-     * List of sonarjs rules we turned off after release of eslint-plugin-sonarjs v2
-     * Some rules are too restrictive for common use cases,
-     * and others are already covered by other plugins used here.
-     */
-    "sonarjs/different-types-comparison": "off",
+    // This rule is not helpful in TypeScript files, and in JavaScript we often return different types from functions, so this is not a strictness level we want to enforce.
     "sonarjs/function-return-type": "off",
-    "sonarjs/no-clear-text-protocols": "warn",
+    // We may want to catch errors but not use the error object directly, just trigger error handling fallbacks within the catch block.
     "sonarjs/no-ignored-exceptions": "off",
-    "sonarjs/no-misused-promises": "off",
-    "sonarjs/no-nested-functions": "off",
+    "sonarjs/no-nested-functions": ["warn", { threshold: 5 }],
+    // Overlaps with @typescript-eslint/prefer-nullish-coalescing
     "sonarjs/prefer-nullish-coalescing": "off",
+    // Overlaps with @typescript-eslint/no-unused-vars
     "sonarjs/sonar-no-unused-vars": "off",
+    // Overlaps with @typescript-eslint/prefer-optional-chain
     "sonarjs/sonar-prefer-optional-chain": "off",
+    // Useful for guarding against prop mutation in React, but too much of a lift as very rarely do we apply readonly/ReadonlyArray<T> to type definitions
     "sonarjs/sonar-prefer-read-only-props": "off",
+    // Noisy rule: if we wanted stricter linting of TODOs, we could use unicorn/expiring-todo-comments
     "sonarjs/todo-tag": "off",
+    // A useful rule to consider for libraries to better document (and export) type definitions, but noisy in app usages (especially around redux type definitions)
     "sonarjs/use-type-alias": "off",
     "@typescript-eslint/no-unused-vars": [
       "error",

package/package.json

@@ -15,10 +15,10 @@
     "eslint-plugin-sonarjs": "2.0.2",
     "eslint-plugin-sort-destructure-keys": "2.0.0",
     "eslint-plugin-typescript-sort-keys": "3.2.0",
-    "eslint-plugin-unicorn": "55.0.0"
+    "eslint-plugin-unicorn": "56.0.0"
   },
   "devDependencies": {
-    "eslint": "8.57.0",
+    "eslint": "8.57.1",
     "jest": "29.7.0",
     "prettier": "3.3.3"
   },
@@ -42,5 +42,5 @@
     "access": "public"
   },
   "repository": "https://github.com/open-turo/eslint-config-typescript",
-  "version": "9.0.16"
+  "version": "9.0.18"
 }