@open-turo/eslint-config-typescript 9.0.15 → 9.0.17

package/.github/workflows/ci.yaml

@@ -14,7 +14,7 @@ jobs:
           mkdir -p "$HOME/bin"
           bash <(curl https://raw.githubusercontent.com/rhysd/actionlint/main/scripts/download-actionlint.bash) latest "$HOME/bin"
           echo "${HOME}/bin" >> "$GITHUB_PATH"
-      - uses: open-turo/actions-node/lint@v5
+      - uses: open-turo/actions-node/lint@v6
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           npm-token: ${{ secrets.OPEN_TURO_NPM_TOKEN }}
@@ -22,7 +22,7 @@ jobs:
     name: Test
     runs-on: ubuntu-latest
     steps:
-      - uses: open-turo/actions-node/test@v5
+      - uses: open-turo/actions-node/test@v6
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           test-flags: --coverage

package/.github/workflows/release.yaml

@@ -10,7 +10,7 @@ jobs:
     name: Release
     runs-on: ubuntu-latest
     steps:
-      - uses: open-turo/actions-node/release@v5
+      - uses: open-turo/actions-node/release@v6
         with:
           github-token: ${{ secrets.OPEN_TURO_GITHUB_TOKEN }}
           npm-token: ${{ secrets.OPEN_TURO_NPM_TOKEN }}

package/index.js

@@ -72,22 +72,22 @@ module.exports = {
     "simple-import-sort/imports": "error",
     "simple-import-sort/exports": "error",
     "sort-destructure-keys/sort-destructure-keys": "error",
-    /**
-     * List of sonarjs rules we turned off after release of eslint-plugin-sonarjs v2
-     * Some rules are too restrictive for common use cases,
-     * and others are already covered by other plugins used here.
-     */
-    "sonarjs/different-types-comparison": "off",
+    // This rule is not helpful in TypeScript files, and in JavaScript we often return different types from functions, so this is not a strictness level we want to enforce.
     "sonarjs/function-return-type": "off",
-    "sonarjs/no-clear-text-protocols": "warn",
+    // We may want to catch errors but not use the error object directly, just trigger error handling fallbacks within the catch block.
     "sonarjs/no-ignored-exceptions": "off",
-    "sonarjs/no-misused-promises": "off",
-    "sonarjs/no-nested-functions": "off",
+    "sonarjs/no-nested-functions": ["warn", { threshold: 5 }],
+    // Overlaps with @typescript-eslint/prefer-nullish-coalescing
     "sonarjs/prefer-nullish-coalescing": "off",
+    // Overlaps with @typescript-eslint/no-unused-vars
     "sonarjs/sonar-no-unused-vars": "off",
+    // Overlaps with @typescript-eslint/prefer-optional-chain
     "sonarjs/sonar-prefer-optional-chain": "off",
+    // Useful for guarding against prop mutation in React, but too much of a lift as very rarely do we apply readonly/ReadonlyArray<T> to type definitions
     "sonarjs/sonar-prefer-read-only-props": "off",
+    // Noisy rule: if we wanted stricter linting of TODOs, we could use unicorn/expiring-todo-comments
     "sonarjs/todo-tag": "off",
+    // A useful rule to consider for libraries to better document (and export) type definitions, but noisy in app usages (especially around redux type definitions)
     "sonarjs/use-type-alias": "off",
     /**
      * {@link https://typescript-eslint.io/rules/consistent-type-imports | TypeScript ESLint: consistent-type-imports docs}

package/legacy.js

@@ -73,22 +73,22 @@ module.exports = {
     "simple-import-sort/imports": "error",
     "simple-import-sort/exports": "error",
     "sort-destructure-keys/sort-destructure-keys": "error",
-    /**
-     * List of sonarjs rules we turned off after release of eslint-plugin-sonarjs v2
-     * Some rules are too restrictive for common use cases,
-     * and others are already covered by other plugins used here.
-     */
-    "sonarjs/different-types-comparison": "off",
+    // This rule is not helpful in TypeScript files, and in JavaScript we often return different types from functions, so this is not a strictness level we want to enforce.
     "sonarjs/function-return-type": "off",
-    "sonarjs/no-clear-text-protocols": "warn",
+    // We may want to catch errors but not use the error object directly, just trigger error handling fallbacks within the catch block.
     "sonarjs/no-ignored-exceptions": "off",
-    "sonarjs/no-misused-promises": "off",
-    "sonarjs/no-nested-functions": "off",
+    "sonarjs/no-nested-functions": ["warn", { threshold: 5 }],
+    // Overlaps with @typescript-eslint/prefer-nullish-coalescing
     "sonarjs/prefer-nullish-coalescing": "off",
+    // Overlaps with @typescript-eslint/no-unused-vars
     "sonarjs/sonar-no-unused-vars": "off",
+    // Overlaps with @typescript-eslint/prefer-optional-chain
     "sonarjs/sonar-prefer-optional-chain": "off",
+    // Useful for guarding against prop mutation in React, but too much of a lift as very rarely do we apply readonly/ReadonlyArray<T> to type definitions
     "sonarjs/sonar-prefer-read-only-props": "off",
+    // Noisy rule: if we wanted stricter linting of TODOs, we could use unicorn/expiring-todo-comments
     "sonarjs/todo-tag": "off",
+    // A useful rule to consider for libraries to better document (and export) type definitions, but noisy in app usages (especially around redux type definitions)
     "sonarjs/use-type-alias": "off",
     "@typescript-eslint/no-unused-vars": [
       "error",

package/package.json

@@ -7,7 +7,7 @@
     "eslint-config-prettier": "9.1.0",
     "eslint-import-resolver-typescript": "3.6.3",
     "eslint-plugin-import": "2.30.0",
-    "eslint-plugin-jest": "28.8.2",
+    "eslint-plugin-jest": "28.8.3",
     "eslint-plugin-json": "4.0.1",
     "eslint-plugin-node": "11.1.0",
     "eslint-plugin-prettier": "5.2.1",
@@ -42,5 +42,5 @@
     "access": "public"
   },
   "repository": "https://github.com/open-turo/eslint-config-typescript",
-  "version": "9.0.15"
+  "version": "9.0.17"
 }