@open-turo/eslint-config-typescript 23.1.7 → 23.1.8

package/index.js

@@ -124,6 +124,8 @@ const sonarJsConfig = () =>
   eslintConfig.defineConfig({
     extends: [sonarjsPlugin.configs.recommended],
     rules: {
+      /** Some of our specs as written trigger on this rule even though they would error as written (e.g. `await findBy*` errors) */
+      "sonarjs/assertions-in-tests": "off",
       // Noisy rule - we may have helpers/methods that we mark as @deprecated but aren't planning to remove in the near future. This rule also significantly adds to eslint running time, which slows down both local development and CI.
       "sonarjs/deprecation": "off",
       // This rule is not helpful in TypeScript files, and in JavaScript we often return different types from functions, so this is not a strictness level we want to enforce.
@@ -132,6 +134,8 @@ const sonarJsConfig = () =>
       "sonarjs/no-async-constructor": "off",
       // Performance issues, inconsistent behavior, and primarily catches edge cases rather than common issues
       "sonarjs/no-dead-store": "off",
+      /** This rule only triggers in our test suite, and is noisy. */
+      "sonarjs/no-floating-point-equality": "off",
       // We may want to catch errors but not use the error object directly, just trigger error handling fallbacks within the catch block.
       "sonarjs/no-ignored-exceptions": "off",
       "sonarjs/no-nested-functions": ["warn", { threshold: 5 }],
@@ -144,6 +148,8 @@ const sonarJsConfig = () =>
       "sonarjs/prefer-optional-chain": "off",
       // Useful for guarding against prop mutation in React, but too much of a lift as very rarely do we apply readonly/ReadonlyArray<T> to type definitions
       "sonarjs/prefer-read-only-props": "off",
+      /** This rule errors on assertions that are already easy to read. It's unnecessary friction. */
+      "sonarjs/prefer-specific-assertions": "off",
       // Noisy rule: if we wanted stricter linting of TODOs, we could use unicorn/expiring-todo-comments
       "sonarjs/todo-tag": "off",
       // A useful rule to consider for libraries to better document (and export) type definitions, but noisy in app usages (especially around redux type definitions)

package/package.json

@@ -6,7 +6,7 @@
     "@eslint/js": "9.39.4",
     "@typescript-eslint/eslint-plugin": "8.62.1",
     "@typescript-eslint/parser": "8.62.1",
-    "@vitest/eslint-plugin": "1.6.20",
+    "@vitest/eslint-plugin": "1.6.21",
     "eslint-config-prettier": "10.1.8",
     "eslint-import-resolver-typescript": "4.4.5",
     "eslint-plugin-import": "2.32.0",
@@ -57,6 +57,6 @@
     "access": "public"
   },
   "repository": "https://github.com/open-turo/eslint-config-typescript",
-  "version": "23.1.7",
+  "version": "23.1.8",
   "packageManager": "npm@11.18.0"
 }

package/test/__snapshots__/test.spec.js.snap

@@ -1848,7 +1848,7 @@ exports[`validate config the flat config is correct for index.js 1`] = `
     },
   ],
   "sonarjs/assertions-in-tests": [
-    2,
+    0,
   ],
   "sonarjs/async-test-assertions": [
     2,
@@ -2257,7 +2257,7 @@ exports[`validate config the flat config is correct for index.js 1`] = `
     2,
   ],
   "sonarjs/no-floating-point-equality": [
-    2,
+    0,
   ],
   "sonarjs/no-for-in-iterable": [
     0,
@@ -2578,7 +2578,7 @@ exports[`validate config the flat config is correct for index.js 1`] = `
     2,
   ],
   "sonarjs/prefer-specific-assertions": [
-    2,
+    0,
   ],
   "sonarjs/prefer-type-guard": [
     2,
@@ -5135,7 +5135,7 @@ exports[`validate config the flat config is correct for index.mjs 1`] = `
     },
   ],
   "sonarjs/assertions-in-tests": [
-    2,
+    0,
   ],
   "sonarjs/async-test-assertions": [
     2,
@@ -5544,7 +5544,7 @@ exports[`validate config the flat config is correct for index.mjs 1`] = `
     2,
   ],
   "sonarjs/no-floating-point-equality": [
-    2,
+    0,
   ],
   "sonarjs/no-for-in-iterable": [
     0,
@@ -5865,7 +5865,7 @@ exports[`validate config the flat config is correct for index.mjs 1`] = `
     2,
   ],
   "sonarjs/prefer-specific-assertions": [
-    2,
+    0,
   ],
   "sonarjs/prefer-type-guard": [
     2,
@@ -8422,7 +8422,7 @@ exports[`validate config the flat config with vitest is correct for index.js 1`]
     },
   ],
   "sonarjs/assertions-in-tests": [
-    2,
+    0,
   ],
   "sonarjs/async-test-assertions": [
     2,
@@ -8831,7 +8831,7 @@ exports[`validate config the flat config with vitest is correct for index.js 1`]
     2,
   ],
   "sonarjs/no-floating-point-equality": [
-    2,
+    0,
   ],
   "sonarjs/no-for-in-iterable": [
     0,
@@ -9152,7 +9152,7 @@ exports[`validate config the flat config with vitest is correct for index.js 1`]
     2,
   ],
   "sonarjs/prefer-specific-assertions": [
-    2,
+    0,
   ],
   "sonarjs/prefer-type-guard": [
     2,
@@ -11796,7 +11796,7 @@ exports[`validate config the flat config with vitest is correct for index.mjs 1`
     },
   ],
   "sonarjs/assertions-in-tests": [
-    2,
+    0,
   ],
   "sonarjs/async-test-assertions": [
     2,
@@ -12205,7 +12205,7 @@ exports[`validate config the flat config with vitest is correct for index.mjs 1`
     2,
   ],
   "sonarjs/no-floating-point-equality": [
-    2,
+    0,
   ],
   "sonarjs/no-for-in-iterable": [
     0,
@@ -12526,7 +12526,7 @@ exports[`validate config the flat config with vitest is correct for index.mjs 1`
     2,
   ],
   "sonarjs/prefer-specific-assertions": [
-    2,
+    0,
   ],
   "sonarjs/prefer-type-guard": [
     2,