@open-turo/eslint-config-typescript 16.0.0-pr-373.9.1.1 → 16.0.0-pr-373.10.1.1

package/index.cjs

@@ -10,6 +10,7 @@ const sonarjsPlugin = require("eslint-plugin-sonarjs");
 const unicornPlugin = require("eslint-plugin-unicorn");
 const tseslint = require("typescript-eslint");
 
+const FILES_JS = "**/*.?([cm])js";
 const FILES_SRC_EXTENSION = "?([cm])[jt]s?(x)";
 const FILES_TS = "**/*.?([cm])ts";
 const FILES_TSX = "**/*.?([cm])tsx";
@@ -27,6 +28,16 @@ const typescriptLanguageOptions = () => ({
   },
 });
 
+const javascriptConfig = (ecmaVersion = "latest") =>
+  tseslint.config(eslint.configs.recommended, {
+    files: [FILES_JS],
+    languageOptions: {
+      parserOptions: {
+        ecmaVersion,
+      },
+    },
+  });
+
 const importConfig = () =>
   tseslint.config({
     extends: [importPlugin.flatConfigs.recommended],
@@ -186,13 +197,14 @@ const ignoresConfig = (ignores = []) =>
  * @param [options.allowModules] - List of modules to allow in the n/no-unpublished-import rule
  * @param [options.ignores] - List of patterns to ignore
  * @param [options.typescript] - Whether to include typescript rules
+ * @param [options.ecmaVersion] - The ECMAScript version to use
  * @returns {ConfigArray}
  */
 module.exports = function config(options = {}) {
   const useTypescript =
     options.typescript === undefined ? true : options.typescript;
   return tseslint.config(
-    eslint.configs.recommended,
+    javascriptConfig(options.ecmaVersion),
     importConfig(),
     nPluginConfig(options.allowModules),
     perfectionistPlugin.configs["recommended-alphabetical"],

package/package.json

@@ -54,5 +54,5 @@
     "access": "public"
   },
   "repository": "https://github.com/open-turo/eslint-config-typescript",
-  "version": "16.0.0-pr-373.9.1.1"
+  "version": "16.0.0-pr-373.10.1.1"
 }

package/test/test.spec.js

@@ -1,44 +1,52 @@
 import { loadESLint } from "eslint";
 
 describe("validate config", () => {
-  test.each(["./index.mjs", "./index.cjs", "./recommended.cjs"])(
-    `load config file in ESLint to validate all rules are correct for %s`,
-    async (config) => {
-      const testFileName = "test.js";
-      const useFlatConfig = !config.includes("recommended");
+  const testFileName = "test.js";
+  const code = `const foo = 1;\nconsole.log(foo);\n`;
+  const parserOptions = {
+    projectService: {
+      allowDefaultProject: [testFileName],
+    },
+  };
+
+  test("the legacy recommended config is correct", async () => {
+    const ESLint = await loadESLint({
+      useFlatConfig: false,
+    });
+    const linter = new ESLint({
+      overrideConfig: {
+        parserOptions,
+      },
+      overrideConfigFile: "./recommended.cjs",
+    });
+    const messages = await linter.lintText(code, {
+      filePath: testFileName,
+    });
+    expect(messages[0].messages).toEqual([]);
+    expect(messages[0].errorCount).toEqual(0);
+  });
+
+  test.each(["index.mjs", "index.cjs"])(
+    `the flat config is correct for %s`,
+    async (configFile) => {
       const ESLint = await loadESLint({
-        useFlatConfig,
+        useFlatConfig: true,
       });
+      const { default: config } = await import(`../${configFile}`);
       const linter = new ESLint({
-        overrideConfig: useFlatConfig
-          ? [
-              {
-                files: [testFileName],
-                languageOptions: {
-                  parserOptions: {
-                    projectService: {
-                      allowDefaultProject: [testFileName],
-                    },
-                  },
-                },
-              },
-            ]
-          : {
-              parserOptions: {
-                projectService: {
-                  allowDefaultProject: [testFileName],
-                },
-              },
+        baseConfig: config(),
+        overrideConfig: [
+          {
+            files: [testFileName],
+            languageOptions: {
+              parserOptions,
             },
-        // cwd: cwd,
-        overrideConfigFile: config,
+          },
+        ],
+      });
+      const messages = await linter.lintText(code, {
+        filePath: testFileName,
       });
-      const messages = await linter.lintText(
-        `const foo = 1;\nconsole.log(foo);\n`,
-        {
-          filePath: testFileName,
-        },
-      );
       expect(messages[0].messages).toEqual([]);
       expect(messages[0].errorCount).toEqual(0);
     },