@open-mercato/ui 0.8.1-develop.7218.1.9f22882799 → 0.8.1-develop.7219.1.f96cb57e70

package/build.mjs

@@ -1,22 +1,49 @@
-import { writeFileSync } from 'node:fs'
+import { existsSync, readFileSync, writeFileSync } from 'node:fs'
 import { dirname, join } from 'node:path'
 import { fileURLToPath } from 'node:url'
 import { buildPackage } from '../../scripts/build-package.mjs'
 import { discoverResolvedIcons } from './scripts/lucideIconDiscovery.cjs'
-import { buildLucideRegistrySource } from './scripts/lucideRegistrySource.cjs'
+import { buildLucideRegistrySource, checkLucideRegistryDrift } from './scripts/lucideRegistrySource.cjs'
 
 const packageDir = dirname(fileURLToPath(import.meta.url))
+// `--check` regenerates the lucide registry in memory and fails on drift
+// without writing or building — the CI guard mode (`yarn ui:icons:check`).
+const checkOnly = process.argv.includes('--check')
 
 async function generateLucideRegistry() {
   const repoRoot = join(packageDir, '..', '..')
   const resolved = await discoverResolvedIcons(repoRoot)
 
   const outPath = join(packageDir, 'src/backend/icons/lucideRegistry.generated.tsx')
-  writeFileSync(outPath, buildLucideRegistrySource(resolved))
+  const source = buildLucideRegistrySource(resolved)
+
+  // `--check` makes this a drift guard instead of a writer. The committed
+  // registry is a canonical mirror of a repo-wide scan, so nothing inside
+  // `packages/ui`'s own test suite can protect it: a PR that adds
+  // `icon: 'some-lucide-name'` in another package never selects `packages/ui`
+  // under turbo's `--filter=[base]...` (ui is a dependency of those packages,
+  // not a dependent), which is exactly how #4391 drifted unnoticed. CI calls
+  // this unfiltered, mirroring `ds:tokens:check`.
+  if (checkOnly) {
+    const committed = existsSync(outPath) ? readFileSync(outPath, 'utf8') : ''
+    const drift = checkLucideRegistryDrift(committed, source, outPath)
+    if (drift.drifted) {
+      console.error(drift.message)
+      process.exit(1)
+    }
+    console.log(`Lucide registry is in sync (${resolved.length} icons).`)
+    return
+  }
+
+  writeFileSync(outPath, source)
   console.log(`Generated lucide registry with ${resolved.length} icons -> ${outPath}`)
 }
 
-await buildPackage(packageDir, {
-  name: 'ui',
-  beforeBuild: generateLucideRegistry,
-})
+if (checkOnly) {
+  await generateLucideRegistry()
+} else {
+  await buildPackage(packageDir, {
+    name: 'ui',
+    beforeBuild: generateLucideRegistry,
+  })
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@open-mercato/ui",
-  "version": "0.8.1-develop.7218.1.9f22882799",
+  "version": "0.8.1-develop.7219.1.f96cb57e70",
   "license": "MIT",
   "type": "module",
   "main": "./dist/index.js",
@@ -155,14 +155,14 @@
     "remark-gfm": "^4.0.1"
   },
   "peerDependencies": {
-    "@open-mercato/shared": "0.8.1-develop.7218.1.9f22882799",
+    "@open-mercato/shared": "0.8.1-develop.7219.1.f96cb57e70",
     "react": ">=18.0.0",
     "react-dom": ">=18.0.0",
     "react-is": ">=18.0.0"
   },
   "devDependencies": {
     "@figma/code-connect": "^1.3.4",
-    "@open-mercato/shared": "0.8.1-develop.7218.1.9f22882799",
+    "@open-mercato/shared": "0.8.1-develop.7219.1.f96cb57e70",
     "@testing-library/dom": "^10.4.1",
     "@testing-library/jest-dom": "^7.0.1",
     "@testing-library/react": "^16.3.3",

package/scripts/lucideRegistrySource.cjs

@@ -130,4 +130,19 @@ function buildLucideRegistrySource(resolvedIcons) {
   return normalizeSourceText(sourceFile.getFullText())
 }
 
-module.exports = { buildLucideRegistrySource }
+// Drift decision for the committed registry, kept here rather than inline in
+// build.mjs so it is reachable from Jest: build.mjs's top level awaits a full
+// package build, so nothing can import it to exercise this comparison. The
+// caller owns reporting and the exit code; this only decides.
+function checkLucideRegistryDrift(committedSource, generatedSource, registryPath = GENERATED_FILE_NAME) {
+  if (committedSource === generatedSource) return { drifted: false }
+
+  return {
+    drifted: true,
+    message: `Lucide icon registry is out of date: ${registryPath}\n`
+      + 'A referenced icon name was added or removed without regenerating it.\n'
+      + 'Run `yarn workspace @open-mercato/ui build` and commit the result.',
+  }
+}
+
+module.exports = { buildLucideRegistrySource, checkLucideRegistryDrift }

package/src/backend/icons/__tests__/lucideRegistryGenerator.test.ts

@@ -4,7 +4,7 @@ import { tmpdir } from 'node:os'
 import { join } from 'node:path'
 import { Project, ScriptKind, SyntaxKind, type ObjectLiteralExpression, type SourceFile } from 'ts-morph'
 import { discoverResolvedIcons } from '../../../../scripts/lucideIconDiscovery.cjs'
-import { buildLucideRegistrySource } from '../../../../scripts/lucideRegistrySource.cjs'
+import { buildLucideRegistrySource, checkLucideRegistryDrift } from '../../../../scripts/lucideRegistrySource.cjs'
 import jestConfig from '../../../../jest.config.cjs'
 
 const packageDir = join(__dirname, '..', '..', '..', '..')
@@ -272,6 +272,32 @@ describe('committed lucideRegistry.generated.tsx', () => {
   })
 })
 
+// `yarn ui:icons:check` runs this decision unfiltered in CI, where only the in-sync
+// branch is ever exercised — every PR runs it against a registry that matches. The
+// branch that does the work is the drifted one, so it is asserted here instead.
+describe('checkLucideRegistryDrift', () => {
+  const source = buildLucideRegistrySource(populatedFixture)
+
+  it('reports no drift when the committed file matches the emitter', () => {
+    expect(checkLucideRegistryDrift(source, source)).toEqual({ drifted: false })
+  })
+
+  it('reports drift when an icon is missing from the committed file', () => {
+    const stale = buildLucideRegistrySource(populatedFixture.slice(0, -1))
+    expect(checkLucideRegistryDrift(stale, source).drifted).toBe(true)
+  })
+
+  it('reports drift when the committed file has never been written', () => {
+    expect(checkLucideRegistryDrift('', source).drifted).toBe(true)
+  })
+
+  it('names the drifted file and the command that regenerates it', () => {
+    const drift = checkLucideRegistryDrift('', source, '/repo/lucideRegistry.generated.tsx')
+    expect(drift.message).toContain('/repo/lucideRegistry.generated.tsx')
+    expect(drift.message).toContain('yarn workspace @open-mercato/ui build')
+  })
+})
+
 describe('jest transform scope', () => {
   const transformPatterns = Object.keys(jestConfig.transform).map((key) => new RegExp(key))