@open-mercato/ui 0.7.1-develop.7131.1.20abf9e885 → 0.7.1-develop.7135.1.19bf969756

package/build.mjs

@@ -1,93 +1,15 @@
-import { glob } from 'glob'
-import { readFileSync, writeFileSync } from 'node:fs'
+import { writeFileSync } from 'node:fs'
 import { dirname, join } from 'node:path'
 import { fileURLToPath } from 'node:url'
 import { buildPackage } from '../../scripts/build-package.mjs'
+import { discoverResolvedIcons } from './scripts/lucideIconDiscovery.cjs'
 import { buildLucideRegistrySource } from './scripts/lucideRegistrySource.cjs'
 
 const packageDir = dirname(fileURLToPath(import.meta.url))
 
-function normalizeKebabIconName(input) {
-  const trimmed = input.trim()
-  if (!trimmed) return ''
-  const withoutPrefix = trimmed.startsWith('lucide:') ? trimmed.slice('lucide:'.length) : trimmed
-  if (!withoutPrefix) return ''
-  if (!withoutPrefix.includes('-') && !withoutPrefix.includes('_') && !withoutPrefix.includes(' ') && /[A-Z]/.test(withoutPrefix)) {
-    return withoutPrefix
-      .replace(/([a-z0-9])([A-Z])/g, '$1-$2')
-      .replace(/([A-Z])([A-Z][a-z])/g, '$1-$2')
-      .toLowerCase()
-  }
-  return withoutPrefix
-    .replace(/[_\s]+/g, '-')
-    .replace(/-+/g, '-')
-    .toLowerCase()
-}
-
-function kebabToLucideExportName(kebab) {
-  return kebab
-    .split('-')
-    .filter(Boolean)
-    .map((part) => {
-      if (/^\d+$/.test(part)) return part
-      return part.charAt(0).toUpperCase() + part.slice(1)
-    })
-    .join('')
-}
-
 async function generateLucideRegistry() {
   const repoRoot = join(packageDir, '..', '..')
-  const candidateFiles = await glob(['apps/**/*.{ts,tsx}', 'packages/**/*.{ts,tsx}'], {
-    cwd: repoRoot,
-    absolute: true,
-    ignore: [
-      '**/node_modules/**',
-      '**/dist/**',
-      '**/.mercato/**',
-      'packages/core/generated/**',
-      '**/__tests__/**',
-      '**/*.test.ts',
-      '**/*.test.tsx',
-      '**/*.generated.ts',
-      '**/*.generated.tsx',
-      '**/*.d.ts',
-    ],
-  })
-
-  const iconStrings = new Set()
-  const patterns = [
-    /\bicon\s*:\s*['"`]([^'"`]+)['"`]/g,
-    /\bicon\s*=\s*['"`]([^'"`]+)['"`]/g,
-  ]
-
-  for (const absPath of candidateFiles) {
-    const content = readFileSync(absPath, 'utf-8')
-    for (const pattern of patterns) {
-      pattern.lastIndex = 0
-      for (;;) {
-        const match = pattern.exec(content)
-        if (!match) break
-        const raw = match[1]
-        if (!raw) continue
-        const normalized = normalizeKebabIconName(raw)
-        if (!normalized) continue
-        iconStrings.add(normalized)
-      }
-    }
-  }
-
-  const lucide = await import('lucide-react')
-  const exportKeys = new Set(Object.keys(lucide))
-  const excludedLucideExports = new Set(['Icon'])
-
-  const resolved = []
-  for (const name of iconStrings) {
-    const exportName = kebabToLucideExportName(name)
-    if (excludedLucideExports.has(exportName)) continue
-    if (exportKeys.has(exportName)) {
-      resolved.push({ kebab: name, exportName })
-    }
-  }
+  const resolved = await discoverResolvedIcons(repoRoot)
 
   const outPath = join(packageDir, 'src/backend/icons/lucideRegistry.generated.tsx')
   writeFileSync(outPath, buildLucideRegistrySource(resolved))

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@open-mercato/ui",
-  "version": "0.7.1-develop.7131.1.20abf9e885",
+  "version": "0.7.1-develop.7135.1.19bf969756",
   "license": "MIT",
   "type": "module",
   "main": "./dist/index.js",
@@ -155,20 +155,21 @@
     "remark-gfm": "^4.0.1"
   },
   "peerDependencies": {
-    "@open-mercato/shared": "0.7.1-develop.7131.1.20abf9e885",
+    "@open-mercato/shared": "0.7.1-develop.7135.1.19bf969756",
     "react": ">=18.0.0",
     "react-dom": ">=18.0.0",
     "react-is": ">=18.0.0"
   },
   "devDependencies": {
     "@figma/code-connect": "^1.3.4",
-    "@open-mercato/shared": "0.7.1-develop.7131.1.20abf9e885",
+    "@open-mercato/shared": "0.7.1-develop.7135.1.19bf969756",
     "@testing-library/dom": "^10.4.1",
     "@testing-library/jest-dom": "^7.0.0",
     "@testing-library/react": "^16.3.1",
     "@types/jest": "^30.0.0",
     "@types/react": "^19.2.17",
     "@types/react-dom": "^19.2.3",
+    "glob": "^13.0.6",
     "jest": "^30.4.2",
     "jest-environment-jsdom": "^30.4.1",
     "react": "19.2.8",

package/scripts/lucideIconDiscovery.cjs

@@ -0,0 +1,108 @@
+// Pure discovery pass feeding src/backend/icons/lucideRegistry.generated.tsx.
+// Kept side-effect free, and CommonJS so both build.mjs and the Jest suite can load it.
+
+const { glob } = require('glob')
+const { readFileSync } = require('node:fs')
+
+const SOURCE_GLOBS = ['apps/**/*.{ts,tsx}', 'packages/**/*.{ts,tsx}']
+
+const IGNORED_GLOBS = [
+  '**/node_modules/**',
+  '**/dist/**',
+  '**/.mercato/**',
+  'packages/core/generated/**',
+  '**/__tests__/**',
+  '**/*.test.ts',
+  '**/*.test.tsx',
+  '**/*.generated.ts',
+  '**/*.generated.tsx',
+  '**/*.d.ts',
+]
+
+const ICON_STRING_PATTERNS = [
+  /\bicon\s*:\s*['"`]([^'"`]+)['"`]/g,
+  /\bicon\s*=\s*['"`]([^'"`]+)['"`]/g,
+]
+
+const EXCLUDED_LUCIDE_EXPORTS = new Set(['Icon'])
+
+function normalizeKebabIconName(input) {
+  const trimmed = input.trim()
+  if (!trimmed) return ''
+  const withoutPrefix = trimmed.startsWith('lucide:') ? trimmed.slice('lucide:'.length) : trimmed
+  if (!withoutPrefix) return ''
+  if (!withoutPrefix.includes('-') && !withoutPrefix.includes('_') && !withoutPrefix.includes(' ') && /[A-Z]/.test(withoutPrefix)) {
+    return withoutPrefix
+      .replace(/([a-z0-9])([A-Z])/g, '$1-$2')
+      .replace(/([A-Z])([A-Z][a-z])/g, '$1-$2')
+      .toLowerCase()
+  }
+  return withoutPrefix
+    .replace(/[_\s]+/g, '-')
+    .replace(/-+/g, '-')
+    .toLowerCase()
+}
+
+function kebabToLucideExportName(kebab) {
+  return kebab
+    .split('-')
+    .filter(Boolean)
+    .map((part) => {
+      if (/^\d+$/.test(part)) return part
+      return part.charAt(0).toUpperCase() + part.slice(1)
+    })
+    .join('')
+}
+
+async function discoverIconNames(repoRoot) {
+  const candidateFiles = await glob(SOURCE_GLOBS, {
+    cwd: repoRoot,
+    absolute: true,
+    ignore: IGNORED_GLOBS,
+  })
+
+  const iconStrings = new Set()
+  for (const absPath of candidateFiles) {
+    const content = readFileSync(absPath, 'utf-8')
+    for (const pattern of ICON_STRING_PATTERNS) {
+      pattern.lastIndex = 0
+      for (;;) {
+        const match = pattern.exec(content)
+        if (!match) break
+        const raw = match[1]
+        if (!raw) continue
+        const normalized = normalizeKebabIconName(raw)
+        if (!normalized) continue
+        iconStrings.add(normalized)
+      }
+    }
+  }
+
+  return iconStrings
+}
+
+function resolveIconNames(iconNames, exportNames) {
+  const exportKeys = exportNames instanceof Set ? exportNames : new Set(exportNames)
+  const resolved = []
+  for (const kebab of iconNames) {
+    const exportName = kebabToLucideExportName(kebab)
+    if (EXCLUDED_LUCIDE_EXPORTS.has(exportName)) continue
+    if (exportKeys.has(exportName)) {
+      resolved.push({ kebab, exportName })
+    }
+  }
+  return resolved
+}
+
+async function discoverResolvedIcons(repoRoot) {
+  const lucide = await import('lucide-react')
+  return resolveIconNames(await discoverIconNames(repoRoot), Object.keys(lucide))
+}
+
+module.exports = {
+  normalizeKebabIconName,
+  kebabToLucideExportName,
+  discoverIconNames,
+  resolveIconNames,
+  discoverResolvedIcons,
+}

package/src/backend/icons/__tests__/lucideRegistryGenerator.test.ts

@@ -1,8 +1,9 @@
 import { execFileSync } from 'node:child_process'
-import { readFileSync } from 'node:fs'
+import { existsSync, readFileSync } from 'node:fs'
 import { tmpdir } from 'node:os'
 import { join } from 'node:path'
 import { Project, ScriptKind, SyntaxKind, type ObjectLiteralExpression, type SourceFile } from 'ts-morph'
+import { discoverResolvedIcons } from '../../../../scripts/lucideIconDiscovery.cjs'
 import { buildLucideRegistrySource } from '../../../../scripts/lucideRegistrySource.cjs'
 import jestConfig from '../../../../jest.config.cjs'
 
@@ -225,6 +226,52 @@ describe('lucideRegistry.generated importers', () => {
   })
 })
 
+type MonorepoProbe = { available: true } | { available: false; reason: string }
+
+function detectMonorepoCheckout(repoRoot: string): MonorepoProbe {
+  const generatorPath = join(repoRoot, 'packages', 'ui', 'build.mjs')
+  if (!existsSync(generatorPath)) return { available: false, reason: `${generatorPath} is missing` }
+  return { available: true }
+}
+
+// The registry is build output, so a module can reference an icon string and merge
+// while the committed file still lacks it — the icon then silently renders as nothing.
+// Running the real discovery pass here turns that drift into a failing test.
+describe('committed lucideRegistry.generated.tsx', () => {
+  const repoRoot = join(packageDir, '..', '..')
+  const committedSource = readFileSync(join(iconsDir, 'lucideRegistry.generated.tsx'), 'utf-8')
+  const regenerationHint = 'run `yarn build:packages` and commit the regenerated file'
+  // The scan reads the repo, so — like the `git grep` guard above — it can only run
+  // inside the monorepo. Published tarballs ship these tests without the sources they
+  // scan, where an empty scan would fail an invariant it cannot evaluate rather than
+  // report real drift. There, this degrades to a skip that states why.
+  const checkout = detectMonorepoCheckout(repoRoot)
+  const itInsideMonorepo = checkout.available ? it : it.skip
+  const skipReason = checkout.available ? '' : ` — skipped: ${checkout.reason}`
+  let discoveredIcons: ResolvedIcon[] = []
+
+  beforeAll(async () => {
+    if (!checkout.available) return
+    discoveredIcons = await discoverResolvedIcons(repoRoot)
+  })
+
+  itInsideMonorepo(`registers every icon string used across the repo — ${regenerationHint}${skipReason}`, () => {
+    const registered = new Set(Object.keys(registryEntries(committedSource)))
+    const missing = discoveredIcons.map((icon) => icon.kebab).filter((kebab) => !registered.has(kebab))
+    expect(missing).toEqual([])
+  })
+
+  itInsideMonorepo(`is byte-identical to a fresh generator run — ${regenerationHint}${skipReason}`, () => {
+    expect(committedSource).toBe(buildLucideRegistrySource(discoveredIcons))
+  })
+
+  it('states a reason instead of asserting when the monorepo sources are absent', () => {
+    const probe = detectMonorepoCheckout(join(tmpdir(), 'lucide-registry-absent-monorepo'))
+    expect(probe.available).toBe(false)
+    expect(probe.available ? '' : probe.reason).toContain('build.mjs')
+  })
+})
+
 describe('jest transform scope', () => {
   const transformPatterns = Object.keys(jestConfig.transform).map((key) => new RegExp(key))