@open-mercato/storage-s3 0.6.4-develop.4095.1.9c790dc021 → 0.6.4-develop.4110.1.836aafde58

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@open-mercato/storage-s3",
-  "version": "0.6.4-develop.4095.1.9c790dc021",
+  "version": "0.6.4-develop.4110.1.836aafde58",
   "type": "module",
   "main": "./dist/index.js",
   "scripts": {
@@ -68,14 +68,14 @@
   "dependencies": {
     "@aws-sdk/client-s3": "^3.1053.0",
     "@aws-sdk/s3-request-presigner": "^3.1053.0",
-    "@open-mercato/core": "0.6.4-develop.4095.1.9c790dc021"
+    "@open-mercato/core": "0.6.4-develop.4110.1.836aafde58"
   },
   "peerDependencies": {
     "@mikro-orm/postgresql": "^6.6.10",
-    "@open-mercato/shared": "0.6.4-develop.4095.1.9c790dc021"
+    "@open-mercato/shared": "0.6.4-develop.4110.1.836aafde58"
   },
   "devDependencies": {
-    "@open-mercato/shared": "0.6.4-develop.4095.1.9c790dc021",
+    "@open-mercato/shared": "0.6.4-develop.4110.1.836aafde58",
     "@types/jest": "^30.0.0",
     "esbuild": "^0.28.0",
     "glob": "^13.0.6",

package/src/modules/storage_s3/__tests__/acl-dependencies.test.ts

@@ -0,0 +1,34 @@
+import {
+  resolveAclDependencyDiagnostics,
+  type FeatureDescriptor,
+} from '@open-mercato/shared/security/aclDependencies'
+import { features as storageS3Features } from '../acl'
+
+const catalog: FeatureDescriptor[] = storageS3Features
+const ownIds = new Set(catalog.map((feature) => feature.id))
+
+describe('storage_s3 acl dependency declarations', () => {
+  it('declares dependsOn only against features registered in the catalog', () => {
+    const granted = catalog.map((feature) => feature.id)
+    const diagnostics = resolveAclDependencyDiagnostics(granted, catalog)
+    const ownUnknown = diagnostics.unknownReferences.filter((ref) => ownIds.has(ref.feature))
+    expect(ownUnknown).toEqual([])
+  })
+
+  it('resolves cleanly with no missing deps when every feature is granted', () => {
+    const granted = catalog.map((feature) => feature.id)
+    const diagnostics = resolveAclDependencyDiagnostics(granted, catalog)
+    const ownMissing = diagnostics.missingDependencies.filter((dep) => ownIds.has(dep.feature))
+    expect(ownMissing).toEqual([])
+    expect(diagnostics.unknownReferences).toEqual([])
+  })
+
+  it('keeps every internal dependency target within the module feature set', () => {
+    const internalDeps = catalog.flatMap((feature) =>
+      (feature.dependsOn ?? []).filter((dep) => ownIds.has(dep) || dep.startsWith('storage_providers.')),
+    )
+    for (const dep of internalDeps) {
+      expect(ownIds.has(dep)).toBe(true)
+    }
+  })
+})