@open-mercato/shared 0.6.7-develop.6862.1.c11a64ce0a → 0.6.7

package/dist/lib/crud/factory.js

@@ -38,7 +38,6 @@ import {
   isCrudCacheEnabled,
   normalizeIdentifierValue,
   normalizeTagSegment,
-  pickFirstIdentifier,
   resolveCrudCache
 } from "./cache.js";
 import { deriveCrudSegmentTag } from "./cache-stats.js";
@@ -52,7 +51,6 @@ import { parseExtensionHeaders } from "../umes/extension-headers.js";
 import { createGenericOptimisticLockReader } from "./optimistic-lock.js";
 import { registerOptimisticLockReaderIfAbsent } from "./optimistic-lock-store.js";
 import { createLogger } from "../logger/index.js";
-import { isTransientDbError } from "../db/pg-errors.js";
 const logger = createLogger("shared").child({ component: "crud" });
 function resolveSortParams(queryParams) {
   const rawSortField = queryParams.sortField ?? queryParams.sort ?? "id";
@@ -298,15 +296,6 @@ function handleError(err) {
   if (err instanceof Response) return err;
   if (isCrudHttpError(err)) return json(err.body, { status: err.status });
   if (err instanceof z.ZodError) return json({ error: "Invalid input", details: err.issues }, { status: 400 });
-  if (isTransientDbError(err)) {
-    logger.warn("Transient DB failure during CRUD handler", {
-      message: err instanceof Error ? err.message : void 0
-    });
-    return json(
-      { error: "Service temporarily unavailable" },
-      { status: 503, headers: { "Retry-After": "2" } }
-    );
-  }
   const message = err instanceof Error ? err.message : void 0;
   const stack = err instanceof Error ? err.stack : void 0;
   logger.error("Unexpected CRUD error", { message, stack, err });
@@ -571,12 +560,6 @@ function buildCrudCacheKey(resource, request, ctx, enricherSignature = "") {
     `tenant:${normalizeTagSegment(ctx.auth?.tenantId ?? null)}`,
     `selectedOrg:${normalizeTagSegment(ctx.selectedOrganizationId ?? null)}`,
     `scope:${scopeSegment}`,
-    // List payloads can vary per caller identity beyond tenant/org scope:
-    // buildFilters may narrow by ctx.auth (e.g. ?mine=true), before-interceptor
-    // query rewrites are feature-gated per user, and afterList/after-interceptor
-    // output is embedded in the stored payload — so entries MUST be partitioned
-    // per actor (API key or user), never shared across identities.
-    `user:${normalizeTagSegment(ctx.auth?.keyId ?? ctx.auth?.sub ?? null)}`,
     `query:${serializeSearchParams(url.searchParams)}`
   ];
   if (enricherSignature) {
@@ -1606,29 +1589,6 @@ function makeCrudRoute(opts) {
             }
           }
         }
-        const createCmdUserFeatures = await resolveUserFeatures(ctx);
-        const { allGuards: createCmdAllGuards } = collectAndRunGuards(ctx.container);
-        let createCmdGuardAfterCallbacks = [];
-        if (createCmdAllGuards.length && ctx.auth.tenantId) {
-          const guardResult = await runMutationGuards(createCmdAllGuards, {
-            tenantId: ctx.auth.tenantId,
-            organizationId: ctx.selectedOrganizationId ?? ctx.auth.orgId ?? null,
-            userId: ctx.auth.sub,
-            resourceKind,
-            resourceId: null,
-            operation: "create",
-            requestMethod: request.method,
-            requestHeaders: request.headers,
-            mutationPayload: input2 && typeof input2 === "object" ? input2 : null
-          }, { userFeatures: createCmdUserFeatures ?? [] });
-          if (!guardResult.ok) {
-            return json(guardResult.errorBody ?? { error: "Operation blocked by guard" }, { status: guardResult.errorStatus ?? 422 });
-          }
-          if (guardResult.modifiedPayload && typeof input2 === "object" && input2) {
-            input2 = { ...input2, ...guardResult.modifiedPayload };
-          }
-          createCmdGuardAfterCallbacks = guardResult.afterSuccessCallbacks;
-        }
         const baseMetadata = {
           tenantId: ctx.auth?.tenantId ?? null,
           organizationId: ctx.selectedOrganizationId ?? ctx.auth.orgId ?? null,
@@ -1668,22 +1628,6 @@ function makeCrudRoute(opts) {
         const status = action.status ?? 201;
         const response = json(resolvedPayload, { status });
         attachOperationHeader(response, logEntry);
-        const commandResultId = pickFirstIdentifier(
-          result?.id,
-          resolvedPayload?.id
-        );
-        if (createCmdGuardAfterCallbacks.length && ctx.auth.tenantId && commandResultId) {
-          await runGuardAfterSuccessCallbacks(createCmdGuardAfterCallbacks, {
-            tenantId: ctx.auth.tenantId,
-            organizationId: ctx.selectedOrganizationId ?? ctx.auth.orgId ?? null,
-            userId: ctx.auth.sub,
-            resourceKind,
-            resourceId: commandResultId,
-            operation: "create",
-            requestMethod: request.method,
-            requestHeaders: request.headers
-          });
-        }
         return response;
       }
       const createConfig = opts.create;
@@ -1770,8 +1714,7 @@ function makeCrudRoute(opts) {
               recordId: String(created[ormCfg.idField]),
               organizationId: targetOrgId,
               tenantId: writeTenantId,
-              values,
-              notify: false
+              values
             });
           }
         }
@@ -2074,8 +2017,7 @@ function makeCrudRoute(opts) {
               recordId: String(updated[ormCfg.idField]),
               organizationId: targetOrgId,
               tenantId: writeTenantId,
-              values,
-              notify: false
+              values
             });
           }
         }
@@ -2171,8 +2113,7 @@ function makeCrudRoute(opts) {
           ctx,
           request,
           method: "DELETE",
-          body: interceptorInput,
-          query: raw.query
+          body: interceptorInput
         });
         if (beforeInterceptors2.errorResponse) return beforeInterceptors2.errorResponse;
         interceptorRequestPayload = beforeInterceptors2.requestPayload;
@@ -2283,7 +2224,7 @@ function makeCrudRoute(opts) {
         request,
         method: "DELETE",
         body: idFrom === "query" ? void 0 : { id },
-        query: idFrom === "query" ? Object.fromEntries(url.searchParams.entries()) : void 0
+        query: idFrom === "query" ? { id } : void 0
       });
       if (beforeInterceptors.errorResponse) return beforeInterceptors.errorResponse;
       interceptorRequestPayload = beforeInterceptors.requestPayload;