@open-mercato/shared 0.6.6 → 0.6.7-develop.6553.1.2ec7246e04

package/AGENTS.md

@@ -52,6 +52,7 @@ yarn workspace @open-mercato/shared build
 | `number.ts` | When parsing numeric strings from env/query params with a fallback and optional min/integer constraint | `@open-mercato/shared/lib/number` |
 | `openapi/` | When generating CRUD OpenAPI specs | `@open-mercato/shared/lib/openapi/crud` |
 | `profiler/` | When profiling with `OM_PROFILE` env flag | `@open-mercato/shared/lib/profiler` |
+| `string.ts` | When parsing comma-separated lists from CLI args/query params, or coercing a string to `undefined` when blank | `@open-mercato/shared/lib/string` |
 | `testing/` | When bootstrapping tests — register only what the test needs | `@open-mercato/shared/lib/testing/bootstrap` |
 
 ## Module Types (`src/modules/`)
@@ -94,6 +95,23 @@ const results = await findWithDecryption(em, 'Entity', filter, { tenantId, organ
 import { parseBooleanToken, parseBooleanWithDefault } from '@open-mercato/shared/lib/boolean'
 ```
 
+### Comma-Separated List Parsing — MUST use instead of ad-hoc splitting
+
+```typescript
+import { parseCommaSeparatedList } from '@open-mercato/shared/lib/string'
+```
+
+`parseCommaSeparatedList(value)` splits on commas, trims each entry, and drops blanks. Non-string
+inputs (`null`/`undefined`) yield `[]`. MUST use it instead of hand-rolling
+`value.split(',').map((s) => s.trim()).filter(Boolean)` when reading CLI flags or query params.
+
+Keep the surrounding guard when a call site distinguishes "not supplied" (`undefined`) from
+"supplied but empty" (`[]`) — the helper always returns an array:
+
+```typescript
+const roleNames = rolesCsv ? parseCommaSeparatedList(rolesCsv) : undefined
+```
+
 ### Browser Storage — use the shared helpers instead of raw `localStorage`
 
 Persisted client UI state MUST go through the shared `browser/` helpers, never raw `window.localStorage` reads/writes scattered per component:

package/dist/lib/crud/factory.js

@@ -264,6 +264,8 @@ function json(data, init) {
     headers: { "content-type": "application/json", ...init?.headers || {} }
   });
 }
+const SELECTED_ORG_COOKIE = "om_selected_org";
+const CLEAR_SELECTED_ORG_COOKIE = `${SELECTED_ORG_COOKIE}=; Path=/; Max-Age=0; SameSite=Lax`;
 function attachOperationHeader(res, logEntry) {
   if (!res || !(res instanceof Response)) return res;
   if (!logEntry || typeof logEntry !== "object") return res;
@@ -892,6 +894,26 @@ function makeCrudRoute(opts) {
     }
     return { container, auth: scopedAuth, organizationScope: scope, selectedOrganizationId, organizationIds, request };
   }
+  function rejectInvalidOrgSelection(ctx, action) {
+    if (!ormCfg.orgField) return null;
+    if (!ctx.organizationScope?.selectionRejected) return null;
+    logForbidden({
+      resourceKind,
+      action,
+      reason: "organization_selection_invalid",
+      userId: ctx.auth?.sub ?? null,
+      tenantId: ctx.auth?.tenantId ?? null,
+      organizationIds: ctx.organizationIds
+    });
+    const headers = action === "list" ? { "set-cookie": CLEAR_SELECTED_ORG_COOKIE } : {};
+    return json(
+      {
+        error: "Your selected organization is no longer available. Please re-select an organization and try again.",
+        code: "organization_selection_invalid"
+      },
+      { status: 422, headers }
+    );
+  }
   async function GET(request) {
     const profiler = createCrudProfiler(resourceKind, "list");
     const requestMeta = { method: request.method };
@@ -919,6 +941,11 @@ function makeCrudRoute(opts) {
         finishProfile({ reason: "unauthorized" });
         return json({ error: "Unauthorized" }, { status: 401 });
       }
+      const listSelectionRejected = rejectInvalidOrgSelection(ctx, "list");
+      if (listSelectionRejected) {
+        finishProfile({ reason: "organization_selection_invalid" });
+        return listSelectionRejected;
+      }
       if (!opts.list) {
         finishProfile({ reason: "list_not_configured" });
         return json({ error: "Not implemented" }, { status: 501 });
@@ -1510,6 +1537,8 @@ function makeCrudRoute(opts) {
       if (!opts.create && !useCommand) return json({ error: "Not implemented" }, { status: 501 });
       const ctx = await withCtx(request);
       if (!ctx.auth) return json({ error: "Unauthorized" }, { status: 401 });
+      const createSelectionRejected = rejectInvalidOrgSelection(ctx, "create");
+      if (createSelectionRejected) return createSelectionRejected;
       if (ormCfg.orgField && ctx.organizationIds && ctx.organizationIds.length === 0) {
         logForbidden({
           resourceKind,
@@ -1753,6 +1782,8 @@ function makeCrudRoute(opts) {
       if (!opts.update && !useCommand) return json({ error: "Not implemented" }, { status: 501 });
       const ctx = await withCtx(request);
       if (!ctx.auth) return json({ error: "Unauthorized" }, { status: 401 });
+      const updateSelectionRejected = rejectInvalidOrgSelection(ctx, "update");
+      if (updateSelectionRejected) return updateSelectionRejected;
       if (ormCfg.orgField && ctx.organizationIds && ctx.organizationIds.length === 0) {
         logForbidden({
           resourceKind,
@@ -2053,6 +2084,8 @@ function makeCrudRoute(opts) {
     try {
       const ctx = await withCtx(request);
       if (!ctx.auth) return json({ error: "Unauthorized" }, { status: 401 });
+      const deleteSelectionRejected = rejectInvalidOrgSelection(ctx, "delete");
+      if (deleteSelectionRejected) return deleteSelectionRejected;
       if (ormCfg.orgField && ctx.organizationIds && ctx.organizationIds.length === 0) {
         logForbidden({
           resourceKind,