@open-mercato/gateway-stripe 0.6.4-develop.4217.1.c9aa050183 → 0.6.4-develop.4239.1.4a264a5828

package/dist/modules/gateway_stripe/acl.js

@@ -1,6 +1,16 @@
 const features = [
-  { id: "gateway_stripe.view", title: "View Stripe gateway configuration", module: "gateway_stripe" },
-  { id: "gateway_stripe.configure", title: "Configure Stripe gateway settings", module: "gateway_stripe" }
+  {
+    id: "gateway_stripe.view",
+    title: "View Stripe gateway configuration",
+    module: "gateway_stripe",
+    dependsOn: ["payment_gateways.view"]
+  },
+  {
+    id: "gateway_stripe.configure",
+    title: "Configure Stripe gateway settings",
+    module: "gateway_stripe",
+    dependsOn: ["gateway_stripe.view", "payment_gateways.manage"]
+  }
 ];
 var acl_default = features;
 export {

package/dist/modules/gateway_stripe/acl.js.map

@@ -1,7 +1,7 @@
 {
   "version": 3,
   "sources": ["../../../src/modules/gateway_stripe/acl.ts"],
-  "sourcesContent": ["export const features = [\n  { id: 'gateway_stripe.view', title: 'View Stripe gateway configuration', module: 'gateway_stripe' },\n  { id: 'gateway_stripe.configure', title: 'Configure Stripe gateway settings', module: 'gateway_stripe' },\n]\n\nexport default features\n"],
-  "mappings": "AAAO,MAAM,WAAW;AAAA,EACtB,EAAE,IAAI,uBAAuB,OAAO,qCAAqC,QAAQ,iBAAiB;AAAA,EAClG,EAAE,IAAI,4BAA4B,OAAO,qCAAqC,QAAQ,iBAAiB;AACzG;AAEA,IAAO,cAAQ;",
+  "sourcesContent": ["export const features = [\n  {\n    id: 'gateway_stripe.view',\n    title: 'View Stripe gateway configuration',\n    module: 'gateway_stripe',\n    dependsOn: ['payment_gateways.view'],\n  },\n  {\n    id: 'gateway_stripe.configure',\n    title: 'Configure Stripe gateway settings',\n    module: 'gateway_stripe',\n    dependsOn: ['gateway_stripe.view', 'payment_gateways.manage'],\n  },\n]\n\nexport default features\n"],
+  "mappings": "AAAO,MAAM,WAAW;AAAA,EACtB;AAAA,IACE,IAAI;AAAA,IACJ,OAAO;AAAA,IACP,QAAQ;AAAA,IACR,WAAW,CAAC,uBAAuB;AAAA,EACrC;AAAA,EACA;AAAA,IACE,IAAI;AAAA,IACJ,OAAO;AAAA,IACP,QAAQ;AAAA,IACR,WAAW,CAAC,uBAAuB,yBAAyB;AAAA,EAC9D;AACF;AAEA,IAAO,cAAQ;",
   "names": []
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@open-mercato/gateway-stripe",
-  "version": "0.6.4-develop.4217.1.c9aa050183",
+  "version": "0.6.4-develop.4239.1.4a264a5828",
   "type": "module",
   "main": "./dist/index.js",
   "scripts": {
@@ -61,21 +61,21 @@
     }
   },
   "dependencies": {
-    "@open-mercato/core": "0.6.4-develop.4217.1.c9aa050183",
-    "@open-mercato/queue": "0.6.4-develop.4217.1.c9aa050183",
-    "@open-mercato/ui": "0.6.4-develop.4217.1.c9aa050183",
+    "@open-mercato/core": "0.6.4-develop.4239.1.4a264a5828",
+    "@open-mercato/queue": "0.6.4-develop.4239.1.4a264a5828",
+    "@open-mercato/ui": "0.6.4-develop.4239.1.4a264a5828",
     "@stripe/react-stripe-js": "^6.4.0",
     "@stripe/stripe-js": "^9.6.0",
     "stripe": "^22.1.1"
   },
   "peerDependencies": {
     "@mikro-orm/postgresql": "^7.0.14",
-    "@open-mercato/shared": "0.6.4-develop.4217.1.c9aa050183",
+    "@open-mercato/shared": "0.6.4-develop.4239.1.4a264a5828",
     "react": "^19.0.0",
     "react-dom": "^19.0.0"
   },
   "devDependencies": {
-    "@open-mercato/shared": "0.6.4-develop.4217.1.c9aa050183",
+    "@open-mercato/shared": "0.6.4-develop.4239.1.4a264a5828",
     "@types/jest": "^30.0.0",
     "@types/react": "^19.2.15",
     "@types/react-dom": "^19.2.3",

package/src/modules/gateway_stripe/__tests__/acl-dependencies.test.ts

@@ -0,0 +1,82 @@
+/** @jest-environment node */
+
+import { describe, test, expect } from '@jest/globals'
+import {
+  resolveAclDependencyDiagnostics,
+  type FeatureDescriptor,
+} from '@open-mercato/shared/security/aclDependencies'
+import { features as gatewayStripeFeatures } from '../acl'
+import { features as paymentGatewaysFeatures } from '@open-mercato/core/modules/payment_gateways/acl'
+
+// The gateway_stripe dependency table (spec §6.36) references features from the
+// payment_gateways module, so the catalog the resolver checks against must
+// include them.
+const combinedCatalog: FeatureDescriptor[] = [
+  ...(gatewayStripeFeatures as FeatureDescriptor[]),
+  ...(paymentGatewaysFeatures as FeatureDescriptor[]),
+]
+
+const gatewayStripeFeatureIds = (gatewayStripeFeatures as FeatureDescriptor[]).map((f) => f.id)
+
+describe('gateway_stripe ACL dependency declarations', () => {
+  test('every gateway_stripe dependency resolves to a known feature (no unknown references)', () => {
+    const diagnostics = resolveAclDependencyDiagnostics(
+      combinedCatalog.map((f) => f.id),
+      combinedCatalog,
+    )
+    const gatewayStripeUnknown = diagnostics.unknownReferences.filter((entry) =>
+      entry.feature.startsWith('gateway_stripe.'),
+    )
+    expect(gatewayStripeUnknown).toEqual([])
+  })
+
+  test('view depends on the payment gateways read feature', () => {
+    const view = (gatewayStripeFeatures as FeatureDescriptor[]).find(
+      (f) => f.id === 'gateway_stripe.view',
+    )
+    expect(view?.dependsOn).toEqual(['payment_gateways.view'])
+  })
+
+  test('configure depends on the local view feature and the payment gateways manage feature', () => {
+    const configure = (gatewayStripeFeatures as FeatureDescriptor[]).find(
+      (f) => f.id === 'gateway_stripe.configure',
+    )
+    expect([...(configure?.dependsOn ?? [])].sort()).toEqual(
+      ['gateway_stripe.view', 'payment_gateways.manage'].sort(),
+    )
+  })
+
+  test('granting gateway_stripe.view alone surfaces the missing payment_gateways read dependency', () => {
+    const diagnostics = resolveAclDependencyDiagnostics(['gateway_stripe.view'], combinedCatalog)
+    const viewEntry = diagnostics.missingDependencies.find(
+      (entry) => entry.feature === 'gateway_stripe.view',
+    )
+    expect(viewEntry).toBeDefined()
+    expect([...(viewEntry?.missing ?? [])]).toEqual(['payment_gateways.view'])
+  })
+
+  test('granting gateway_stripe.configure alone surfaces both declared dependencies', () => {
+    const diagnostics = resolveAclDependencyDiagnostics(
+      ['gateway_stripe.configure'],
+      combinedCatalog,
+    )
+    const configureEntry = diagnostics.missingDependencies.find(
+      (entry) => entry.feature === 'gateway_stripe.configure',
+    )
+    expect(configureEntry).toBeDefined()
+    expect([...(configureEntry?.missing ?? [])].sort()).toEqual(
+      ['gateway_stripe.view', 'payment_gateways.manage'].sort(),
+    )
+  })
+
+  test('granting all referenced features clears gateway_stripe dependency warnings', () => {
+    const diagnostics = resolveAclDependencyDiagnostics(
+      combinedCatalog.map((f) => f.id),
+      combinedCatalog,
+    )
+    const gatewayStripeMissing = diagnostics.missingDependencies.filter((entry) =>
+      entry.feature.startsWith('gateway_stripe.'),
+    )
+    expect(gatewayStripeMissing).toEqual([])
+  })
+})

package/src/modules/gateway_stripe/acl.ts

@@ -1,6 +1,16 @@
 export const features = [
-  { id: 'gateway_stripe.view', title: 'View Stripe gateway configuration', module: 'gateway_stripe' },
-  { id: 'gateway_stripe.configure', title: 'Configure Stripe gateway settings', module: 'gateway_stripe' },
+  {
+    id: 'gateway_stripe.view',
+    title: 'View Stripe gateway configuration',
+    module: 'gateway_stripe',
+    dependsOn: ['payment_gateways.view'],
+  },
+  {
+    id: 'gateway_stripe.configure',
+    title: 'Configure Stripe gateway settings',
+    module: 'gateway_stripe',
+    dependsOn: ['gateway_stripe.view', 'payment_gateways.manage'],
+  },
 ]
 
 export default features