@open-mercato/core 0.7.1-develop.7193.1.910a5b0a1e → 0.7.1-develop.7194.1.ab4fc81f82

package/dist/modules/workflows/commands/tasks.js

@@ -0,0 +1,81 @@
+import { z } from "zod";
+import { registerCommand } from "@open-mercato/shared/lib/commands";
+import { UserTask } from "../data/entities.js";
+import { loadTaskDecisionContext } from "../lib/task-decision-context.js";
+const WORKFLOWS_TASK_COMPLETE_COMMAND_ID = "workflows.tasks.complete";
+const COMPLETE_TASK_FEATURE = "workflows.tasks.complete";
+const completeTaskCommandSchema = z.object({
+  id: z.string().uuid(),
+  comments: z.string().optional()
+});
+async function callerMayCompleteTasks(ctx, scope) {
+  const userId = ctx.auth?.sub;
+  if (!userId) return false;
+  try {
+    const rbac = ctx.container.resolve("rbacService");
+    if (!rbac?.userHasAllFeatures) return false;
+    return await rbac.userHasAllFeatures(userId, [COMPLETE_TASK_FEATURE], {
+      tenantId: scope.tenantId,
+      organizationId: scope.organizationId
+    });
+  } catch {
+    return false;
+  }
+}
+const completeUserTaskCommand = {
+  id: WORKFLOWS_TASK_COMPLETE_COMMAND_ID,
+  async execute(rawInput, ctx) {
+    const parsed = completeTaskCommandSchema.parse(rawInput);
+    const userId = ctx.auth?.sub;
+    const tenantId = ctx.auth?.tenantId ?? null;
+    const organizationId = ctx.selectedOrganizationId ?? ctx.auth?.orgId ?? null;
+    if (!userId || !tenantId || !organizationId) {
+      throw new Error("[internal] workflows.tasks.complete requires an authenticated caller scope");
+    }
+    const scope = { tenantId, organizationId };
+    if (!await callerMayCompleteTasks(ctx, scope)) {
+      throw new Error("[internal] Caller is not allowed to complete workflow tasks");
+    }
+    const container = ctx.container;
+    const em = container.resolve("em").fork();
+    const task = await em.findOne(UserTask, {
+      id: parsed.id,
+      tenantId,
+      organizationId,
+      status: { $in: ["PENDING", "IN_PROGRESS"] }
+    });
+    if (!task) {
+      throw new Error("[internal] Task not found or already completed");
+    }
+    const { decisions } = await loadTaskDecisionContext(em, task);
+    if (decisions.length > 1) {
+      throw new Error("[internal] Task offers multiple decisions and cannot be completed in one click");
+    }
+    const decisionId = decisions[0]?.id ?? null;
+    const taskHandler = container.resolve("taskHandler");
+    await taskHandler.completeUserTask(em, container, {
+      taskId: task.id,
+      formData: {},
+      userId,
+      comments: parsed.comments,
+      ...decisionId ? { decisionId } : {},
+      scope
+    });
+    return { taskId: task.id, decisionId };
+  },
+  buildLog({ input, result }) {
+    return {
+      resourceKind: "workflows.user_task",
+      resourceId: result?.taskId ?? input.id,
+      actionLabel: "workflows.tasks.complete",
+      payload: { decisionId: result?.decisionId ?? null }
+    };
+  }
+};
+registerCommand(completeUserTaskCommand);
+var tasks_default = completeUserTaskCommand;
+export {
+  WORKFLOWS_TASK_COMPLETE_COMMAND_ID,
+  tasks_default as default
+};
+//# sourceMappingURL=tasks.js.map

package/dist/modules/workflows/commands/tasks.js.map

@@ -0,0 +1,7 @@
+{
+  "version": 3,
+  "sources": ["../../../../src/modules/workflows/commands/tasks.ts"],
+  "sourcesContent": ["/**\n * `workflows.tasks.complete` \u2014 the command behind a notification quick action.\n *\n * The notifications module executes a `commandId` action through the command\n * bus after claiming the row with a conditional UPDATE, so a double-click or a\n * retried request is a 409 rather than a second completion\n * (`notificationService.executeAction`). That claim is the outer idempotency\n * guard; `completeUserTask`'s own `status IN (PENDING, IN_PROGRESS)` lookup is\n * the inner one.\n *\n * The command input is `{ id: <userTaskId> }` \u2014 the notification's\n * `sourceEntityId`. It carries no decision, which is precisely why\n * `lib/task-quick-action.ts` only offers this button for a task with at most\n * one decision: the sole decision is re-resolved here from the instance's\n * pinned definition, so a quick action selects exactly the route the full task\n * page would have.\n *\n * Nothing about this path is more permissive than the HTTP route: the caller\n * must hold `workflows.tasks.complete`, and only the notification's own\n * recipient can execute an action on it.\n */\n\nimport { z } from 'zod'\nimport { registerCommand } from '@open-mercato/shared/lib/commands'\nimport type { CommandHandler, CommandRuntimeContext } from '@open-mercato/shared/lib/commands'\nimport type { EntityManager } from '@mikro-orm/postgresql'\nimport type { AwilixContainer } from 'awilix'\nimport { UserTask } from '../data/entities'\nimport { loadTaskDecisionContext } from '../lib/task-decision-context'\nimport type { TaskHandlerService } from '../lib/task-handler'\n\nexport const WORKFLOWS_TASK_COMPLETE_COMMAND_ID = 'workflows.tasks.complete'\n\nconst COMPLETE_TASK_FEATURE = 'workflows.tasks.complete'\n\n/**\n * Non-strict on purpose: the notifications module spreads the action payload\n * into the command input, so unrelated keys must be ignored rather than reject\n * the whole call.\n */\nconst completeTaskCommandSchema = z.object({\n  id: z.string().uuid(),\n  comments: z.string().optional(),\n})\n\nexport type CompleteTaskCommandInput = z.infer<typeof completeTaskCommandSchema>\n\ntype RbacServiceLike = {\n  userHasAllFeatures: (\n    userId: string,\n    required: string[],\n    scope: { tenantId: string | null; organizationId: string | null }\n  ) => Promise<boolean>\n}\n\n/**\n * Fail-closed: no caller identity, no rbacService, or a thrown check all deny.\n * A command reachable from a notification must never be a softer gate than the\n * route that does the same thing.\n */\nasync function callerMayCompleteTasks(\n  ctx: CommandRuntimeContext,\n  scope: { tenantId: string; organizationId: string }\n): Promise<boolean> {\n  const userId = ctx.auth?.sub\n  if (!userId) return false\n  try {\n    const rbac = ctx.container.resolve('rbacService') as RbacServiceLike | undefined\n    if (!rbac?.userHasAllFeatures) return false\n    return await rbac.userHasAllFeatures(userId, [COMPLETE_TASK_FEATURE], {\n      tenantId: scope.tenantId,\n      organizationId: scope.organizationId,\n    })\n  } catch {\n    return false\n  }\n}\n\nconst completeUserTaskCommand: CommandHandler<\n  CompleteTaskCommandInput,\n  { taskId: string; decisionId: string | null }\n> = {\n  id: WORKFLOWS_TASK_COMPLETE_COMMAND_ID,\n  async execute(rawInput, ctx) {\n    const parsed = completeTaskCommandSchema.parse(rawInput)\n\n    const userId = ctx.auth?.sub\n    const tenantId = ctx.auth?.tenantId ?? null\n    const organizationId = ctx.selectedOrganizationId ?? ctx.auth?.orgId ?? null\n\n    if (!userId || !tenantId || !organizationId) {\n      throw new Error('[internal] workflows.tasks.complete requires an authenticated caller scope')\n    }\n\n    const scope = { tenantId, organizationId }\n    if (!(await callerMayCompleteTasks(ctx, scope))) {\n      throw new Error('[internal] Caller is not allowed to complete workflow tasks')\n    }\n\n    const container = ctx.container as AwilixContainer\n    const em = (container.resolve('em') as EntityManager).fork()\n\n    const task = await em.findOne(UserTask, {\n      id: parsed.id,\n      tenantId,\n      organizationId,\n      status: { $in: ['PENDING', 'IN_PROGRESS'] },\n    })\n    if (!task) {\n      throw new Error('[internal] Task not found or already completed')\n    }\n\n    // Re-resolved from the pinned definition, exactly as the task page does.\n    // More than one decision means the quick action should never have been\n    // offered (see `lib/task-quick-action.ts`), so refuse rather than pick one.\n    const { decisions } = await loadTaskDecisionContext(em, task)\n    if (decisions.length > 1) {\n      throw new Error('[internal] Task offers multiple decisions and cannot be completed in one click')\n    }\n    const decisionId = decisions[0]?.id ?? null\n\n    const taskHandler = container.resolve('taskHandler') as TaskHandlerService\n    await taskHandler.completeUserTask(em, container, {\n      taskId: task.id,\n      formData: {},\n      userId,\n      comments: parsed.comments,\n      ...(decisionId ? { decisionId } : {}),\n      scope,\n    })\n\n    return { taskId: task.id, decisionId }\n  },\n  buildLog({ input, result }) {\n    return {\n      resourceKind: 'workflows.user_task',\n      resourceId: result?.taskId ?? input.id,\n      actionLabel: 'workflows.tasks.complete',\n      payload: { decisionId: result?.decisionId ?? null },\n    }\n  },\n}\n\nregisterCommand(completeUserTaskCommand)\n\nexport default completeUserTaskCommand\n"],
+  "mappings": "AAsBA,SAAS,SAAS;AAClB,SAAS,uBAAuB;AAIhC,SAAS,gBAAgB;AACzB,SAAS,+BAA+B;AAGjC,MAAM,qCAAqC;AAElD,MAAM,wBAAwB;AAO9B,MAAM,4BAA4B,EAAE,OAAO;AAAA,EACzC,IAAI,EAAE,OAAO,EAAE,KAAK;AAAA,EACpB,UAAU,EAAE,OAAO,EAAE,SAAS;AAChC,CAAC;AAiBD,eAAe,uBACb,KACA,OACkB;AAClB,QAAM,SAAS,IAAI,MAAM;AACzB,MAAI,CAAC,OAAQ,QAAO;AACpB,MAAI;AACF,UAAM,OAAO,IAAI,UAAU,QAAQ,aAAa;AAChD,QAAI,CAAC,MAAM,mBAAoB,QAAO;AACtC,WAAO,MAAM,KAAK,mBAAmB,QAAQ,CAAC,qBAAqB,GAAG;AAAA,MACpE,UAAU,MAAM;AAAA,MAChB,gBAAgB,MAAM;AAAA,IACxB,CAAC;AAAA,EACH,QAAQ;AACN,WAAO;AAAA,EACT;AACF;AAEA,MAAM,0BAGF;AAAA,EACF,IAAI;AAAA,EACJ,MAAM,QAAQ,UAAU,KAAK;AAC3B,UAAM,SAAS,0BAA0B,MAAM,QAAQ;AAEvD,UAAM,SAAS,IAAI,MAAM;AACzB,UAAM,WAAW,IAAI,MAAM,YAAY;AACvC,UAAM,iBAAiB,IAAI,0BAA0B,IAAI,MAAM,SAAS;AAExE,QAAI,CAAC,UAAU,CAAC,YAAY,CAAC,gBAAgB;AAC3C,YAAM,IAAI,MAAM,4EAA4E;AAAA,IAC9F;AAEA,UAAM,QAAQ,EAAE,UAAU,eAAe;AACzC,QAAI,CAAE,MAAM,uBAAuB,KAAK,KAAK,GAAI;AAC/C,YAAM,IAAI,MAAM,6DAA6D;AAAA,IAC/E;AAEA,UAAM,YAAY,IAAI;AACtB,UAAM,KAAM,UAAU,QAAQ,IAAI,EAAoB,KAAK;AAE3D,UAAM,OAAO,MAAM,GAAG,QAAQ,UAAU;AAAA,MACtC,IAAI,OAAO;AAAA,MACX;AAAA,MACA;AAAA,MACA,QAAQ,EAAE,KAAK,CAAC,WAAW,aAAa,EAAE;AAAA,IAC5C,CAAC;AACD,QAAI,CAAC,MAAM;AACT,YAAM,IAAI,MAAM,gDAAgD;AAAA,IAClE;AAKA,UAAM,EAAE,UAAU,IAAI,MAAM,wBAAwB,IAAI,IAAI;AAC5D,QAAI,UAAU,SAAS,GAAG;AACxB,YAAM,IAAI,MAAM,gFAAgF;AAAA,IAClG;AACA,UAAM,aAAa,UAAU,CAAC,GAAG,MAAM;AAEvC,UAAM,cAAc,UAAU,QAAQ,aAAa;AACnD,UAAM,YAAY,iBAAiB,IAAI,WAAW;AAAA,MAChD,QAAQ,KAAK;AAAA,MACb,UAAU,CAAC;AAAA,MACX;AAAA,MACA,UAAU,OAAO;AAAA,MACjB,GAAI,aAAa,EAAE,WAAW,IAAI,CAAC;AAAA,MACnC;AAAA,IACF,CAAC;AAED,WAAO,EAAE,QAAQ,KAAK,IAAI,WAAW;AAAA,EACvC;AAAA,EACA,SAAS,EAAE,OAAO,OAAO,GAAG;AAC1B,WAAO;AAAA,MACL,cAAc;AAAA,MACd,YAAY,QAAQ,UAAU,MAAM;AAAA,MACpC,aAAa;AAAA,MACb,SAAS,EAAE,YAAY,QAAQ,cAAc,KAAK;AAAA,IACpD;AAAA,EACF;AACF;AAEA,gBAAgB,uBAAuB;AAEvC,IAAO,gBAAQ;",
+  "names": []
+}