@open-mercato/core 0.6.5-develop.5337.1.534b781eac → 0.6.5

package/src/modules/customers/components/DealsKpiStrip.tsx

@@ -0,0 +1,389 @@
+"use client"
+
+import * as React from 'react'
+import { CheckCircle } from 'lucide-react'
+import { cn } from '@open-mercato/shared/lib/utils'
+import { useT, useLocale } from '@open-mercato/shared/lib/i18n/context'
+import { apiCall } from '@open-mercato/ui/backend/utils/apiCall'
+import { KpiCard, DeltaBadge, Sparkline } from '@open-mercato/ui/backend/charts'
+import { Avatar, AvatarStack } from '@open-mercato/ui/primitives/avatar'
+import { Button } from '@open-mercato/ui/primitives/button'
+import { Spinner } from '@open-mercato/ui/primitives/spinner'
+import type { DictionaryMap } from '@open-mercato/core/modules/dictionaries/components/dictionaryAppearance'
+import { PipelineStageBar } from './kpi/PipelineStageBar'
+
+type DeltaDirection = 'up' | 'down' | 'unchanged'
+
+type SummaryDelta = {
+  value: number
+  direction: DeltaDirection
+}
+
+type DealsSummaryResponse = {
+  baseCurrencyCode: string | null
+  convertedAll: boolean
+  missingRateCurrencies: string[]
+  pipelineValue: {
+    value: number
+    delta: SummaryDelta
+    stages: { stage: string | null; count: number; value: number }[]
+  }
+  activeDeals: {
+    value: number
+    delta: SummaryDelta
+    ownersCount: number
+    needAttention: number
+    owners: { id: string; count: number }[]
+    ownersOverflow: number
+  }
+  wonThisQuarter: {
+    value: number
+    delta: SummaryDelta
+    dealsClosed: number
+    avgDeal: number
+  }
+  winRate: {
+    value: number
+    deltaPp: number
+    direction: DeltaDirection
+    previousValue: number
+    series: { period: string; rate: number }[]
+  }
+}
+
+export type DealsKpiStripProps = {
+  ownerNames: Record<string, string>
+  stageDictionary: DictionaryMap
+  pipelineCount: number
+  className?: string
+  /** Bumped by the host when the active org scope changes — forces a KPI refetch so the cards never show another org's data. */
+  scopeVersion?: number
+  /** Bumped by the host on manual refresh / after mutations — forces a KPI refetch so totals stay in sync with the table. */
+  reloadToken?: number
+  onNeedsAttentionClick?: () => void
+}
+
+const compactNumberFormatter = new Intl.NumberFormat(undefined, {
+  notation: 'compact',
+  maximumFractionDigits: 1,
+})
+
+function formatCompact(value: number): string {
+  return compactNumberFormatter.format(value)
+}
+
+function buildCurrencySuffix(code: string | null, convertedAll: boolean): string {
+  if (!code) return convertedAll ? '' : '≈'
+  return convertedAll ? code : `≈ ${code}`
+}
+
+const KPI_TITLE_CLASS = 'text-xs font-semibold uppercase tracking-wide text-muted-foreground'
+
+function DealKpiCard(props: React.ComponentProps<typeof KpiCard>) {
+  return <KpiCard titleClassName={KPI_TITLE_CLASS} {...props} />
+}
+
+function KpiDeltaBadge({
+  direction,
+  value,
+  unit,
+  title,
+}: {
+  direction: DeltaDirection
+  value: number
+  unit?: string
+  title: string
+}) {
+  if (direction === 'unchanged' && value === 0) {
+    return (
+      <span
+        className="inline-flex items-center rounded-md bg-status-neutral-bg px-2 py-0.5 text-xs font-medium text-status-neutral-text"
+        title={title}
+      >
+        --
+      </span>
+    )
+  }
+  return <DeltaBadge direction={direction} value={value} unit={unit} title={title} />
+}
+
+function isObject(value: unknown): value is Record<string, unknown> {
+  return typeof value === 'object' && value !== null
+}
+
+// Guard the summary payload before rendering: a non-conforming response (an unrelated
+// endpoint mock, an error body, or a future contract drift) must surface the error card,
+// never crash the whole deals page by dereferencing missing sections/arrays.
+function isDealsSummaryResponse(value: unknown): value is DealsSummaryResponse {
+  if (!isObject(value)) return false
+  const { pipelineValue, activeDeals, wonThisQuarter, winRate } = value
+  return (
+    isObject(pipelineValue) && Array.isArray(pipelineValue.stages) &&
+    isObject(activeDeals) && Array.isArray(activeDeals.owners) &&
+    isObject(wonThisQuarter) &&
+    isObject(winRate) && Array.isArray(winRate.series)
+  )
+}
+
+export function DealsKpiStrip({
+  ownerNames,
+  stageDictionary,
+  pipelineCount,
+  className,
+  scopeVersion,
+  reloadToken,
+  onNeedsAttentionClick,
+}: DealsKpiStripProps) {
+  const t = useT()
+  const locale = useLocale()
+  const pluralCat = React.useCallback((count: number): string => {
+    try {
+      return new Intl.PluralRules(locale).select(count)
+    } catch {
+      return count === 1 ? 'one' : 'other'
+    }
+  }, [locale])
+  const pf = React.useCallback((base: string, count: number): string => {
+    const cat = pluralCat(count)
+    const key = `${base}.${cat}`
+    const out = t(key, { count })
+    return out === key ? t(`${base}.other`, { count }) : out
+  }, [t, pluralCat])
+  const [data, setData] = React.useState<DealsSummaryResponse | null>(null)
+  const [loading, setLoading] = React.useState(true)
+  const [error, setError] = React.useState<string | null>(null)
+  const [retryToken, setRetryToken] = React.useState(0)
+  const previousScopeVersionRef = React.useRef(scopeVersion)
+
+  const retry = React.useCallback(() => {
+    setRetryToken((token) => token + 1)
+  }, [])
+
+  React.useEffect(() => {
+    let cancelled = false
+    const scopeChanged = previousScopeVersionRef.current !== scopeVersion
+    previousScopeVersionRef.current = scopeVersion
+    if (scopeChanged) setData(null)
+    setLoading(true)
+    setError(null)
+    apiCall<DealsSummaryResponse>('/api/customers/deals/summary')
+      .then((call) => {
+        if (cancelled) return
+        if (!call.ok || !isDealsSummaryResponse(call.result)) {
+          setError(t('customers.deals.list.kpi.error'))
+          return
+        }
+        setData(call.result)
+      })
+      .catch(() => {
+        if (cancelled) return
+        setError(t('customers.deals.list.kpi.error'))
+      })
+      .finally(() => {
+        if (!cancelled) setLoading(false)
+      })
+    return () => {
+      cancelled = true
+    }
+  }, [t, scopeVersion, reloadToken, retryToken])
+
+  const wrapperClassName = cn('space-y-2', className)
+  const gridClassName = 'grid grid-cols-1 gap-3 sm:grid-cols-2 xl:grid-cols-4'
+
+  if (loading && !data) {
+    return (
+      <div className={wrapperClassName}>
+        <div className={gridClassName}>
+          <DealKpiCard loading title={t('customers.deals.list.kpi.pipelineValue')} value={null} />
+          <DealKpiCard loading title={t('customers.deals.list.kpi.activeDeals')} value={null} />
+          <DealKpiCard loading title={t('customers.deals.list.kpi.wonThisQuarter')} value={null} />
+          <DealKpiCard loading title={t('customers.deals.list.kpi.winRate')} value={null} />
+        </div>
+      </div>
+    )
+  }
+
+  if (!data) {
+    const errorMessage = error ?? t('customers.deals.list.kpi.error')
+    return (
+      <div className={wrapperClassName}>
+        <div className="flex items-center justify-between gap-3 rounded-lg border border-destructive/30 bg-destructive/5 p-4">
+          <p className="text-sm text-destructive">{errorMessage}</p>
+          <Button type="button" variant="destructive-outline" size="sm" onClick={retry}>
+            {t('customers.deals.list.kpi.retry')}
+          </Button>
+        </div>
+      </div>
+    )
+  }
+
+  const currencySuffix = buildCurrencySuffix(data.baseCurrencyCode, data.convertedAll)
+  const unassignedLabel = t('customers.deals.list.kpi.unassignedStage')
+  const deltaTooltip = t('customers.deals.list.kpi.deltaTooltip')
+  const deltaUnavailableTooltip = t('customers.deals.list.kpi.deltaUnavailable')
+  const scopeLabel = t('customers.deals.list.kpi.scopeAllPipelinesThisQuarter')
+  const unknownOwner = t('customers.deals.list.unknownOwner')
+  const currencyHint = !data.convertedAll
+    ? data.baseCurrencyCode
+      ? t('customers.deals.list.kpi.currencyApproxMissing', {
+          currencies: data.missingRateCurrencies.length ? data.missingRateCurrencies.join(', ') : currencySuffix,
+        })
+      : t('customers.deals.list.kpi.currencyApproxNoBase')
+    : null
+  const attentionLabel = pf('customers.deals.list.kpi.frag.needAttention', data.activeDeals.needAttention)
+
+  return (
+    <div className={wrapperClassName}>
+      {error ? (
+        <div className="flex items-center justify-between gap-3 rounded-lg border border-destructive/30 bg-destructive/5 px-3 py-2">
+          <p className="text-xs text-destructive">{error}</p>
+          <Button type="button" variant="destructive-outline" size="2xs" onClick={retry}>
+            {t('customers.deals.list.kpi.retry')}
+          </Button>
+        </div>
+      ) : null}
+      {loading ? (
+        <div className="flex items-center justify-end gap-2 text-xs text-muted-foreground">
+          <Spinner className="h-3 w-3" />
+          <span>{t('customers.deals.list.kpi.updating')}</span>
+        </div>
+      ) : null}
+      <div className={gridClassName}>
+        <DealKpiCard
+          title={t('customers.deals.list.kpi.pipelineValue')}
+          value={data.pipelineValue.value}
+          formatValue={formatCompact}
+          suffix={currencySuffix}
+          headerAction={
+            <KpiDeltaBadge
+              direction={data.pipelineValue.delta.direction}
+              value={data.pipelineValue.delta.value}
+              title={data.pipelineValue.delta.direction === 'unchanged' && data.pipelineValue.delta.value === 0 ? deltaUnavailableTooltip : deltaTooltip}
+            />
+          }
+          footer={
+            <div className="space-y-2">
+              <p className="text-xs text-muted-foreground">{scopeLabel}</p>
+              <p className="text-xs text-muted-foreground">
+                {t('customers.deals.list.kpi.activeAcrossPipelines', {
+                  deals: pf('customers.deals.list.kpi.frag.activeDeals', data.activeDeals.value),
+                  pipelines: pf('customers.deals.list.kpi.frag.pipelines', pipelineCount),
+                })}
+              </p>
+              {currencyHint ? <p className="text-xs text-muted-foreground">{currencyHint}</p> : null}
+              <PipelineStageBar
+                stages={data.pipelineValue.stages}
+                stageDictionary={stageDictionary}
+                unassignedLabel={unassignedLabel}
+              />
+            </div>
+          }
+        />
+
+        <DealKpiCard
+          title={t('customers.deals.list.kpi.activeDeals')}
+          value={data.activeDeals.value}
+          formatValue={formatCompact}
+          headerAction={
+            <KpiDeltaBadge
+              direction={data.activeDeals.delta.direction}
+              value={data.activeDeals.delta.value}
+              title={data.activeDeals.delta.direction === 'unchanged' && data.activeDeals.delta.value === 0 ? deltaUnavailableTooltip : deltaTooltip}
+            />
+          }
+          footer={
+            <div className="space-y-2">
+              <p className="text-xs text-muted-foreground">{scopeLabel}</p>
+              <div className="flex flex-wrap items-center gap-x-1.5 gap-y-1 text-xs text-muted-foreground">
+                <span>{pf('customers.deals.list.kpi.frag.owners', data.activeDeals.ownersCount)}</span>
+                <span aria-hidden="true">·</span>
+                {onNeedsAttentionClick && data.activeDeals.needAttention > 0 ? (
+                  <Button
+                    type="button"
+                    variant="link"
+                    size="2xs"
+                    className="h-auto p-0 text-xs"
+                    onClick={onNeedsAttentionClick}
+                  >
+                    {attentionLabel}
+                  </Button>
+                ) : (
+                  <span>{attentionLabel}</span>
+                )}
+              </div>
+              {data.activeDeals.owners.length > 0 ? (
+                <AvatarStack max={4} size="sm" overflowCount={data.activeDeals.ownersOverflow}>
+                  {data.activeDeals.owners.map((owner) => {
+                    const ownerLabel = ownerNames[owner.id]?.trim() || unknownOwner
+                    return <Avatar key={owner.id} label={ownerLabel} size="sm" />
+                  })}
+                </AvatarStack>
+              ) : null}
+            </div>
+          }
+        />
+
+        <DealKpiCard
+          title={t('customers.deals.list.kpi.wonThisQuarter')}
+          value={data.wonThisQuarter.value}
+          formatValue={formatCompact}
+          suffix={currencySuffix}
+          headerAction={
+            <KpiDeltaBadge
+              direction={data.wonThisQuarter.delta.direction}
+              value={data.wonThisQuarter.delta.value}
+              title={data.wonThisQuarter.delta.direction === 'unchanged' && data.wonThisQuarter.delta.value === 0 ? deltaUnavailableTooltip : deltaTooltip}
+            />
+          }
+          footer={
+            <div className="space-y-1">
+              <p className="text-xs text-muted-foreground">{scopeLabel}</p>
+              <div className="flex items-center gap-1.5 text-xs text-muted-foreground">
+                <CheckCircle className="h-4 w-4 text-status-success-text" aria-hidden />
+                <span>
+                  {pf('customers.deals.list.kpi.frag.dealsClosed', data.wonThisQuarter.dealsClosed)}
+                </span>
+              </div>
+              <p className="text-xs text-muted-foreground">
+                {t('customers.deals.list.kpi.avgDeal', {
+                  value: `${formatCompact(data.wonThisQuarter.avgDeal)}${currencySuffix ? ` ${currencySuffix}` : ''}`,
+                })}
+              </p>
+              {currencyHint ? <p className="text-xs text-muted-foreground">{currencyHint}</p> : null}
+            </div>
+          }
+        />
+
+        <DealKpiCard
+          title={t('customers.deals.list.kpi.winRate')}
+          value={data.winRate.value}
+          suffix="%"
+          headerAction={
+            <KpiDeltaBadge
+              direction={data.winRate.direction}
+              value={Math.abs(data.winRate.deltaPp)}
+              unit="pp"
+              title={data.winRate.previousValue === 0 ? deltaUnavailableTooltip : deltaTooltip}
+            />
+          }
+          footer={
+            <div className="space-y-2">
+              <p className="text-xs text-muted-foreground">{scopeLabel}</p>
+              <p className="text-xs text-muted-foreground">
+                {t('customers.deals.list.kpi.fromLastQuarter', { value: data.winRate.previousValue })}
+              </p>
+              <div className="text-primary">
+                <Sparkline
+                  values={data.winRate.series.map((point) => point.rate)}
+                  ariaLabel={t('customers.deals.list.kpi.winRate')}
+                />
+              </div>
+            </div>
+          }
+        />
+      </div>
+    </div>
+  )
+}
+
+export default DealsKpiStrip

package/src/modules/customers/components/detail/ConfirmDealLostDialog.tsx

@@ -116,7 +116,6 @@ export function ConfirmDealLostDialog({
 
           <div className="space-y-6 px-7 py-6">
             <Alert variant="warning" className="rounded-md">
-              <AlertTriangle className="size-4" />
               <AlertTitle>
                 {t('customers.deals.detail.lost.warningTitle', 'This action closes the deal')}
               </AlertTitle>

package/src/modules/customers/components/detail/DealForm.tsx

@@ -38,6 +38,9 @@ export type DealFormBaseValues = {
   companyIds?: string[]
 }
 
+type PipelineOption = { id: string; name: string; isDefault: boolean }
+type PipelineStageOption = { id: string; label: string; order: number }
+
 export type DealFormSubmitPayload = {
   base: DealFormBaseValues
   custom: Record<string, unknown>
@@ -64,6 +67,8 @@ export type DealFormProps = {
   showAssociationsGroup?: boolean
   showVersionHistory?: boolean
   showCancelAction?: boolean
+  initialPipelineOptions?: PipelineOption[]
+  initialPipelineStageOptions?: PipelineStageOption[]
 }
 
 type EntityOption = {
@@ -92,6 +97,84 @@ type EntityMultiSelectProps = {
 
 const DEAL_ENTITY_IDS = [E.customers.customer_deal]
 const CURRENCY_PRIORITY = ['EUR', 'USD', 'GBP', 'PLN'] as const
+const PIPELINE_OPTIONS_TTL_MS = 60_000
+const PIPELINE_STAGE_OPTIONS_TTL_MS = 30_000
+
+type MetadataCacheEntry<T> = {
+  expiresAt: number
+  promise: Promise<T>
+}
+
+let pipelineOptionsCache: MetadataCacheEntry<PipelineOption[]> | null = null
+const pipelineStageOptionsCache = new Map<string, MetadataCacheEntry<PipelineStageOption[]>>()
+
+function isFreshCacheEntry<T>(entry: MetadataCacheEntry<T> | null | undefined): entry is MetadataCacheEntry<T> {
+  return Boolean(entry && entry.expiresAt > Date.now())
+}
+
+function normalizePipelineOptions(options: PipelineOption[] | undefined): PipelineOption[] {
+  const byId = new Map<string, PipelineOption>()
+  for (const option of options ?? []) {
+    if (!option.id) continue
+    byId.set(option.id, {
+      id: option.id,
+      name: option.name,
+      isDefault: option.isDefault === true,
+    })
+  }
+  return Array.from(byId.values())
+}
+
+function mergePipelineOptions(seed: PipelineOption[], loaded: PipelineOption[]): PipelineOption[] {
+  const byId = new Map<string, PipelineOption>()
+  for (const option of seed) byId.set(option.id, option)
+  for (const option of loaded) byId.set(option.id, option)
+  return Array.from(byId.values())
+}
+
+function normalizePipelineStageOptions(options: PipelineStageOption[] | undefined): PipelineStageOption[] {
+  return [...(options ?? [])]
+    .filter((option) => option.id)
+    .sort((left, right) => left.order - right.order)
+}
+
+async function fetchPipelineOptions(): Promise<PipelineOption[]> {
+  if (isFreshCacheEntry(pipelineOptionsCache)) return pipelineOptionsCache.promise
+  const entry: MetadataCacheEntry<PipelineOption[]> = {
+    expiresAt: Date.now() + PIPELINE_OPTIONS_TTL_MS,
+    promise: apiCall<{ items: PipelineOption[] }>('/api/customers/pipelines')
+      .then((call) => (call.ok && call.result?.items ? normalizePipelineOptions(call.result.items) : [])),
+  }
+  pipelineOptionsCache = entry
+  try {
+    return await entry.promise
+  } catch (error) {
+    if (pipelineOptionsCache === entry) pipelineOptionsCache = null
+    throw error
+  }
+}
+
+async function fetchPipelineStageOptions(pipelineId: string): Promise<PipelineStageOption[]> {
+  const cached = pipelineStageOptionsCache.get(pipelineId)
+  if (isFreshCacheEntry(cached)) return cached.promise
+  const entry: MetadataCacheEntry<PipelineStageOption[]> = {
+    expiresAt: Date.now() + PIPELINE_STAGE_OPTIONS_TTL_MS,
+    promise: apiCall<{ items: PipelineStageOption[] }>(`/api/customers/pipeline-stages?pipelineId=${encodeURIComponent(pipelineId)}`)
+      .then((call) => (call.ok && call.result?.items ? normalizePipelineStageOptions(call.result.items) : [])),
+  }
+  pipelineStageOptionsCache.set(pipelineId, entry)
+  try {
+    return await entry.promise
+  } catch (error) {
+    if (pipelineStageOptionsCache.get(pipelineId) === entry) pipelineStageOptionsCache.delete(pipelineId)
+    throw error
+  }
+}
+
+export function resetDealPipelineMetadataCacheForTests() {
+  pipelineOptionsCache = null
+  pipelineStageOptionsCache.clear()
+}
 
 const schema = z.object({
   title: z
@@ -647,6 +730,8 @@ export function DealForm({
   showAssociationsGroup = true,
   showVersionHistory = true,
   showCancelAction = true,
+  initialPipelineOptions,
+  initialPipelineStageOptions,
 }: DealFormProps) {
   const t = useT()
   const [pending, setPending] = React.useState(false)
@@ -733,25 +818,36 @@ export function DealForm({
   const disabled = pending || isSubmitting
   const canDelete = mode === 'edit' && typeof onDelete === 'function'
 
-  type PipelineOption = { id: string; name: string; isDefault: boolean }
-  type PipelineStageOption = { id: string; label: string; order: number }
+  const mountedRef = React.useRef(false)
+  const seedPipelineOptions = React.useMemo(
+    () => normalizePipelineOptions(initialPipelineOptions),
+    [initialPipelineOptions],
+  )
+  const seedPipelineStageOptions = React.useMemo(
+    () => Array.isArray(initialPipelineStageOptions) ? normalizePipelineStageOptions(initialPipelineStageOptions) : null,
+    [initialPipelineStageOptions],
+  )
+
+  const [pipelines, setPipelines] = React.useState<PipelineOption[]>(() => seedPipelineOptions)
+  const [pipelineStages, setPipelineStages] = React.useState<PipelineStageOption[]>(() => seedPipelineStageOptions ?? [])
 
-  const [pipelines, setPipelines] = React.useState<PipelineOption[]>([])
-  const [pipelineStages, setPipelineStages] = React.useState<PipelineStageOption[]>([])
+  React.useEffect(() => {
+    mountedRef.current = true
+    return () => {
+      mountedRef.current = false
+    }
+  }, [])
 
   const loadStagesForPipeline = React.useCallback(async (pipelineId: string) => {
     if (!pipelineId) {
-      setPipelineStages([])
+      if (mountedRef.current) setPipelineStages([])
       return
     }
     try {
-      const call = await apiCall<{ items: PipelineStageOption[] }>(`/api/customers/pipeline-stages?pipelineId=${encodeURIComponent(pipelineId)}`)
-      if (call.ok && call.result?.items) {
-        const sorted = [...call.result.items].sort((a, b) => a.order - b.order)
-        setPipelineStages(sorted)
-      }
+      const stages = await fetchPipelineStageOptions(pipelineId)
+      if (mountedRef.current) setPipelineStages(stages)
     } catch {
-      setPipelineStages([])
+      if (mountedRef.current) setPipelineStages([])
     }
   }, [])
 
@@ -759,24 +855,30 @@ export function DealForm({
     let cancelled = false
     ;(async () => {
       try {
-        const call = await apiCall<{ items: PipelineOption[] }>('/api/customers/pipelines')
-        if (cancelled) return
-        if (call.ok && call.result?.items) {
-          setPipelines(call.result.items)
-        }
+        const loaded = await fetchPipelineOptions()
+        if (cancelled || !mountedRef.current) return
+        setPipelines(mergePipelineOptions(seedPipelineOptions, loaded))
       } catch {
-        // ignore
+        if (!cancelled && mountedRef.current && seedPipelineOptions.length > 0) {
+          setPipelines(seedPipelineOptions)
+        }
       }
     })().catch(() => {})
     return () => { cancelled = true }
-  }, [])
+  }, [seedPipelineOptions])
 
   React.useEffect(() => {
     const pid = initialValues?.pipelineId
     if (typeof pid === 'string' && pid.length) {
+      if (seedPipelineStageOptions) {
+        setPipelineStages(seedPipelineStageOptions)
+        return
+      }
       loadStagesForPipeline(pid).catch(() => {})
+    } else {
+      setPipelineStages([])
     }
-  }, [initialValues?.pipelineId, loadStagesForPipeline])
+  }, [initialValues?.pipelineId, loadStagesForPipeline, seedPipelineStageOptions])
 
   const baseFields = React.useMemo<CrudField[]>(() => [
     {

package/src/modules/customers/components/detail/PersonDetailTabs.tsx

@@ -13,6 +13,7 @@ import {
   History,
   Paperclip,
   Plus,
+  MapPin,
 } from 'lucide-react'
 import type { SectionAction } from '@open-mercato/ui/backend/detail'
 
@@ -21,6 +22,7 @@ export type PersonTabId =
   | 'emails'
   | 'deals'
   | 'companies'
+  | 'addresses'
   | 'tasks'
   | 'changelog'
   | 'files'
@@ -40,13 +42,14 @@ type PersonDetailTabsProps = {
   activitiesCount?: number
   dealsCount?: number
   companiesCount?: number
+  addressesCount?: number
   tasksCount?: number
   filesCount?: number
   sectionAction?: SectionAction | null
   children: React.ReactNode
 }
 
-const SUPPORTED_TAB_IDS = new Set<PersonTabId>(['activities', 'emails', 'deals', 'companies', 'tasks', 'changelog', 'files'])
+const SUPPORTED_TAB_IDS = new Set<PersonTabId>(['activities', 'emails', 'deals', 'companies', 'addresses', 'tasks', 'changelog', 'files'])
 
 export function resolveLegacyTab(tab: string | null | undefined): PersonTabId {
   if (!tab) return 'activities'
@@ -77,6 +80,7 @@ export function PersonDetailTabs({
   activitiesCount = 0,
   dealsCount = 0,
   companiesCount = 0,
+  addressesCount = 0,
   tasksCount = 0,
   filesCount = 0,
   sectionAction = null,
@@ -109,6 +113,12 @@ export function PersonDetailTabs({
         icon: <Building2 className="size-4" />,
         badge: <CountBadge count={companiesCount} />,
       },
+      {
+        id: 'addresses',
+        label: t('customers.people.detail.tabs.addresses', 'Addresses'),
+        icon: <MapPin className="size-4" />,
+        badge: <CountBadge count={addressesCount} />,
+      },
       {
         id: 'tasks',
         label: t('customers.people.detail.tabs.tasks', 'Tasks'),
@@ -128,7 +138,7 @@ export function PersonDetailTabs({
         badge: <CountBadge count={filesCount} />,
       },
     ],
-    [t, activitiesCount, dealsCount, companiesCount, tasksCount, filesCount],
+    [t, activitiesCount, dealsCount, companiesCount, addressesCount, tasksCount, filesCount],
   )
 
   const allTabs: TabDef[] = React.useMemo(

package/src/modules/customers/components/detail/ScheduleActivityDialog.tsx

@@ -1,7 +1,7 @@
 'use client'
 
 import * as React from 'react'
-import { Users, Phone, Check, Mail, Calendar, AlertTriangle, X, StickyNote } from 'lucide-react'
+import { Users, Phone, Check, Mail, Calendar, X, StickyNote } from 'lucide-react'
 import { cn } from '@open-mercato/shared/lib/utils'
 import { useT } from '@open-mercato/shared/lib/i18n/context'
 import { validatePhoneNumber } from '@open-mercato/shared/lib/phone'
@@ -498,7 +498,6 @@ export function ScheduleActivityDialog({
         {/* Conflict warning */}
         {state.conflict && (
           <Alert variant="warning" className="rounded-lg">
-            <AlertTriangle className="size-5" />
             <AlertTitle>
               {t('customers.schedule.conflict.title', 'Calendar conflict')}
             </AlertTitle>