@open-mercato/core 0.4.5-develop-811deeb983 → 0.4.5-develop-3d8e759e45

package/src/modules/inbox_ops/components/proposals/ActionCard.tsx

@@ -19,6 +19,61 @@ import {
   ShoppingBag,
 } from 'lucide-react'
 import type { ActionDetail, DiscrepancyDetail } from './types'
+import { hasContactNameIssue } from '../../lib/contactValidation'
+
+export { hasContactNameIssue }
+
+/**
+ * Resolves discrepancy description i18n keys stored in the database.
+ * Falls back to the raw description string for legacy data or LLM-generated descriptions.
+ */
+export function useDiscrepancyDescriptions(): (description: string, foundValue?: string | null) => string {
+  const t = useT()
+  const translations: Record<string, string> = {
+    'inbox_ops.discrepancy.desc.no_channel': t('inbox_ops.discrepancy.desc.no_channel', 'No sales channel available. Create a channel in Sales settings before accepting this order.'),
+    'inbox_ops.discrepancy.desc.no_currency': t('inbox_ops.discrepancy.desc.no_currency', 'No currency could be resolved for this order. Set a currency code or configure a sales channel with a default currency.'),
+    'inbox_ops.discrepancy.desc.product_not_matched': t('inbox_ops.discrepancy.desc.product_not_matched', 'Product could not be matched to any catalog product'),
+    'inbox_ops.discrepancy.desc.no_matching_contact': t('inbox_ops.discrepancy.desc.no_matching_contact', 'No matching contact found'),
+    'inbox_ops.discrepancy.desc.draft_reply_no_contact': t('inbox_ops.discrepancy.desc.draft_reply_no_contact', 'Draft reply target has no matching contact. Create the contact first.'),
+    'inbox_ops.discrepancy.desc.duplicate_order_reference': t('inbox_ops.discrepancy.desc.duplicate_order_reference', 'An order with this customer reference already exists'),
+  }
+  return (description: string, foundValue?: string | null) => {
+    const translated = translations[description]
+    if (!translated) return description
+    if (foundValue && (description === 'inbox_ops.discrepancy.desc.product_not_matched' || description === 'inbox_ops.discrepancy.desc.no_matching_contact')) {
+      return `${translated}: ${foundValue}`
+    }
+    return translated
+  }
+}
+
+/**
+ * Resolves action description i18n keys stored in the database.
+ * Auto-generated actions store keys like `inbox_ops.action.desc.create_contact`;
+ * LLM-generated actions store plain text which is returned as-is.
+ */
+export function useActionDescriptionResolver(): (description: string, payload: Record<string, unknown>) => string {
+  const t = useT()
+  return (description: string, payload: Record<string, unknown>) => {
+    if (!description.startsWith('inbox_ops.action.desc.')) return description
+    const name = (payload.name as string) || (payload.contactName as string) || ''
+    const email = (payload.email as string) || (payload.emailAddress as string) || ''
+    const title = (payload.title as string) || ''
+    const toName = (payload.toName as string) || (payload.to as string) || ''
+    const subject = (payload.subject as string) || ''
+    const translations: Record<string, string> = {
+      'inbox_ops.action.desc.create_contact': t('inbox_ops.action.desc.create_contact', 'Create contact for {name} ({email})')
+        .replace('{name}', name).replace('{email}', email),
+      'inbox_ops.action.desc.link_contact': t('inbox_ops.action.desc.link_contact', 'Link {name} ({email}) to existing contact')
+        .replace('{name}', name).replace('{email}', email),
+      'inbox_ops.action.desc.create_product': t('inbox_ops.action.desc.create_product', 'Create catalog product "{title}"')
+        .replace('{title}', title),
+      'inbox_ops.action.desc.draft_reply': t('inbox_ops.action.desc.draft_reply', 'Draft reply to {toName}: {subject}')
+        .replace('{toName}', toName).replace('{subject}', subject),
+    }
+    return translations[description] || description
+  }
+}
 
 const ACTION_TYPE_ICONS: Record<string, React.ElementType> = {
   create_order: Package,
@@ -169,6 +224,7 @@ export function ActionCard({
   onRetry,
   onEdit,
   translatedDescription,
+  resolveDiscrepancyDescription,
 }: {
   action: ActionDetail
   discrepancies: DiscrepancyDetail[]
@@ -178,14 +234,16 @@ export function ActionCard({
   onRetry: (id: string) => void
   onEdit: (action: ActionDetail) => void
   translatedDescription?: string
+  resolveDiscrepancyDescription?: (description: string, foundValue?: string | null) => string
 }) {
   const t = useT()
   const Icon = ACTION_TYPE_ICONS[action.actionType] || Package
   const label = actionTypeLabels[action.actionType] || action.actionType
+  const resolveActionDescription = useActionDescriptionResolver()
 
   const actionDiscrepancies = discrepancies.filter((d) => d.actionId === action.id && !d.resolved)
   const hasBlockingDiscrepancies = actionDiscrepancies.some((d) => d.severity === 'error')
-  const displayDescription = translatedDescription || action.description
+  const displayDescription = translatedDescription || resolveActionDescription(action.description, action.payload)
 
   if (action.status === 'executed') {
     return (
@@ -198,7 +256,7 @@ export function ActionCard({
         {action.createdEntityId && (
           <div className="mt-2">
             <span className="text-xs text-green-600">
-              Created {action.createdEntityType} · {action.executedAt && new Date(action.executedAt).toLocaleString()}
+              {t('inbox_ops.action.created_entity', 'Created {type}').replace('{type}', action.createdEntityType || '')} · {action.executedAt && new Date(action.executedAt).toLocaleString()}
             </span>
           </div>
         )}
@@ -233,6 +291,7 @@ export function ActionCard({
         )}
         <div className="mt-3 flex items-center gap-2">
           <Button
+            type="button"
             size="sm"
             className="h-11 md:h-9"
             onClick={() => onRetry(action.id)}
@@ -241,6 +300,7 @@ export function ActionCard({
             {t('inbox_ops.action.retry', 'Retry')}
           </Button>
           <Button
+            type="button"
             variant="outline"
             size="sm"
             className="h-11 md:h-9"
@@ -250,6 +310,7 @@ export function ActionCard({
             {t('inbox_ops.action.edit', 'Edit')}
           </Button>
           <Button
+            type="button"
             variant="outline"
             size="sm"
             className="h-11 md:h-9"
@@ -263,6 +324,8 @@ export function ActionCard({
     )
   }
 
+  const hasNameIssue = hasContactNameIssue(action)
+
   return (
     <div className="border rounded-lg p-3 md:p-4">
       <div className="flex items-center gap-2 mb-2">
@@ -288,12 +351,12 @@ export function ActionCard({
             }`}>
               <AlertTriangle className="h-3 w-3 mt-0.5 flex-shrink-0" />
               <div>
-                <span>{d.description}</span>
+                <span>{resolveDiscrepancyDescription ? resolveDiscrepancyDescription(d.description, d.foundValue) : d.description}</span>
                 {(d.expectedValue || d.foundValue) && (
                   <div className="mt-0.5 text-[11px] opacity-80">
-                    {d.expectedValue && <span>Expected: {d.expectedValue}</span>}
+                    {d.expectedValue && <span>{t('inbox_ops.discrepancy.expected', 'Expected')}: {d.expectedValue}</span>}
                     {d.expectedValue && d.foundValue && <span> · </span>}
-                    {d.foundValue && <span>Found: {d.foundValue}</span>}
+                    {d.foundValue && <span>{t('inbox_ops.discrepancy.found', 'Found')}: {d.foundValue}</span>}
                   </div>
                 )}
               </div>
@@ -302,19 +365,39 @@ export function ActionCard({
         </div>
       )}
 
+      {hasNameIssue && (
+        <div className="mb-3 flex items-start gap-2 text-xs rounded px-2 py-1.5 bg-amber-50 text-amber-700 dark:bg-amber-950/20 dark:text-amber-300">
+          <AlertTriangle className="h-3 w-3 mt-0.5 flex-shrink-0" />
+          <span>{action.actionType === 'link_contact'
+            ? t('inbox_ops.contact.link_name_missing_warning', 'Contact name is missing. Please edit and provide a name before accepting.')
+            : t('inbox_ops.contact.name_missing_warning', 'First and last name could not be extracted. Please edit before accepting.')
+          }</span>
+        </div>
+      )}
+
       <div className="flex items-center gap-2">
-        <div title={hasBlockingDiscrepancies ? t('inbox_ops.action.accept_blocked', 'Resolve errors before accepting') : undefined}>
+        <div title={
+          hasNameIssue
+            ? action.actionType === 'link_contact'
+              ? t('inbox_ops.contact.link_name_missing_warning', 'Contact name is missing. Please edit and provide a name before accepting.')
+              : t('inbox_ops.contact.name_missing_warning', 'First and last name could not be extracted. Please edit before accepting.')
+            : hasBlockingDiscrepancies
+              ? t('inbox_ops.action.accept_blocked', 'Resolve errors before accepting')
+              : undefined
+        }>
           <Button
+            type="button"
             size="sm"
             className="h-11 md:h-9"
             onClick={() => onAccept(action.id)}
-            disabled={hasBlockingDiscrepancies}
+            disabled={hasBlockingDiscrepancies || hasNameIssue}
           >
             <CheckCircle className="h-4 w-4 mr-1" />
             {t('inbox_ops.action.accept', 'Accept')}
           </Button>
         </div>
         <Button
+          type="button"
           variant="outline"
           size="sm"
           className="h-11 md:h-9"
@@ -324,6 +407,7 @@ export function ActionCard({
           {t('inbox_ops.action.edit', 'Edit')}
         </Button>
         <Button
+          type="button"
           variant="outline"
           size="sm"
           className="h-11 md:h-9"

package/src/modules/inbox_ops/components/proposals/EditActionDialog.tsx

@@ -3,6 +3,7 @@
 import * as React from 'react'
 import { Button } from '@open-mercato/ui/primitives/button'
 import { apiCall } from '@open-mercato/ui/backend/utils/apiCall'
+import { useGuardedMutation } from '@open-mercato/ui/backend/injection/useGuardedMutation'
 import { flash } from '@open-mercato/ui/backend/FlashMessages'
 import { useT } from '@open-mercato/shared/lib/i18n/context'
 import { Loader2 } from 'lucide-react'
@@ -75,18 +76,62 @@ function ContactPayloadEditor({
   updateField: (key: string, value: unknown) => void
 }) {
   const t = useT()
+  const type = (payload.type as string) || 'person'
+  const isPerson = type === 'person'
+
+  const existingName = (payload.name as string) || ''
+  const nameParts = existingName.trim().split(/\s+/).filter((p) => p.length > 0)
+  const [firstName, setFirstName] = React.useState(() => isPerson ? (nameParts[0] || '') : '')
+  const [lastName, setLastName] = React.useState(() => isPerson ? (nameParts.slice(1).join(' ') || '') : '')
+
+  const updatePersonName = React.useCallback((first: string, last: string) => {
+    const combined = `${first} ${last}`.trim()
+    updateField('name', combined)
+  }, [updateField])
+
+  const lastNameMissing = isPerson && !lastName.trim()
+
   return (
     <div className="space-y-3">
       <div className="grid grid-cols-2 gap-3">
-        <div>
-          <Label>{t('inbox_ops.edit_dialog.name', 'Name')}</Label>
-          <Input value={(payload.name as string) || ''} onChange={(event) => updateField('name', event.target.value)} />
-        </div>
+        {isPerson ? (
+          <>
+            <div>
+              <Label>{t('inbox_ops.contact.first_name', 'First Name')}</Label>
+              <Input
+                value={firstName}
+                onChange={(event) => {
+                  setFirstName(event.target.value)
+                  updatePersonName(event.target.value, lastName)
+                }}
+              />
+            </div>
+            <div>
+              <Label>{t('inbox_ops.contact.last_name', 'Last Name')}</Label>
+              <Input
+                value={lastName}
+                onChange={(event) => {
+                  setLastName(event.target.value)
+                  updatePersonName(firstName, event.target.value)
+                }}
+                className={lastNameMissing ? 'border-red-500' : ''}
+              />
+              {lastNameMissing && (
+                <p className="text-xs text-red-600 mt-1">{t('inbox_ops.contact.last_name_required', 'Last name is required')}</p>
+              )}
+            </div>
+          </>
+        ) : (
+          <div>
+            <Label>{t('inbox_ops.edit_dialog.name', 'Name')}</Label>
+            <Input value={existingName} onChange={(event) => updateField('name', event.target.value)} />
+          </div>
+        )}
         <div>
           <Label>{t('inbox_ops.edit_dialog.type', 'Type')}</Label>
           <select
             className="flex h-9 w-full rounded-md border border-input bg-transparent px-3 py-1 text-sm shadow-sm"
-            value={(payload.type as string) || 'person'}
+            value={type}
             onChange={(event) => updateField('type', event.target.value)}
           >
             <option value="person">{t('inbox_ops.contact_type.person', 'Person')}</option>
@@ -367,6 +412,9 @@ export function EditActionDialog({
   onSaved: () => void
 }) {
   const t = useT()
+  const { runMutation } = useGuardedMutation<Record<string, unknown>>({
+    contextId: 'inbox-ops-edit-action',
+  })
   const [payload, setPayload] = React.useState<Record<string, unknown>>(
     () => structuredClone(action.payload),
   )
@@ -388,10 +436,13 @@ export function EditActionDialog({
     }
 
     setIsSaving(true)
-    const result = await apiCall<{ ok: boolean; error?: string }>(
-      `/api/inbox_ops/proposals/${action.proposalId}/actions/${action.id}`,
-      { method: 'PATCH', body: JSON.stringify({ payload: finalPayload }) },
-    )
+    const result = await runMutation({
+      operation: () => apiCall<{ ok: boolean; error?: string }>(
+        `/api/inbox_ops/proposals/${action.proposalId}/actions/${action.id}`,
+        { method: 'PATCH', body: JSON.stringify({ payload: finalPayload }) },
+      ),
+      context: {},
+    })
     if (result?.ok && result.result?.ok) {
       flash(t('inbox_ops.edit_dialog.saved', 'Action updated successfully'), 'success')
       onSaved()
@@ -400,7 +451,7 @@ export function EditActionDialog({
       flash(result?.result?.error || t('inbox_ops.flash.save_failed', 'Failed to save'), 'error')
     }
     setIsSaving(false)
-  }, [action, payload, jsonMode, jsonText, t, onSaved, onClose])
+  }, [action, payload, jsonMode, jsonText, t, onSaved, onClose, runMutation])
 
   React.useEffect(() => {
     function handleKeyDown(event: KeyboardEvent) {
@@ -471,6 +522,7 @@ export function EditActionDialog({
 
           {hasTypedEditor && (
             <Button
+              type="button"
               variant="ghost"
               size="sm"
               onClick={() => {
@@ -494,10 +546,10 @@ export function EditActionDialog({
         </div>
 
         <DialogFooter>
-          <Button variant="outline" onClick={onClose} disabled={isSaving}>
+          <Button type="button" variant="outline" onClick={onClose} disabled={isSaving}>
             {t('inbox_ops.edit_dialog.cancel', 'Cancel')}
           </Button>
-          <Button onClick={handleSave} disabled={isSaving}>
+          <Button type="button" onClick={handleSave} disabled={isSaving}>
             {isSaving && <Loader2 className="h-4 w-4 animate-spin mr-1" />}
             {t('inbox_ops.edit_dialog.save', 'Save Changes')}
           </Button>

package/src/modules/inbox_ops/lib/constants.ts

@@ -1,5 +1,14 @@
 import type { InboxActionType } from '../data/entities'
 
+/**
+ * Synchronous action-type-to-RBAC-feature mapping.
+ *
+ * The generated inbox action registry (`getInboxAction(type)?.requiredFeature`)
+ * provides the same data but requires async loading. This map exists as the
+ * synchronous equivalent used by the extraction worker and execution engine.
+ *
+ * TODO: Consolidate with the generated registry once it supports sync access.
+ */
 export const REQUIRED_FEATURES_MAP: Record<InboxActionType, string> = {
   create_order: 'sales.orders.manage',
   create_quote: 'sales.quotes.manage',

package/src/modules/inbox_ops/lib/contactValidation.ts

@@ -0,0 +1,54 @@
+import type { InboxActionType } from '../data/entities'
+
+/**
+ * Check if a contact action has a name issue that prevents acceptance.
+ * - create_contact (person): requires first+last name (2+ space-separated parts)
+ * - link_contact: requires a non-empty contactName
+ */
+export function hasContactNameIssue(action: {
+  actionType: InboxActionType | string
+  payload: Record<string, unknown>
+}): boolean {
+  if (action.actionType === 'link_contact') {
+    const contactName = (action.payload.contactName as string) || ''
+    return contactName.trim().length === 0
+  }
+  if (action.actionType !== 'create_contact') return false
+  const type = (action.payload.type as string) || 'person'
+  if (type !== 'person') return false
+  const name = (action.payload.name as string) || ''
+  return name.trim().split(/\s+/).length < 2
+}
+
+/**
+ * Split a full name into first and last name parts.
+ * Falls back to deriving name parts from email when name is a single word.
+ */
+export function splitPersonName(name: string, email?: string): { firstName: string; lastName: string } {
+  const trimmed = name.trim()
+  const parts = trimmed.split(/\s+/).filter((item) => item.length > 0)
+
+  if (parts.length >= 2) {
+    return {
+      firstName: parts[0],
+      lastName: parts.slice(1).join(' '),
+    }
+  }
+
+  // Fallback: try to derive first/last from email address
+  if (email) {
+    const localPart = email.split('@')[0] || ''
+    const emailParts = localPart.split(/[._-]/).filter((p) => p.length > 0)
+    if (emailParts.length >= 2) {
+      return {
+        firstName: emailParts[0].charAt(0).toUpperCase() + emailParts[0].slice(1).toLowerCase(),
+        lastName: emailParts.slice(1).map((p) => p.charAt(0).toUpperCase() + p.slice(1).toLowerCase()).join(' '),
+      }
+    }
+  }
+
+  return {
+    firstName: parts[0] || trimmed,
+    lastName: '',
+  }
+}