@open-mercato/core 0.4.2-canary-f821f89ef6 → 0.4.2-canary-3b5064ce72

package/src/modules/business_rules/lib/__tests__/rule-engine.test.ts

@@ -654,6 +654,57 @@ describe('Rule Engine (Unit Tests)', () => {
       expect(result.errors).toBeDefined()
       expect(result.errors![0]).toContain('Rule count limit exceeded')
     })
+
+    test('should emit execution_failed event when rule evaluation fails', async () => {
+      const mockRule: Partial<BusinessRule> = {
+        id: 'rule-1',
+        ruleId: 'TEST-001',
+        ruleName: 'Test Rule',
+        ruleType: 'ACTION',
+        entityType: 'WorkOrder',
+        conditionExpression: { field: 'status', operator: '=', value: 'RELEASED' },
+        enabled: true,
+        tenantId: testTenantId,
+        organizationId: testOrgId,
+      }
+
+      mockEm.find.mockResolvedValue([mockRule as BusinessRule])
+      mockEm.create.mockReturnValue({ id: 'log-1' } as any)
+      mockEm.persistAndFlush.mockResolvedValue(undefined)
+
+      jest.mocked(ruleEvaluator.evaluateSingleRule).mockResolvedValue({
+        rule: mockRule as BusinessRule,
+        conditionsPassed: false,
+        evaluationCompleted: false,
+        evaluationTime: 1,
+        error: 'Evaluation error',
+      })
+
+      const eventBus = { emitEvent: jest.fn().mockResolvedValue(undefined) }
+
+      const context: RuleEngineContext = {
+        entityType: 'WorkOrder',
+        entityId: testEntityId,
+        data: { status: 'RELEASED' },
+        tenantId: testTenantId,
+        organizationId: testOrgId,
+        dryRun: false,
+      }
+
+      await ruleEngine.executeRules(mockEm, context, { eventBus })
+
+      expect(eventBus.emitEvent).toHaveBeenCalledWith(
+        'business_rules.rule.execution_failed',
+        expect.objectContaining({
+          ruleId: 'TEST-001',
+          ruleName: 'Test Rule',
+          entityType: 'WorkOrder',
+          errorMessage: 'Evaluation error',
+          tenantId: testTenantId,
+          organizationId: testOrgId,
+        })
+      )
+    })
   })
 
   describe('logRuleExecution', () => {

package/src/modules/business_rules/lib/rule-engine.ts

@@ -1,10 +1,11 @@
 import type { EntityManager } from '@mikro-orm/core'
+import type { EventBus } from '@open-mercato/events'
 import { BusinessRule, RuleExecutionLog, type RuleType } from '../data/entities'
 import * as ruleEvaluator from './rule-evaluator'
 import * as actionExecutor from './action-executor'
 import type { RuleEvaluationContext } from './rule-evaluator'
 import type { ActionContext, ActionExecutionOutcome } from './action-executor'
-import { ruleEngineContextSchema, ruleDiscoveryOptionsSchema, directRuleExecutionContextSchema, ruleIdExecutionContextSchema } from '../data/validators'
+import { ruleEngineContextSchema, ruleDiscoveryOptionsSchema } from '../data/validators'
 
 /**
  * Constants
@@ -85,63 +86,17 @@ export interface RuleDiscoveryOptions {
   ruleType?: RuleType
 }
 
-/**
- * Direct rule execution context (for executing a specific rule by ID)
- */
-export interface DirectRuleExecutionContext {
-  ruleId: string  // Database UUID of the rule
-  data: any
-  user?: {
-    id?: string
-    email?: string
-    role?: string
-    [key: string]: any
-  }
-  tenantId: string
-  organizationId: string
-  executedBy?: string
-  dryRun?: boolean
-  // Optional for logging (falls back to rule's entityType)
-  entityType?: string
-  entityId?: string
-  eventType?: string
+export type RuleEngineExecutionOptions = {
+  eventBus?: Pick<EventBus, 'emitEvent'> | null
 }
 
-/**
- * Direct rule execution result
- */
-export interface DirectRuleExecutionResult {
-  success: boolean
+type RuleExecutionFailedPayload = {
   ruleId: string
   ruleName: string
-  conditionResult: boolean
-  actionsExecuted: ActionExecutionOutcome | null
-  executionTime: number
-  error?: string
-  logId?: string
-}
-
-/**
- * Context for executing a rule by its string rule_id identifier
- * Unlike DirectRuleExecutionContext which uses database UUID,
- * this uses the string identifier (e.g., "workflow_checkout_inventory_available")
- */
-export interface RuleIdExecutionContext {
-  ruleId: string  // String identifier (e.g., "workflow_checkout_inventory_available")
-  data: any
-  user?: {
-    id?: string
-    email?: string
-    role?: string
-    [key: string]: any
-  }
+  entityType?: string | null
+  errorMessage?: string | null
   tenantId: string
-  organizationId: string
-  executedBy?: string
-  dryRun?: boolean
-  entityType?: string
-  entityId?: string
-  eventType?: string
+  organizationId?: string | null
 }
 
 /**
@@ -172,7 +127,8 @@ async function withTimeout<T>(
  */
 export async function executeRules(
   em: EntityManager,
-  context: RuleEngineContext
+  context: RuleEngineContext,
+  options: RuleEngineExecutionOptions = {}
 ): Promise<RuleEngineResult> {
   // Validate input
   const validation = ruleEngineContextSchema.safeParse(context)
@@ -218,7 +174,7 @@ export async function executeRules(
     const executionPromise = (async () => {
       for (const rule of rules) {
       try {
-        const ruleResult = await executeSingleRule(em, rule, context)
+        const ruleResult = await executeSingleRule(em, rule, context, options)
         executedRules.push(ruleResult)
 
         if (ruleResult.logId) {
@@ -236,6 +192,17 @@ export async function executeRules(
           `Unexpected error in rule execution [ruleId=${rule.ruleId}, type=${rule.ruleType}]: ${errorMessage}`
         )
 
+        if (!context.dryRun) {
+          await emitRuleExecutionFailed(options.eventBus, {
+            ruleId: rule.ruleId,
+            ruleName: rule.ruleName,
+            entityType: context.entityType ?? null,
+            errorMessage,
+            tenantId: context.tenantId,
+            organizationId: context.organizationId ?? null,
+          })
+        }
+
         executedRules.push({
           rule,
           conditionResult: false,
@@ -292,7 +259,8 @@ export async function executeRules(
 export async function executeSingleRule(
   em: EntityManager,
   rule: BusinessRule,
-  context: RuleEngineContext
+  context: RuleEngineContext,
+  options: RuleEngineExecutionOptions = {}
 ): Promise<RuleExecutionResult> {
   const startTime = Date.now()
 
@@ -328,6 +296,15 @@ export async function executeSingleRule(
             executionTime,
             error: result.error,
           })
+
+          await emitRuleExecutionFailed(options.eventBus, {
+            ruleId: rule.ruleId,
+            ruleName: rule.ruleName,
+            entityType: context.entityType ?? null,
+            errorMessage: result.error ?? null,
+            tenantId: context.tenantId,
+            organizationId: context.organizationId ?? null,
+          })
         }
 
         return {
@@ -405,6 +382,15 @@ export async function executeSingleRule(
         executionTime,
         error: enhancedError,
       })
+
+      await emitRuleExecutionFailed(options.eventBus, {
+        ruleId: rule.ruleId,
+        ruleName: rule.ruleName,
+        entityType: context.entityType ?? null,
+        errorMessage: enhancedError,
+        tenantId: context.tenantId,
+        organizationId: context.organizationId ?? null,
+      })
     }
 
     return {
@@ -463,227 +449,6 @@ export async function findApplicableRules(
   })
 }
 
-/**
- * Execute a specific rule by its database UUID
- * This bypasses the entityType/eventType discovery mechanism and directly executes the rule
- */
-export async function executeRuleById(
-  em: EntityManager,
-  context: DirectRuleExecutionContext
-): Promise<DirectRuleExecutionResult> {
-  const startTime = Date.now()
-
-  // Validate input
-  const validation = directRuleExecutionContextSchema.safeParse(context)
-  if (!validation.success) {
-    const validationErrors = validation.error.issues.map(e => `${e.path.join('.')}: ${e.message}`)
-    return {
-      success: false,
-      ruleId: context.ruleId,
-      ruleName: 'Unknown',
-      conditionResult: false,
-      actionsExecuted: null,
-      executionTime: Date.now() - startTime,
-      error: `Validation failed: ${validationErrors.join(', ')}`,
-    }
-  }
-
-  // Fetch rule by ID with tenant/org validation
-  const rule = await em.findOne(BusinessRule, {
-    id: context.ruleId,
-    tenantId: context.tenantId,
-    organizationId: context.organizationId,
-    deletedAt: null,
-  })
-
-  if (!rule) {
-    return {
-      success: false,
-      ruleId: context.ruleId,
-      ruleName: 'Unknown',
-      conditionResult: false,
-      actionsExecuted: null,
-      executionTime: Date.now() - startTime,
-      error: 'Rule not found',
-    }
-  }
-
-  if (!rule.enabled) {
-    return {
-      success: false,
-      ruleId: rule.ruleId,
-      ruleName: rule.ruleName,
-      conditionResult: false,
-      actionsExecuted: null,
-      executionTime: Date.now() - startTime,
-      error: 'Rule is disabled',
-    }
-  }
-
-  // Check effective date range
-  const now = new Date()
-  if (rule.effectiveFrom && rule.effectiveFrom > now) {
-    return {
-      success: false,
-      ruleId: rule.ruleId,
-      ruleName: rule.ruleName,
-      conditionResult: false,
-      actionsExecuted: null,
-      executionTime: Date.now() - startTime,
-      error: `Rule is not yet effective (starts ${rule.effectiveFrom.toISOString()})`,
-    }
-  }
-  if (rule.effectiveTo && rule.effectiveTo < now) {
-    return {
-      success: false,
-      ruleId: rule.ruleId,
-      ruleName: rule.ruleName,
-      conditionResult: false,
-      actionsExecuted: null,
-      executionTime: Date.now() - startTime,
-      error: `Rule has expired (ended ${rule.effectiveTo.toISOString()})`,
-    }
-  }
-
-  // Build RuleEngineContext (use provided entityType or fall back to rule's)
-  const engineContext: RuleEngineContext = {
-    entityType: context.entityType || rule.entityType,
-    entityId: context.entityId,
-    eventType: context.eventType || rule.eventType || undefined,
-    data: context.data,
-    user: context.user,
-    tenantId: context.tenantId,
-    organizationId: context.organizationId,
-    executedBy: context.executedBy,
-    dryRun: context.dryRun,
-  }
-
-  // Execute via existing executeSingleRule
-  const result = await executeSingleRule(em, rule, engineContext)
-
-  return {
-    success: !result.error,
-    ruleId: rule.ruleId,
-    ruleName: rule.ruleName,
-    conditionResult: result.conditionResult,
-    actionsExecuted: result.actionsExecuted,
-    executionTime: result.executionTime,
-    error: result.error,
-    logId: result.logId,
-  }
-}
-
-/**
- * Execute a rule by its string rule_id identifier
- * Looks up rule by rule_id (string column) + tenant_id (unique constraint)
- * This is useful for workflow conditions that reference rules by their string identifiers
- */
-export async function executeRuleByRuleId(
-  em: EntityManager,
-  context: RuleIdExecutionContext
-): Promise<DirectRuleExecutionResult> {
-  const startTime = Date.now()
-
-  // Validate input
-  const validation = ruleIdExecutionContextSchema.safeParse(context)
-  if (!validation.success) {
-    const validationErrors = validation.error.issues.map(e => `${e.path.join('.')}: ${e.message}`)
-    return {
-      success: false,
-      ruleId: context.ruleId || 'unknown',
-      ruleName: 'Unknown',
-      conditionResult: false,
-      actionsExecuted: null,
-      executionTime: Date.now() - startTime,
-      error: `Validation failed: ${validationErrors.join(', ')}`,
-    }
-  }
-
-  // Fetch rule by rule_id (string identifier) + tenant/org
-  const rule = await em.findOne(BusinessRule, {
-    ruleId: context.ruleId,  // String identifier column
-    tenantId: context.tenantId,
-    organizationId: context.organizationId,
-    deletedAt: null,
-  })
-
-  if (!rule) {
-    return {
-      success: false,
-      ruleId: context.ruleId,
-      ruleName: 'Unknown',
-      conditionResult: false,
-      actionsExecuted: null,
-      executionTime: Date.now() - startTime,
-      error: 'Rule not found',
-    }
-  }
-
-  if (!rule.enabled) {
-    return {
-      success: false,
-      ruleId: rule.ruleId,
-      ruleName: rule.ruleName,
-      conditionResult: false,
-      actionsExecuted: null,
-      executionTime: Date.now() - startTime,
-      error: 'Rule is disabled',
-    }
-  }
-
-  // Check effective date range
-  const now = new Date()
-  if (rule.effectiveFrom && rule.effectiveFrom > now) {
-    return {
-      success: false,
-      ruleId: rule.ruleId,
-      ruleName: rule.ruleName,
-      conditionResult: false,
-      actionsExecuted: null,
-      executionTime: Date.now() - startTime,
-      error: `Rule is not yet effective (starts ${rule.effectiveFrom.toISOString()})`,
-    }
-  }
-  if (rule.effectiveTo && rule.effectiveTo < now) {
-    return {
-      success: false,
-      ruleId: rule.ruleId,
-      ruleName: rule.ruleName,
-      conditionResult: false,
-      actionsExecuted: null,
-      executionTime: Date.now() - startTime,
-      error: `Rule has expired (ended ${rule.effectiveTo.toISOString()})`,
-    }
-  }
-
-  // Build RuleEngineContext (use provided entityType or fall back to rule's)
-  const engineContext: RuleEngineContext = {
-    entityType: context.entityType || rule.entityType,
-    entityId: context.entityId,
-    eventType: context.eventType || rule.eventType || undefined,
-    data: context.data,
-    user: context.user,
-    tenantId: context.tenantId,
-    organizationId: context.organizationId,
-    executedBy: context.executedBy,
-    dryRun: context.dryRun,
-  }
-
-  // Execute via existing executeSingleRule
-  const result = await executeSingleRule(em, rule, engineContext)
-
-  return {
-    success: !result.error,
-    ruleId: rule.ruleId,
-    ruleName: rule.ruleName,
-    conditionResult: result.conditionResult,
-    actionsExecuted: result.actionsExecuted,
-    executionTime: result.executionTime,
-    error: result.error,
-    logId: result.logId,
-  }
-}
-
 /**
  * Sensitive field patterns to exclude from logs
  */
@@ -824,3 +589,12 @@ export async function logRuleExecution(
 
   return log.id
 }
+
+async function emitRuleExecutionFailed(
+  eventBus: Pick<EventBus, 'emitEvent'> | null | undefined,
+  payload: RuleExecutionFailedPayload
+): Promise<void> {
+  if (!eventBus?.emitEvent) return
+
+  await eventBus.emitEvent('business_rules.rule.execution_failed', payload).catch(() => undefined)
+}

package/src/modules/business_rules/notifications.ts

@@ -0,0 +1,25 @@
+import type { NotificationTypeDefinition } from '@open-mercato/shared/modules/notifications/types'
+
+export const notificationTypes: NotificationTypeDefinition[] = [
+  {
+    type: 'business_rules.rule.execution_failed',
+    module: 'business_rules',
+    titleKey: 'businessRules.notifications.rule.executionFailed.title',
+    bodyKey: 'businessRules.notifications.rule.executionFailed.body',
+    icon: 'alert-triangle',
+    severity: 'error',
+    actions: [
+      {
+        id: 'view',
+        labelKey: 'common.view',
+        variant: 'outline',
+        href: '/backend/business-rules/{sourceEntityId}',
+        icon: 'external-link',
+      },
+    ],
+    linkHref: '/backend/business-rules/{sourceEntityId}',
+    expiresAfterHours: 168, // 7 days
+  },
+]
+
+export default notificationTypes

package/src/modules/business_rules/subscribers/rule-execution-failed-notification.ts

@@ -0,0 +1,50 @@
+import type { EntityManager } from '@mikro-orm/postgresql'
+import { resolveNotificationService } from '../../notifications/lib/notificationService'
+import { buildFeatureNotificationFromType } from '../../notifications/lib/notificationBuilder'
+import { notificationTypes } from '../notifications'
+
+export const metadata = {
+  event: 'business_rules.rule.execution_failed',
+  persistent: true,
+  id: 'business_rules:rule-execution-failed-notification',
+}
+
+type RuleExecutionFailedPayload = {
+  ruleId: string
+  ruleName: string
+  entityType?: string | null
+  errorMessage?: string | null
+  tenantId: string
+  organizationId?: string | null
+}
+
+type ResolverContext = {
+  resolve: <T = unknown>(name: string) => T
+}
+
+export default async function handle(payload: RuleExecutionFailedPayload, ctx: ResolverContext) {
+  try {
+    const notificationService = resolveNotificationService(ctx)
+    const typeDef = notificationTypes.find((type) => type.type === 'business_rules.rule.execution_failed')
+    if (!typeDef) return
+
+    const notificationInput = buildFeatureNotificationFromType(typeDef, {
+      requiredFeature: 'business_rules.manage',
+      bodyVariables: {
+        ruleName: payload.ruleName,
+        entityType: payload.entityType ?? '',
+        errorMessage: payload.errorMessage ?? 'Unknown error',
+      },
+      sourceEntityType: 'business_rules:rule',
+      sourceEntityId: payload.ruleId,
+      linkHref: `/backend/business-rules/${payload.ruleId}`,
+    })
+
+    await notificationService.createForFeature(notificationInput, {
+      tenantId: payload.tenantId,
+      organizationId: payload.organizationId ?? null,
+    })
+  } catch (err) {
+    console.error('[business_rules:rule-execution-failed-notification] Failed to create notification:', err)
+  }
+}

package/src/modules/catalog/components/PriceKindSettings.tsx

@@ -420,10 +420,12 @@ export function PriceKindSettings() {
             <RowActions
               items={[
                 {
+                  id: 'edit',
                   label: t('catalog.priceKinds.actions.edit', 'Edit'),
                   onSelect: () => openDialog({ mode: 'edit', entry }),
                 },
                 {
+                  id: 'delete',
                   label: t('catalog.priceKinds.actions.delete', 'Delete'),
                   destructive: true,
                   onSelect: () => { void handleDelete(entry) },

package/src/modules/catalog/components/categories/CategoriesDataTable.tsx

@@ -221,8 +221,8 @@ export default function CategoriesDataTable() {
         canManage ? (
           <RowActions
             items={[
-              { label: t('catalog.categories.list.actions.edit', 'Edit'), href: `/backend/catalog/categories/${row.id}/edit` },
-              { label: t('catalog.categories.list.actions.delete', 'Delete'), destructive: true, onSelect: () => handleDelete(row) },
+              { id: 'edit', label: t('catalog.categories.list.actions.edit', 'Edit'), href: `/backend/catalog/categories/${row.id}/edit` },
+              { id: 'delete', label: t('catalog.categories.list.actions.delete', 'Delete'), destructive: true, onSelect: () => handleDelete(row) },
             ]}
           />
         ) : null

package/src/modules/catalog/components/products/ProductsDataTable.tsx

@@ -650,10 +650,12 @@ export default function ProductsDataTable() {
         <RowActions
           items={[
             {
+              id: 'edit',
               label: t('catalog.products.table.actions.edit', 'Edit'),
               href: `/backend/catalog/products/${row.id}`,
             },
             {
+              id: 'delete',
               label: t('catalog.products.table.actions.delete', 'Delete'),
               destructive: true,
               onSelect: () => {

package/src/modules/catalog/i18n/en.json

@@ -681,5 +681,7 @@
         "deleteError": "Failed to delete variant."
       }
     }
-  }
+  },
+  "catalog.notifications.product.lowStock.title": "Low Stock Alert",
+  "catalog.notifications.product.lowStock.body": "{productName}{sku, select, other { ({sku})}} is running low on stock ({currentStock} remaining, threshold: {threshold})"
 }

package/src/modules/catalog/notifications.ts

@@ -0,0 +1,25 @@
+import type { NotificationTypeDefinition } from '@open-mercato/shared/modules/notifications/types'
+
+export const notificationTypes: NotificationTypeDefinition[] = [
+  {
+    type: 'catalog.product.low_stock',
+    module: 'catalog',
+    titleKey: 'catalog.notifications.product.lowStock.title',
+    bodyKey: 'catalog.notifications.product.lowStock.body',
+    icon: 'package-x',
+    severity: 'warning',
+    actions: [
+      {
+        id: 'view',
+        labelKey: 'common.view',
+        variant: 'outline',
+        href: '/backend/catalog/products/{sourceEntityId}',
+        icon: 'external-link',
+      },
+    ],
+    linkHref: '/backend/catalog/products/{sourceEntityId}',
+    expiresAfterHours: 72, // 3 days
+  },
+]
+
+export default notificationTypes

package/src/modules/catalog/subscribers/low-stock-notification.ts

@@ -0,0 +1,52 @@
+import type { EntityManager } from '@mikro-orm/postgresql'
+import { resolveNotificationService } from '../../notifications/lib/notificationService'
+import { buildFeatureNotificationFromType } from '../../notifications/lib/notificationBuilder'
+import { notificationTypes } from '../notifications'
+
+export const metadata = {
+  event: 'catalog.product.stock_low',
+  persistent: true,
+  id: 'catalog:low-stock-notification',
+}
+
+type LowStockPayload = {
+  productId: string
+  productName: string
+  sku?: string | null
+  currentStock: number
+  threshold: number
+  tenantId: string
+  organizationId?: string | null
+}
+
+type ResolverContext = {
+  resolve: <T = unknown>(name: string) => T
+}
+
+export default async function handle(payload: LowStockPayload, ctx: ResolverContext) {
+  try {
+    const notificationService = resolveNotificationService(ctx)
+    const typeDef = notificationTypes.find((type) => type.type === 'catalog.product.low_stock')
+    if (!typeDef) return
+
+    const notificationInput = buildFeatureNotificationFromType(typeDef, {
+      requiredFeature: 'catalog.products.manage',
+      bodyVariables: {
+        productName: payload.productName,
+        sku: payload.sku ?? '',
+        currentStock: String(payload.currentStock),
+        threshold: String(payload.threshold),
+      },
+      sourceEntityType: 'catalog:product',
+      sourceEntityId: payload.productId,
+      linkHref: `/backend/catalog/products/${payload.productId}`,
+    })
+
+    await notificationService.createForFeature(notificationInput, {
+      tenantId: payload.tenantId,
+      organizationId: payload.organizationId ?? null,
+    })
+  } catch (err) {
+    console.error('[catalog:low-stock-notification] Failed to create notification:', err)
+  }
+}

package/src/modules/configs/cli.ts

@@ -2,6 +2,7 @@ import type { ModuleCli } from '@open-mercato/shared/modules/registry'
 import { createRequestContainer } from '@open-mercato/shared/lib/di/container'
 import type { ModuleConfigService } from './lib/module-config-service'
 import { parseBooleanToken } from '@open-mercato/shared/lib/boolean'
+import { DEFAULT_NOTIFICATION_DELIVERY_CONFIG, NOTIFICATIONS_DELIVERY_CONFIG_KEY } from '../notifications/lib/deliveryConfig'
 
 function envDisablesAutoIndexing(): boolean {
   const raw = process.env.DISABLE_VECTOR_SEARCH_AUTOINDEXING
@@ -31,6 +32,11 @@ const restoreDefaults: ModuleCli = {
             name: 'auto_index_enabled',
             value: defaultEnabled,
           },
+          {
+            moduleId: 'notifications',
+            name: NOTIFICATIONS_DELIVERY_CONFIG_KEY,
+            value: DEFAULT_NOTIFICATION_DELIVERY_CONFIG,
+          },
         ],
         { force: true },
       )