@open-mercato/core 0.4.2-canary-ab36fbd8f2 → 0.4.2-canary-da2b080494

package/src/modules/business_rules/notifications.ts

@@ -1,25 +0,0 @@
-import type { NotificationTypeDefinition } from '@open-mercato/shared/modules/notifications/types'
-
-export const notificationTypes: NotificationTypeDefinition[] = [
-  {
-    type: 'business_rules.rule.execution_failed',
-    module: 'business_rules',
-    titleKey: 'businessRules.notifications.rule.executionFailed.title',
-    bodyKey: 'businessRules.notifications.rule.executionFailed.body',
-    icon: 'alert-triangle',
-    severity: 'error',
-    actions: [
-      {
-        id: 'view',
-        labelKey: 'common.view',
-        variant: 'outline',
-        href: '/backend/business-rules/{sourceEntityId}',
-        icon: 'external-link',
-      },
-    ],
-    linkHref: '/backend/business-rules/{sourceEntityId}',
-    expiresAfterHours: 168, // 7 days
-  },
-]
-
-export default notificationTypes

package/src/modules/business_rules/subscribers/rule-execution-failed-notification.ts

@@ -1,50 +0,0 @@
-import type { EntityManager } from '@mikro-orm/postgresql'
-import { resolveNotificationService } from '../../notifications/lib/notificationService'
-import { buildFeatureNotificationFromType } from '../../notifications/lib/notificationBuilder'
-import { notificationTypes } from '../notifications'
-
-export const metadata = {
-  event: 'business_rules.rule.execution_failed',
-  persistent: true,
-  id: 'business_rules:rule-execution-failed-notification',
-}
-
-type RuleExecutionFailedPayload = {
-  ruleId: string
-  ruleName: string
-  entityType?: string | null
-  errorMessage?: string | null
-  tenantId: string
-  organizationId?: string | null
-}
-
-type ResolverContext = {
-  resolve: <T = unknown>(name: string) => T
-}
-
-export default async function handle(payload: RuleExecutionFailedPayload, ctx: ResolverContext) {
-  try {
-    const notificationService = resolveNotificationService(ctx)
-    const typeDef = notificationTypes.find((type) => type.type === 'business_rules.rule.execution_failed')
-    if (!typeDef) return
-
-    const notificationInput = buildFeatureNotificationFromType(typeDef, {
-      requiredFeature: 'business_rules.manage',
-      bodyVariables: {
-        ruleName: payload.ruleName,
-        entityType: payload.entityType ?? '',
-        errorMessage: payload.errorMessage ?? 'Unknown error',
-      },
-      sourceEntityType: 'business_rules:rule',
-      sourceEntityId: payload.ruleId,
-      linkHref: `/backend/business-rules/${payload.ruleId}`,
-    })
-
-    await notificationService.createForFeature(notificationInput, {
-      tenantId: payload.tenantId,
-      organizationId: payload.organizationId ?? null,
-    })
-  } catch (err) {
-    console.error('[business_rules:rule-execution-failed-notification] Failed to create notification:', err)
-  }
-}

package/src/modules/catalog/notifications.ts

@@ -1,25 +0,0 @@
-import type { NotificationTypeDefinition } from '@open-mercato/shared/modules/notifications/types'
-
-export const notificationTypes: NotificationTypeDefinition[] = [
-  {
-    type: 'catalog.product.low_stock',
-    module: 'catalog',
-    titleKey: 'catalog.notifications.product.lowStock.title',
-    bodyKey: 'catalog.notifications.product.lowStock.body',
-    icon: 'package-x',
-    severity: 'warning',
-    actions: [
-      {
-        id: 'view',
-        labelKey: 'common.view',
-        variant: 'outline',
-        href: '/backend/catalog/products/{sourceEntityId}',
-        icon: 'external-link',
-      },
-    ],
-    linkHref: '/backend/catalog/products/{sourceEntityId}',
-    expiresAfterHours: 72, // 3 days
-  },
-]
-
-export default notificationTypes

package/src/modules/catalog/subscribers/low-stock-notification.ts

@@ -1,52 +0,0 @@
-import type { EntityManager } from '@mikro-orm/postgresql'
-import { resolveNotificationService } from '../../notifications/lib/notificationService'
-import { buildFeatureNotificationFromType } from '../../notifications/lib/notificationBuilder'
-import { notificationTypes } from '../notifications'
-
-export const metadata = {
-  event: 'catalog.product.stock_low',
-  persistent: true,
-  id: 'catalog:low-stock-notification',
-}
-
-type LowStockPayload = {
-  productId: string
-  productName: string
-  sku?: string | null
-  currentStock: number
-  threshold: number
-  tenantId: string
-  organizationId?: string | null
-}
-
-type ResolverContext = {
-  resolve: <T = unknown>(name: string) => T
-}
-
-export default async function handle(payload: LowStockPayload, ctx: ResolverContext) {
-  try {
-    const notificationService = resolveNotificationService(ctx)
-    const typeDef = notificationTypes.find((type) => type.type === 'catalog.product.low_stock')
-    if (!typeDef) return
-
-    const notificationInput = buildFeatureNotificationFromType(typeDef, {
-      requiredFeature: 'catalog.products.manage',
-      bodyVariables: {
-        productName: payload.productName,
-        sku: payload.sku ?? '',
-        currentStock: String(payload.currentStock),
-        threshold: String(payload.threshold),
-      },
-      sourceEntityType: 'catalog:product',
-      sourceEntityId: payload.productId,
-      linkHref: `/backend/catalog/products/${payload.productId}`,
-    })
-
-    await notificationService.createForFeature(notificationInput, {
-      tenantId: payload.tenantId,
-      organizationId: payload.organizationId ?? null,
-    })
-  } catch (err) {
-    console.error('[catalog:low-stock-notification] Failed to create notification:', err)
-  }
-}

package/src/modules/customers/notifications.ts

@@ -1,44 +0,0 @@
-import type { NotificationTypeDefinition } from '@open-mercato/shared/modules/notifications/types'
-
-export const notificationTypes: NotificationTypeDefinition[] = [
-  {
-    type: 'customers.deal.won',
-    module: 'customers',
-    titleKey: 'customers.notifications.deal.won.title',
-    bodyKey: 'customers.notifications.deal.won.body',
-    icon: 'trophy',
-    severity: 'success',
-    actions: [
-      {
-        id: 'view',
-        labelKey: 'common.view',
-        variant: 'outline',
-        href: '/backend/customers/deals/{sourceEntityId}',
-        icon: 'external-link',
-      },
-    ],
-    linkHref: '/backend/customers/deals/{sourceEntityId}',
-    expiresAfterHours: 168, // 7 days
-  },
-  {
-    type: 'customers.deal.lost',
-    module: 'customers',
-    titleKey: 'customers.notifications.deal.lost.title',
-    bodyKey: 'customers.notifications.deal.lost.body',
-    icon: 'x-circle',
-    severity: 'warning',
-    actions: [
-      {
-        id: 'view',
-        labelKey: 'common.view',
-        variant: 'outline',
-        href: '/backend/customers/deals/{sourceEntityId}',
-        icon: 'external-link',
-      },
-    ],
-    linkHref: '/backend/customers/deals/{sourceEntityId}',
-    expiresAfterHours: 168, // 7 days
-  },
-]
-
-export default notificationTypes

package/src/modules/dashboards/lib/role-widgets.ts

@@ -1,80 +0,0 @@
-import type { EntityManager } from '@mikro-orm/postgresql'
-import { Role } from '@open-mercato/core/modules/auth/data/entities'
-import { DashboardRoleWidgets } from '../data/entities'
-import { loadAllWidgets } from './widgets'
-
-type RoleWidgetScope = {
-  tenantId: string
-  organizationId?: string | null
-  roleNames: string[]
-  widgetIds: string[]
-}
-
-async function findRoleByName(
-  em: EntityManager,
-  roleName: string,
-  tenantId: string,
-): Promise<Role | null> {
-  const tenantRole = await em.findOne(Role, { name: roleName, tenantId })
-  if (tenantRole) return tenantRole
-  return em.findOne(Role, { name: roleName, tenantId: null })
-}
-
-export async function resolveAnalyticsWidgetIds(): Promise<string[]> {
-  const widgets = await loadAllWidgets()
-  return widgets
-    .filter((widget) => widget.metadata.category === 'analytics' || widget.metadata.id.startsWith('dashboards.analytics.'))
-    .map((widget) => widget.metadata.id)
-}
-
-export async function appendWidgetsToRoles(
-  em: EntityManager,
-  { tenantId, organizationId = null, roleNames, widgetIds }: RoleWidgetScope,
-): Promise<boolean> {
-  const trimmedTenantId = tenantId.trim()
-  const widgets = await loadAllWidgets()
-  const validWidgetIds = new Set(widgets.map((widget) => widget.metadata.id))
-  const resolvedWidgetIds = widgetIds.filter((id) => validWidgetIds.has(id))
-  if (!resolvedWidgetIds.length) return false
-
-  let updated = false
-  await em.transactional(async (tem) => {
-    for (const roleName of roleNames) {
-      const role = await findRoleByName(tem, roleName, trimmedTenantId)
-      if (!role) continue
-
-      const record = await tem.findOne(DashboardRoleWidgets, {
-        roleId: String(role.id),
-        tenantId: trimmedTenantId,
-        organizationId,
-        deletedAt: null,
-      })
-      const roleRecord = record ?? (organizationId
-        ? await tem.findOne(DashboardRoleWidgets, {
-          roleId: String(role.id),
-          tenantId: trimmedTenantId,
-          organizationId: null,
-          deletedAt: null,
-        })
-        : null)
-      if (!roleRecord) continue
-
-      const current = Array.isArray(roleRecord.widgetIdsJson) ? roleRecord.widgetIdsJson : []
-      const next = [...current]
-      const existing = new Set(current)
-      for (const widgetId of resolvedWidgetIds) {
-        if (existing.has(widgetId)) continue
-        existing.add(widgetId)
-        next.push(widgetId)
-      }
-
-      if (next.length === current.length) continue
-      roleRecord.widgetIdsJson = next
-      roleRecord.updatedAt = new Date()
-      tem.persist(roleRecord)
-      updated = true
-    }
-  })
-
-  return updated
-}

package/src/modules/notifications/__tests__/deliver-notification.test.ts

@@ -1,195 +0,0 @@
-import type { Notification } from '../data/entities'
-import type { NotificationDeliveryConfig } from '../lib/deliveryConfig'
-import type { NotificationDeliveryStrategy } from '../lib/deliveryStrategies'
-
-const sendEmail = jest.fn()
-const getNotificationDeliveryStrategies = jest.fn()
-const resolveNotificationDeliveryConfig = jest.fn()
-const resolveNotificationPanelUrl = jest.fn()
-const findOneWithDecryption = jest.fn()
-const NotificationEmail = jest.fn(() => 'notification-email')
-
-jest.mock('@open-mercato/shared/lib/email/send', () => ({
-  sendEmail: (...args: unknown[]) => sendEmail(...args),
-}))
-
-jest.mock('../lib/deliveryStrategies', () => ({
-  getNotificationDeliveryStrategies: (...args: unknown[]) => getNotificationDeliveryStrategies(...args),
-}))
-
-jest.mock('../lib/deliveryConfig', () => ({
-  DEFAULT_NOTIFICATION_DELIVERY_CONFIG: {
-    panelPath: '/backend/notifications',
-    strategies: {
-      database: { enabled: true },
-      email: { enabled: true },
-      custom: {},
-    },
-  },
-  resolveNotificationDeliveryConfig: (...args: unknown[]) => resolveNotificationDeliveryConfig(...args),
-  resolveNotificationPanelUrl: (...args: unknown[]) => resolveNotificationPanelUrl(...args),
-}))
-
-jest.mock('@open-mercato/shared/lib/i18n/server', () => ({
-  loadDictionary: jest.fn().mockResolvedValue({}),
-}))
-
-jest.mock('@open-mercato/shared/lib/i18n/translate', () => ({
-  createFallbackTranslator: () => (key: string, fallback?: string) => fallback ?? key,
-}))
-
-jest.mock('@open-mercato/shared/lib/encryption/find', () => ({
-  findOneWithDecryption: (...args: unknown[]) => findOneWithDecryption(...args),
-}))
-
-jest.mock('../emails/NotificationEmail', () => ({
-  __esModule: true,
-  default: (...args: unknown[]) => NotificationEmail(...args),
-}))
-
-describe('deliver notification subscriber', () => {
-  const notification: Notification = {
-    id: '32e22a6e-7aa9-4f3b-8a7b-42c2d1223a5f',
-    recipientUserId: '3eae68bb-1e4c-4b21-85c7-b8f5b2c22b01',
-    tenantId: 'c33b6f78-8c4b-4ef4-9c54-2b64b5f5d0d0',
-    organizationId: null,
-    type: 'system',
-    title: 'New notification',
-    body: 'Check details',
-    titleKey: null,
-    bodyKey: null,
-    titleVariables: null,
-    bodyVariables: null,
-    icon: null,
-    severity: 'info',
-    actionData: {
-      actions: [{ id: 'action-1', label: 'Review' }],
-      primaryActionId: 'action-1',
-    },
-    sourceModule: null,
-    sourceEntityType: null,
-    sourceEntityId: null,
-    linkHref: null,
-    groupKey: null,
-    status: 'unread',
-    readAt: null,
-    actionedAt: null,
-    dismissedAt: null,
-    createdAt: new Date(),
-    updatedAt: new Date(),
-    expiresAt: null,
-    actionTaken: null,
-    actionResult: null,
-  } as Notification
-
-  const baseConfig: NotificationDeliveryConfig = {
-    appUrl: 'https://app.example.com',
-    panelPath: '/backend/notifications',
-    strategies: {
-      database: { enabled: true },
-      email: {
-        enabled: true,
-        from: 'notifications@example.com',
-        replyTo: 'reply@example.com',
-        subjectPrefix: '[OM]',
-      },
-      custom: {},
-    },
-  }
-
-  beforeEach(() => {
-    jest.clearAllMocks()
-  })
-
-  it('sends email notifications when enabled', async () => {
-    resolveNotificationDeliveryConfig.mockResolvedValue(baseConfig)
-    resolveNotificationPanelUrl.mockReturnValue('https://app.example.com/backend/notifications')
-    getNotificationDeliveryStrategies.mockReturnValue([])
-    findOneWithDecryption.mockResolvedValue({ email: 'user@example.com', name: 'User' })
-
-    const em = {
-      findOne: jest.fn().mockResolvedValue(notification),
-    }
-
-    const { default: handle } = await import('../subscribers/deliver-notification')
-
-    await handle(
-      {
-        notificationId: notification.id,
-        recipientUserId: notification.recipientUserId,
-        tenantId: notification.tenantId,
-        organizationId: null,
-      },
-      {
-        resolve: (name: string) => {
-          if (name === 'em') return em
-          throw new Error(`Missing dependency: ${name}`)
-        },
-      }
-    )
-
-    expect(NotificationEmail).toHaveBeenCalledWith(
-      expect.objectContaining({
-        title: notification.title,
-        panelUrl: `https://app.example.com/backend/notifications?notificationId=${notification.id}`,
-      })
-    )
-    expect(sendEmail).toHaveBeenCalledWith(
-      expect.objectContaining({
-        to: 'user@example.com',
-        from: baseConfig.strategies.email.from,
-        replyTo: baseConfig.strategies.email.replyTo,
-        subject: `${baseConfig.strategies.email.subjectPrefix} ${notification.title}`,
-      })
-    )
-  })
-
-  it('executes enabled custom delivery strategies', async () => {
-    const customStrategy: NotificationDeliveryStrategy = {
-      id: 'webhook',
-      deliver: jest.fn(),
-    }
-    resolveNotificationDeliveryConfig.mockResolvedValue({
-      ...baseConfig,
-      strategies: {
-        ...baseConfig.strategies,
-        email: { enabled: false },
-        custom: {
-          webhook: { enabled: true, config: { url: 'https://hooks.example.com' } },
-        },
-      },
-    })
-    resolveNotificationPanelUrl.mockReturnValue('/backend/notifications')
-    getNotificationDeliveryStrategies.mockReturnValue([customStrategy])
-    findOneWithDecryption.mockResolvedValue({ email: 'user@example.com', name: 'User' })
-
-    const em = {
-      findOne: jest.fn().mockResolvedValue(notification),
-    }
-
-    const { default: handle } = await import('../subscribers/deliver-notification')
-
-    await handle(
-      {
-        notificationId: notification.id,
-        recipientUserId: notification.recipientUserId,
-        tenantId: notification.tenantId,
-        organizationId: null,
-      },
-      {
-        resolve: (name: string) => {
-          if (name === 'em') return em
-          throw new Error(`Missing dependency: ${name}`)
-        },
-      }
-    )
-
-    expect(customStrategy.deliver).toHaveBeenCalledWith(
-      expect.objectContaining({
-        config: { enabled: true, config: { url: 'https://hooks.example.com' } },
-        panelLink: `/backend/notifications?notificationId=${notification.id}`,
-      })
-    )
-    expect(sendEmail).not.toHaveBeenCalled()
-  })
-})

package/src/modules/notifications/__tests__/deliveryStrategies.test.ts

@@ -1,19 +0,0 @@
-import { type NotificationDeliveryStrategy } from '../lib/deliveryStrategies'
-
-describe('notification delivery strategies', () => {
-  it('orders strategies by priority', async () => {
-    jest.resetModules()
-    const { registerNotificationDeliveryStrategy, getNotificationDeliveryStrategies } = await import('../lib/deliveryStrategies')
-
-    const first: NotificationDeliveryStrategy = { id: 'first', deliver: jest.fn() }
-    const second: NotificationDeliveryStrategy = { id: 'second', deliver: jest.fn() }
-    const third: NotificationDeliveryStrategy = { id: 'third', deliver: jest.fn() }
-
-    registerNotificationDeliveryStrategy(first, { priority: 1 })
-    registerNotificationDeliveryStrategy(second, { priority: 10 })
-    registerNotificationDeliveryStrategy(third, { priority: 5 })
-
-    const ids = getNotificationDeliveryStrategies().map((strategy) => strategy.id)
-    expect(ids).toEqual(['second', 'third', 'first'])
-  })
-})