@open-mercato/core 0.10.1-develop.7841.1.af87ac614d → 0.10.1-develop.7857.1.259928eb85

package/src/modules/directory/api/organization-branding/route.ts

@@ -17,7 +17,7 @@ import { resolveTranslations } from '@open-mercato/shared/lib/i18n/server'
 import { Organization } from '@open-mercato/core/modules/directory/data/entities'
 import { organizationUpdateSchema } from '@open-mercato/core/modules/directory/data/validators'
 import { resolveOrganizationScopeForRequest } from '@open-mercato/core/modules/directory/utils/organizationScope'
-import { resolveSingleOrganizationIdOrDeny } from '@open-mercato/core/modules/directory/utils/organizationScopeFilter'
+import { isExplicitlyEmptyOrganizationScope } from '@open-mercato/shared/lib/auth/organizationScope'
 import '@open-mercato/core/modules/directory/commands/organizations'
 import { createLogger } from '@open-mercato/shared/lib/logger'
 import { getCommandInterceptorHttpRejection } from '@open-mercato/shared/lib/commands/errors'
@@ -82,15 +82,12 @@ async function resolveCurrentOrganization(req: Request) {
 
   const container = await createRequestContainer()
   const scope = await resolveOrganizationScopeForRequest({ container, auth, request: req })
-  let organizationId: string | null
-  try {
-    organizationId = resolveSingleOrganizationIdOrDeny(scope, auth)
-  } catch (error) {
-    if (isCrudHttpError(error)) {
-      return { response: NextResponse.json(error.body, { status: error.status }) }
+  if (isExplicitlyEmptyOrganizationScope(scope)) {
+    return {
+      response: NextResponse.json({ error: translate('api.errors.forbidden', 'Forbidden') }, { status: 403 }),
     }
-    throw error
   }
+  const organizationId = scope.selectedId
   const tenantId = scope.tenantId ?? auth.tenantId ?? null
   if (!organizationId || !tenantId) {
     return {

package/src/modules/directory/backend/directory/branding/page.tsx

@@ -15,7 +15,8 @@ import { Button } from '@open-mercato/ui/primitives/button'
 import { Input } from '@open-mercato/ui/primitives/input'
 import { SwitchField } from '@open-mercato/ui/primitives/switch-field'
 import { useT } from '@open-mercato/shared/lib/i18n/context'
-import { useOrganizationScopeDetail } from '@open-mercato/shared/lib/frontend/useOrganizationScope'
+import { useOrganizationScopeDetail, useOrganizationScopeVersion } from '@open-mercato/shared/lib/frontend/useOrganizationScope'
+import { getCurrentOrganizationScopeVersion } from '@open-mercato/shared/lib/frontend/organizationEvents'
 
 type BrandingPayload = {
   organizationId: string
@@ -42,6 +43,7 @@ export default function OrganizationBrandingPage() {
   const t = useT()
   const queryClient = useQueryClient()
   const { organizationId, tenantId } = useOrganizationScopeDetail()
+  const scopeVersion = useOrganizationScopeVersion()
   const [logoUrl, setLogoUrl] = React.useState('')
   const [logoPreserveAspectRatio, setLogoPreserveAspectRatio] = React.useState(false)
   const [selectedFile, setSelectedFile] = React.useState<File | null>(null)
@@ -67,7 +69,8 @@ export default function OrganizationBrandingPage() {
     setLogoUrl(data?.logoUrl ?? '')
     setLogoPreserveAspectRatio(data?.logoPreserveAspectRatio ?? false)
     setSelectedFile(null)
-  }, [data?.logoPreserveAspectRatio, data?.logoUrl, organizationId, tenantId])
+    if (fileInputRef.current) fileInputRef.current.value = ''
+  }, [scopeVersion, organizationId, tenantId, data?.organizationId, data?.logoPreserveAspectRatio, data?.logoUrl])
 
   React.useEffect(() => {
     if (!selectedFile || typeof URL === 'undefined') {
@@ -111,7 +114,13 @@ export default function OrganizationBrandingPage() {
     try {
       await runMutation({
         operation: async () => {
+          if (getCurrentOrganizationScopeVersion() !== scopeVersion) {
+            throw new Error('[internal] Organization scope changed during branding save')
+          }
           const uploadedLogoUrl = shouldUpload ? await uploadLogo(data.organizationId) : null
+          if (getCurrentOrganizationScopeVersion() !== scopeVersion) {
+            throw new Error('[internal] Organization scope changed during branding save')
+          }
           const resolvedLogoUrl = uploadedLogoUrl ?? nextLogoUrl ?? logoUrl.trim()
           const response = await withScopedApiRequestHeaders(
             buildOptimisticLockHeader(data.updatedAt),
@@ -142,12 +151,15 @@ export default function OrganizationBrandingPage() {
           hasUpload: shouldUpload,
         },
       })
+      if (getCurrentOrganizationScopeVersion() !== scopeVersion) return
       await queryClient.invalidateQueries({ queryKey: ['directory-organization-branding'] })
+      if (getCurrentOrganizationScopeVersion() !== scopeVersion) return
       window.dispatchEvent(new Event('om:refresh-sidebar'))
       setSelectedFile(null)
       if (fileInputRef.current) fileInputRef.current.value = ''
       flash(t('directory.branding.flash.saved', 'Organization branding updated'), 'success')
     } catch (err: unknown) {
+      if (getCurrentOrganizationScopeVersion() !== scopeVersion) return
       if (surfaceRecordConflict(err, t)) return
       const fallback = t('directory.branding.errors.save', 'Failed to update organization branding')
       const message = err instanceof Error ? err.message : fallback
@@ -155,7 +167,7 @@ export default function OrganizationBrandingPage() {
     } finally {
       setSaving(false)
     }
-  }, [data, logoPreserveAspectRatio, logoUrl, queryClient, runMutation, selectedFile, t, uploadLogo])
+  }, [data, logoPreserveAspectRatio, logoUrl, queryClient, runMutation, scopeVersion, selectedFile, t, uploadLogo])
 
   const handleSubmit = React.useCallback((event: React.FormEvent<HTMLFormElement>) => {
     event.preventDefault()

package/src/modules/sales/AGENTS.md

@@ -5,7 +5,7 @@ Use the sales module for orders, quotes, invoices, shipments, and payments. This
 ## Always
 
 1. **MUST use `salesCalculationService` from DI** for document math.
-2. **MUST follow document flow**: Quote → Order → Invoice — no skipping steps
+2. **MUST follow document flow**: Quote → Order → Invoice (quote optional)
 3. **MUST scope all documents to a channel** — channel selection affects pricing, numbering, and visibility
 
 ## Ask First
@@ -36,7 +36,7 @@ Quote → Order → Invoice
     Shipments + Payments
 ```
 
-- Quotes convert to orders — MUST NOT create orders without a source quote (unless configured)
+- Quotes convert via `sales.quotes.convert_to_order`; orders MAY also be created without a quote
 - Orders track shipments and payments independently
 - Each entity has its own status workflow — MUST NOT skip workflow states
 
@@ -56,7 +56,7 @@ const calcService = container.resolve('salesCalculationService')
 
 ### Core Entities
 - **Sales Orders** — confirmed customer orders. MUST have a channel and at least one line
-- **Sales Quotes** — proposed orders. MUST track conversion status
+- **Sales Quotes** — proposed orders; deleted on conversion
 - **Order/Quote Lines** — individual items. MUST reference valid products
 - **Adjustments** — discounts/surcharges. MUST use registered `AdjustmentKind`
 

package/src/modules/wms/api/listEnrichers.ts

@@ -277,7 +277,8 @@ const CUSTOMER_FIELDS = ['id', 'display_name']
 /**
  * Decorate list items with `vendor_name` when they carry a `vendor_id` column
  * referencing `customers.customer_entity` by UUID only (no ORM cross-module
- * relations). Mutates `payload.items` in place.
+ * relations). No-op when the optional `customers` module is not enabled.
+ * Mutates `payload.items` in place.
  */
 export async function attachVendorLabelsToListItems(
   payload: AnyListPayload,
@@ -285,11 +286,13 @@ export async function attachVendorLabelsToListItems(
 ): Promise<void> {
   const items = Array.isArray(payload?.items) ? payload.items : []
   if (items.length === 0) return
+  const customerEntityId = E.customers?.customer_entity
+  if (!customerEntityId) return
   const ids = uniqueIdsFromKeys(items, ['vendor_id'])
   if (ids.length === 0) return
   const map = (await batchLoadById(
     ctx,
-    E.customers.customer_entity,
+    customerEntityId,
     ids,
     CUSTOMER_FIELDS,
     'vendor',

package/src/modules/wms/index.ts

@@ -9,7 +9,7 @@ export const metadata: ModuleInfo = {
   author: 'Open Mercato Team',
   license: 'MIT',
   ejectable: true,
-  requires: ['catalog', 'sales', 'feature_toggles'],
+  requires: ['catalog', 'customers', 'sales', 'feature_toggles'],
 }
 
 export { features } from './acl'