@open-mercato/checkout 0.6.7-develop.6862.1.c11a64ce0a → 0.6.7

package/src/modules/checkout/commands/__tests__/update-transaction-status.test.ts

@@ -1,363 +0,0 @@
-/** @jest-environment node */
-
-/**
- * Tests for the state-machine guard added to updateTransactionStatusCommand.
- *
- * Exercises:
- * 1. A terminal → non-terminal transition is rejected with a 409 before the
- *    nativeUpdate is even called.
- * 2. A non-terminal → terminal transition succeeds (nativeUpdate called with
- *    the correct WHERE clause locking the current status).
- * 3. When nativeUpdate returns 0 (concurrent write won the race), the command
- *    throws a 409 (concurrent_status_update) and does NOT proceed to emit
- *    terminal events.
- * 4. When nativeUpdate returns 1, the command succeeds and emits the correct
- *    terminal event.
- */
-
-import { commandRegistry } from '@open-mercato/shared/lib/commands/registry'
-import type { CommandRuntimeContext } from '@open-mercato/shared/lib/commands/types'
-import { CheckoutTransaction } from '../../data/entities'
-
-// Register the transaction commands
-import '../transactions'
-
-jest.mock('../../events', () => ({
-  emitCheckoutEvent: jest.fn(async () => undefined),
-}))
-
-const { emitCheckoutEvent } = jest.requireMock('../../events') as {
-  emitCheckoutEvent: jest.Mock
-}
-
-const ORG_ID = '123e4567-e89b-12d3-a456-426614174000'
-const TENANT_ID = '123e4567-e89b-12d3-a456-426614174001'
-const LINK_ID = '123e4567-e89b-12d3-a456-426614174010'
-const TX_ID = '123e4567-e89b-12d3-a456-426614174020'
-
-function makeTransaction(status: CheckoutTransaction['status']) {
-  return {
-    id: TX_ID,
-    linkId: LINK_ID,
-    organizationId: ORG_ID,
-    tenantId: TENANT_ID,
-    status,
-    paymentStatus: null,
-    gatewayTransactionId: null,
-    amount: '100.00',
-    currencyCode: 'USD',
-    createdAt: new Date(),
-    updatedAt: new Date(),
-  }
-}
-
-function makeLink() {
-  return {
-    id: LINK_ID,
-    organizationId: ORG_ID,
-    tenantId: TENANT_ID,
-    slug: 'test-link',
-    templateId: null,
-    gatewayProviderKey: 'stripe',
-    activeReservationCount: 1,
-    completionCount: 0,
-    maxCompletions: null,
-    isLocked: false,
-    deletedAt: null,
-  }
-}
-
-type MockEm = {
-  findOne: jest.Mock
-  nativeUpdate: jest.Mock
-  flush: jest.Mock
-  refresh: jest.Mock
-  transactional: (fn: (tx: MockEm) => Promise<unknown>) => Promise<unknown>
-}
-
-function makeMockEm(
-  transaction: ReturnType<typeof makeTransaction>,
-  nativeUpdateResult = 1,
-  // When nativeUpdate returns 0, the post-CAS findOne should return a
-  // different status to simulate the winning writer's value.
-  postCasStatus?: CheckoutTransaction['status'],
-): MockEm {
-  let findOneCallCount = 0
-  const mockTx: MockEm = {
-    findOne: jest.fn(async (_entity: unknown, filter: Record<string, unknown>) => {
-      findOneCallCount++
-      if (filter.id === TX_ID) {
-        // After a CAS miss (nativeUpdate=0) the command re-reads the row with
-        // refresh:true to fetch the winning writer's status. Return the
-        // post-CAS status on subsequent calls when one is provided.
-        if (findOneCallCount > 1 && postCasStatus !== undefined) {
-          return { ...transaction, status: postCasStatus }
-        }
-        return transaction
-      }
-      if (filter.id === LINK_ID) return makeLink()
-      return null
-    }),
-    nativeUpdate: jest.fn(async () => nativeUpdateResult),
-    flush: jest.fn(async () => undefined),
-    refresh: jest.fn(async () => undefined),
-    transactional: (fn) => fn(mockTx),
-  }
-  return mockTx
-}
-
-function makeContext(em: MockEm): CommandRuntimeContext {
-  return {
-    container: {
-      resolve: (token: string) => {
-        if (token === 'em') return em
-        return null
-      },
-    } as unknown as CommandRuntimeContext['container'],
-    auth: null,
-    organizationScope: null,
-    selectedOrganizationId: ORG_ID,
-    organizationIds: [ORG_ID],
-  }
-}
-
-function baseInput(status: string) {
-  return {
-    id: TX_ID,
-    status,
-    paymentStatus: null,
-    gatewayTransactionId: null,
-    organizationId: ORG_ID,
-    tenantId: TENANT_ID,
-  }
-}
-
-async function runUpdateStatus(em: MockEm, status: string) {
-  const handler = commandRegistry.get('checkout.transaction.updateStatus')
-  if (!handler) throw new Error('checkout.transaction.updateStatus not registered')
-  return handler.execute(baseInput(status), makeContext(em))
-}
-
-describe('updateTransactionStatusCommand — state-machine guard', () => {
-  beforeEach(() => {
-    jest.clearAllMocks()
-  })
-
-  describe('valid transitions', () => {
-    it('processing → completed: calls nativeUpdate with status=processing in the WHERE clause', async () => {
-      const transaction = makeTransaction('processing')
-      const em = makeMockEm(transaction, 1)
-
-      await runUpdateStatus(em, 'completed')
-
-      expect(em.nativeUpdate).toHaveBeenCalledWith(
-        expect.anything(),
-        expect.objectContaining({
-          id: TX_ID,
-          organizationId: ORG_ID,
-          tenantId: TENANT_ID,
-          status: 'processing', // pins the current status for atomicity
-        }),
-        expect.objectContaining({ status: 'completed' }),
-      )
-    })
-
-    it('processing → completed: emits checkout.transaction.completed event', async () => {
-      const transaction = makeTransaction('processing')
-      const em = makeMockEm(transaction, 1)
-
-      await runUpdateStatus(em, 'completed')
-
-      expect(emitCheckoutEvent).toHaveBeenCalledWith(
-        'checkout.transaction.completed',
-        expect.any(Object),
-      )
-    })
-
-    it('pending → processing: nativeUpdate is called with correct WHERE', async () => {
-      const transaction = makeTransaction('pending')
-      const em = makeMockEm(transaction, 1)
-
-      await runUpdateStatus(em, 'processing')
-
-      expect(em.nativeUpdate).toHaveBeenCalledWith(
-        expect.anything(),
-        expect.objectContaining({ status: 'pending' }),
-        expect.objectContaining({ status: 'processing' }),
-      )
-    })
-
-    it('pending → processing: does NOT emit a terminal event', async () => {
-      const transaction = makeTransaction('pending')
-      const em = makeMockEm(transaction, 1)
-
-      await runUpdateStatus(em, 'processing')
-
-      expect(emitCheckoutEvent).not.toHaveBeenCalledWith(
-        'checkout.transaction.completed',
-        expect.any(Object),
-      )
-      expect(emitCheckoutEvent).not.toHaveBeenCalledWith(
-        'checkout.transaction.failed',
-        expect.any(Object),
-      )
-    })
-  })
-
-  describe('regression guard — terminal → non-terminal (the race condition)', () => {
-    it('completed → processing: throws 409 with code invalid_status_transition', async () => {
-      expect.assertions(3)
-      const transaction = makeTransaction('completed')
-      const em = makeMockEm(transaction, 1)
-
-      try {
-        await runUpdateStatus(em, 'processing')
-      } catch (err) {
-        const error = err as { status?: number; body?: Record<string, unknown> }
-        expect(error.status).toBe(409)
-        expect(error.body?.code).toBe('invalid_status_transition')
-        expect(em.nativeUpdate).not.toHaveBeenCalled()
-      }
-    })
-
-    it('completed → failed: throws 409', async () => {
-      expect.assertions(2)
-      const transaction = makeTransaction('completed')
-      const em = makeMockEm(transaction, 1)
-
-      try {
-        await runUpdateStatus(em, 'failed')
-      } catch (err) {
-        const error = err as { status?: number; body?: Record<string, unknown> }
-        expect(error.status).toBe(409)
-        expect(em.nativeUpdate).not.toHaveBeenCalled()
-      }
-    })
-
-    it('expired → processing: throws 409', async () => {
-      expect.assertions(2)
-      const transaction = makeTransaction('expired')
-      const em = makeMockEm(transaction, 1)
-
-      try {
-        await runUpdateStatus(em, 'processing')
-      } catch (err) {
-        const error = err as { status?: number; body?: Record<string, unknown> }
-        expect(error.status).toBe(409)
-        expect(em.nativeUpdate).not.toHaveBeenCalled()
-      }
-    })
-
-    it('failed → completed: throws 409', async () => {
-      expect.assertions(2)
-      const transaction = makeTransaction('failed')
-      const em = makeMockEm(transaction, 1)
-
-      try {
-        await runUpdateStatus(em, 'completed')
-      } catch (err) {
-        const error = err as { status?: number; body?: Record<string, unknown> }
-        expect(error.status).toBe(409)
-        expect(em.nativeUpdate).not.toHaveBeenCalled()
-      }
-    })
-  })
-
-  describe('TOCTOU guard — nativeUpdate returns 0 (concurrent write wins)', () => {
-    it('nativeUpdate=0 throws 409 with code concurrent_status_update', async () => {
-      expect.assertions(5)
-      // Transaction is still processing from our read, but another writer won
-      // the race and set status to completed. The post-CAS re-read (refresh:true)
-      // should return the winner's status, not the stale identity-mapped value.
-      const transaction = makeTransaction('processing')
-      const em = makeMockEm(transaction, 0, 'completed')
-
-      try {
-        await runUpdateStatus(em, 'completed')
-      } catch (err) {
-        const error = err as { status?: number; body?: Record<string, unknown> }
-        expect(error.status).toBe(409)
-        expect(error.body?.code).toBe('concurrent_status_update')
-        expect(error.body?.expectedStatus).toBe('processing')
-        // currentStatus must reflect the winning writer's value, not the stale snapshot
-        expect(error.body?.currentStatus).toBe('completed')
-        // The terminal event must NOT be emitted when the update was a no-op
-        expect(emitCheckoutEvent).not.toHaveBeenCalledWith(
-          'checkout.transaction.completed',
-          expect.any(Object),
-        )
-      }
-    })
-
-    it('nativeUpdate=0 does NOT emit any event', async () => {
-      expect.assertions(1)
-      const transaction = makeTransaction('processing')
-      const em = makeMockEm(transaction, 0)
-
-      try {
-        await runUpdateStatus(em, 'completed')
-      } catch {
-        // Expected 409 — assert no events were emitted
-        expect(emitCheckoutEvent).not.toHaveBeenCalled()
-      }
-    })
-  })
-
-  describe('same-state transitions (idempotency support)', () => {
-    it('processing → processing: succeeds and calls nativeUpdate', async () => {
-      const transaction = makeTransaction('processing')
-      const em = makeMockEm(transaction, 1)
-
-      await runUpdateStatus(em, 'processing')
-
-      expect(em.nativeUpdate).toHaveBeenCalledWith(
-        expect.anything(),
-        expect.objectContaining({ status: 'processing' }),
-        expect.objectContaining({ status: 'processing' }),
-      )
-    })
-
-    it('completed → completed: succeeds and calls nativeUpdate', async () => {
-      const transaction = makeTransaction('completed')
-      const em = makeMockEm(transaction, 1)
-
-      await runUpdateStatus(em, 'completed')
-
-      expect(em.nativeUpdate).toHaveBeenCalledWith(
-        expect.anything(),
-        expect.objectContaining({ status: 'completed' }),
-        expect.objectContaining({ status: 'completed' }),
-      )
-    })
-
-    it('completed → completed: does NOT re-emit checkout.transaction.completed (idempotent redelivery guard)', async () => {
-      const transaction = makeTransaction('completed')
-      const em = makeMockEm(transaction, 1)
-
-      await runUpdateStatus(em, 'completed')
-
-      expect(emitCheckoutEvent).not.toHaveBeenCalledWith(
-        'checkout.transaction.completed',
-        expect.any(Object),
-      )
-    })
-
-    it('authorized → captured (both → completed): CAS succeeds but terminal event is NOT re-emitted', async () => {
-      // Both payment_gateways.payment.authorized and .captured map to 'completed'.
-      // The second delivery (captured) finds the transaction already completed;
-      // the CAS still succeeds (same-state), but checkout.transaction.completed
-      // must NOT fire a second time so the customer does not receive a duplicate notification.
-      const transaction = makeTransaction('completed')
-      const em = makeMockEm(transaction, 1)
-
-      await runUpdateStatus(em, 'completed')
-
-      expect(em.nativeUpdate).toHaveBeenCalledTimes(1)
-      expect(emitCheckoutEvent).not.toHaveBeenCalledWith(
-        'checkout.transaction.completed',
-        expect.any(Object),
-      )
-    })
-  })
-})
-

package/src/modules/checkout/extension-points.ts

@@ -1,67 +0,0 @@
-import {
-  componentExtensionHost,
-  dataTableExtensionHost,
-  defineModuleExtensionPoints,
-  injectionExtensionHost,
-} from '@open-mercato/shared/modules/widgets/extension-points'
-
-const payPageSpot = (spotId: string) => injectionExtensionHost({
-  family: 'detail',
-  spotId,
-  supported: ['render-widget'],
-  contextContract: 'checkout.pay-page.v1',
-  source: 'components/PayPage.tsx',
-})
-
-const payPageComponent = (componentId: string) => componentExtensionHost({
-  componentId,
-  propsContract: 'checkout.pay-page.v1',
-  source: 'components/PayPage.tsx',
-})
-
-export const extensionPoints = defineModuleExtensionPoints({
-  moduleId: 'checkout',
-  hosts: {
-    linksTable: dataTableExtensionHost({ tableId: 'checkout-links', source: 'backend/checkout/pay-links/page.tsx' }),
-    templatesTable: dataTableExtensionHost({ tableId: 'checkout-templates', source: 'backend/checkout/templates/page.tsx' }),
-    transactionsTable: dataTableExtensionHost({ tableId: 'checkout-transactions', source: 'backend/checkout/transactions/page.tsx' }),
-    gatewayWidgetBefore: payPageSpot('checkout.pay-page:gateway-widget:before'),
-    gatewayRendererBefore: payPageSpot('checkout.pay-page:gateway-widget:renderer:before'),
-    gatewayRendererAfter: payPageSpot('checkout.pay-page:gateway-widget:renderer:after'),
-    gatewayActionsBefore: payPageSpot('checkout.pay-page:gateway-widget:actions:before'),
-    gatewayActionsAfter: payPageSpot('checkout.pay-page:gateway-widget:actions:after'),
-    gatewayWidgetAfter: payPageSpot('checkout.pay-page:gateway-widget:after'),
-    headerBefore: payPageSpot('checkout.pay-page:header:before'),
-    headerAfter: payPageSpot('checkout.pay-page:header:after'),
-    descriptionAfter: payPageSpot('checkout.pay-page:description:after'),
-    customerFieldsBefore: payPageSpot('checkout.pay-page:customer-fields:before'),
-    customerFieldsAfter: payPageSpot('checkout.pay-page:customer-fields:after'),
-    pricingBefore: payPageSpot('checkout.pay-page:pricing:before'),
-    pricingAfter: payPageSpot('checkout.pay-page:pricing:after'),
-    summaryBefore: payPageSpot('checkout.pay-page:summary:before'),
-    summaryAfter: payPageSpot('checkout.pay-page:summary:after'),
-    legalConsentBefore: payPageSpot('checkout.pay-page:legal-consent:before'),
-    legalConsentAfter: payPageSpot('checkout.pay-page:legal-consent:after'),
-    submitBefore: payPageSpot('checkout.pay-page:submit:before'),
-    submitAfter: payPageSpot('checkout.pay-page:submit:after'),
-    helpBefore: payPageSpot('checkout.pay-page:help:before'),
-    helpAfter: payPageSpot('checkout.pay-page:help:after'),
-    paymentBefore: payPageSpot('checkout.pay-page:payment:before'),
-    paymentAfter: payPageSpot('checkout.pay-page:payment:after'),
-    footerBefore: payPageSpot('checkout.pay-page:footer:before'),
-    footerAfter: payPageSpot('checkout.pay-page:footer:after'),
-    payPage: payPageComponent('page:checkout.pay-page'),
-    header: payPageComponent('section:checkout.pay-page.header'),
-    description: payPageComponent('section:checkout.pay-page.description'),
-    summary: payPageComponent('section:checkout.pay-page.summary'),
-    pricing: payPageComponent('section:checkout.pay-page.pricing'),
-    payment: payPageComponent('section:checkout.pay-page.payment'),
-    customerForm: payPageComponent('section:checkout.pay-page.customer-form'),
-    legalConsent: payPageComponent('section:checkout.pay-page.legal-consent'),
-    gatewayForm: payPageComponent('section:checkout.pay-page.gateway-form'),
-    help: payPageComponent('section:checkout.pay-page.help'),
-    footer: payPageComponent('section:checkout.pay-page.footer'),
-  },
-})
-
-export default extensionPoints