@open-code-review/agents 1.8.3 → 1.8.4
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/package.json
CHANGED
|
@@ -357,4 +357,6 @@ Full reviews available in session directory:
|
|
|
357
357
|
|
|
358
358
|
6. **Tech Lead facilitates** — The Tech Lead synthesizes and recommends, but doesn't override individual blockers or suppress feedback.
|
|
359
359
|
|
|
360
|
-
7. **`round-meta.json` matches `final.md`** — When piping data to `ocr state round-complete --stdin
|
|
360
|
+
7. **`round-meta.json` matches `final.md`** — When piping data to `ocr state round-complete --stdin`:
|
|
361
|
+
- The `category` on each finding MUST reflect the **post-synthesis** classification (promoted/demoted categories).
|
|
362
|
+
- The `synthesis_counts` object MUST contain the **deduplicated** counts matching the actual numbered items in `final.md`. Multiple reviewers flag the same issue → one item in `final.md`. Count the `### N.` headings under Blockers, Should Fix, and Suggestions in your final output and set `synthesis_counts.blockers`, `synthesis_counts.should_fix`, and `synthesis_counts.suggestions` accordingly. The dashboard uses these counts when present.
|
|
@@ -649,11 +649,18 @@ See `references/discourse.md` for detailed instructions.
|
|
|
649
649
|
|
|
650
650
|
> **CRITICAL — Category reflects synthesis, not original reviewer tags**: The `category` field on each finding must match the final synthesized classification — NOT the category the individual reviewer originally used. If discourse or synthesis promoted a `should_fix` to `blocker` (or demoted a `blocker` to `should_fix`), the JSON you pipe here MUST use the **promoted/demoted category**. The dashboard derives all counts from these categories. If they don't match `final.md`, the dashboard will show wrong numbers.
|
|
651
651
|
|
|
652
|
+
> **CRITICAL — `synthesis_counts` must match `final.md`**: The `synthesis_counts` object contains the **deduplicated** counts of items in each section of `final.md`. Multiple reviewers often flag the same issue independently, so the per-reviewer findings array will have more entries than `final.md` lists. Count the actual numbered items under each section heading in your synthesized review (`## Blockers`, `## Should Fix`, `## Suggestions`) and set those counts here. The dashboard uses `synthesis_counts` when present, falling back to derived counts only for older reviews.
|
|
653
|
+
|
|
652
654
|
```bash
|
|
653
655
|
cat <<'JSON' | ocr state round-complete --stdin
|
|
654
656
|
{
|
|
655
657
|
"schema_version": 1,
|
|
656
658
|
"verdict": "REQUEST CHANGES",
|
|
659
|
+
"synthesis_counts": {
|
|
660
|
+
"blockers": 1,
|
|
661
|
+
"should_fix": 3,
|
|
662
|
+
"suggestions": 5
|
|
663
|
+
},
|
|
657
664
|
"reviewers": [
|
|
658
665
|
{
|
|
659
666
|
"type": "principal",
|
|
@@ -681,11 +688,13 @@ See `references/discourse.md` for detailed instructions.
|
|
|
681
688
|
```
|
|
682
689
|
|
|
683
690
|
The CLI will:
|
|
684
|
-
1. Validate the JSON schema (schema_version, verdict, reviewers, findings)
|
|
691
|
+
1. Validate the JSON schema (schema_version, verdict, synthesis_counts, reviewers, findings)
|
|
685
692
|
2. Write `round-meta.json` to `{session_dir}/rounds/round-{n}/round-meta.json`
|
|
686
|
-
3.
|
|
693
|
+
3. Use `synthesis_counts` for dashboard display (falls back to derived counts if absent)
|
|
687
694
|
4. Record a `round_completed` orchestration event in SQLite
|
|
688
695
|
|
|
696
|
+
**`synthesis_counts`**: Count the actual numbered items (`### 1.`, `### 2.`, etc.) under each section of `final.md`. This is the **deduplicated** count after merging cross-reviewer duplicates.
|
|
697
|
+
|
|
689
698
|
**Finding categories**: `"blocker"` | `"should_fix"` | `"suggestion"` | `"style"`
|
|
690
699
|
**Finding severity**: `"critical"` | `"high"` | `"medium"` | `"low"` | `"info"`
|
|
691
700
|
|