@open-audio-stack/core 0.1.45 → 0.1.47

package/build/classes/ManagerLocal.js

@@ -1,7 +1,7 @@
 import path from 'path';
 import { Package } from './Package.js';
 import { Manager } from './Manager.js';
-import { archiveExtract, dirCreate, dirDelete, dirEmpty, dirMove, dirRead, fileCreate, fileCreateJson, fileCreateYaml, fileExists, fileHash, fileInstall, fileOpen, fileReadJson, fileReadYaml, filesMove, isAdmin, runCliAsAdmin, } from '../helpers/file.js';
+import { archiveExtract, dirCreate, dirDelete, dirEmpty, dirIs, dirMove, dirRead, fileCreate, fileCreateJson, fileCreateYaml, fileExec, fileExists, fileHash, fileInstall, fileOpen, fileReadJson, fileReadYaml, filesMove, isAdmin, runCliAsAdmin, } from '../helpers/file.js';
 import { isValidVersion, pathGetSlug, pathGetVersion, toSlug } from '../helpers/utils.js';
 import { commandExists, getArchitecture, getSystem, isTests } from '../helpers/utilsLocal.js';
 import { apiBuffer } from '../helpers/api.js';
@@ -260,12 +260,85 @@ export class ManagerLocal extends Manager {
                     fileCreateJson(path.join(dirTarget, 'index.json'), pkgVersion);
                 }
                 else {
-                    // Move only supported file extensions into their respective installation directories.
-                    const filesMoved = filesMove(dirSource, this.typeDir, dirSub, formatDir);
-                    filesMoved.forEach((fileMoved) => {
-                        const fileJson = path.join(path.dirname(fileMoved), 'index.json');
-                        fileCreateJson(fileJson, pkgVersion);
+                    // Check if archive contains installer files (pkg, dmg) that should be run
+                    const allFiles = dirRead(`${dirSource}/**/*`).filter(f => !dirIs(f));
+                    const installerFiles = allFiles.filter(f => {
+                        const ext = path.extname(f).toLowerCase();
+                        return ext === '.pkg' || ext === '.dmg';
                     });
+                    if (installerFiles.length > 0) {
+                        // Run installer files found in archive
+                        for (const installerFile of installerFiles) {
+                            if (isTests())
+                                fileOpen(installerFile);
+                            else
+                                fileInstall(installerFile);
+                        }
+                        // Create directory and save package info for installer
+                        const dirTarget = path.join(this.typeDir, 'Installers', dirSub);
+                        dirCreate(dirTarget);
+                        fileCreateJson(path.join(dirTarget, 'index.json'), pkgVersion);
+                    }
+                    else if (this.type === RegistryType.Plugins) {
+                        // For plugins, move files into type-specific subdirectories
+                        const filesMoved = filesMove(dirSource, this.typeDir, dirSub, formatDir);
+                        if (filesMoved.length === 0) {
+                            throw new Error(`No compatible files found to install for ${slug}`);
+                        }
+                        filesMoved.forEach((fileMoved) => {
+                            const fileJson = path.join(path.dirname(fileMoved), 'index.json');
+                            fileCreateJson(fileJson, pkgVersion);
+                        });
+                    }
+                    else {
+                        // For apps/projects/presets, move entire directory without type subdirectories
+                        const dirTarget = path.join(this.typeDir, dirSub);
+                        dirCreate(dirTarget);
+                        dirMove(dirSource, dirTarget);
+                        fileCreateJson(path.join(dirTarget, 'index.json'), pkgVersion);
+                        // Ensure executable permissions for likely executables inside moved app/project/preset
+                        try {
+                            const movedFiles = dirRead(path.join(dirTarget, '**', '*')).filter(f => !dirIs(f));
+                            movedFiles.forEach((movedFile) => {
+                                const ext = path.extname(movedFile).slice(1).toLowerCase();
+                                if (['', 'elf', 'exe'].includes(ext)) {
+                                    try {
+                                        fileExec(movedFile);
+                                    }
+                                    catch (err) {
+                                        this.log(`Failed to set exec on ${movedFile}:`, err);
+                                    }
+                                }
+                            });
+                        }
+                        catch (err) {
+                            this.log('Error while setting executable permissions:', err);
+                        }
+                        // Also handle macOS .app bundles: set exec on binaries in Contents/MacOS
+                        try {
+                            const appDirs = dirRead(path.join(dirTarget, '**', '*.app')).filter(d => dirIs(d));
+                            appDirs.forEach((appDir) => {
+                                try {
+                                    const macosBinPattern = path.join(appDir, 'Contents', 'MacOS', '**', '*');
+                                    const macosFiles = dirRead(macosBinPattern).filter(f => !dirIs(f));
+                                    macosFiles.forEach((binFile) => {
+                                        try {
+                                            fileExec(binFile);
+                                        }
+                                        catch (err) {
+                                            this.log(`Failed to set exec on app binary ${binFile}:`, err);
+                                        }
+                                    });
+                                }
+                                catch (err) {
+                                    this.log(`Error scanning .app contents for ${appDir}:`, err);
+                                }
+                            });
+                        }
+                        catch (err) {
+                            this.log(err);
+                        }
+                    }
                 }
             }
         }
@@ -282,9 +355,9 @@ export class ManagerLocal extends Manager {
             return this.listPackages();
         }
         // Loop through all packages and install each one.
-        for (const [slug, pkg] of this.packages) {
+        for (const pkg of this.listPackages()) {
             const versionNum = pkg.latestVersion();
-            await this.install(slug, versionNum);
+            await this.install(pkg.slug, versionNum);
         }
         return this.listPackages();
     }
@@ -295,15 +368,17 @@ export class ManagerLocal extends Manager {
         manager.scan();
         const pkg = manager.getPackage(slug);
         if (!pkg)
-            return this.log(`Package ${slug} not found in registry`);
+            throw new Error(`Package ${slug} not found in registry`);
         const versionNum = version || pkg.latestVersion();
         const pkgVersion = pkg?.getVersion(versionNum);
         if (!pkgVersion)
-            return this.log(`Package ${slug} version ${versionNum} not found in registry`);
+            throw new Error(`Package ${slug} version ${versionNum} not found in registry`);
         // Get local package file.
         const pkgFile = packageLoadFile(filePath);
         if (pkgFile[type] && pkgFile[type][slug] && pkgFile[type][slug] === versionNum) {
-            return this.log(`Package ${slug} version ${versionNum} is already a dependency`);
+            this.log(`Package ${slug} version ${versionNum} is already a dependency`);
+            pkgFile.installed = true;
+            return pkgFile;
         }
         // Install dependency.
         await manager.install(slug, version);
@@ -352,14 +427,16 @@ export class ManagerLocal extends Manager {
         try {
             const openPath = openableFile.open;
             const fileExt = path.extname(openPath).slice(1).toLowerCase();
-            let formatDir = pluginFormatDir[fileExt] || 'Plugin';
-            if (this.type === RegistryType.Apps)
-                formatDir = pluginFormatDir[fileExt] || 'App';
-            else if (this.type === RegistryType.Presets)
-                formatDir = presetFormatDir[fileExt] || 'Preset';
-            else if (this.type === RegistryType.Projects)
-                formatDir = projectFormatDir[fileExt] || 'Project';
-            const packageDir = path.join(this.typeDir, formatDir, slug, versionNum);
+            let packageDir;
+            if (this.type === RegistryType.Plugins) {
+                // For plugins, use type-specific subdirectories
+                const formatDir = pluginFormatDir[fileExt] || 'Plugin';
+                packageDir = path.join(this.typeDir, formatDir, slug, versionNum);
+            }
+            else {
+                // For apps/projects/presets, files are in direct package directory
+                packageDir = path.join(this.typeDir, slug, versionNum);
+            }
             let fullPath;
             if (path.isAbsolute(openPath)) {
                 fullPath = openPath;
@@ -434,9 +511,9 @@ export class ManagerLocal extends Manager {
         // Get local package file.
         const pkgFile = packageLoadFile(filePath);
         if (!pkgFile[type])
-            return this.log(`Package ${type} is missing`);
+            throw new Error(`Package ${type} is missing`);
         if (!pkgFile[type][slug])
-            return this.log(`Package ${type} ${slug} is not a dependency`);
+            throw new Error(`Package ${type} ${slug} is not a dependency`);
         // Uninstall dependency.
         const manager = new ManagerLocal(type, this.config.config);
         await manager.sync();

package/build/classes/Package.js

@@ -28,7 +28,7 @@ export class Package extends Base {
         if (Object.keys(report).length > 0)
             this.reports.set(num, report);
         if (errors.length > 0)
-            return this.log(`Package ${version.name} version ${num} errors`, errors);
+            throw new Error(`Package ${version.name} version ${num} has validation errors: ${JSON.stringify(errors)}`);
         version.verified = packageIsVerified(this.slug, version);
         this.versions.set(num, version);
         this.version = this.latestVersion();

package/build/helpers/admin.js

@@ -35,14 +35,14 @@ export function adminArguments() {
     return args;
 }
 export async function adminInit() {
-    const args = adminArguments();
-    const manager = new ManagerLocal(args.type, { appDir: args.appDir });
-    if (args.log)
-        manager.logEnable();
-    manager.log('adminInit', args);
-    await manager.sync();
-    manager.scan();
     try {
+        const args = adminArguments();
+        const manager = new ManagerLocal(args.type, { appDir: args.appDir });
+        if (args.log)
+            manager.logEnable();
+        manager.log('adminInit', args);
+        await manager.sync();
+        manager.scan();
         if (args.operation === 'install') {
             await manager.install(args.id, args.version);
         }
@@ -61,7 +61,7 @@ export async function adminInit() {
         const message = err && err.message ? err.message : String(err);
         const errorResult = { status: 'error', code: err && err.code ? err.code : 1, message };
         process.stdout.write('\n');
-        console.log(JSON.stringify(errorResult));
+        console.error(JSON.stringify(errorResult));
         process.exit(typeof errorResult.code === 'number' ? errorResult.code : 1);
     }
 }

package/build/helpers/file.js

@@ -16,9 +16,14 @@ import { fileURLToPath } from 'url';
 import sudoPrompt from '@vscode/sudo-prompt';
 import { getSystem } from './utilsLocal.js';
 import { log } from './utils.js';
+import mime from 'mime-types';
 export async function archiveExtract(filePath, dirPath) {
     log('⎋', dirPath);
+    const fileName = path.basename(filePath).toLowerCase();
     const ext = path.extname(filePath).trim().toLowerCase();
+    const tarExtensions = ['.tar', '.gz', '.tgz', '.xz', '.bz2', '.tbz2'];
+    const tarCompoundExtensions = ['.tar.gz', '.tar.xz', '.tar.bz2'];
+    const isTarFile = tarExtensions.includes(ext) || tarCompoundExtensions.some(compoundExt => fileName.endsWith(compoundExt));
     if (ext === '.zip') {
         const zip = new AdmZip(filePath);
         try {
@@ -44,7 +49,7 @@ export async function archiveExtract(filePath, dirPath) {
             }
         }
     }
-    else if (ext === '.tar' || ext === '.gz' || ext === '.tgz') {
+    else if (isTarFile) {
         return await tar.extract({
             file: filePath,
             cwd: dirPath,
@@ -252,15 +257,32 @@ export function fileMove(filePath, newPath) {
 export function filesMove(dirSource, dirTarget, dirSub, formatDir) {
     const filesAndFolders = dirRead(`${dirSource}/**/*`);
     log('filesAndFolders', filesAndFolders);
+    // First pass: identify bundle directories (app, clap, vst3, lv2, etc.)
+    const bundleDirs = new Set();
+    filesAndFolders.forEach(f => {
+        if (dirIs(f)) {
+            // Check if this is a macOS application bundle or plugin bundle
+            if (fileExists(path.join(f, 'Contents', 'Info.plist'))) {
+                bundleDirs.add(f);
+            }
+            // Check if this is an LV2 plugin folder
+            if (fileExists(path.join(f, 'manifest.ttl'))) {
+                bundleDirs.add(f);
+            }
+        }
+    });
     const files = filesAndFolders.filter(f => {
-        // Include files.
+        // Exclude files/folders that are inside bundle directories
+        for (const bundleDir of bundleDirs) {
+            if (f.startsWith(bundleDir + path.sep)) {
+                return false; // This path is inside a bundle, exclude it
+            }
+        }
+        // Include regular files (not directories).
         if (!dirIs(f))
             return true;
-        // Include macOS application bundles (directory of files presented as a single file).
-        if (fileExists(path.join(f, 'Contents', 'Info.plist')))
-            return true;
-        // Include LV2 plugin folders.
-        if (fileExists(path.join(f, 'manifest.ttl')))
+        // Include bundle directories themselves (already identified above).
+        if (bundleDirs.has(f))
             return true;
         // Otherwise ignore.
         return false;
@@ -270,7 +292,14 @@ export function filesMove(dirSource, dirTarget, dirSub, formatDir) {
     // For each file, move to correct folder based on type
     files.forEach((fileSource) => {
         const fileExt = path.extname(fileSource).slice(1).toLowerCase();
-        const fileExtTarget = formatDir[fileExt];
+        let fileExtTarget = formatDir[fileExt];
+        // Use mime-type detection as fallback for unmapped extensions
+        if (!fileExtTarget) {
+            const mimeType = mime.lookup(fileSource) || '';
+            if (!mimeType || mimeType.startsWith('application/')) {
+                fileExtTarget = 'App';
+            }
+        }
         // If this is not a supported file format, then ignore.
         if (fileExtTarget === undefined)
             return log(`${fileSource} - ${fileExt || 'no extension'} not mapped to a installation folder, skipping.`);
@@ -392,14 +421,6 @@ export function runCliAsAdmin(args) {
         log(`Running as admin: node "${script}" ${args}`);
         const cmd = `node "${script}" ${args}`;
         sudoPrompt.exec(cmd, { name: 'Open Audio Stack' }, (error, stdout, stderr) => {
-            // Prefer explicit error from sudo-prompt callback
-            if (error) {
-                const stderrStr = stderr ? (typeof stderr === 'string' ? stderr : stderr.toString()) : '';
-                const msg = `runCliAsAdmin: admin command failed: ${error && error.message ? error.message : String(error)}${stderrStr ? `\nstderr: ${stderrStr}` : ''}`;
-                const err = new Error(msg);
-                err.code = error && error.code ? error.code : undefined;
-                return reject(err);
-            }
             // Convert stdout/stderr buffers to strings for inspection
             const stdoutStr = stdout ? (typeof stdout === 'string' ? stdout : stdout.toString()) : '';
             const stderrStr = stderr ? (typeof stderr === 'string' ? stderr : stderr.toString()) : '';
@@ -421,6 +442,7 @@ export function runCliAsAdmin(args) {
                     // This line is not JSON, continue searching
                 }
             }
+            // If we found JSON output from admin script, prioritize it over sudoPrompt error
             if (jsonPayload) {
                 if (jsonPayload && (jsonPayload.status === 'ok' || jsonPayload.code === 0)) {
                     return resolve();
@@ -428,6 +450,13 @@ export function runCliAsAdmin(args) {
                 const errMsg = jsonPayload && jsonPayload.message ? jsonPayload.message : JSON.stringify(jsonPayload);
                 return reject(new Error(`runCliAsAdmin: admin command reported error: ${errMsg}`));
             }
+            // If no JSON found, check for sudoPrompt error
+            if (error) {
+                const msg = `runCliAsAdmin: admin command failed: ${error && error.message ? error.message : String(error)}${stderrStr ? `\nstderr: ${stderrStr}` : ''}`;
+                const err = new Error(msg);
+                err.code = error && error.code ? error.code : undefined;
+                return reject(err);
+            }
             return reject(new Error(`runCliAsAdmin: admin command did not report completion. stdout: ${stdoutStr} stderr: ${stderrStr}`));
         });
     });

package/build/types/PluginFormat.d.ts

@@ -19,9 +19,7 @@ export declare enum PluginFormat {
 export type PluginFormatDir = {
     [format in PluginFormat]: string;
 };
-export declare const pluginFormatDir: PluginFormatDir & {
-    '': string;
-};
+export declare const pluginFormatDir: PluginFormatDir;
 export interface PluginFormatOption {
     description: string;
     value: PluginFormat;

package/build/types/PluginFormat.js

@@ -34,7 +34,6 @@ export const pluginFormatDir = {
     [PluginFormat.VSTMac]: 'VST',
     [PluginFormat.VSTWin]: 'VST',
     [PluginFormat.WinStandalone]: 'Exe',
-    '': 'App',
 };
 export const pluginFormats = [
     {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@open-audio-stack/core",
-  "version": "0.1.45",
+  "version": "0.1.47",
   "description": "Open-source audio plugin management software",
   "type": "module",
   "main": "./build/index.js",
@@ -42,6 +42,7 @@
     "@types/adm-zip": "^0.5.5",
     "@types/fs-extra": "^11.0.4",
     "@types/js-yaml": "^4.0.9",
+    "@types/mime-types": "^3.0.1",
     "@types/node": "^22.7.8",
     "@types/semver": "^7.5.8",
     "@vitest/coverage-v8": "^3.0.5",
@@ -62,6 +63,7 @@
     "glob": "^11.0.0",
     "inquirer": "^12.4.1",
     "js-yaml": "^4.1.0",
+    "mime-types": "^3.0.2",
     "semver": "^7.6.3",
     "slugify": "^1.6.6",
     "tar": "^7.4.3",