@open-agent-toolkit/cli 0.3.15 → 0.3.17

package/assets/skills/oat-project-implement/SKILL.md

@@ -7,7 +7,7 @@ disable-model-invocation: true
 user-invocable: true
 allowed-tools: Read, Write, Bash(git:*), Bash(oat:*), Bash(oat project log:*), Glob, Grep, AskUserQuestion, Task
 metadata:
-  version: 2.3.16
+  version: 2.3.18
 ---
 
 # Implementation Phase
@@ -74,6 +74,11 @@ to be clean; each append is committed by the bookkeeping that owns it.
   entry with the verdict and fix-loop count.
 - After every parallel-group merge attempt, invoke `oat project log append` for
   a structural entry with the merge result.
+- Append root-judgment entries through `oat project log append` for breaks,
+  surprises, workarounds, or notable successes, including observations relayed
+  from subagent reports; queue one that surfaces while a child owns the worktree
+  until the next bookkeeping boundary. Phase implementers and dispatched
+  subagents have no logging duties.
 
 ## Autonomy Policy
 

package/assets/skills/oat-project-implement/references/completion-and-closeout.md

@@ -114,9 +114,9 @@ PROJECT_SCOPE=$(oat project scope "$PROJECT_PATH" --format value) || { echo "oat
 if [ "$PROJECT_SCOPE" = "synced" ]; then
   oat project push "$PROJECT_PATH" --message "chore(oat): prepare final implementation closeout" || { echo "oat: project push failed; run oat project pull, resolve the reported state, and retry" >&2; exit 1; }
 else
-  git add "$PROJECT_PATH/implementation.md" "$PROJECT_PATH/state.md" "$PROJECT_PATH/plan.md"
-  [ -f "$PROJECT_PATH/project-log.md" ] && git add "$PROJECT_PATH/project-log.md"
-  git diff --cached --quiet || git commit -m "chore(oat): prepare final implementation closeout"
+  OWNED_COMMIT_PATHS=("$PROJECT_PATH/implementation.md" "$PROJECT_PATH/state.md" "$PROJECT_PATH/plan.md")
+  [ -f "$PROJECT_PATH/project-log.md" ] && OWNED_COMMIT_PATHS+=("$PROJECT_PATH/project-log.md")
+  oat internal commit-paths --identity "${COMMIT_IDENTITY:?set once and retain for retries}:oat-project-implement:completion-and-closeout:1" --message "chore(oat): prepare final implementation closeout" -- "${OWNED_COMMIT_PATHS[@]}" || exit 1
 fi
 ```
 
@@ -294,6 +294,15 @@ To run in a separate session use: oat-project-review-provide code final
 - If Critical/High findings: Fix tasks added, re-run the `oat-project-implement` skill
 - Loop until final review passes (max 3 cycles per oat-project-review-receive)
 
+**Final review cap.** When the final review reaches the three-cycle cap,
+dispatch the complexity review that
+`references/docs/complexity-review-fallback.md` defines for the final loop,
+then show its decision message; under `OAT_AUTONOMOUS=1`, put the same content
+in the boundary report instead. Record the operator's choice with the report
+path in `implementation.md`. Agents never select the disposition. One exhausted
+loop gets one review: follow that doc's reuse rule, so a report the receive
+step's cycle cap already produced for this final loop serves here too.
+
 **After final review is marked `passed`:**
 
 - Record the passed final review and keep the project in implementation closeout.
@@ -311,7 +320,11 @@ or satisfies this configured exit gate.
 **Persisted transition contract:**
 
 `"$PROJECT_PATH/state.md"` is the routing source of truth. Store one closeout
-generation as a sibling of `oat_post_implement_sequence`:
+generation as a sibling of `oat_post_implement_sequence`. Its `status`,
+`disposition`, `config_fingerprint`, `reviewed_head`, and `decided_at` fields
+are the shared lifecycle gate record core defined in
+`references/docs/gate-approval-record.md`; the additional values and fields
+below, and the freshness rules in this step, belong to this carrier:
 
 ```yaml
 oat_implement_exit_gate:
@@ -351,6 +364,7 @@ oat_implement_exit_gate:
   receive_completed: false
   failure: null
   updated_at: '2026-07-18T00:00:00Z'
+  decided_at: null # ISO 8601 UTC; set with every allowed or blocked outcome
 ```
 
 At the start of a new closeout generation, require a current passed final
@@ -550,6 +564,9 @@ disposition.
 - An explicit prompt continuation persists `allowed/prompt_approved`; defer or
   no response persists `blocked` and stops. A warn continuation persists
   `allowed/warned` before closeout proceeds.
+- Every write that sets `status` to `allowed` or `blocked` also sets
+  `decided_at` to the current ISO 8601 UTC time; `pending` and `stale` writes
+  leave it unchanged.
 
 **Interruption, resume, and freshness:**
 
@@ -790,6 +807,16 @@ completion, or success output, run the configured gate:
    correlation failures, and receive failures cannot continue to sequencing,
    final HiLL, completion, or success output regardless of `on_failure`.
 
+   **Complexity review at `maxAttempts`.** When the gate ends in `block` after
+   attempts are exhausted, dispatch the complexity review that
+   `references/docs/complexity-review-fallback.md` defines for this exhausted
+   gate loop before escalating, then show its decision message with the
+   accumulated feedback; under `OAT_AUTONOMOUS=1`, put the same content in the
+   boundary report instead. Record the operator's choice with the report path
+   in `implementation.md`. Agents never select the disposition. A single
+   unresolved policy boundary that consumed no remediation attempt is not a
+   budget exhaustion and does not trigger the review.
+
    When the gate ends in `block` after attempts are exhausted or remains at an
    unresolved `prompt` boundary, the completion steps below MUST NOT run. The
    project stays `in_progress` and resumable through `oat-project-implement`.
@@ -1188,9 +1215,9 @@ PROJECT_SCOPE=$(oat project scope "$PROJECT_PATH" --format value) || { echo "oat
 if [ "$PROJECT_SCOPE" = "synced" ]; then
   oat project push "$PROJECT_PATH" --message "chore(oat): mark implementation complete" || { echo "oat: project push failed; run oat project pull, resolve the reported state, and retry" >&2; exit 1; }
 else
-  git add "$PROJECT_PATH/implementation.md" "$PROJECT_PATH/state.md" "$PROJECT_PATH/plan.md"
-  [ -f "$PROJECT_PATH/project-log.md" ] && git add "$PROJECT_PATH/project-log.md"
-  git diff --cached --quiet || git commit -m "chore(oat): mark implementation complete"
+  OWNED_COMMIT_PATHS=("$PROJECT_PATH/implementation.md" "$PROJECT_PATH/state.md" "$PROJECT_PATH/plan.md")
+  [ -f "$PROJECT_PATH/project-log.md" ] && OWNED_COMMIT_PATHS+=("$PROJECT_PATH/project-log.md")
+  oat internal commit-paths --identity "${COMMIT_IDENTITY:?set once and retain for retries}:oat-project-implement:completion-and-closeout:2" --message "chore(oat): mark implementation complete" -- "${OWNED_COMMIT_PATHS[@]}" || exit 1
 fi
 ```