@open-agent-toolkit/cli 0.2.2 → 0.2.4

package/assets/skills/oat-project-implement/references/phase-execution.md

@@ -132,8 +132,41 @@ handle. Only explicit pre-start rejection allows another route. Timeout,
 interruption, `BLOCKED`, or contract refusal is the review outcome and never a
 reason to replace an accepted reviewer.
 
-Validate artifact scope and commit range. Zero Critical and zero Important
-findings passes. Medium/Minor findings are recorded without blocking.
+Before validating the review artifact scope or commit range, or updating any
+project bookkeeping, consume the reviewer's brief artifact-mode confirmation.
+It must contain exactly one of these exact lines:
+
+- `**Reconnaissance:** attempted`
+- `**Reconnaissance:** not-attempted`
+
+A missing, duplicate, or invalid reconnaissance signal is an
+incomplete-artifact error: stop and fail closed without validating the review
+artifact, updating bookkeeping, or appending a project-log entry.
+
+Use the valid signal to validate the review artifact's orchestration evidence:
+
+- For `attempted`, require a complete `## Review Orchestration` section with
+  one compact account of every attempted wave: task class, classification
+  rationale, selected target, acceptance/outcome, floor satisfaction, fallback,
+  and primary reconciliation. Missing or incomplete evidence is an
+  incomplete-artifact error. After successful validation, append exactly once
+  through `oat project log append`, creating one concise structural entry that
+  references the review artifact path.
+- For `not-attempted`, the artifact must not contain
+  `## Review Orchestration`; treat a present section as an inconsistent,
+  incomplete artifact. Do not append a log entry and do not invoke
+  `oat project log append`.
+
+For the attempted branch, do not mirror individual worker records. Defer flags
+and entry format to `oat project log append --help`; never pre-check project-log
+configuration because the helper no-ops when logging is disabled. The reviewer
+and workers never write `project-log.md` or append this entry.
+
+After successful signal and orchestration validation, validate the review
+artifact scope and commit range.
+
+Zero Critical and zero Important findings passes. Medium/Minor findings are
+recorded without blocking.
 
 #### Bounded Fix and Re-Review Loop
 

package/assets/skills/oat-project-next/SKILL.md

@@ -1,6 +1,6 @@
 ---
 name: oat-project-next
-version: 1.0.9
+version: 1.0.10
 description: Use when continuing work on the active OAT project. Reads project state, determines the next lifecycle action, and invokes the appropriate skill automatically.
 disable-model-invocation: true
 user-invocable: true
@@ -101,14 +101,15 @@ ls -d "$PROJECTS_ROOT"/*/ 2>/dev/null
 
 Read `"$PROJECT_PATH/state.md"` frontmatter and extract:
 
-| Field                  | Used For                                                                     |
-| ---------------------- | ---------------------------------------------------------------------------- |
-| `oat_phase`            | Current lifecycle position (discovery, spec, design, plan, implement)        |
-| `oat_phase_status`     | Phase completion state (in_progress, complete, pr_open)                      |
-| `oat_workflow_mode`    | Routing table selection (spec-driven, quick, import). Default: `spec-driven` |
-| `oat_hill_checkpoints` | Which phases require HiLL approval                                           |
-| `oat_hill_completed`   | Which HiLL gates have been passed                                            |
-| `oat_blockers`         | Informational warnings (not routing gates)                                   |
+| Field                     | Used For                                                                     |
+| ------------------------- | ---------------------------------------------------------------------------- |
+| `oat_phase`               | Current lifecycle position (discovery, spec, design, plan, implement)        |
+| `oat_phase_status`        | Phase completion state (in_progress, complete, pr_open)                      |
+| `oat_workflow_mode`       | Routing table selection (spec-driven, quick, import). Default: `spec-driven` |
+| `oat_hill_checkpoints`    | Which phases require HiLL approval                                           |
+| `oat_hill_completed`      | Which HiLL gates have been passed                                            |
+| `oat_blockers`            | Informational warnings (not routing gates)                                   |
+| `oat_implement_exit_gate` | Whether the implementation exit gate is allowed and fresh                    |
 
 **If state.md is missing or unreadable:** Report error and suggest running the relevant phase skill directly. STOP.
 
@@ -261,26 +262,66 @@ Entry condition: `oat_phase == "implement"` AND (`oat_phase_status == "complete"
 
 Apply the following checks in priority order. Stop at the first match:
 
-**5.0: Incomplete approval-aware post-implementation sequence**
+**5.0: Unresolved implementation exit gate**
+
+Before every other post-implementation route, inspect
+`oat_implement_exit_gate` in project state. If
+`oat_implement_exit_gate` is absent, `pending`, `blocked`, `stale`, malformed,
+or not fresh, route to `oat-project-implement`.
+
+This override applies even when `oat_phase_status` is `complete` or `pr_open`,
+and before the summary, document, PR, or `oat-project-complete` routes. Announce
+exactly: "Implementation exit gate unresolved or stale — resume with
+`oat-project-implement` before post-implementation routing."
+
+Only an `allowed` and fresh exit-gate disposition falls through to the normal
+post-implementation checks.
+
+Validate freshness from the complete persisted transition, not from `status`
+alone:
+
+- `allowed/no_gate` is valid only with `disposition: no_gate`, null gate-run and
+  artifact provenance, and current `reviewed_head` and implementation
+  fingerprint fields.
+- `allowed/configured` is valid only with `disposition: passed`, `warned`, or
+  `prompt_approved`; matching `config_fingerprint`, `reviewed_head`,
+  `implementation_fingerprint`, and configured gate-run provenance; and any
+  eligible receive durably completed.
+- `pending`, `blocked`, malformed, contradictory, or legacy-absent state never
+  falls through. Pending and blocked generations resume their persisted
+  configuration; configuration-fingerprint mismatch fails closed.
+- Recognized closeout-only descendants preserve a fresh allowed result; unknown
+  paths and substantive changes route as stale. The recognized set is limited
+  to configured gate artifacts and receipts, project tracking and
+  `project-log.md` appends, summary/documentation/PR sequence outputs, final
+  HiLL bookkeeping, and completion bookkeeping.
+- Any implementation, test, skill, template, workflow configuration, or other
+  unrecognized change after `reviewed_head` invalidates the implementation
+  fingerprint and routes to `oat-project-implement`.
+
+Routing is read-only: announce stale or malformed state, but leave transition
+repair, gate execution, receive, and persistence to `oat-project-implement`.
+
+**5.1: Incomplete approval-aware post-implementation sequence**
 
 Before every other post-implementation route, inspect `oat_post_implement_sequence`
 in project state. When the snapshot exists and is incomplete, route to
 `oat-project-implement`. This applies even when `oat_phase_status` is `pr_open`
 or a summary exists. A completed snapshot falls through to the normal router.
 
-**5.1: Incomplete revision tasks**
+**5.2: Incomplete revision tasks**
 
 Grep plan.md for `p-revN` phases. If any `p-revN` tasks exist with status != completed in implementation.md:
 → Route to `oat-project-implement`
 → Announce: "Revision tasks pending — continuing implementation"
 
-**5.2: Unprocessed reviews**
+**5.3: Unprocessed reviews**
 
 Run the Review Safety Check (Step 4 above). If unprocessed reviews exist:
 → Route to `oat-project-review-receive`
 → Announce: "Unprocessed review feedback detected"
 
-**5.3: Final code review not passed**
+**5.4: Final code review not passed**
 
 Extract only the exact level-two `## Reviews` ledger, stopping before the next
 level-two heading, then select its latest appended event with `Scope="final"`
@@ -305,14 +346,14 @@ Ignore matching rows outside `REVIEWS_SECTION`; they are not review events.
   → Route to `oat-project-review-provide` (with scope hint: "code final")
   → Announce: "Review fixes implemented — triggering re-review"
 
-- If `FINAL_ROW` has another non-passed status (e.g., `"received"`, `"fixes_added"`) and Step 5.2 did not find an active top-level review artifact:
+- If `FINAL_ROW` has another non-passed status (e.g., `"received"`, `"fixes_added"`) and Step 5.3 did not find an active top-level review artifact:
   → Route to `oat-project-review-provide` (with scope hint: "code final")
   → Announce: "Final review is not passed and no active review artifact exists — rerunning final review"
 
 - If `FINAL_ROW` has `Status="passed"`:
-  → Continue to 5.4
+  → Continue to 5.5
 
-**5.4: Summary not done**
+**5.5: Summary not done**
 
 Read `{PROJECT_PATH}/summary.md`:
 
@@ -320,13 +361,13 @@ Read `{PROJECT_PATH}/summary.md`:
   → Route to `oat-project-summary`
   → Announce: "Final review passed — generating project summary"
 
-**5.5: PR not created**
+**5.6: PR not created**
 
 If `oat_phase_status != "pr_open"`:
 → Route to `oat-project-pr-final`
 → Announce: "Summary complete — creating final PR"
 
-**5.6: PR is open**
+**5.7: PR is open**
 
 If `oat_phase_status == "pr_open"`:
 → Route to `oat-project-complete`