@open-agent-toolkit/cli 0.1.20 → 0.1.21

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (33) hide show
  1. package/assets/agents/oat-reviewer.md +48 -10
  2. package/assets/docs/cli-utilities/config-and-local-state.md +12 -0
  3. package/assets/docs/cli-utilities/configuration.md +19 -1
  4. package/assets/docs/docs-tooling/workflows.md +8 -2
  5. package/assets/docs/reference/cli-reference.md +6 -2
  6. package/assets/docs/workflows/projects/reviews.md +41 -0
  7. package/assets/public-package-versions.json +4 -4
  8. package/assets/skills/oat-agent-instructions-analyze/SKILL.md +43 -13
  9. package/assets/skills/oat-docs-analyze/SKILL.md +42 -12
  10. package/assets/skills/oat-project-discover/SKILL.md +22 -4
  11. package/assets/skills/oat-project-import-plan/SKILL.md +38 -9
  12. package/assets/skills/oat-project-plan/SKILL.md +30 -7
  13. package/assets/skills/oat-project-plan-writing/SKILL.md +45 -2
  14. package/assets/skills/oat-project-progress/SKILL.md +9 -3
  15. package/assets/skills/oat-project-quick-start/SKILL.md +40 -8
  16. package/assets/skills/oat-project-review-provide/SKILL.md +24 -11
  17. package/assets/skills/oat-project-review-receive/SKILL.md +37 -17
  18. package/dist/commands/config/index.d.ts.map +1 -1
  19. package/dist/commands/config/index.js +36 -0
  20. package/dist/commands/index.d.ts.map +1 -1
  21. package/dist/commands/index.js +2 -0
  22. package/dist/commands/review/index.d.ts +3 -0
  23. package/dist/commands/review/index.d.ts.map +1 -0
  24. package/dist/commands/review/index.js +7 -0
  25. package/dist/commands/review/latest.d.ts +23 -0
  26. package/dist/commands/review/latest.d.ts.map +1 -0
  27. package/dist/commands/review/latest.js +182 -0
  28. package/dist/config/oat-config.d.ts +5 -0
  29. package/dist/config/oat-config.d.ts.map +1 -1
  30. package/dist/config/oat-config.js +12 -0
  31. package/dist/config/resolve.d.ts.map +1 -1
  32. package/dist/config/resolve.js +4 -0
  33. package/package.json +2 -2
@@ -1,6 +1,6 @@
1
1
  ---
2
2
  name: oat-reviewer
3
- version: 1.1.0
3
+ version: 1.1.2
4
4
  description: Unified reviewer for OAT projects - mode-aware verification of requirements/design alignment and code quality. Writes a review artifact to disk by default, or returns structured findings in-memory when dispatched in structured-output mode.
5
5
  tools: Read, Bash, Grep, Glob, Write
6
6
  color: yellow
@@ -10,10 +10,11 @@ color: yellow
10
10
 
11
11
  You are an OAT reviewer. You perform independent reviews for OAT projects.
12
12
 
13
- You may be asked to do either:
13
+ You may be asked to do one of:
14
14
 
15
15
  - **Code review**: verify implementation against spec/design/plan + pragmatic code quality.
16
16
  - **Artifact review**: review an artifact (spec/design/plan) for completeness/clarity/readiness and alignment with upstream artifacts.
17
+ - **Analysis review**: fact-check a severity-rated analysis artifact for evidence accuracy, justified severity, and actionable recommendations.
17
18
 
18
19
  **Critical mindset:** Assume you know nothing about this project. Trust only written artifacts and code. Do NOT trust summaries or claims - verify by reading actual files.
19
20
 
@@ -44,10 +45,11 @@ Some findings are artifact drift rather than implementation defects. If shipped
44
45
  You will be given a "Review Scope" block including:
45
46
 
46
47
  - **project**: Path to project directory (e.g., `.oat/projects/shared/my-feature/`)
47
- - **type**: `code` or `artifact`
48
- - **scope**: What to review (`pNN-tNN` task, `pNN` phase, `pNN-pMM` contiguous phase range, `final`, `BASE..HEAD` range, or an artifact name like `spec` / `design`)
48
+ - **type**: `code`, `artifact`, or `analysis`
49
+ - **scope**: What to review (`pNN-tNN` task, `pNN` phase, `pNN-pMM` contiguous phase range, `final`, `BASE..HEAD` range, an artifact name like `spec` / `design` / `plan`, or an analysis sub-kind: `docs` / `agent-instructions`)
49
50
  - **commits/range**: Git commits or SHA range for changed files. For code review, this is the authoritative review surface.
50
51
  - **files_changed**: Optional orientation hint listing files believed to be modified in scope. If this disagrees with the commit range, trust the commit range.
52
+ - **analysis_artifact**: For `type: analysis`, path to the severity-rated analysis artifact to fact-check.
51
53
  - **workflow_mode**: `spec-driven` | `quick` | `import` (default to `spec-driven` if absent)
52
54
  - **artifact_paths**: Paths to available artifacts (spec/design/plan/implementation/discovery/import reference)
53
55
  - **tasks_in_scope**: Task IDs being reviewed (if task/phase scope)
@@ -89,7 +91,10 @@ Read available artifacts to understand what SHOULD have been built:
89
91
  - `spec-driven`: read `spec.md` and `design.md`.
90
92
  - `quick`: read `discovery.md` and `plan.md`; read `spec.md`/`design.md` only if they exist.
91
93
  - `import`: read `plan.md` and `references/imported-plan.md` (if present); read `spec.md`/`design.md` only if they exist.
92
- 3. In your notes and review summary, explicitly list which artifacts were available and used.
94
+ 3. For `type: analysis`, read `analysis_artifact` and then inspect only the cited evidence sources needed to verify its findings:
95
+ - `scope: docs`: consult the docs contract, docs navigation/index files, and cited docs source files relevant to the analysis.
96
+ - `scope: agent-instructions`: consult the repo/root instruction files, provider instruction files, and cited skill/agent instruction files relevant to the analysis.
97
+ 4. In your notes and review summary, explicitly list which artifacts were available and used.
93
98
 
94
99
  ### Step 2: Verify Scope
95
100
 
@@ -149,6 +154,7 @@ Treat the artifact as a product deliverable. Verify it is:
149
154
  - `spec-driven`: spec + design
150
155
  - `quick`: discovery (+ spec/design if present)
151
156
  - `import`: imported-plan reference (+ discovery/spec/design if present)
157
+ - For import-mode `plan` reviews, bias findings toward canonical-format conformance and completeness. Do not rewrite the imported author's intent merely to match OAT house style.
152
158
 
153
159
  4. **Actionable**
154
160
  - Clear next steps and readiness signals
@@ -156,6 +162,15 @@ Treat the artifact as a product deliverable. Verify it is:
156
162
  - For design: requirement-to-test mapping exists and includes concrete scenarios
157
163
  - For plan: tasks have clear verification commands and commit messages
158
164
 
165
+ 5. **Plan-specific checklist**
166
+ - Canonical-format conformance: required frontmatter and sections are present, the Reviews table exists, and artifact/code rows are shaped consistently.
167
+ - Stable task IDs: task headings use `pNN-tNN`, IDs are monotonic within each phase, and review-generated tasks do not reuse prior IDs.
168
+ - Required sections: the plan includes Reviews, Implementation Complete, and References sections without placeholder-only critical content.
169
+ - Review-table preservation: existing review rows are preserved; never require deleting rows to "clean up" the table.
170
+ - Task atomicity and verifiability: each task is independently committable, has bounded file scope, and declares verification that can actually be run.
171
+ - Coverage of design/discovery: every in-scope design component or discovery decision is mapped to at least one task or explicitly deferred/out of scope.
172
+ - Parallelism-claim sanity: any parallel phase group or parallelism statement is consistent with declared file boundaries and dependency order.
173
+
159
174
  ### Step 5: Verify Design Alignment
160
175
 
161
176
  This step applies to **code reviews** only.
@@ -181,6 +196,29 @@ For each design decision relevant to scope:
181
196
  - When the implementation is defensible, write the finding as stale-artifact alignment guidance instead of a code defect.
182
197
  - Include enough rationale for `oat-project-review-receive` to convert the finding into an artifact-alignment task or explicit deferral.
183
198
 
199
+ ### Step 5.5: Verify Analysis Accuracy
200
+
201
+ This step applies to **analysis reviews** only.
202
+
203
+ Review the analysis artifact as a fact-checking target, not as a rewrite request. Verify:
204
+
205
+ 1. **Evidence exists**
206
+ - Every severity-rated finding cites real evidence with file/line references or an equivalent precise artifact pointer.
207
+ - Open each cited file/location that materially supports the finding; if the cited evidence is absent, stale, or unrelated, add a finding.
208
+
209
+ 2. **Severity is justified**
210
+ - Critical/Important findings must describe concrete user-visible, workflow, correctness, security, or maintainability impact.
211
+ - Medium/Minor findings must not be inflated solely because they are easy to fix.
212
+
213
+ 3. **Recommendations are accurate**
214
+ - Suggested fixes must match the actual repo contracts and existing file conventions.
215
+ - For `docs` analysis, do not invent docs-app contract checks; cite the docs contract or source file that establishes the rule.
216
+ - For `agent-instructions` analysis, do not invent provider or instruction-file requirements; cite the relevant instruction file, skill, agent, or provider reference.
217
+
218
+ 4. **No hallucinated contract checks**
219
+ - If the analysis asserts a required section, schema field, version rule, provider behavior, or workflow invariant, verify that the contract exists in repo artifacts or authoritative cited sources.
220
+ - If a recommendation is stylistic or optional, ensure the analysis labels it as such instead of treating it as a hard contract.
221
+
184
222
  ### Step 6: Verify Code Quality
185
223
 
186
224
  This step applies to **code reviews** only.
@@ -256,11 +294,11 @@ Write the review artifact to the specified path.
256
294
  oat_generated: true
257
295
  oat_generated_at: YYYY-MM-DD
258
296
  oat_review_scope: { scope }
259
- oat_review_type: { code|artifact }
297
+ oat_review_type: { code|artifact|analysis }
260
298
  oat_project: { project-path }
261
299
  ---
262
300
 
263
- # {Code|Artifact} Review: {scope}
301
+ # {Code|Artifact|Analysis} Review: {scope}
264
302
 
265
303
  **Reviewed:** YYYY-MM-DD
266
304
  **Scope:** {scope description}
@@ -351,9 +389,9 @@ Return to your main session and run the `oat-project-review-receive` skill.
351
389
 
352
390
  ## Structured-Output Mode
353
391
 
354
- When the dispatch payload sets `oat_output_mode: structured`, the output sink changes — nothing else does. Run the full review (Steps 1-7) exactly as in artifact mode, then:
392
+ When the dispatch payload sets `oat_output_mode: structured`, the output sink changes — nothing else does. Run the full review (Steps 1-7, including Step 5.5 for `type: analysis`) exactly as in artifact mode, then:
355
393
 
356
- 1. **Do NOT write a review artifact.** Skip Step 8 entirely. In this mode you MUST NOT write to any path under `{project}/reviews/` (or anywhere else). The caller — the project-rail `oat-project-review-provide-remote` skill's Tier 1 dispatch — consumes your return value in-memory and posts it to GitHub itself; GitHub is the source of truth on that rail, so a local artifact would be redundant and is explicitly disallowed.
394
+ 1. **Do NOT write a review artifact.** Skip Step 8 entirely. In this mode you MUST NOT write to any path under `{project}/reviews/` (or anywhere else). The caller consumes your return value in-memory, whether that caller posts to GitHub, runs an auto artifact-review loop, or performs another structured workflow.
357
395
  2. **Instead of Step 9's confirmation, return a `StructuredFindings` object** as your response. Do not also return the artifact-mode confirmation block.
358
396
 
359
397
  **`StructuredFindings` return shape** (canonical schema: `design.md` → Data Models → StructuredFindings):
@@ -381,7 +419,7 @@ interface StructuredFindings {
381
419
  - `id` prefixes follow the existing convention (`C`/`I`/`M`/`m`) and are stable within a single dispatch — no renumbering.
382
420
  - `verification_commands` carries what Step 8's "Verification Commands" section would have carried, as an array of command strings.
383
421
 
384
- Default behavior is unaffected: when `oat_output_mode` is absent or set to anything other than `structured`, follow Steps 8-9 and write the artifact exactly as before.
422
+ Default behavior is unaffected: when `oat_output_mode` is absent or set to anything other than `structured`, follow Steps 8-9 and write the artifact exactly as before. Analysis reviews MUST honor `oat_output_mode: structured` whenever supplied by an auto-review loop: return the `StructuredFindings` object and write no artifact.
385
423
 
386
424
  ## Critical Rules
387
425
 
@@ -76,6 +76,18 @@ Tool-pack installation state also lives here as shared repo config:
76
76
 
77
77
  Use `oat config get tools.<pack>` when you need an explicit installed-capability signal for workflows or troubleshooting.
78
78
 
79
+ Workflow automation preferences are also visible through `oat config` and can be set at local, shared, or user scope. Notable review-loop keys:
80
+
81
+ - `workflow.autoArtifactReview.plan` - default-on bounded artifact review for generated `plan.md` files before implementation handoff
82
+ - `workflow.autoArtifactReview.analysis` - default-on bounded accuracy review for generated docs and agent-instructions analysis artifacts before apply workflows consume them
83
+
84
+ Use `oat config describe workflow.autoArtifactReview.plan` or `oat config describe workflow.autoArtifactReview.analysis` to inspect precedence, defaults, and writable surfaces. Set either key to `false` only when you intentionally want to bypass that generated-artifact review loop:
85
+
86
+ ```bash
87
+ oat config set workflow.autoArtifactReview.plan false --shared
88
+ oat config set workflow.autoArtifactReview.analysis false --local
89
+ ```
90
+
79
91
  When archive settings are configured, completion uploads dated archive snapshots to S3, exports dated summary snapshots into the configured summary reference directory, and lets `oat-wrap-up` write tracked wrap-up reports into the configured wrap-up directory.
80
92
 
81
93
  Use these reference pages for file ownership and schema details:
@@ -255,13 +255,26 @@ Workflow preference keys live under the `workflow.*` namespace:
255
255
  - `workflow.reviewExecutionModel` — `subagent`, `inline`, or `fresh-session`. Default final-review execution model in `oat-project-implement`. `subagent` and `inline` run automatically. `fresh-session` is a soft preference: the skill prints guidance to run the review in another session but still offers escape hatches to `subagent` or `inline` if you change your mind. When unset, the skill prompts.
256
256
  - `workflow.autoReviewAtHillCheckpoints` — boolean. Automatically run the extra lifecycle review when a HiLL checkpoint is reached. This does not control Tier 1 per-phase `oat-reviewer` gates, which run after each phase in Tier 1 regardless of this setting. When unset, the skill prompts.
257
257
  - `workflow.autoNarrowReReviewScope` — boolean. Auto-narrow re-review scope to fix-task commits only in `oat-project-review-provide`. When unset, the skill prompts.
258
+ - `workflow.autoArtifactReview.plan` — boolean, default `true`. Automatically run the bounded artifact-review loop for generated `plan.md` files before implementation handoff. Set to `false` only when you intentionally want to skip the plan artifact review.
259
+ - `workflow.autoArtifactReview.analysis` — boolean, default `true`. Automatically run the bounded accuracy-review loop for generated docs and agent-instructions analysis artifacts before the matching apply workflow consumes them.
258
260
  - `workflow.dispatchCeiling.preset` — `balanced`, `maximum`, or `cost-conscious`. Convenience preset that compiles to per-provider values at write time. Setting this key is the recommended way to configure the ceiling.
259
261
  - `workflow.dispatchCeiling.providers.codex` — `low`, `medium`, `high`, or `xhigh`. Concrete Codex ceiling. Set automatically when a preset is selected; also settable directly for Advanced (no preset) configurations. Provider default effort is informational for base/unpinned roles and is not treated as this ceiling.
260
262
  - `workflow.dispatchCeiling.providers.claude` — `haiku`, `sonnet`, or `opus`. Concrete Claude ceiling. Set automatically when a preset is selected; also settable directly for Advanced configurations. Claude has no separate per-dispatch effort axis, so the effort axis remains `not-applicable`.
261
263
 
264
+ ### Auto artifact-review preferences
265
+
266
+ `workflow.autoArtifactReview.*` controls the artifact-quality loops that run before downstream workflow steps consume generated artifacts. Both keys are default-on. Only an explicit `false` disables the matching loop:
267
+
268
+ | Key | Default | Controls |
269
+ | -------------------------------------- | ------- | ------------------------------------------------------------------------ |
270
+ | `workflow.autoArtifactReview.plan` | `true` | `plan.md` artifact review after plan authoring and before implementation |
271
+ | `workflow.autoArtifactReview.analysis` | `true` | Accuracy review for generated docs and agent-instructions analysis files |
272
+
273
+ The loops use `oat-reviewer` structured-output mode. They do not write standalone review artifacts unless the calling workflow records an outcome row or tracking metadata. The retry bound comes from the project `oat_orchestration_retry_limit` setting and defaults to `2`.
274
+
262
275
  ### Three-layer resolution
263
276
 
264
- Workflow preferences resolve through three config surfaces, with `env > local > shared > user > default` precedence per key. This is the same generic resolution used by `oat config dump`:
277
+ Workflow preferences resolve through three config surfaces, with `local > shared > user > default` precedence per key. `oat config dump` can also report an `env` source for keys that have explicit environment aliases, such as `projects.root` and `worktrees.root`; `workflow.autoArtifactReview.plan` and `workflow.autoArtifactReview.analysis` do not have environment aliases and use config-file/default resolution.
265
278
 
266
279
  - **User-level** (`~/.oat/config.json`): personal defaults that apply to every repo. This is where most power users should start — set preferences once, never worry about them again.
267
280
  - **Shared repo** (`.oat/config.json`): team decisions for this repo. Overrides user defaults when present.
@@ -282,16 +295,20 @@ oat config set workflow.autoReviewAtHillCheckpoints true --user
282
295
  oat config set workflow.autoNarrowReReviewScope true --user
283
296
  oat config set workflow.designMode selective --user
284
297
  oat config set workflow.dispatchCeiling.preset balanced --user
298
+ oat config set workflow.autoArtifactReview.plan true --user
299
+ oat config set workflow.autoArtifactReview.analysis true --user
285
300
 
286
301
  # Shared repo: team decision for this repo
287
302
  oat config set workflow.createPrOnComplete false --shared
288
303
  oat config set workflow.designMode collaborative --shared
289
304
  oat config set workflow.dispatchCeiling.preset balanced --shared
305
+ oat config set workflow.autoArtifactReview.plan false --shared
290
306
 
291
307
  # Repo-local: personal override for this repo (default when no flag)
292
308
  oat config set workflow.hillCheckpointDefault every
293
309
  oat config set workflow.designMode draft
294
310
  oat config set workflow.dispatchCeiling.providers.codex medium # Advanced: per-provider override
311
+ oat config set workflow.autoArtifactReview.analysis false
295
312
  ```
296
313
 
297
314
  Default (no flag) targets `.oat/config.local.json` for workflow keys. Pass at most one of `--user`, `--shared`, or `--local`. Structural keys (`projects.root`, `worktrees.root`, `git.*`, `documentation.*`, `archive.*`, `tools.*`) are still shared-only regardless of flag.
@@ -312,6 +329,7 @@ Some preferences are **genuinely personal** — their correct value is the same
312
329
 
313
330
  Other preferences **depend on per-repo configuration** to be safe. These should be set at `--shared` (in each repo where they apply), not `--user`:
314
331
 
332
+ - `workflow.autoArtifactReview.plan` / `workflow.autoArtifactReview.analysis` — default to `true`; use shared config only when a repo intentionally opts out of generated-artifact review loops, and local config for one-off debugging or emergency bypasses.
315
333
  - `workflow.archiveOnComplete` — correctness depends on the repo's `archive.s3Uri` / `archive.s3SyncOnComplete` being configured. A user-level `true` would try to archive in repos that aren't set up for it.
316
334
  - `workflow.postImplementSequence` — correctness depends on `documentation.requireForProjectCompletion`. Setting `pr` at user level would foot-gun you in any repo that requires docs, because completion would later block on the docs gate while the PR is already open.
317
335
  - `workflow.createPrOnComplete` — this key is almost always redundant with `postImplementSequence`-driven flows. When it's meaningful, its correctness depends on the same per-repo docs and PR gates. Prefer shared scope, or omit it entirely and rely on `postImplementSequence: pr` or `docs-pr` to handle PR creation at the end of implement.
@@ -28,7 +28,9 @@ Install the workflow skills with `oat tools install docs` (preferred) or
28
28
  name distinct from package name), labeled post-patches for open CLI gaps,
29
29
  build verification, config inspection, and an educational walkthrough
30
30
  - `oat-docs-analyze` evaluates a docs surface for structure, drift, coverage,
31
- contributor guidance, and docs-app contract issues
31
+ contributor guidance, and docs-app contract issues, then runs the shared
32
+ auto artifact-review loop to verify the generated analysis artifact's
33
+ evidence, severities, and recommendations
32
34
  - `oat-docs-apply` consumes the analysis artifact and applies only approved,
33
35
  evidence-backed recommendations
34
36
  - `oat-project-document` performs post-implementation docs sync for a tracked project,
@@ -42,6 +44,9 @@ Install the workflow skills with `oat tools install docs` (preferred) or
42
44
  The docs workflow mirrors the agent-instructions analyze/apply split:
43
45
 
44
46
  - Analyze owns discovery, evidence gathering, confidence, and disclosure decisions
47
+ - Analyze also owns accuracy verification of the generated analysis artifact
48
+ through the shared auto artifact-review loop before the apply workflow consumes
49
+ it
45
50
  - Apply consumes the artifact, asks for approval, and must not invent new docs conventions
46
51
 
47
52
  This keeps deterministic behavior in the CLI and judgment-heavy behavior in the
@@ -56,7 +61,8 @@ skills.
56
61
  5. Sync navigation:
57
62
  - **MkDocs:** `oat docs nav sync`
58
63
  - **Fumadocs:** `oat docs generate-index` (runs automatically via `predev`/`prebuild` hooks)
59
- 6. Run `oat-docs-analyze`
64
+ 6. Run `oat-docs-analyze`; by default it verifies the generated analysis artifact
65
+ through `workflow.autoArtifactReview.analysis`
60
66
  7. Review the artifact and run `oat-docs-apply`
61
67
 
62
68
  ## Progressive disclosure
@@ -33,6 +33,7 @@ The CLI is also a standalone value path. You can use `oat init`, `oat sync`, `oa
33
33
  | `oat docs ...` | Docs app bootstrap, migration, index generation, nav sync, and docs workflow entrypoints. | [Docs Tooling Commands](../docs-tooling/commands.md) |
34
34
  | `oat status` / `oat sync` / `oat providers ...` | Provider sync, drift inspection, provider configuration, and adoption behavior. | [Provider Sync](../provider-sync/index.md) |
35
35
  | `oat project ...` / `oat cleanup ...` | Project scaffolding, active-project status inspection, tracked-project listing, plan validation, archive creation, and project/artifact cleanup commands. | [Workflow & Projects](../workflows/projects/index.md) |
36
+ | `oat review ...` | Review artifact discovery helpers, including latest-review resolution for project and ad-hoc review flows. | [Reviews](../workflows/projects/reviews.md) |
36
37
  | `oat repo ...` | Repository-level workflows such as archive sync and PR-comment analysis. | [Repository Analysis](../workflows/projects/repo-analysis.md) |
37
38
 
38
39
  Notable commands introduced in the current CLI surface:
@@ -42,6 +43,7 @@ Notable commands introduced in the current CLI surface:
42
43
  - `oat project status --field <path>` - print one arbitrary dot-path field from the same status payload, e.g. `project.workflowMode` or `project.timestamps.stateUpdated`. Missing/null fields print `null`; object and array fields print compact JSON.
43
44
  - `oat project status --project-path <path>` - read from a repo-relative or absolute project path instead of `.oat/config.local.json`'s active project pointer. Combine it with `--field` or `--shell` when a skill has already resolved the target project path.
44
45
  - `oat project status --shell NAME=path ...` - print shell-safe assignments for one or more fields from one status read, e.g. `WORKFLOW_MODE='quick'`. This is the preferred multi-field read API for skills. See [Writing Skills → Reading project state](../contributing/skills.md#reading-project-state) for examples and the `npx`-backed `oat` shim contract.
46
+ - `oat review latest --json` - find the newest review artifact by `oat_generated_at`, scanning the active or specified project's `reviews/` and `reviews/archived/` directories plus ad-hoc review locations. Same-time candidates use target priority, then lifecycle recency (`final` > higher phase/task > lower phase/task). The JSON contract returns `path`, `scope`, `generatedAt`, and `kind` (`project` or `adhoc`), with `null` values when no review exists.
45
47
  - `oat project list --json` - summary state for tracked projects under the configured projects root
46
48
  - `oat project complete-state <project-path>` - apply the canonical completed-state mutation to a project's `state.md`; used by `oat-project-complete` during lifecycle closeout
47
49
  - `oat project archive [project-path]` - archive a tracked project through the same local move, summary export, and optional S3 upload path used by completion. When omitted, the project path falls back to the active project.
@@ -63,7 +65,7 @@ Per-key restrictions apply: structural keys can only be written at shared scope,
63
65
 
64
66
  ## `workflow.*` preference keys
65
67
 
66
- The `workflow.*` namespace holds user-facing workflow preferences that let you answer repetitive confirmation prompts once and have OAT skills respect the answer automatically. Seven keys:
68
+ The `workflow.*` namespace holds user-facing workflow preferences that let you answer repetitive confirmation prompts once and have OAT skills respect the answer automatically. Common keys:
67
69
 
68
70
  - `workflow.hillCheckpointDefault` (`every` | `final`) — default HiLL checkpoint behavior in `oat-project-implement`
69
71
  - `workflow.archiveOnComplete` (`boolean`) — skip the archive prompt in `oat-project-complete`
@@ -72,5 +74,7 @@ The `workflow.*` namespace holds user-facing workflow preferences that let you a
72
74
  - `workflow.reviewExecutionModel` (`subagent` | `inline` | `fresh-session`) — default final-review execution model
73
75
  - `workflow.autoReviewAtHillCheckpoints` (`boolean`) — auto-run the extra lifecycle review at HiLL checkpoints
74
76
  - `workflow.autoNarrowReReviewScope` (`boolean`) — auto-narrow re-review scope to fix-task commits
77
+ - `workflow.autoArtifactReview.plan` (`boolean`, default `true`) — auto-run the bounded `plan.md` artifact-review loop before implementation handoff
78
+ - `workflow.autoArtifactReview.analysis` (`boolean`, default `true`) — auto-run the bounded accuracy-review loop for generated analysis artifacts before apply workflows consume them
75
79
 
76
- All seven keys resolve through the 3-layer precedence chain (`env > local > shared > user > default`). See [Workflow preferences in the Configuration guide](../cli-utilities/configuration.md#workflow-preferences-workflow) for full descriptions, surface guidance, and cross-repo foot-gun examples.
80
+ These workflow keys resolve through config files and defaults (`local > shared > user > default`). Some config keys have explicit environment aliases, but `workflow.autoArtifactReview.plan` and `workflow.autoArtifactReview.analysis` do not. See [Workflow preferences in the Configuration guide](../cli-utilities/configuration.md#workflow-preferences-workflow) for full descriptions, surface guidance, and cross-repo foot-gun examples.
@@ -19,6 +19,19 @@ Review loop:
19
19
  - `reviews/archived/` is the local-only historical surface. Active `reviews/` content is not gitignored by default.
20
20
  - Ad-hoc review artifacts still default to local-only orphan storage under `.oat/projects/local/orphan-reviews/`.
21
21
 
22
+ ## Latest review resolver
23
+
24
+ Use `oat review latest` when a skill or operator needs to resolve "the most recent review" without hand-selecting a file.
25
+
26
+ ```bash
27
+ oat review latest --json
28
+ oat review latest --project .oat/projects/shared/example --json
29
+ ```
30
+
31
+ The resolver orders candidates by `oat_generated_at` frontmatter, not filesystem mtime. With an active or explicit project, it scans the project's `reviews/` directory first, then `reviews/archived/`, then ad-hoc review locations (`.oat/repo/reviews/` and `.oat/projects/local/orphan-reviews/`). When candidates share the same generated time, active project reviews outrank archived and ad-hoc reviews, then lifecycle recency breaks remaining ties (`final` > higher phase/task scope > lower phase/task scope). The JSON response contains `path`, `scope`, `generatedAt`, and `kind` (`project` or `adhoc`). If no review exists, those fields are `null`.
32
+
33
+ `oat-project-review-receive` uses this resolver when it is invoked from natural language and needs to offer the latest project review, or route an ad-hoc result to `oat-review-receive`.
34
+
22
35
  ## Bookkeeping commits (required)
23
36
 
24
37
  Both `oat-project-review-receive` and `oat-project-review-receive-remote` conclude with a required atomic commit of `plan.md`, `implementation.md`, `state.md`, and the archived review artifact (when tracked). This is the safety net that prevents cross-agent bookkeeping drift: when a subagent runs a receive skill in isolation, the commit ensures the original agent sees a clean checkout on return.
@@ -43,6 +56,17 @@ The commit is scoped and explicit — it stages only the project's tracking file
43
56
 
44
57
  The `*-provide-remote` and `*-receive-remote` skills are the two halves of the cross-machine loop: one agent posts a review to a PR; an agent on the PR's own machine receives it and turns it into fix tasks.
45
58
 
59
+ ## Model-invokable review skills
60
+
61
+ The project review skills are model-invokable only for explicit user asks and confirmation flows. They are not auto-invoked just because a phase completed, a review artifact exists, or a checkout looks ready for review.
62
+
63
+ - `oat-project-review-provide` handles explicit asks such as "review project" after resolving an active project and summarizing the inferred scope for confirmation.
64
+ - `oat-project-review-receive` handles explicit asks such as "receive review" or "process review" after resolving the latest review target. If the latest target is ad-hoc, it offers to route to `oat-review-receive`.
65
+ - `oat-project-progress` is also model-invokable for read-only status asks such as "check progress" or "what's next"; it reports before offering any next-step routing.
66
+ - `oat-project-discover` is model-invokable only when an active spec-driven project exists. Otherwise it declines and points to `oat-project-new`, `oat-project-quick-start`, or `oat-project-open`.
67
+
68
+ The common rule is offer-and-confirm: the model may recognize the request and propose the matching workflow skill, but must ask before mutating project artifacts or starting a review.
69
+
46
70
  ## Remote provide
47
71
 
48
72
  `oat-review-provide-remote` (ad-hoc) and `oat-project-review-provide-remote` (project-scoped) let an agent on one machine review a GitHub PR opened from another machine and post the review back to GitHub. They mirror the existing `*-receive-remote` skills, closing the local-vs-remote × provide-vs-receive matrix.
@@ -83,6 +107,23 @@ Auto-triggered reviews use `oat_review_invocation: auto` in the review artifact
83
107
 
84
108
  This feature is opt-in and disabled by default. When disabled, the manual `oat-project-review-provide` workflow applies.
85
109
 
110
+ ## Auto artifact-review loops
111
+
112
+ Generated planning and analysis artifacts have a separate review loop from code/phase reviews.
113
+
114
+ For plans, `oat-project-plan`, `oat-project-quick-start`, and `oat-project-import-plan` run a bounded `plan.md` artifact review before marking the plan ready for implementation. The loop dispatches `oat-reviewer` in structured-output artifact mode with `scope: plan`, applies unambiguous Critical and Important artifact-local fixes, offers Medium and Minor fixes, and re-runs until clean or the retry bound is exhausted. A clean result records the `plan` row in the plan's `## Reviews` table as `passed`.
115
+
116
+ For analysis artifacts, `oat-docs-analyze` and `oat-agent-instructions-analyze` run a bounded accuracy review after writing their severity-rated artifacts. The reviewer checks cited evidence, severity, and recommendations before the matching apply workflow consumes the artifact. The analysis loop updates tracking metadata to mark the artifact verified.
117
+
118
+ Both loops are default-on and controlled through:
119
+
120
+ ```bash
121
+ oat config set workflow.autoArtifactReview.plan false
122
+ oat config set workflow.autoArtifactReview.analysis false
123
+ ```
124
+
125
+ Only an explicit `false` skips a loop. The retry bound comes from `oat_orchestration_retry_limit` and defaults to `2`.
126
+
86
127
  ## Re-review scope narrowing
87
128
 
88
129
  When re-reviewing after fix tasks have been applied, `oat-project-review-provide` detects completed `(review)` fix tasks and offers to narrow the re-review scope to just the fix-task commits. This avoids re-examining already-approved code.
@@ -1,6 +1,6 @@
1
1
  {
2
- "cli": "0.1.20",
3
- "docs-config": "0.1.20",
4
- "docs-theme": "0.1.20",
5
- "docs-transforms": "0.1.20"
2
+ "cli": "0.1.21",
3
+ "docs-config": "0.1.21",
4
+ "docs-theme": "0.1.21",
5
+ "docs-transforms": "0.1.21"
6
6
  }
@@ -1,10 +1,10 @@
1
1
  ---
2
2
  name: oat-agent-instructions-analyze
3
- version: 1.10.0
3
+ version: 1.11.0
4
4
  description: Run when you need to evaluate agent instruction file coverage, quality, and drift. Produces a severity-rated analysis artifact. Run before oat-agent-instructions-apply to identify what needs improvement.
5
5
  disable-model-invocation: true
6
6
  user-invocable: true
7
- allowed-tools: Read, Write, Bash(git:*), Glob, Grep, AskUserQuestion
7
+ allowed-tools: Read, Write, Bash(git:*), Glob, Grep, AskUserQuestion, Task
8
8
  ---
9
9
 
10
10
  # Agent Instructions Analysis
@@ -32,6 +32,7 @@ Scan, evaluate, and report on agent instruction file coverage, quality, and drif
32
32
  - Reading all instruction files and project configuration.
33
33
  - Running helper scripts for discovery.
34
34
  - Writing analysis artifact to `.oat/repo/analysis/`.
35
+ - Reviewing and correcting the analysis artifact and companion bundle through the shared Auto Artifact-Review Loop.
35
36
  - Updating `.oat/tracking.json`.
36
37
 
37
38
  ## Analyze vs Apply Boundary
@@ -58,16 +59,17 @@ or fill in missing evidence gaps on its own.
58
59
  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
59
60
 
60
61
  - Step indicators:
61
- - `[1/10] Resolving providers + mode…`
62
- - `[2/10] Discovering instruction files…`
63
- - `[3/10] Discovering documentation surfaces…`
64
- - `[4/10] Evaluating quality + validating existing rules…`
65
- - `[5/10] Assessing directory coverage gaps…`
66
- - `[6/10] Discovering file-type patterns…`
67
- - `[7/10] Checking for drift…`
68
- - `[8/10] Checking cross-format consistency…`
69
- - `[9/10] Writing analysis artifact…`
70
- - `[10/10] Updating tracking + summary…`
62
+ - `[1/11] Resolving providers + mode…`
63
+ - `[2/11] Discovering instruction files…`
64
+ - `[3/11] Discovering documentation surfaces…`
65
+ - `[4/11] Evaluating quality + validating existing rules…`
66
+ - `[5/11] Assessing directory coverage gaps…`
67
+ - `[6/11] Discovering file-type patterns…`
68
+ - `[7/11] Checking for drift…`
69
+ - `[8/11] Checking cross-format consistency…`
70
+ - `[9/11] Writing analysis artifact…`
71
+ - `[10/11] Reviewing artifact accuracy…`
72
+ - `[11/11] Updating verified tracking + summary…`
71
73
 
72
74
  ## Process
73
75
 
@@ -435,7 +437,32 @@ The markdown artifact and companion bundle together are the contract for apply.
435
437
  recommendation that requires judgment during generation
436
438
  - stable recommendation IDs and pack references for any recommendation that apply may execute
437
439
 
438
- ### Step 9: Update Tracking and Output Summary
440
+ ### Step 9: Review Analysis Artifact Accuracy
441
+
442
+ Run the shared **Auto Artifact-Review Loop** from `oat-project-plan-writing` after `$ARTIFACT_PATH` and `$BUNDLE_DIR` are written and before tracking is updated or `oat-agent-instructions-apply` is recommended.
443
+
444
+ Use the `analysis` target:
445
+
446
+ - `type: analysis`
447
+ - `scope: agent-instructions`
448
+ - `analysis_artifact: $ARTIFACT_PATH`
449
+ - `oat_output_mode: structured`
450
+
451
+ Follow the canonical loop exactly:
452
+
453
+ 1. Resolve `workflow.autoArtifactReview.analysis`; missing config means enabled, and only explicit `false` skips the loop.
454
+ 2. Resolve `oat_orchestration_retry_limit`; default to `2` if unavailable.
455
+ 3. Dispatch `oat-reviewer` in structured mode via Tier 1 subagent when available, falling back to the same reviewer prompt inline when needed.
456
+ 4. Apply Critical and Important fixes when they are local to the analysis artifact, companion bundle, and unambiguous.
457
+ 5. Offer Medium and Minor fixes rather than applying them silently.
458
+ 6. Rewrite `$ARTIFACT_PATH` and any affected bundle files after applied fixes, then re-dispatch while retries remain.
459
+ 7. Stop when the reviewer is clean or the retry bound is exhausted.
460
+
461
+ The review loop may only edit the markdown analysis artifact and its companion bundle. It must not modify or create instruction files, provider rules, repo configuration, or any other downstream apply target. If a finding cannot be fixed inside the analysis artifact or bundle, preserve it as a residual review finding and surface it in the summary before handoff.
462
+
463
+ If the loop is disabled, note `Auto artifact review: skipped (workflow.autoArtifactReview.analysis=false)` in the summary and do not describe the artifact as verified.
464
+
465
+ ### Step 10: Update Verified Tracking and Output Summary
439
466
 
440
467
  **Update tracking:**
441
468
 
@@ -454,6 +481,8 @@ bash "$TRACKING_SCRIPT" write \
454
481
  {providers...}
455
482
  ```
456
483
 
484
+ Only run this tracking write after Step 9 finishes. A tracked agent-instructions analysis artifact is therefore reviewed/verified unless the summary explicitly says the auto artifact-review loop was skipped.
485
+
457
486
  **Output summary to the user:**
458
487
 
459
488
  ```
@@ -472,6 +501,7 @@ Analysis complete.
472
501
 
473
502
  Artifact: {artifact_path}
474
503
  Bundle: {bundle_dir}
504
+ Auto artifact review: {passed|passed with residual findings|skipped}
475
505
 
476
506
  Next step: Run oat-agent-instructions-apply to act on these findings.
477
507
  ```
@@ -1,10 +1,10 @@
1
1
  ---
2
2
  name: oat-docs-analyze
3
- version: 1.2.0
3
+ version: 1.3.0
4
4
  description: Run when you need to evaluate documentation structure, navigation, and coverage against the OAT docs app contract. Produces a severity-rated analysis artifact for oat-docs-apply.
5
5
  disable-model-invocation: true
6
6
  user-invocable: true
7
- allowed-tools: Read, Write, Bash(git:*), Glob, Grep, AskUserQuestion
7
+ allowed-tools: Read, Write, Bash(git:*), Glob, Grep, AskUserQuestion, Task
8
8
  ---
9
9
 
10
10
  # Docs Analysis
@@ -32,6 +32,7 @@ Scan a repository's documentation surface, evaluate it against the OAT docs cont
32
32
 
33
33
  - Reading docs trees, MkDocs config, and related repository metadata.
34
34
  - Writing a docs analysis artifact to `.oat/repo/analysis/`.
35
+ - Reviewing and correcting the docs analysis artifact itself through the shared Auto Artifact-Review Loop.
35
36
  - Updating docs analysis tracking metadata.
36
37
 
37
38
  ## Analyze vs Apply Boundary
@@ -66,15 +67,16 @@ When executing this skill, provide lightweight progress feedback so the user can
66
67
  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
67
68
 
68
69
  - Use step indicators:
69
- - `[1/9] Resolving docs target + mode…`
70
- - `[2/9] Inventorying docs files…`
71
- - `[3/9] Evaluating index contract…`
72
- - `[4/9] Assessing quality + coverage…`
73
- - `[5/9] Verifying substantive claims…`
74
- - `[6/9] Finding content opportunities…`
75
- - `[7/9] Checking nav and drift…`
76
- - `[8/9] Writing analysis artifact…`
77
- - `[9/9] Updating tracking + summary…`
70
+ - `[1/10] Resolving docs target + mode…`
71
+ - `[2/10] Inventorying docs files…`
72
+ - `[3/10] Evaluating index contract…`
73
+ - `[4/10] Assessing quality + coverage…`
74
+ - `[5/10] Verifying substantive claims…`
75
+ - `[6/10] Finding content opportunities…`
76
+ - `[7/10] Checking nav and drift…`
77
+ - `[8/10] Writing analysis artifact…`
78
+ - `[9/10] Reviewing artifact accuracy…`
79
+ - `[10/10] Updating verified tracking + summary…`
78
80
 
79
81
  ## Process
80
82
 
@@ -302,7 +304,32 @@ Populate the artifact with:
302
304
  - Progressive disclosure decisions (`inline`, `link_only`, `omit`, `ask_user`)
303
305
  - Canonical link targets when deeper detail should stay out of always-on docs pages
304
306
 
305
- ### Step 9: Update Tracking and Output Summary
307
+ ### Step 9: Review Analysis Artifact Accuracy
308
+
309
+ Run the shared **Auto Artifact-Review Loop** from `oat-project-plan-writing` after `$ARTIFACT_PATH` is written and before tracking is updated or `oat-docs-apply` is recommended.
310
+
311
+ Use the `analysis` target:
312
+
313
+ - `type: analysis`
314
+ - `scope: docs`
315
+ - `analysis_artifact: $ARTIFACT_PATH`
316
+ - `oat_output_mode: structured`
317
+
318
+ Follow the canonical loop exactly:
319
+
320
+ 1. Resolve `workflow.autoArtifactReview.analysis`; missing config means enabled, and only explicit `false` skips the loop.
321
+ 2. Resolve `oat_orchestration_retry_limit`; default to `2` if unavailable.
322
+ 3. Dispatch `oat-reviewer` in structured mode via Tier 1 subagent when available, falling back to the same reviewer prompt inline when needed.
323
+ 4. Apply Critical and Important fixes when they are local to the analysis artifact and unambiguous.
324
+ 5. Offer Medium and Minor fixes rather than applying them silently.
325
+ 6. Rewrite `$ARTIFACT_PATH` after applied fixes and re-dispatch while retries remain.
326
+ 7. Stop when the reviewer is clean or the retry bound is exhausted.
327
+
328
+ The review loop may only edit the analysis artifact. It must not edit docs content, `mkdocs.yml`, navigation files, or any other downstream apply target. If a finding cannot be fixed inside the analysis artifact, preserve it as a residual review finding and surface it in the summary before handoff.
329
+
330
+ If the loop is disabled, note `Auto artifact review: skipped (workflow.autoArtifactReview.analysis=false)` in the summary and do not describe the artifact as verified.
331
+
332
+ ### Step 10: Update Verified Tracking and Output Summary
306
333
 
307
334
  Update docs tracking using the shared helper:
308
335
 
@@ -320,6 +347,8 @@ bash "$TRACKING_SCRIPT" write \
320
347
  --artifact-path "$ARTIFACT_PATH"
321
348
  ```
322
349
 
350
+ Only run this tracking write after Step 9 finishes. A tracked docs analysis artifact is therefore reviewed/verified unless the summary explicitly says the auto artifact-review loop was skipped.
351
+
323
352
  Output a summary:
324
353
 
325
354
  ```text
@@ -337,6 +366,7 @@ Analysis complete.
337
366
  Low: {N}
338
367
 
339
368
  Artifact: {artifact_path}
369
+ Auto artifact review: {passed|passed with residual findings|skipped}
340
370
 
341
371
  Next step: Run oat-docs-apply to act on these findings.
342
372
  ```
@@ -1,8 +1,8 @@
1
1
  ---
2
2
  name: oat-project-discover
3
- version: 2.0.2
4
- description: Use when starting a project or when requirements are still unclear. Runs structured discovery to gather requirements, constraints, and context.
5
- disable-model-invocation: true
3
+ version: 2.0.3
4
+ description: Use when the user explicitly asks to continue discovery for an active spec-driven OAT project — e.g. "continue discovery", "run discovery", or confirms a previously offered discovery step. Do NOT auto-invoke for new ideas or quick-mode projects. Gathers requirements and context before spec/design.
5
+ disable-model-invocation: false
6
6
  user-invocable: true
7
7
  allowed-tools: Read, Write, Bash(git:*), Bash(oat:*), Bash(pnpm:*), Glob, Grep, AskUserQuestion
8
8
  ---
@@ -15,6 +15,20 @@ Gather requirements and understand the problem space through natural collaborati
15
15
 
16
16
  **Required:** Knowledge base must exist. If missing, run the `oat-repo-knowledge-index` skill first.
17
17
 
18
+ **Required for model invocation:** An active spec-driven OAT project must already exist. If no active project exists, route to `oat-project-new` for spec-driven setup or `oat-project-quick-start` for quick workflow. If the active project is quick or import mode, decline this skill and route to the current mode's next step instead.
19
+
20
+ ## Model Invocation Gate
21
+
22
+ This skill is model-invokable only for explicit discovery-continuation asks on an active spec-driven project. Do NOT auto-invoke when the user mentions a new idea, asks for a quick workflow, or has an active quick/import project.
23
+
24
+ Before acting:
25
+
26
+ 1. Resolve `activeProject`.
27
+ 2. Confirm `{PROJECT_PATH}/state.md` exists.
28
+ 3. Confirm `oat_workflow_mode` is `spec-driven` or absent only in a legacy spec-driven project.
29
+
30
+ If any check fails, decline this skill. Offer `oat-project-new` for a new spec-driven project, `oat-project-quick-start` for a quick project, or `oat-project-open` for switching to an existing project. When the gate passes, summarize the active project and ask before continuing discovery.
31
+
18
32
  ## Mode Assertion
19
33
 
20
34
  **OAT MODE: Discovery**
@@ -68,7 +82,7 @@ If you catch yourself:
68
82
 
69
83
  ## Process
70
84
 
71
- ### Step 1: Resolve Active Project (or Create a New One)
85
+ ### Step 1: Resolve Active Spec-Driven Project
72
86
 
73
87
  OAT stores active project context in `.oat/config.local.json` (`activeProject`, local-only).
74
88
 
@@ -84,6 +98,10 @@ PROJECTS_ROOT="${PROJECTS_ROOT%/}"
84
98
 
85
99
  - Derive `project-name` from the directory name (basename of the path)
86
100
  - Read `{PROJECT_PATH}/state.md` (if it exists) and show current status
101
+ - Read `oat_workflow_mode` from `{PROJECT_PATH}/state.md`
102
+ - If `oat_workflow_mode` is present and not `spec-driven`, stop and route:
103
+ - quick project: continue with `oat-project-quick-start` / `oat-project-progress`
104
+ - import project: continue with `oat-project-import-plan` / `oat-project-progress`
87
105
  - Ask user:
88
106
  - **Continue** with active project, or
89
107
  - **Switch projects**: