@op-engineering/op-sqlite 9.1.2 → 9.1.3

package/cpp/bridge.cpp

@@ -742,9 +742,11 @@ opsqlite_execute_raw(std::string const &dbName, std::string const &query,
       opsqlite_bind_statement(statement, params);
     }
 
-    int i, count, column_type;
+    int i, column_type;
     std::string column_name, column_declared_type;
 
+    int column_count = sqlite3_column_count(statement);
+
     while (isConsuming) {
       step = sqlite3_step(statement);
 
@@ -755,25 +757,15 @@ opsqlite_execute_raw(std::string const &dbName, std::string const &query,
         }
 
         std::vector<JSVariant> row;
+        row.reserve(column_count);
 
         i = 0;
 
-        count = sqlite3_column_count(statement);
-
-        while (i < count) {
+        while (i < column_count) {
           column_type = sqlite3_column_type(statement, i);
 
           switch (column_type) {
-          case SQLITE_INTEGER: {
-            /**
-             * Warning this will loose precision because JS can
-             * only represent Integers up to 53 bits
-             */
-            double column_value = sqlite3_column_double(statement, i);
-            row.emplace_back(column_value);
-            break;
-          }
-
+          case SQLITE_INTEGER:
           case SQLITE_FLOAT: {
             double column_value = sqlite3_column_double(statement, i);
             row.emplace_back(column_value);
@@ -809,7 +801,7 @@ opsqlite_execute_raw(std::string const &dbName, std::string const &query,
           i++;
         }
 
-        results->push_back(row);
+          results->emplace_back(row);
 
         break;
       }
@@ -871,7 +863,7 @@ std::string operation_to_string(int operation_type) {
     return "UPDATE";
 
   default:
-    throw std::invalid_argument("Uknown SQLite operation on hook");
+    throw std::invalid_argument("Unknown SQLite operation on hook");
   }
 }
 

package/ios/OPSQLite.mm

@@ -12,10 +12,6 @@
 
 RCT_EXPORT_MODULE()
 
-- (void)setBridge:(RCTBridge *)bridge {
-  _bridge = bridge;
-}
-
 + (BOOL)requiresMainQueueSetup {
   return YES;
 }
@@ -97,10 +93,8 @@ RCT_EXPORT_BLOCKING_SYNCHRONOUS_METHOD(install) {
   return @true;
 }
 
-RCT_EXPORT_METHOD(moveAssetsDatabase
-                  : (NSDictionary *)args resolve
-                  : (RCTPromiseResolveBlock)resolve reject
-                  : (RCTPromiseRejectBlock)reject) {
+RCT_EXPORT_METHOD(moveAssetsDatabase : (NSDictionary *)args resolve : (
+    RCTPromiseResolveBlock)resolve reject : (RCTPromiseRejectBlock)reject) {
   NSString *documentPath = [NSSearchPathForDirectoriesInDomains(
       NSLibraryDirectory, NSUserDomainMask, true) objectAtIndex:0];
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@op-engineering/op-sqlite",
-  "version": "9.1.2",
+  "version": "9.1.3",
   "description": "Next generation SQLite for React Native",
   "main": "lib/commonjs/index",
   "module": "lib/module/index",