@op-engineering/op-sqlite 9.1.0 → 9.1.2

package/README.md

@@ -1,4 +1,4 @@
-![benchmark](benchmark.png)
+![benchmark](benchmark.jpg)
 
 Created by [@ospfranco](https://twitter.com/ospfranco). **Please consider sponsoring!**.
 

package/cpp/DBHostObject.cpp

@@ -333,6 +333,10 @@ void DBHostObject::create_jsi_functions() {
           auto status = opsqlite_execute_raw(db_name, query, &params, &results);
 #endif
 
+          if (invalidated) {
+            return;
+          }
+
           invoker->invokeAsync([&rt, results = std::move(results),
                                 status = std::move(status), resolve, reject] {
             if (status.type == SQLiteOk) {
@@ -379,8 +383,9 @@ void DBHostObject::create_jsi_functions() {
       auto resolve = std::make_shared<jsi::Value>(rt, args[0]);
       auto reject = std::make_shared<jsi::Value>(rt, args[1]);
 
-      auto task = [&rt, this, query, params = std::move(params), resolve,
-                   reject, invoker = this->jsCallInvoker]() {
+      auto task = [&rt, this, query = std::move(query),
+                   params = std::move(params), resolve, reject,
+                   invoker = this->jsCallInvoker]() {
         try {
 
 #ifdef OP_SQLITE_USE_LIBSQL
@@ -389,9 +394,9 @@ void DBHostObject::create_jsi_functions() {
           auto status = opsqlite_execute(db_name, query, &params);
 #endif
 
-          //            if (invalidated) {
-          //              return;
-          //            }
+          if (invalidated) {
+            return;
+          }
 
           invoker->invokeAsync([&rt, status = std::move(status), resolve,
                                 reject] {
@@ -455,9 +460,9 @@ void DBHostObject::create_jsi_functions() {
                                                       &results, metadata);
 #endif
 
-          //            if (invalidated) {
-          //              return;
-          //            }
+          if (invalidated) {
+            return;
+          }
 
           invoker->invokeAsync(
               [&rt,
@@ -533,6 +538,11 @@ void DBHostObject::create_jsi_functions() {
 #else
           auto batchResult = opsqlite_execute_batch(db_name, commands.get());
 #endif
+
+          if (invalidated) {
+            return;
+          }
+
           jsCallInvoker->invokeAsync([&rt, batchResult = std::move(batchResult),
                                       resolve, reject] {
             if (batchResult.type == SQLiteOk) {
@@ -934,4 +944,8 @@ void DBHostObject::set(jsi::Runtime &rt, const jsi::PropNameID &name,
   throw std::runtime_error("You cannot write to this object!");
 }
 
+void DBHostObject::invalidate() { invalidated = true; }
+
+DBHostObject::~DBHostObject() { invalidated = true; }
+
 } // namespace opsqlite

package/cpp/DBHostObject.h

@@ -51,6 +51,8 @@ public:
   jsi::Value get(jsi::Runtime &rt, const jsi::PropNameID &propNameID);
   void set(jsi::Runtime &rt, const jsi::PropNameID &name,
            const jsi::Value &value);
+  void invalidate();
+  ~DBHostObject();
 
 private:
   void auto_register_update_hook();
@@ -68,6 +70,7 @@ private:
   jsi::Runtime &rt;
   std::vector<std::shared_ptr<ReactiveQuery>> reactive_queries;
   bool is_update_hook_registered = false;
+  bool invalidated = false;
 };
 
 } // namespace opsqlite

package/cpp/bindings.cpp

@@ -24,6 +24,7 @@ std::string _crsqlite_path;
 std::string _sqlite_vec_path;
 std::shared_ptr<react::CallInvoker> _invoker;
 std::shared_ptr<ThreadPool> thread_pool = std::make_shared<ThreadPool>();
+std::vector<std::shared_ptr<DBHostObject>> dbs;
 
 // React native will try to clean the module on JS context invalidation
 // (CodePush/Hot Reload) The clearState function is called and we use this flag
@@ -31,6 +32,9 @@ std::shared_ptr<ThreadPool> thread_pool = std::make_shared<ThreadPool>();
 bool invalidated = false;
 
 void clearState() {
+  for (const auto &db : dbs) {
+    db->invalidate();
+  }
   invalidated = true;
 
 #ifdef OP_SQLITE_USE_LIBSQL
@@ -88,6 +92,7 @@ void install(jsi::Runtime &rt, std::shared_ptr<react::CallInvoker> invoker,
     std::shared_ptr<DBHostObject> db = std::make_shared<DBHostObject>(
         rt, path, invoker, thread_pool, name, path, _crsqlite_path,
         _sqlite_vec_path, encryptionKey);
+    dbs.emplace_back(db);
     return jsi::Object::createFromHostObject(rt, db);
   });
 

package/cpp/bridge.cpp

@@ -63,7 +63,7 @@ BridgeResult opsqlite_open(std::string const &name,
 
   if (dbMap.count(name) != 0) {
     throw std::runtime_error(
-        "[OP-SQLITE] Only JS connection per database is allowed, db name: " +
+        "[OP-SQLITE] Only one connection per database is allowed, db name: " +
         name);
   }
 #endif
@@ -315,7 +315,7 @@ BridgeResult opsqlite_execute_prepared_statement(
       }
 
       if (results != nullptr) {
-        results->push_back(row);
+        results->emplace_back(row);
       }
 
       break;
@@ -335,7 +335,7 @@ BridgeResult opsqlite_execute_prepared_statement(
           metadata.fields.emplace_back("type",
                                        type == nullptr ? "UNKNOWN" : type);
 
-          metadatas->push_back(metadata);
+          metadatas->emplace_back(metadata);
           i++;
         }
       }
@@ -400,11 +400,9 @@ BridgeResult opsqlite_execute(std::string const &name, std::string const &query,
   int status, current_column, column_count, column_type;
   std::string column_name, column_declared_type;
   std::vector<std::string> column_names;
-  column_names.reserve(20);
   std::vector<std::vector<JSVariant>> rows;
   rows.reserve(20);
   std::vector<JSVariant> row;
-  row.reserve(10);
 
   do {
     const char *query_str =
@@ -432,6 +430,7 @@ BridgeResult opsqlite_execute(std::string const &name, std::string const &query,
     }
 
     column_count = sqlite3_column_count(statement);
+    column_names.reserve(column_count);
     bool is_consuming_rows = true;
     double double_value;
     const char *string_value;
@@ -449,7 +448,7 @@ BridgeResult opsqlite_execute(std::string const &name, std::string const &query,
       case SQLITE_ROW:
         current_column = 0;
         row = std::vector<JSVariant>();
-        column_count = sqlite3_column_count(statement);
+        row.reserve(column_count);
 
         while (current_column < column_count) {
           column_type = sqlite3_column_type(statement, current_column);
@@ -494,7 +493,7 @@ BridgeResult opsqlite_execute(std::string const &name, std::string const &query,
           current_column++;
         }
 
-        rows.push_back(row);
+        rows.emplace_back(std::move(row));
         break;
 
       case SQLITE_DONE:

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@op-engineering/op-sqlite",
-  "version": "9.1.0",
+  "version": "9.1.2",
   "description": "Next generation SQLite for React Native",
   "main": "lib/commonjs/index",
   "module": "lib/module/index",