@op-engineering/op-sqlite 9.0.0 → 9.1.0

package/cpp/bridge.cpp

@@ -400,8 +400,11 @@ BridgeResult opsqlite_execute(std::string const &name, std::string const &query,
   int status, current_column, column_count, column_type;
   std::string column_name, column_declared_type;
   std::vector<std::string> column_names;
+  column_names.reserve(20);
   std::vector<std::vector<JSVariant>> rows;
+  rows.reserve(20);
   std::vector<JSVariant> row;
+  row.reserve(10);
 
   do {
     const char *query_str =
@@ -436,7 +439,7 @@ BridgeResult opsqlite_execute(std::string const &name, std::string const &query,
     // Do a first pass to get the column names
     for (int i = 0; i < column_count; i++) {
       column_name = sqlite3_column_name(statement, i);
-      column_names.push_back(column_name);
+      column_names.emplace_back(column_name);
     }
 
     while (is_consuming_rows) {
@@ -464,9 +467,9 @@ BridgeResult opsqlite_execute(std::string const &name, std::string const &query,
           case SQLITE_TEXT: {
             string_value = reinterpret_cast<const char *>(
                 sqlite3_column_text(statement, current_column));
-            int byteLen = sqlite3_column_bytes(statement, current_column);
+            int len = sqlite3_column_bytes(statement, current_column);
             // Specify length too; in case string contains NULL in the middle
-            row.emplace_back(std::string(string_value, byteLen));
+            row.emplace_back(std::string(string_value, len));
             break;
           }
 

package/cpp/utils.cpp

@@ -13,7 +13,7 @@ namespace opsqlite {
 
 namespace jsi = facebook::jsi;
 
-jsi::Value toJSI(jsi::Runtime &rt, JSVariant value) {
+jsi::Value toJSI(jsi::Runtime &rt, const JSVariant &value) {
   if (std::holds_alternative<bool>(value)) {
     return std::get<bool>(value);
   } else if (std::holds_alternative<int>(value)) {
@@ -158,7 +158,7 @@ std::vector<JSVariant> to_variant_vec(jsi::Runtime &rt, jsi::Value const &xs) {
   return res;
 }
 
-jsi::Value create_js_rows(jsi::Runtime &rt, BridgeResult status) {
+jsi::Value create_js_rows(jsi::Runtime &rt, const BridgeResult &status) {
   if (status.type == SQLiteError) {
     throw std::invalid_argument(status.message);
   }
@@ -181,10 +181,10 @@ jsi::Value create_js_rows(jsi::Runtime &rt, BridgeResult status) {
         auto value = toJSI(rt, native_row[j]);
         row.setValueAtIndex(rt, j, value);
       }
-      rows.setValueAtIndex(rt, i, std::move(row));
+      rows.setValueAtIndex(rt, i, row);
     }
   }
-  res.setProperty(rt, "rawRows", std::move(rows));
+  res.setProperty(rt, "rawRows", rows);
 
   size_t column_count = status.column_names.size();
   auto column_array = jsi::Array(rt, column_count);

package/cpp/utils.h

@@ -15,7 +15,7 @@ namespace opsqlite {
 
 namespace jsi = facebook::jsi;
 
-jsi::Value toJSI(jsi::Runtime &rt, JSVariant value);
+jsi::Value toJSI(jsi::Runtime &rt, const JSVariant &value);
 JSVariant toVariant(jsi::Runtime &rt, jsi::Value const &value);
 std::vector<std::string> to_string_vec(jsi::Runtime &rt, jsi::Value const &xs);
 std::vector<JSVariant> to_variant_vec(jsi::Runtime &rt, jsi::Value const &xs);
@@ -23,7 +23,7 @@ std::vector<int> to_int_vec(jsi::Runtime &rt, jsi::Value const &xs);
 jsi::Value createResult(jsi::Runtime &rt, BridgeResult status,
                         std::vector<DumbHostObject> *results,
                         std::shared_ptr<std::vector<SmartHostObject>> metadata);
-jsi::Value create_js_rows(jsi::Runtime &rt, BridgeResult status);
+jsi::Value create_js_rows(jsi::Runtime &rt, const BridgeResult &status);
 jsi::Value
 create_raw_result(jsi::Runtime &rt, BridgeResult status,
                   const std::vector<std::vector<JSVariant>> *results);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@op-engineering/op-sqlite",
-  "version": "9.0.0",
+  "version": "9.1.0",
   "description": "Next generation SQLite for React Native",
   "main": "lib/commonjs/index",
   "module": "lib/module/index",