@op-engineering/op-sqlite 2.0.9 → 2.0.12

package/README.md

@@ -16,7 +16,7 @@ Created by [@ospfranco](https://twitter.com/ospfranco). **Please consider Sponso
 
 ## Benchmarks
 
-You can find the [benchmarking code in the example app](https://github.com/OP-Engineering/op-sqlite/blob/main/example/src/Database.ts#L44). You should expect anywhere between a 5x to an 8x improvement over non-JSI packages, and now a 5x to 8x improvement over quick-sqlite and expo-sqlite. Loading a 300k record database (in milliseconds).
+You can find the [benchmarking code in the example app](https://github.com/OP-Engineering/op-sqlite/blob/main/example/src/Database.ts#L44). This is run using the `OP_SQLITE_PERF` flag which in turns disables some old and unused features of sqlite to squeeze the last drop of performance.
 
 ![benchmark](benchmark.png)
 
@@ -104,7 +104,7 @@ const largeDb = open({
 });
 ```
 
-# Speed
+# Performance
 
 op-sqlite is already the fastest solution it can be, but it doesn't mean you cannot tweak SQLite to be faster (at the cost of some disadvantages). One possible tweak is turning on [Memory Mapping](https://www.sqlite.org/mmap.html). It allows to read/write to/from the disk without going through the kernel. However, if your queries throw an error your application might crash.
 
@@ -129,6 +129,14 @@ If you use [prepared statements](#prepared-statements) plus memory mapping and s
 
 ![mmkv comparison](mmkv.png)
 
+# Perf flag
+
+You can turn on the performance flag to tweak all possible performance enhancing compilation flags, this greatly affects performance of sqlite itself
+
+```
+OP_SQLITE_PERF=1 npx pod-install
+```
+
 # SQLite Gotchas
 
 ## Strictness

package/cpp/bindings.cpp

@@ -38,7 +38,6 @@ void clearState() {
   sqlite_close_all();
   // We then join all the threads before the context gets invalidated
   pool.restartPool();
-
   updateHooks.clear();
   commitHooks.clear();
   rollbackHooks.clear();
@@ -422,9 +421,8 @@ void install(jsi::Runtime &rt,
 
   auto updateHook = HOSTFN("updateHook", 2) {
     if (sizeof(args) < 2) {
-      throw std::runtime_error(
-          "[op-sqlite][loadFileAsync] Incorrect parameters: "
-          "dbName and callback needed");
+      throw std::runtime_error("[op-sqlite][updateHook] Incorrect parameters: "
+                               "dbName and callback needed");
       return {};
     }
 
@@ -481,9 +479,8 @@ void install(jsi::Runtime &rt,
 
   auto commitHook = HOSTFN("commitHook", 2) {
     if (sizeof(args) < 2) {
-      throw std::runtime_error(
-          "[op-sqlite][loadFileAsync] Incorrect parameters: "
-          "dbName and callback needed");
+      throw std::runtime_error("[op-sqlite][commitHook] Incorrect parameters: "
+                               "dbName and callback needed");
       return {};
     }
 
@@ -508,7 +505,7 @@ void install(jsi::Runtime &rt,
   auto rollbackHook = HOSTFN("rollbackHook", 2) {
     if (sizeof(args) < 2) {
       throw std::runtime_error(
-          "[op-sqlite][loadFileAsync] Incorrect parameters: "
+          "[op-sqlite][rollbackHook] Incorrect parameters: "
           "dbName and callback needed");
       return {};
     }

package/cpp/bridge.cpp

@@ -581,6 +581,9 @@ void sqlite_close_all() {
     sqlite3_close_v2(x.second);
   }
   dbMap.clear();
+  updateCallbackMap.clear();
+  rollbackCallbackMap.clear();
+  commitCallbackMap.clear();
 }
 
 std::string operation_to_string(int operation_type) {

package/op-sqlite.podspec

@@ -12,14 +12,14 @@ Pod::Spec.new do |s|
   s.license      = package["license"]
   s.authors      = package["author"]
 
-  s.platforms    = { :ios => "12.0", :osx => "10.13" }
+  s.platforms    = { :ios => "13.0", :osx => "10.15" }
   s.source       = { :git => "https://github.com/op-engineering/op-sqlite.git", :tag => "#{s.version}" }
 
   s.pod_target_xcconfig = {
     :GCC_PREPROCESSOR_DEFINITIONS => "HAVE_FULLFSYNC=1",
     :WARNING_CFLAGS => "-Wno-shorten-64-to-32 -Wno-comma -Wno-unreachable-code -Wno-conditional-uninitialized -Wno-deprecated-declarations",
     :USE_HEADERMAP => "No",
-    :CLANG_CXX_LANGUAGE_STANDARD => "c++17"
+    :CLANG_CXX_LANGUAGE_STANDARD => "c++17",
   }
   
   s.header_mappings_dir = "cpp"
@@ -37,5 +37,15 @@ Pod::Spec.new do |s|
     s.exclude_files = "cpp/sqlite3.c", "cpp/sqlite3.h"
     s.library = "sqlite3"
   end
+
+  if ENV['OP_SQLITE_PERF'] == '1' then
+    s.pod_target_xcconfig = {
+      :GCC_PREPROCESSOR_DEFINITIONS => "HAVE_FULLFSYNC=1",
+      :WARNING_CFLAGS => "-Wno-shorten-64-to-32 -Wno-comma -Wno-unreachable-code -Wno-conditional-uninitialized -Wno-deprecated-declarations",
+      :USE_HEADERMAP => "No",
+      :CLANG_CXX_LANGUAGE_STANDARD => "c++17",
+      :OTHER_CFLAGS => '$(inherited) -DSQLITE_DQS=0 -DSQLITE_THREADSAFE=0 -DSQLITE_DEFAULT_MEMSTATUS=0 -DSQLITE_DEFAULT_WAL_SYNCHRONOUS=1 -DSQLITE_LIKE_DOESNT_MATCH_BLOBS=1 -DSQLITE_MAX_EXPR_DEPTH=0 -DSQLITE_OMIT_DEPRECATED=1 -DSQLITE_OMIT_PROGRESS_CALLBACK=1 -DSQLITE_OMIT_SHARED_CACHE=1 -DSQLITE_USE_ALLOCA=1'
+    }
+  end
   
 end

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@op-engineering/op-sqlite",
-  "version": "2.0.9",
+  "version": "2.0.12",
   "description": "Next generation SQLite for React Native",
   "main": "lib/commonjs/index",
   "module": "lib/module/index",