@oondemand/oon-core-back 0.3.64 → 0.3.65

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@oondemand/oon-core-back",
-  "version": "0.3.64",
+  "version": "0.3.65",
   "repository": {
     "type": "git",
     "url": "git+https://github.com/oondemand/oon-platform.git",

package/src/modules/omie/client.js

@@ -95,6 +95,22 @@ function responseError(body, statusCode) {
   });
 }
 
+function normalizedStringList(value) {
+  const values = Array.isArray(value) ? value : value === undefined || value === null ? [] : [value];
+  return values.map((item) => String(item).trim()).filter(Boolean);
+}
+
+function isConfiguredEmptyResult(callDefinition = {}, body = {}) {
+  const code = String(body?.faultcode ?? body?.code ?? body?.codigo_status ?? "").trim();
+  const description = String(
+    body?.faultstring ?? body?.description ?? body?.descricao_status ?? "",
+  ).trim();
+  const codes = normalizedStringList(callDefinition.emptyResultFaultCodes);
+  const messages = normalizedStringList(callDefinition.emptyResultMessages);
+  return (code && codes.includes(code))
+    || (description && messages.some((message) => description.includes(message)));
+}
+
 function retryableTransportError(error) {
   const statusCode = Number(error?.response?.status || error?.statusCode || 0);
   return RETRYABLE_HTTP.has(statusCode)
@@ -166,9 +182,10 @@ function createOmieClient(options = {}) {
       app_secret: appSecret,
       param: Array.isArray(resolvedParam) ? resolvedParam : [resolvedParam],
     };
+    const callMaxAttempts = Math.max(1, Number(callDefinition.maxAttempts ?? maxAttempts));
     let lastError;
 
-    for (let attempt = 1; attempt <= maxAttempts; attempt += 1) {
+    for (let attempt = 1; attempt <= callMaxAttempts; attempt += 1) {
       const startedAt = Date.now();
       const trace = {
         endpoint: callDefinition.endpoint,
@@ -185,14 +202,18 @@ function createOmieClient(options = {}) {
         });
         const status = Number(response?.status || 200);
         const data = response?.data ?? {};
+        const emptyResult = isConfiguredEmptyResult(callDefinition, data);
         trace.httpStatus = status;
         trace.response = sanitizeIntegrationValue(data);
         trace.durationMs = Date.now() - startedAt;
-        const normalized = responseError(data, status);
-        if (normalized) throw normalized;
+        trace.emptyResult = emptyResult;
+        if (!emptyResult) {
+          const normalized = responseError(data, status);
+          if (normalized) throw normalized;
+        }
         trace.status = "success";
         context.recordRequest?.(trace);
-        return { data, trace };
+        return { data, trace, emptyResult };
       } catch (error) {
         const normalized = error instanceof OmieApiError
           ? error
@@ -209,7 +230,7 @@ function createOmieClient(options = {}) {
         context.recordRequest?.(trace);
         normalized.trace = trace;
         lastError = normalized;
-        if (!normalized.retryable || attempt >= maxAttempts) throw normalized;
+        if (!normalized.retryable || attempt >= callMaxAttempts) throw normalized;
         const delay = Math.min(5_000, retryInitialMs * (2 ** (attempt - 1)));
         await wait(delay);
       }
@@ -253,8 +274,9 @@ module.exports = {
   OmieApiError,
   createOmieClient,
   getPath,
+  isConfiguredEmptyResult,
   normalizeEndpoint,
   resolveCallParam,
   resolveTemplate,
   responseError,
-};
+};